184772 2018-04-19 06:12:38 -0700 Use CheckedArithmetic for length computation in JSArray::unshiftCountWithAnyIndexingType 2018-05-01 09:04:01 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1415900 0 rmorisset 2018-04-19 06:12:38 -0700 <rdar://problem/39146327> 1415903 1 338318 rmorisset 2018-04-19 06:20:13 -0700 Created attachment 338318 Patch 1415906 2 338319 rmorisset 2018-04-19 06:45:26 -0700 Created attachment 338319 Patch 1415908 3 rmorisset 2018-04-19 06:47:32 -0700 The second patch uploaded was for a different bug, I marked it obsolete and un-obsoleted the first patch. 1419290 4 rmorisset 2018-05-01 07:19:50 -0700 ping review. 1419318 5 338318 commit-queue 2018-05-01 09:04:00 -0700 Comment on attachment 338318 Patch Clearing flags on attachment: 338318 Committed r231198: <https://trac.webkit.org/changeset/231198> 1419319 6 commit-queue 2018-05-01 09:04:01 -0700 All reviewed patches have been landed. Closing bug. 338318 2018-04-19 06:20:13 -0700 2018-05-01 09:04:00 -0700 Patch bug-184772-20180419152011.patch text/plain 3037 rmorisset U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi MGQ5ZTJkMWI4MGU4MzM2OGM3MWY4ZDg4ZmRjOWFjZWY5ZDZiMjE3Li5mMzZkODZhNWVhNzFjMWRl ZmJiNmU0ODdkMmZlNjM0NzIwYmZmNzE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0wNC0xOSAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIFVzZSBDaGVja2VkQXJpdGhtZXRpYyBmb3IgbGVuZ3RoIGNvbXB1dGF0 aW9uIGluIEpTQXJyYXk6OnVuc2hpZnRDb3VudFdpdGhBbnlJbmRleGluZ1R5cGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDc3MgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMzkxNDYzMjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmVsYXRlZCB0byBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgzNjU3ICg8cmRhcjovL3Byb2JsZW0vMzg0NjQzOTkpLCB3aGVyZSBhIGNo ZWNrIHdhcyBtaXNzaW5nLgorICAgICAgICBUaGlzIHBhdGNoIG5vdyBtYWtlcyBzdXJlIHRoYXQg dGhlIGNoZWNrIGNvcnJlY3RseSBkZXRlY3RzIGlmIHRoZXJlIGlzIGFuIGludGVnZXIgb3ZlcmZs b3cuCisKKyAgICAgICAgKiBydW50aW1lL0pTQXJyYXkuY3BwOgorICAgICAgICAoSlNDOjpKU0Fy cmF5Ojp1bnNoaWZ0Q291bnRXaXRoQW55SW5kZXhpbmdUeXBlKToKKwogMjAxOC0wNC0xOCAgUm9z cyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lP TihyMjMwNzQ4KSBbV2luQ2Fpcm9dICdKU0M6OkpJVDo6YXBwZW5kQ2FsbFdpdGhTbG93UGF0aFJl dHVyblR5cGUnOiBmdW5jdGlvbiBkb2VzIG5vdCB0YWtlIDEgYXJndW1lbnRzCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCmluZGV4IDQyNjBjYTRmNWU0YThjODQ1M2E3 OWFkMWYzNjg0Yjg5ZGUzNTViZDIuLjc4YmVmOTRmMGFmYjFmZjJjZWYwOGZkYWQ2M2U1MTMwMDQy Y2M0MGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXku Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCkBAIC0x MDYzLDEwICsxMDYzLDE2IEBAIGJvb2wgSlNBcnJheTo6dW5zaGlmdENvdW50V2l0aEFueUluZGV4 aW5nVHlwZShFeGVjU3RhdGUqIGV4ZWMsIHVuc2lnbmVkIHN0YXJ0SW5kCiAgICAgICAgICAgICBy ZXR1cm4gdW5zaGlmdENvdW50V2l0aEFycmF5U3RvcmFnZShleGVjLCBzdGFydEluZGV4LCBjb3Vu dCwgZW5zdXJlQXJyYXlTdG9yYWdlKHZtKSk7CiAgICAgICAgIH0KIAotICAgICAgICBpZiAob2xk TGVuZ3RoICsgY291bnQgPiBNQVhfU1RPUkFHRV9WRUNUT1JfTEVOR1RIKQorICAgICAgICBDaGVj a2VkPHVuc2lnbmVkLCBSZWNvcmRPdmVyZmxvdz4gY2hlY2tlZExlbmd0aChvbGRMZW5ndGgpOwor ICAgICAgICBjaGVja2VkTGVuZ3RoICs9IGNvdW50OworICAgICAgICB1bnNpZ25lZCBuZXdMZW5n dGg7CisgICAgICAgIGlmIChDaGVja2VkU3RhdGU6OkRpZE92ZXJmbG93ID09IGNoZWNrZWRMZW5n dGguc2FmZUdldChuZXdMZW5ndGgpKSB7CisgICAgICAgICAgICB0aHJvd091dE9mTWVtb3J5RXJy b3IoZXhlYywgc2NvcGUpOworICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgIH0KKyAg ICAgICAgaWYgKG5ld0xlbmd0aCA+IE1BWF9TVE9SQUdFX1ZFQ1RPUl9MRU5HVEgpCiAgICAgICAg ICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICAgICAgaWYgKCFlbnN1cmVMZW5ndGgodm0sIG9sZExl bmd0aCArIGNvdW50KSkgeworICAgICAgICBpZiAoIWVuc3VyZUxlbmd0aCh2bSwgbmV3TGVuZ3Ro KSkgewogICAgICAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9yKGV4ZWMsIHNjb3BlKTsKICAg ICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICB9CkBAIC0xMTEwLDEwICsxMTE2LDE2IEBA IGJvb2wgSlNBcnJheTo6dW5zaGlmdENvdW50V2l0aEFueUluZGV4aW5nVHlwZShFeGVjU3RhdGUq IGV4ZWMsIHVuc2lnbmVkIHN0YXJ0SW5kCiAgICAgICAgICAgICByZXR1cm4gdW5zaGlmdENvdW50 V2l0aEFycmF5U3RvcmFnZShleGVjLCBzdGFydEluZGV4LCBjb3VudCwgZW5zdXJlQXJyYXlTdG9y YWdlKHZtKSk7CiAgICAgICAgIH0KIAotICAgICAgICBpZiAob2xkTGVuZ3RoICsgY291bnQgPiBN QVhfU1RPUkFHRV9WRUNUT1JfTEVOR1RIKQorICAgICAgICBDaGVja2VkPHVuc2lnbmVkLCBSZWNv cmRPdmVyZmxvdz4gY2hlY2tlZExlbmd0aChvbGRMZW5ndGgpOworICAgICAgICBjaGVja2VkTGVu Z3RoICs9IGNvdW50OworICAgICAgICB1bnNpZ25lZCBuZXdMZW5ndGg7CisgICAgICAgIGlmIChD aGVja2VkU3RhdGU6OkRpZE92ZXJmbG93ID09IGNoZWNrZWRMZW5ndGguc2FmZUdldChuZXdMZW5n dGgpKSB7CisgICAgICAgICAgICB0aHJvd091dE9mTWVtb3J5RXJyb3IoZXhlYywgc2NvcGUpOwor ICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgIH0KKyAgICAgICAgaWYgKG5ld0xlbmd0 aCA+IE1BWF9TVE9SQUdFX1ZFQ1RPUl9MRU5HVEgpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7 Ci0KLSAgICAgICAgaWYgKCFlbnN1cmVMZW5ndGgodm0sIG9sZExlbmd0aCArIGNvdW50KSkgewor ICAgICAgICBpZiAoIWVuc3VyZUxlbmd0aCh2bSwgbmV3TGVuZ3RoKSkgewogICAgICAgICAgICAg dGhyb3dPdXRPZk1lbW9yeUVycm9yKGV4ZWMsIHNjb3BlKTsKICAgICAgICAgICAgIHJldHVybiB0 cnVlOwogICAgICAgICB9Cg== 338319 2018-04-19 06:45:26 -0700 2018-04-19 06:46:41 -0700 Patch bug-184772-20180419154524.patch text/plain 4279 rmorisset U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi MGQ5ZTJkMWI4MGU4MzM2OGM3MWY4ZDg4ZmRjOWFjZWY5ZDZiMjE3Li40MDMwNmEwYWRiMjhhZWYy MDE1NWEyMGJiNmJkMDdkYTM5YWI1MTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0wNC0xOSAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIEluIEZUTExvd2VyREZHVG9CMy5jcHA6OmNvbXBpbGVDcmVhdGVSZXN0 LCBhbHdheXMgdXNlIGEgY29udGlndW91cyBhcnJheSBhcyB0aGUgaW5kZXhpbmcgdHlwZSB3aGVu IHVuZGVyIGlzV2F0Y2hpbmdIYXZpbmdBQmFkVGltZVdhdGNocG9pbnQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDc3MworICAgICAgICA8cmRhcjov L3Byb2JsZW0vMzc3NzM2MTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2Ugd2VyZSBjYWxsaW5nIHJlc3RQYXJhbWV0ZXJTdHJ1Y3R1cmUoKSwgd2hp Y2ggcmV0dXJucyBhcnJheVN0cnVjdHVyZUZvckluZGV4aW5nVHlwZUR1cmluZ0FsbG9jYXRpb24o QXJyYXlXaXRoQ29udGlndW91cykuCisgICAgICAgIGFycmF5U3RydWN0dXJlRm9ySW5kZXhpbmdU eXBlRHVyaW5nQWxsb2NhdGlvbiB1c2VzIG1fYXJyYXlTdHJ1Y3R1cmVGb3JJbmRleGluZ1NoYXBl RHVyaW5nQWxsb2NhdGlvbiwgd2hpY2ggaXMgc2V0IHRvIFNsb3dQdXRBcnJheVN0b3JhZ2Ugd2hl biB3ZSBhcmUgJ2hhdmluZyBhIGJhZCB0aW1lJy4KKyAgICAgICAgVGhpcyBpcyBwcm9ibGVtYXRp YywgYmVjYXVzZSB0aGUgc3RydWN0dXJlIGlzIHRoZW4gcGFzc2VkIHRvIGFsbG9jYXRlVW5pbml0 aWFsaXplZENvbnRpZ3VvdXNKU0FycmF5LCB3aGljaCBBU1NFUlRzIHRoYXQgdGhlIGluZGV4aW5n IHR5cGUgaXMgY29udGlndW91cyAob3IgaW50MzIpLgorICAgICAgICBXZSBzb2x2ZSB0aGUgcHJv YmxlbSBieSB1c2luZyBvcmlnaW5hbEFycmF5U3RydWN0dXJlRm9ySW5kZXhpbmdUeXBlIHdoaWNo IGFsd2F5cyByZXR1cm5zIGEgc3RydWN0dXJlIHdpdGggdGhlIHJpZ2h0IGluZGV4aW5nIHR5cGUg KGNvbnRpZ3VvdXMpLCBldmVuIGlmIHdlIGFyZSBoYXZpbmcgYSBiYWQgdGltZS4KKyAgICAgICAg VGhpcyBpcyBzYWZlLCBhcyB3ZSBhcmUgdW5kZXIgaXNXYXRjaGluZ0hhdmluZ0FCYWRUaW1lV2F0 Y2hwb2ludCwgc28gaWYgd2UgaGF2ZSBhIGJhZCB0aW1lLCB0aGUgY29kZSB3ZSBnZW5lcmF0ZSB3 aWxsIG5ldmVyIGJlIGluc3RhbGxlZC4KKworICAgICAgICAqIGZ0bC9GVExMb3dlckRGR1RvQjMu Y3BwOgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0IzOjpjb21waWxlQ3JlYXRl UmVzdCk6CisKIDIwMTgtMDQtMTggIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnku Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIzMDc0OCkgW1dpbkNhaXJvXSAnSlNDOjpKSVQ6 OmFwcGVuZENhbGxXaXRoU2xvd1BhdGhSZXR1cm5UeXBlJzogZnVuY3Rpb24gZG9lcyBub3QgdGFr ZSAxIGFyZ3VtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExM b3dlckRGR1RvQjMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1Rv QjMuY3BwCmluZGV4IDY5NzVmN2EwMWVjOTg1MGRkZjU3YWY1ZmYzN2JmZWQ0NDZkNTMwNDQuLjQ1 MDg4YTNiYjkxMDQ5YTJmM2VmOWMwZmUzZjkxMjIyYmMxNDg3NjcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAKQEAgLTUyODEsNyArNTI4MSw3IEBA IHByaXZhdGU6CiAgICAgICAgICAgICBMVmFsdWUgYXJyYXlMZW5ndGggPSBsb3dJbnQzMihtX25v ZGUtPmNoaWxkMSgpKTsKICAgICAgICAgICAgIExCYXNpY0Jsb2NrIGxvb3BTdGFydCA9IG1fb3V0 Lm5ld0Jsb2NrKCk7CiAgICAgICAgICAgICBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0ID0g bV9ncmFwaC5nbG9iYWxPYmplY3RGb3IobV9ub2RlLT5vcmlnaW4uc2VtYW50aWMpOwotICAgICAg ICAgICAgUmVnaXN0ZXJlZFN0cnVjdHVyZSBzdHJ1Y3R1cmUgPSBtX2dyYXBoLnJlZ2lzdGVyU3Ry dWN0dXJlKGdsb2JhbE9iamVjdC0+cmVzdFBhcmFtZXRlclN0cnVjdHVyZSgpKTsKKyAgICAgICAg ICAgIFJlZ2lzdGVyZWRTdHJ1Y3R1cmUgc3RydWN0dXJlID0gbV9ncmFwaC5yZWdpc3RlclN0cnVj dHVyZShnbG9iYWxPYmplY3QtPm9yaWdpbmFsQXJyYXlTdHJ1Y3R1cmVGb3JJbmRleGluZ1R5cGUo QXJyYXlXaXRoQ29udGlndW91cykpOwogICAgICAgICAgICAgQXJyYXlWYWx1ZXMgYXJyYXlWYWx1 ZXMgPSBhbGxvY2F0ZVVuaW5pdGlhbGl6ZWRDb250aWd1b3VzSlNBcnJheShhcnJheUxlbmd0aCwg c3RydWN0dXJlKTsKICAgICAgICAgICAgIExWYWx1ZSBhcnJheSA9IGFycmF5VmFsdWVzLmFycmF5 OwogICAgICAgICAgICAgTFZhbHVlIGJ1dHRlcmZseSA9IGFycmF5VmFsdWVzLmJ1dHRlcmZseTsK ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg ODMxNDdhYWU3NGU5ZTExNTFjYTIwNmNhNTkxMDI0NzY2YmYyNGZjMC4uYThhYTU5ZWM5YTdjNDZi YzQ3OGVmMDcxNzc2MDI0YmVmYjM3NzM1YiAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cK KysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxOC0wNC0xOSAgUm9i aW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUuY29tPgorCisgICAgICAgIEluIEZUTExvd2Vy REZHVG9CMy5jcHA6OmNvbXBpbGVDcmVhdGVSZXN0LCBhbHdheXMgdXNlIGEgY29udGlndW91cyBh cnJheSBhcyB0aGUgaW5kZXhpbmcgdHlwZSB3aGVuIHVuZGVyIGlzV2F0Y2hpbmdIYXZpbmdBQmFk VGltZVdhdGNocG9pbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4NDc3MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzc3NzM2MTI+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBidWcgcmVxdWly ZXMgYSByYWNlIGJldHdlZW4gdGhlIHRocmVhZCBkb2luZyBGVEwgY29tcGlsYXRpb24gYW5kIHRo ZSBtYWluIHRocmVhZCwgYnV0IGl0IHRyaWdnZXJzIGluIDEwMCUgb2YgY2FzZXMgKGJlZm9yZSB0 aGUgZml4KSBvbiBteSBtYWNoaW5lCisgICAgICAgIHNvIEkgZGVjaWRlZCB0byBhZGQgaXQgdG8g dGhlIHN0cmVzcyB0ZXN0cyBub25ldGhlbGVzcy4KKworICAgICAgICAqIHN0cmVzcy9jcmVhdGUt cmVzdC13aGlsZS1oYXZpbmctYS1iYWQtdGltZS5qczogQWRkZWQuCisgICAgICAgIChmKToKKyAg ICAgICAgKGcpOgorICAgICAgICAoaCk6CisKIDIwMTgtMDQtMTggIFl1c3VrZSBTdXp1a2kgIDx1 dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW1dlYkFzc2VtYmx5XVtNb2R1bGVzXSBJ bXBvcnQgdGFibGVzIGluIHdhc20gbW9kdWxlcwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3Mv Y3JlYXRlLXJlc3Qtd2hpbGUtaGF2aW5nLWEtYmFkLXRpbWUuanMgYi9KU1Rlc3RzL3N0cmVzcy9j cmVhdGUtcmVzdC13aGlsZS1oYXZpbmctYS1iYWQtdGltZS5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lNTk5Njgx YmVjYzFhYmQwOGM0ODU5ZTk1NzQ2NGY2ZGZiNWZkNmJmCi0tLSAvZGV2L251bGwKKysrIGIvSlNU ZXN0cy9zdHJlc3MvY3JlYXRlLXJlc3Qtd2hpbGUtaGF2aW5nLWEtYmFkLXRpbWUuanMKQEAgLTAs MCArMSwxNiBAQAorInVzZSBzdHJpY3QiOworZnVuY3Rpb24gZiguLi52KSB7CisgIHJldHVybiBn KHYpOworfQorZnVuY3Rpb24gZygpIHsKKyAgcmV0dXJuIGgoKTsKK30KK2Z1bmN0aW9uIGgoKSB7 Cit9CisKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDA7ICsraSkgeworICBmKDApOworICBmKDAs IDApOworfQorCitPYmplY3QuZGVmaW5lUHJvcGVydHkoQXJyYXkucHJvdG90eXBlLCAiNDIiLCB7 fSk7Cg==