184761 2018-04-18 16:25:31 -0700 [WinCairo][EWS] Build bot should clean user temp directory each time. 2018-07-17 03:17:34 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=182758 https://bugs.webkit.org/show_bug.cgi?id=187725 InRadar P2 Normal --- 1 ross.kirsling ross.kirsling bfulgham commit-queue don.olmstead jbedard lforschler pvollan webkit-bug-importer oldest_to_newest 1415771 0 ross.kirsling 2018-04-18 16:25:31 -0700 [WinCairo][EWS] Build bot should clean user temp directory each time. 1415773 1 338276 ross.kirsling 2018-04-18 16:26:15 -0700 Created attachment 338276 Patch 1415804 2 338288 ross.kirsling 2018-04-18 17:40:03 -0700 Created attachment 338288 Patch 1415808 3 ross.kirsling 2018-04-18 17:47:34 -0700 *** Bug 182371 has been marked as a duplicate of this bug. *** 1415810 4 ross.kirsling 2018-04-18 17:47:45 -0700 *** Bug 182758 has been marked as a duplicate of this bug. *** 1415826 5 338288 lforschler 2018-04-18 18:54:09 -0700 Comment on attachment 338288 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338288&action=review I'm not a powershell expert, but this otherwise seems fine. > Tools/EWSTools/Start-Queue.ps1:58 > + Write-Host 'Cleaning user temp directory'; I would output the temp folder here, just to make it clear what directory you are working on. > Tools/EWSTools/Start-Queue.ps1:67 > + $filesRemoved++; if $file is a directory, it looks like you'll attempt to remove it recursively, but only increment $filesremoved once... so this count may not be accurate. Otherwise, I'm not sure what the purpose of the -Recurse is here on the Remove-Item line. > Tools/EWSTools/Start-Queue.ps1:68 > + Write-Host ('Removed file {0}' -f $file.FullName) This is going to be pretty verbose... do you actually want this list? Or was this just for debugging? 1415853 6 ross.kirsling 2018-04-18 21:18:48 -0700 (In reply to Lucas Forschler from comment #5) > Comment on attachment 338288 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338288&action=review > > I'm not a powershell expert, but this otherwise seems fine. > > > Tools/EWSTools/Start-Queue.ps1:58 > > + Write-Host 'Cleaning user temp directory'; > > I would output the temp folder here, just to make it clear what directory > you are working on. Good idea. > > Tools/EWSTools/Start-Queue.ps1:67 > > + $filesRemoved++; > > if $file is a directory, it looks like you'll attempt to remove it > recursively, but only increment $filesremoved once... so this count may not > be accurate. Otherwise, I'm not sure what the purpose of the -Recurse is > here on the Remove-Item line. > > > Tools/EWSTools/Start-Queue.ps1:68 > > + Write-Host ('Removed file {0}' -f $file.FullName) > > This is going to be pretty verbose... do you actually want this list? Or was > this just for debugging? This was mostly just a copy-paste-and-tweak of Don's function from here: https://github.com/WebKitForWindows/powershell-webkit-dev/blob/master/WebKitDev/Functions/Remove-TempFiles.ps1 But I agree that this could be simplified a bit. 1415856 7 338305 ross.kirsling 2018-04-18 21:21:38 -0700 Created attachment 338305 Patch 1415871 8 338305 commit-queue 2018-04-18 22:38:58 -0700 Comment on attachment 338305 Patch Clearing flags on attachment: 338305 Committed r230796: <https://trac.webkit.org/changeset/230796> 1415872 9 commit-queue 2018-04-18 22:39:00 -0700 All reviewed patches have been landed. Closing bug. 1415873 10 webkit-bug-importer 2018-04-18 22:39:21 -0700 <rdar://problem/39554382> 338276 2018-04-18 16:26:15 -0700 2018-04-18 17:40:01 -0700 Patch bug-184761-20180418162614.patch text/plain 2012 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNzc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2M3ZDIxZmE4ZmE3MWY2YjE3MGU0MjFmN2QwNDhjYWUz ODNhZWVlNC4uOGFkYWEyNTYwYTBmYjhkNzAxM2VjZTg5NjVhMDFjMWQwMDc3MzcxMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA0LTE4ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K KworICAgICAgICBbV2luQ2Fpcm9dW0VXU10gQnVpbGQgYm90IHNob3VsZCBjbGVhbiB1c2VyIHRl bXAgZGlyZWN0b3J5IGVhY2ggdGltZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4NDc2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogRVdTVG9vbHMvU3RhcnQtUXVldWUucHMxOgorICAgICAgICBDbGVh biB1c2VyJ3MgdGVtcCBkaXJlY3RvcnkgYmVmb3JlIGVhY2ggYnVpbGQsIHNvIHRoYXQgV2luZG93 cyBnaXQgZG9lc24ndCBmaWxsIGl0IHVwIG92ZXIgdGltZS4KKwogMjAxOC0wNC0xOCAgUm9zcyBL aXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgRml4IGFyY2hpdmUg c3RlcCBmb3IgV2luQ2Fpcm8gYnVpbGQgYm90LgpkaWZmIC0tZ2l0IGEvVG9vbHMvRVdTVG9vbHMv U3RhcnQtUXVldWUucHMxIGIvVG9vbHMvRVdTVG9vbHMvU3RhcnQtUXVldWUucHMxCmluZGV4IDNk N2JhMzhkMThlNTIwMmI3ZDhkMTgyZTgxNTYwY2YxZjI0OTZmZDYuLjVhMTM5OTlhYjQwZWNjODM0 NTIzNWU1ZjMwZDcxNGMyNDcxM2M5ZGMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0VXU1Rvb2xzL1N0YXJ0 LVF1ZXVlLnBzMQorKysgYi9Ub29scy9FV1NUb29scy9TdGFydC1RdWV1ZS5wczEKQEAgLTUyLDYg KzUyLDI3IEBAIGZ1bmN0aW9uIENsZWFuLUdpdAogICAgIGdpdCBjaGVja291dCBvcmlnaW4vbWFz dGVyIC1iIG1hc3RlcjsKIH0KIAorIyBPdmVyIHRpbWUsIGdpdCBmb3IgV2luZG93cyBjYW4gZmls bCB1cCBhIHVzZXIncyB0ZW1wb3JhcnkgZGlyZWN0b3J5IHdpdGggZmlsZXMuCitmdW5jdGlvbiBD bGVhbi1UZW1wRGlyZWN0b3J5Cit7CisgICAgV3JpdGUtSG9zdCAnQ2xlYW5pbmcgdXNlcidzIHRl bXBvcmFyeSBkaXJlY3RvcnknOworCisgICAgJHRlbXBGaWxlcyA9IEdldC1DaGlsZEl0ZW0gLVJl Y3Vyc2UgLUZvcmNlIC1FcnJvckFjdGlvbiBTaWxlbnRseUNvbnRpbnVlICRlbnY6dGVtcDsKKyAg ICAkZmlsZXNSZW1vdmVkID0gMDsKKworICAgIGZvcmVhY2ggKCRmaWxlIGluICR0ZW1wRmlsZXMp IHsKKyAgICAgIHRyeSB7CisgICAgICAgIFJlbW92ZS1JdGVtICRmaWxlLkZ1bGxOYW1lIC1SZWN1 cnNlIC1Gb3JjZSAtRXJyb3JBY3Rpb24gU3RvcAorICAgICAgICAkZmlsZXNSZW1vdmVkKys7Cisg ICAgICAgIFdyaXRlLUhvc3QgKCdSZW1vdmVkIGZpbGUgezB9JyAtZiAgJGZpbGUuRnVsbE5hbWUp CisgICAgICB9IGNhdGNoIHsKKyAgICAgICAgV3JpdGUtSG9zdCAoJ0NvdWxkIG5vdCByZW1vdmUg ZmlsZSB7MH0nIC1mICAkZmlsZS5GdWxsTmFtZSkKKyAgICAgIH0KKyAgICB9CisKKyAgICBXcml0 ZS1Ib3N0ICgnUmVtb3ZlZCB7MH0gZmlsZXMgZnJvbSB0ZW1wb3JhcnkgZGlyZWN0b3JpZXMnIC1m ICRmaWxlc1JlbW92ZWQpCit9CisKICMgVE9ETzogU3dpdGNoIHRvIHRlc3Qtd2Via2l0cHkgd2hl biBpdCB3b3JrcyB3aXRob3V0IGN5Z3dpbgogZnVuY3Rpb24gQ2xlYW4tUHl0aG9uQwogewpAQCAt ODEsNiArMTAyLDcgQEAgZnVuY3Rpb24gQ2xlYW4tV2ViS2l0QnVpbGQKIHdoaWxlICgkdHJ1ZSkg ewogICAgIENsZWFuLVdlYktpdEJ1aWxkOwogICAgIENsZWFuLVB5dGhvbkM7CisgICAgQ2xlYW4t VGVtcERpcmVjdG9yeTsKICAgICBDbGVhbi1HaXQ7CiAKICAgICBwZXJsIC4vVG9vbHMvU2NyaXB0 cy91cGRhdGUtd2Via2l0Owo= 338288 2018-04-18 17:40:03 -0700 2018-04-18 21:21:36 -0700 Patch bug-184761-20180418174002.patch text/plain 2120 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNzc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2M3ZDIxZmE4ZmE3MWY2YjE3MGU0MjFmN2QwNDhjYWUz ODNhZWVlNC4uOGFkYWEyNTYwYTBmYjhkNzAxM2VjZTg5NjVhMDFjMWQwMDc3MzcxMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA0LTE4ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K KworICAgICAgICBbV2luQ2Fpcm9dW0VXU10gQnVpbGQgYm90IHNob3VsZCBjbGVhbiB1c2VyIHRl bXAgZGlyZWN0b3J5IGVhY2ggdGltZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4NDc2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogRVdTVG9vbHMvU3RhcnQtUXVldWUucHMxOgorICAgICAgICBDbGVh biB1c2VyJ3MgdGVtcCBkaXJlY3RvcnkgYmVmb3JlIGVhY2ggYnVpbGQsIHNvIHRoYXQgV2luZG93 cyBnaXQgZG9lc24ndCBmaWxsIGl0IHVwIG92ZXIgdGltZS4KKwogMjAxOC0wNC0xOCAgUm9zcyBL aXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgRml4IGFyY2hpdmUg c3RlcCBmb3IgV2luQ2Fpcm8gYnVpbGQgYm90LgpkaWZmIC0tZ2l0IGEvVG9vbHMvRVdTVG9vbHMv U3RhcnQtUXVldWUucHMxIGIvVG9vbHMvRVdTVG9vbHMvU3RhcnQtUXVldWUucHMxCmluZGV4IDNk N2JhMzhkMThlNTIwMmI3ZDhkMTgyZTgxNTYwY2YxZjI0OTZmZDYuLjlhMTQxZDdlNGI1ZGNmNzdj M2ZjZDY5NjNjYWMzMDkxZWQ2MzE1OTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0VXU1Rvb2xzL1N0YXJ0 LVF1ZXVlLnBzMQorKysgYi9Ub29scy9FV1NUb29scy9TdGFydC1RdWV1ZS5wczEKQEAgLTUyLDYg KzUyLDMwIEBAIGZ1bmN0aW9uIENsZWFuLUdpdAogICAgIGdpdCBjaGVja291dCBvcmlnaW4vbWFz dGVyIC1iIG1hc3RlcjsKIH0KIAorIyBPdmVyIHRpbWUsIGdpdCBmb3IgV2luZG93cyBjYW4gZmls bCB1cCBhIHVzZXIncyB0ZW1wb3JhcnkgZGlyZWN0b3J5IHdpdGggZmlsZXMuCitmdW5jdGlvbiBD bGVhbi1UZW1wRGlyZWN0b3J5Cit7CisgICAgV3JpdGUtSG9zdCAnQ2xlYW5pbmcgdXNlciB0ZW1w IGRpcmVjdG9yeSc7CisKKyAgICAkdGVtcEZpbGVzID0gR2V0LUNoaWxkSXRlbSAtUmVjdXJzZSAt Rm9yY2UgLUVycm9yQWN0aW9uIFNpbGVudGx5Q29udGludWUgJGVudjp0ZW1wOworICAgICRmaWxl c1JlbW92ZWQgPSAwOworICAgICRmaWxlc05vdFJlbW92ZWQgPSAwOworCisgICAgZm9yZWFjaCAo JGZpbGUgaW4gJHRlbXBGaWxlcykgeworICAgICAgdHJ5IHsKKyAgICAgICAgUmVtb3ZlLUl0ZW0g JGZpbGUuRnVsbE5hbWUgLVJlY3Vyc2UgLUZvcmNlIC1FcnJvckFjdGlvbiBTdG9wCisgICAgICAg ICRmaWxlc1JlbW92ZWQrKzsKKyAgICAgICAgV3JpdGUtSG9zdCAoJ1JlbW92ZWQgZmlsZSB7MH0n IC1mICAkZmlsZS5GdWxsTmFtZSkKKyAgICAgIH0gY2F0Y2ggeworICAgICAgICAkZmlsZXNOb3RS ZW1vdmVkKys7CisgICAgICAgIFdyaXRlLUhvc3QgKCdDb3VsZCBub3QgcmVtb3ZlIGZpbGUgezB9 JyAtZiAgJGZpbGUuRnVsbE5hbWUpCisgICAgICB9CisgICAgfQorCisgICAgV3JpdGUtSG9zdCAo J3swfSBmaWxlcyBzdWNjZXNzZnVsbHkgcmVtb3ZlZC4nIC1mICRmaWxlc1JlbW92ZWQpCisgICAg V3JpdGUtSG9zdCAoJ3swfSBmaWxlcyBjb3VsZCBub3QgYmUgcmVtb3ZlZC4nIC1mICRmaWxlc05v dFJlbW92ZWQpCit9CisKICMgVE9ETzogU3dpdGNoIHRvIHRlc3Qtd2Via2l0cHkgd2hlbiBpdCB3 b3JrcyB3aXRob3V0IGN5Z3dpbgogZnVuY3Rpb24gQ2xlYW4tUHl0aG9uQwogewpAQCAtODEsNiAr MTA1LDcgQEAgZnVuY3Rpb24gQ2xlYW4tV2ViS2l0QnVpbGQKIHdoaWxlICgkdHJ1ZSkgewogICAg IENsZWFuLVdlYktpdEJ1aWxkOwogICAgIENsZWFuLVB5dGhvbkM7CisgICAgQ2xlYW4tVGVtcERp cmVjdG9yeTsKICAgICBDbGVhbi1HaXQ7CiAKICAgICBwZXJsIC4vVG9vbHMvU2NyaXB0cy91cGRh dGUtd2Via2l0Owo= 338305 2018-04-18 21:21:38 -0700 2018-04-18 22:38:58 -0700 Patch bug-184761-20180418212137.patch text/plain 1922 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNzc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2M3ZDIxZmE4ZmE3MWY2YjE3MGU0MjFmN2QwNDhjYWUz ODNhZWVlNC4uNGE5NmJkNmRlNWM3Yzk2YmU3YmZjNzQyMmVhMzBjODI5N2Q1YjJhOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA0LTE4ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K KworICAgICAgICBbV2luQ2Fpcm9dW0VXU10gQnVpbGQgYm90IHNob3VsZCBjbGVhbiB1c2VyIHRl bXAgZGlyZWN0b3J5IGVhY2ggdGltZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4NDc2MQorCisgICAgICAgIFJldmlld2VkIGJ5IEx1Y2FzIEZvcnNj aGxlci4KKworICAgICAgICAqIEVXU1Rvb2xzL1N0YXJ0LVF1ZXVlLnBzMToKKyAgICAgICAgQ2xl YW4gdXNlcidzIHRlbXAgZGlyZWN0b3J5IGJlZm9yZSBlYWNoIGJ1aWxkLCBzbyB0aGF0IFdpbmRv d3MgZ2l0IGRvZXNuJ3QgZmlsbCBpdCB1cCBvdmVyIHRpbWUuCisKIDIwMTgtMDQtMTggIFJvc3Mg S2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAgIEZpeCBhcmNoaXZl IHN0ZXAgZm9yIFdpbkNhaXJvIGJ1aWxkIGJvdC4KZGlmZiAtLWdpdCBhL1Rvb2xzL0VXU1Rvb2xz L1N0YXJ0LVF1ZXVlLnBzMSBiL1Rvb2xzL0VXU1Rvb2xzL1N0YXJ0LVF1ZXVlLnBzMQppbmRleCAz ZDdiYTM4ZDE4ZTUyMDJiN2Q4ZDE4MmU4MTU2MGNmMWYyNDk2ZmQ2Li44Mzc4N2FjNzQ5MzlkNGZk NjljNjRjNmE3NmYzNGIwYWY0NGY5NzJmIDEwMDY0NAotLS0gYS9Ub29scy9FV1NUb29scy9TdGFy dC1RdWV1ZS5wczEKKysrIGIvVG9vbHMvRVdTVG9vbHMvU3RhcnQtUXVldWUucHMxCkBAIC01Miw2 ICs1MiwxOSBAQCBmdW5jdGlvbiBDbGVhbi1HaXQKICAgICBnaXQgY2hlY2tvdXQgb3JpZ2luL21h c3RlciAtYiBtYXN0ZXI7CiB9CiAKKyMgT3ZlciB0aW1lLCBnaXQgZm9yIFdpbmRvd3MgY2FuIGZp bGwgdXAgYSB1c2VyJ3MgdGVtcG9yYXJ5IGRpcmVjdG9yeSB3aXRoIGZpbGVzLgorZnVuY3Rpb24g Q2xlYW4tVGVtcERpcmVjdG9yeQoreworICAgIFdyaXRlLUhvc3QgKCdDbGVhbmluZyB1c2VyIHRl bXAgZGlyZWN0b3J5ICh7MH0pLicgLWYgJGVudjp0ZW1wKTsKKyAgICAkY291bnRCZWZvcmUgPSAo R2V0LUNoaWxkSXRlbSAtUmVjdXJzZSAkZW52OnRlbXAgfCBNZWFzdXJlLU9iamVjdCkuQ291bnQ7 CisKKyAgICBHZXQtQ2hpbGRJdGVtICRlbnY6dGVtcCB8IFJlbW92ZS1JdGVtIC1SZWN1cnNlIC1G b3JjZSAtRXJyb3JBY3Rpb24gU2lsZW50bHlDb250aW51ZTsKKyAgICAkY291bnRBZnRlciA9IChH ZXQtQ2hpbGRJdGVtIC1SZWN1cnNlICRlbnY6dGVtcCB8IE1lYXN1cmUtT2JqZWN0KS5Db3VudDsK KworICAgIFdyaXRlLUhvc3QgKCd7MH0gaXRlbXMgc3VjY2Vzc2Z1bGx5IHJlbW92ZWQuJyAtZiAo JGNvdW50QmVmb3JlIC0gJGNvdW50QWZ0ZXIpKTsKKyAgICBXcml0ZS1Ib3N0ICgnezB9IGl0ZW1z IGNvdWxkIG5vdCBiZSByZW1vdmVkLicgLWYgJGNvdW50QWZ0ZXIpOworfQorCiAjIFRPRE86IFN3 aXRjaCB0byB0ZXN0LXdlYmtpdHB5IHdoZW4gaXQgd29ya3Mgd2l0aG91dCBjeWd3aW4KIGZ1bmN0 aW9uIENsZWFuLVB5dGhvbkMKIHsKQEAgLTgxLDYgKzk0LDcgQEAgZnVuY3Rpb24gQ2xlYW4tV2Vi S2l0QnVpbGQKIHdoaWxlICgkdHJ1ZSkgewogICAgIENsZWFuLVdlYktpdEJ1aWxkOwogICAgIENs ZWFuLVB5dGhvbkM7CisgICAgQ2xlYW4tVGVtcERpcmVjdG9yeTsKICAgICBDbGVhbi1HaXQ7CiAK ICAgICBwZXJsIC4vVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0Owo=