<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>184759</bug_id>
          
          <creation_ts>2018-04-18 14:55:10 -0700</creation_ts>
          <short_desc>Buildbots using Python zipfile should enable compression</short_desc>
          <delta_ts>2018-04-18 16:58:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ross Kirsling">ross.kirsling</reporter>
          <assigned_to name="Ross Kirsling">ross.kirsling</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>lforschler</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1415734</commentid>
    <comment_count>0</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2018-04-18 14:55:10 -0700</bug_when>
    <thetext>Buildbots using Python zipfile should enable compression</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415737</commentid>
    <comment_count>1</comment_count>
      <attachid>338266</attachid>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2018-04-18 14:57:15 -0700</bug_when>
    <thetext>Created attachment 338266
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415739</commentid>
    <comment_count>2</comment_count>
      <attachid>338266</attachid>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2018-04-18 14:59:13 -0700</bug_when>
    <thetext>Comment on attachment 338266
Patch

cool. Do you know offhand which ports call createZipManually? is it only &apos;win&apos; and &apos;wincairo&apos; ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415740</commentid>
    <comment_count>3</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-04-18 15:00:36 -0700</bug_when>
    <thetext>Only WinCairo. AppleWin is using cygwin.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415744</commentid>
    <comment_count>4</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2018-04-18 15:03:10 -0700</bug_when>
    <thetext>Right, Darwin uses `ditto` and Linux/Cygwin use the `zip` command.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415778</commentid>
    <comment_count>5</comment_count>
      <attachid>338266</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-04-18 16:40:41 -0700</bug_when>
    <thetext>Comment on attachment 338266
Patch

Clearing flags on attachment: 338266

Committed r230790: &lt;https://trac.webkit.org/changeset/230790&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415779</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-04-18 16:40:42 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415793</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-04-18 16:58:00 -0700</bug_when>
    <thetext>&lt;rdar://problem/39546871&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>338266</attachid>
            <date>2018-04-18 14:57:15 -0700</date>
            <delta_ts>2018-04-18 16:40:41 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-184759-20180418145714.patch</filename>
            <type>text/plain</type>
            <size>1431</size>
            <attacher name="Ross Kirsling">ross.kirsling</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNzc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2M3ZDIxZmE4ZmE3MWY2YjE3MGU0MjFmN2QwNDhjYWUz
ODNhZWVlNC4uOTY0NGZmYzNmNDc1YWRlNjhmNTliNjc5OTk1MjU5ZjAxNjVmNTA2NiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0
IEBACisyMDE4LTA0LTE4ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K
KworICAgICAgICBCdWlsZGJvdHMgdXNpbmcgUHl0aG9uIHppcGZpbGUgc2hvdWxkIGVuYWJsZSBj
b21wcmVzc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTg0NzU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmU6CisgICAgICAgIChj
cmVhdGVaaXBNYW51YWxseSk6CisgICAgICAgIERlZmF1bHQgaXMgdG8gYXJjaGl2ZSB3aXRob3V0
IGNvbXByZXNzaW5nLCBzbyB0ZWxsIGl0IHRvIGNvbXByZXNzIGFzIHdlbGwuIAorCiAyMDE4LTA0
LTE4ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBG
aXggYXJjaGl2ZSBzdGVwIGZvciBXaW5DYWlybyBidWlsZCBib3QuCmRpZmYgLS1naXQgYS9Ub29s
cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmUgYi9Ub29scy9CdWlsZFNs
YXZlU3VwcG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmUKaW5kZXggOWUwMTBmOWRlM2Y5ZGU2Njlj
MGNiMmU1N2NhMzJjNDc1Y2UzMzRmZi4uNjhmZTRiYTU1MjEzNGY2OTE1YWYyYTk3NTBhZGQ5Y2Vl
ZDNmOGZjZSAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVj
dC1hcmNoaXZlCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJj
aGl2ZQpAQCAtMTI5LDcgKzEyOSw3IEBAIGRlZiBjcmVhdGVaaXBGcm9tTGlzdChsaXN0VG9aaXAs
IGNvbmZpZ3VyYXRpb24sIGV4Y2x1ZGVQYXR0ZXJuPU5vbmUpOgogCiAKIGRlZiBjcmVhdGVaaXBN
YW51YWxseShkaXJlY3RvcnlUb1ppcCwgYXJjaGl2ZUZpbGUpOgotICAgIGFyY2hpdmVaaXAgPSB6
aXBmaWxlLlppcEZpbGUoYXJjaGl2ZUZpbGUsICJ3IikKKyAgICBhcmNoaXZlWmlwID0gemlwZmls
ZS5aaXBGaWxlKGFyY2hpdmVGaWxlLCAidyIsIHppcGZpbGUuWklQX0RFRkxBVEVEKQogCiAgICAg
Zm9yIHBhdGgsIGRpck5hbWVzLCBmaWxlTmFtZXMgaW4gb3Mud2FsayhkaXJlY3RvcnlUb1ppcCk6
CiAgICAgICAgIHJlbGF0aXZlUGF0aCA9IG9zLnBhdGgucmVscGF0aChwYXRoLCBkaXJlY3RvcnlU
b1ppcCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>