184757 2018-04-18 14:23:45 -0700 Ensure correct screen sizes 2018-04-22 14:23:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner aestes bdakin commit-queue thorton wenson_hsieh oldest_to_newest 1415718 0 megan_gardner 2018-04-18 14:23:45 -0700 Ensure correct screen sizes 1415719 1 338262 megan_gardner 2018-04-18 14:25:56 -0700 Created attachment 338262 Patch 1415723 2 megan_gardner 2018-04-18 14:26:23 -0700 <rdar://problem/39540423> 1415725 3 338262 wenson_hsieh 2018-04-18 14:27:35 -0700 Comment on attachment 338262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338262&action=review > Source/WebCore/ChangeLog:6 > + Make sure that the screen sizes are actually correct. Nit - description goes after the "Reviewed by" line. 1415736 4 megan_gardner 2018-04-18 14:55:25 -0700 https://trac.webkit.org/r230785 1416552 5 wenson_hsieh 2018-04-20 17:40:40 -0700 Reopening to attach new patch. 1416553 6 338502 wenson_hsieh 2018-04-20 17:40:40 -0700 Created attachment 338502 Add a layout test 1416785 7 338502 commit-queue 2018-04-22 14:23:21 -0700 Comment on attachment 338502 Add a layout test Clearing flags on attachment: 338502 Committed r230901: <https://trac.webkit.org/changeset/230901> 1416786 8 commit-queue 2018-04-22 14:23:23 -0700 All reviewed patches have been landed. Closing bug. 338262 2018-04-18 14:25:56 -0700 2018-04-20 17:42:59 -0700 Patch bug-184757-20180418142556.patch text/plain 1370 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMDc4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA0LTE4ICBNZWdhbiBH YXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRW5zdXJlIGNvcnJl Y3Qgc2NyZWVuIHNpemVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODQ3NTcKKworICAgICAgICBNYWtlIHN1cmUgdGhhdCB0aGUgc2NyZWVuIHNpemVz IGFyZSBhY3R1YWxseSBjb3JyZWN0LgorICAgICAgICAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm90IGN1cnJlbnRseSB0ZXN0YWJsZSwgd2lsbCBhZGQg dGVzdHMgd2hlbiBpdCBpcy4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9QbGF0Zm9ybVNjcmVl bklPUy5tbToKKwogMjAxOC0wNC0xOCAgTmFuIFdhbmcgIDxuX3dhbmdAYXBwbGUuY29tPgogCiAg ICAgICAgIEFYOiBbbWFjT1NdIFdlYktpdCBoYW5ncyB3aGVuIHRyaWdnZXJpbmcgYW4gYWxlcnQg ZnJvbSBhbiBBT00gaW5jcmVtZW50IGV2ZW50CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9pb3MvUGxhdGZvcm1TY3JlZW5JT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vaW9zL1BsYXRmb3JtU2NyZWVuSU9TLm1tCShyZXZpc2lvbiAyMzA3NzMpCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxhdGZvcm1TY3JlZW5JT1MubW0JKHdvcmtpbmcg Y29weSkKQEAgLTE0NiwxMCArMTQ2LDE0IEBAIEZsb2F0U2l6ZSBhdmFpbGFibGVTY3JlZW5TaXpl KCkKICAgICByZXR1cm4gRmxvYXRTaXplKFtnZXRfVUlLaXRfVUlTY3JlZW5DbGFzcygpIG1haW5T Y3JlZW5dLmJvdW5kcy5zaXplKTsKIH0KIAorI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspICYm IF9faGFzX2luY2x1ZGUoPFdlYktpdEFkZGl0aW9ucy9QbGF0Zm9ybVNjcmVlbklPUy5tbT4pCisj aW1wb3J0IDxXZWJLaXRBZGRpdGlvbnMvUGxhdGZvcm1TY3JlZW5JT1MubW0+CisjZWxzZQogRmxv YXRTaXplIG92ZXJyaWRlU2NyZWVuU2l6ZSgpCiB7CiAgICAgcmV0dXJuIHNjcmVlblNpemUoKTsK IH0KKyNlbmRpZgogCiBmbG9hdCBzY3JlZW5TY2FsZUZhY3RvcihVSVNjcmVlbiAqc2NyZWVuKQog ewo= 338502 2018-04-20 17:40:40 -0700 2018-04-22 14:23:21 -0700 Add a layout test bug-184757-20180420174039.patch text/plain 2496 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwODYxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmZjZGY1NjRkYWJjZGVlNzU1NDA0 YmIzYTMzMjQyOTFmYWIwMDA1YS4uOTk4YmJmZWYyMDY2Yjk1ZjNlYjVmYjZhMGQ0OTE4YTIzODc1 ZWU4MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA0LTIwICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBhIGxheW91dCB0ZXN0IGZvciBy MjMwNzg1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODQ3NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRzIGEgbmV3IGxheW91dCB0ZXN0IHRvIHZlcmlmeSB0aGF0IHRydWUgc2NyZWVuIGRpbWVuc2lv bnMgaW4gZXh0cmEgem9vbSBtb2RlCisgICAgICAgIGFyZSBvYnNlcnZhYmxlIGZyb20gdGhlIHBh Z2UsIHZpYSB3aW5kb3cuc2NyZWVuLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczoKKyAg ICAgICAgKiBmYXN0L2RvbS9XaW5kb3cvZXh0cmF6b29tL3dpbmRvdy1nZXQtcmVhbC1zY3JlZW4t ZGltZW5zaW9ucy5odG1sOiBBZGRlZC4KKwogMjAxOC0wNC0yMCAgQ2hyaXMgTmFyZGkgIDxjbmFy ZGlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVwZGF0ZSBIU0wvSFNMQSBwYXJzaW5nIHRvIG1h dGNoIENTUyBDb2xvciA0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25z IGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA4MTgwY2JkMzNjOTM2MDVmNTVm YTVjZmRjNjBjYWMyNDc1NmY4ZWVlLi5kNDhlMDE0YTk5MTQ5Nzc2NTczMmNmYjBlZTQyNDI2Zjhm MjE2ODg5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xh eW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE4LDYgKzE4LDcgQEAgZWRpdGluZy9jYXJl dC9pb3MgWyBTa2lwIF0KIGVkaXRpbmcvcGFzdGVib2FyZC9ndGsgWyBTa2lwIF0KIGVkaXRpbmcv c2VsZWN0aW9uL2lvcyBbIFNraXAgXQogdGlsZWQtZHJhd2luZyBbIFNraXAgXQorZmFzdC9kb20v V2luZG93L2V4dHJhem9vbSBbIFNraXAgXQogZmFzdC9mb3Jtcy9leHRyYXpvb20gWyBTa2lwIF0K IGZhc3QvdmlzdWFsLXZpZXdwb3J0L2V4dHJhem9vbSBbIFNraXAgXQogZmFzdC92aXN1YWwtdmll d3BvcnQvdGlsZWQtZHJhd2luZyBbIFNraXAgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9kb20vV2luZG93L2V4dHJhem9vbS93aW5kb3ctZ2V0LXJlYWwtc2NyZWVuLWRpbWVuc2lvbnMt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L2V4dHJhem9vbS93aW5k b3ctZ2V0LXJlYWwtc2NyZWVuLWRpbWVuc2lvbnMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmFk NmE1OWRmZjliODA2MDgwYjJlNGZjOWE4NThkOTIzOTk1MDA2MzMKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvZXh0cmF6b29tL3dpbmRvdy1nZXQtcmVhbC1z Y3JlZW4tZGltZW5zaW9ucy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw2IEBACitQQVNTIHNjcmVl bi53aWR0aCBpcyAzMjAKK1BBU1Mgc2NyZWVuLmhlaWdodCBpcyA1NjgKK1BBU1Mgc3VjY2Vzc2Z1 bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9XaW5kb3cvZXh0cmF6b29tL3dpbmRvdy1nZXQtcmVhbC1zY3JlZW4tZGlt ZW5zaW9ucy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L2V4dHJhem9vbS93aW5k b3ctZ2V0LXJlYWwtc2NyZWVuLWRpbWVuc2lvbnMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hZDBhODcwZGI5 YzhhNjBmZDkxMGQ4Nzk3ZTNjMTBhMDZhNTM5Y2E1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9kb20vV2luZG93L2V4dHJhem9vbS93aW5kb3ctZ2V0LXJlYWwtc2NyZWVuLWRp bWVuc2lvbnMuaHRtbApAQCAtMCwwICsxLDExIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwv c2NyaXB0PgorPC9oZWFkPgorPGJvZHk+PC9ib2R5PgorPHNjcmlwdD4KK3Nob3VsZEJlKCJzY3Jl ZW4ud2lkdGgiLCAiMzIwIik7CitzaG91bGRCZSgic2NyZWVuLmhlaWdodCIsICI1NjgiKTsKKzwv c2NyaXB0PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK