184754 2018-04-18 13:34:43 -0700 NetworkResourceLoader should not clean itself inside didReceiveResponse 2018-04-18 14:26:13 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez commit-queue ryanhaddad webkit-bug-importer oldest_to_newest 1415690 0 youennf 2018-04-18 13:34:43 -0700 Cleaning itself will clean NetworkLoad which is waiting for didReceiveResponse to do other stuff. 1415691 1 338257 youennf 2018-04-18 13:38:14 -0700 Created attachment 338257 Patch 1415693 2 338259 youennf 2018-04-18 13:57:41 -0700 Created attachment 338259 Patch 1415694 3 youennf 2018-04-18 13:58:27 -0700 Crash log is: Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x000000017d4ddef8 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Segmentation fault: 11 Termination Reason: Namespace SIGNAL, Code 0xb Terminating Process: exc handler [0] Application Specific Information: This process is running with libgmalloc.dylib (GuardMalloc) which may have forced the crash due to a memory access error. Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x000000010eff6ac6 WebKit::NetworkLoad::notifyDidReceiveResponse(WebCore::ResourceResponse&&, WTF::CompletionHandler<void (WebCore::PolicyAction)>&&) + 126 1 com.apple.WebKit 0x000000010efef1f6 WebKit::NetworkDataTask::didReceiveResponse(WebCore::ResourceResponse&&, WTF::CompletionHandler<void (WebCore::PolicyAction)>&&) + 326 2 com.apple.WebKit 0x000000010f01fb0d -[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:] + 328 3 com.apple.Foundation 0x000000010e83b5df __NSBLOCKOPERATION_IS_CALLING_OUT_TO_A_BLOCK__ + 7 4 com.apple.Foundation 0x000000010e83b441 -[NSBlockOperation main] + 68 1415697 4 youennf 2018-04-18 14:00:46 -0700 http/tests/xmlhttprequest/access-control-basic-denied.html is crashing with guard malloc before the patch, not after. 1415713 5 ryanhaddad 2018-04-18 14:21:50 -0700 <rdar://problem/39487184> 1415720 6 338259 commit-queue 2018-04-18 14:26:11 -0700 Comment on attachment 338259 Patch Clearing flags on attachment: 338259 Committed r230783: <https://trac.webkit.org/changeset/230783> 1415721 7 commit-queue 2018-04-18 14:26:13 -0700 All reviewed patches have been landed. Closing bug. 338257 2018-04-18 13:38:14 -0700 2018-04-18 13:57:40 -0700 Patch bug-184754-20180418133814.patch text/plain 1781 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMyOTAwMTgyYzgzNjUxMzM5 ZjQzODc5ZDYwYzdhYjM0ZWYwMzkxYTguLmM0ZTI3YjY1ZGMyYTM5MmY3ZmMzYWY3YTRiZWZiOWNh NjBiZmYwZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDQtMTggIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE5ldHdvcmtSZXNvdXJjZUxvYWRl ciBzaG91bGQgbm90IGNsZWFuIGl0c2VsZiBpbnNpZGUgZGlkUmVjZWl2ZVJlc3BvbnNlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ3NTQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWxheSB0aGUgY2xl YW51cCB0byBhZnRlciB0aGUgZGlkUmVjZWl2ZVJlc3BvbnNlIGNhbGwgc28gdGhhdCBOZXR3b3Jr TG9hZCBjYW4gdGVybWluYXRlIGl0cyB3b3JrLgorICAgICAgICBDb3ZlcmVkIGJ5IFhIUiBzeW5j IHRlc3RzIG5vIGxvbmdlciBjcmFzaGluZyBvbiBHdWFyZE1hbGxvYyBib3RzLgorCisgICAgICAg ICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdl YktpdDo6TmV0d29ya1Jlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UpOgorCiAyMDE4 LTA0LTE4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkLiBVcGRhdGUgT3B0aW9uc0dUSy5jbWFrZSBhbmQgTkVXUyBmb3IgMi4y MS4xIHJlbGVhc2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05l dHdvcmtSZXNvdXJjZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05l dHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggY2Y3ODhhYzE4NjM2N2UyMDE2YjNiYTdjNzNi MmMyYWM3OTEzMmFiNy4uMDk1MDhkYzE1N2RhYWNiMDhmZTdhZjM5MGJlZWUxNTc0OWYyZmQwYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VM b2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291 cmNlTG9hZGVyLmNwcApAQCAtMzQxLDcgKzM0MSw5IEBAIGF1dG8gTmV0d29ya1Jlc291cmNlTG9h ZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UoUmVzb3VyY2VSZXNwb25zZSYmIHJlY2VpdmVkUmVzcG9u CiAgICAgICAgIGlmICghZXJyb3IuaXNOdWxsKCkpIHsKICAgICAgICAgICAgIG1fc3luY2hyb25v dXNMb2FkRGF0YS0+ZXJyb3IgPSBXVEZNb3ZlKGVycm9yKTsKICAgICAgICAgICAgIHNlbmRSZXBs eVRvU3luY2hyb25vdXNSZXF1ZXN0KCptX3N5bmNocm9ub3VzTG9hZERhdGEsIG51bGxwdHIpOwot ICAgICAgICAgICAgY2xlYW51cCgpOworICAgICAgICAgICAgUnVuTG9vcDo6bWFpbigpLmRpc3Bh dGNoKFtwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyldKCkgbXV0YWJsZSB7CisgICAgICAg ICAgICAgICAgcHJvdGVjdGVkVGhpcy0+Y2xlYW51cCgpOworICAgICAgICAgICAgfSk7CiAgICAg ICAgICAgICByZXR1cm4gU2hvdWxkQ29udGludWVEaWRSZWNlaXZlUmVzcG9uc2U6Ok5vOwogICAg ICAgICB9CiAgICAgfQo= 338259 2018-04-18 13:57:41 -0700 2018-04-18 14:26:11 -0700 Patch bug-184754-20180418135740.patch text/plain 1773 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMyOTAwMTgyYzgzNjUxMzM5 ZjQzODc5ZDYwYzdhYjM0ZWYwMzkxYTguLmM0ZTI3YjY1ZGMyYTM5MmY3ZmMzYWY3YTRiZWZiOWNh NjBiZmYwZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDQtMTggIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE5ldHdvcmtSZXNvdXJjZUxvYWRl ciBzaG91bGQgbm90IGNsZWFuIGl0c2VsZiBpbnNpZGUgZGlkUmVjZWl2ZVJlc3BvbnNlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ3NTQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWxheSB0aGUgY2xl YW51cCB0byBhZnRlciB0aGUgZGlkUmVjZWl2ZVJlc3BvbnNlIGNhbGwgc28gdGhhdCBOZXR3b3Jr TG9hZCBjYW4gdGVybWluYXRlIGl0cyB3b3JrLgorICAgICAgICBDb3ZlcmVkIGJ5IFhIUiBzeW5j IHRlc3RzIG5vIGxvbmdlciBjcmFzaGluZyBvbiBHdWFyZE1hbGxvYyBib3RzLgorCisgICAgICAg ICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdl YktpdDo6TmV0d29ya1Jlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UpOgorCiAyMDE4 LTA0LTE4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkLiBVcGRhdGUgT3B0aW9uc0dUSy5jbWFrZSBhbmQgTkVXUyBmb3IgMi4y MS4xIHJlbGVhc2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05l dHdvcmtSZXNvdXJjZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05l dHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggY2Y3ODhhYzE4NjM2N2UyMDE2YjNiYTdjNzNi MmMyYWM3OTEzMmFiNy4uMjRhYjExMzU3MDc0OWQ0MjJhODRlMDQ5ZThkNmVmMDIwNGVkZjhmYSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VM b2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291 cmNlTG9hZGVyLmNwcApAQCAtMzQxLDcgKzM0MSw5IEBAIGF1dG8gTmV0d29ya1Jlc291cmNlTG9h ZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UoUmVzb3VyY2VSZXNwb25zZSYmIHJlY2VpdmVkUmVzcG9u CiAgICAgICAgIGlmICghZXJyb3IuaXNOdWxsKCkpIHsKICAgICAgICAgICAgIG1fc3luY2hyb25v dXNMb2FkRGF0YS0+ZXJyb3IgPSBXVEZNb3ZlKGVycm9yKTsKICAgICAgICAgICAgIHNlbmRSZXBs eVRvU3luY2hyb25vdXNSZXF1ZXN0KCptX3N5bmNocm9ub3VzTG9hZERhdGEsIG51bGxwdHIpOwot ICAgICAgICAgICAgY2xlYW51cCgpOworICAgICAgICAgICAgUnVuTG9vcDo6bWFpbigpLmRpc3Bh dGNoKFtwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyldKCkgeworICAgICAgICAgICAgICAg IHByb3RlY3RlZFRoaXMtPmNsZWFudXAoKTsKKyAgICAgICAgICAgIH0pOwogICAgICAgICAgICAg cmV0dXJuIFNob3VsZENvbnRpbnVlRGlkUmVjZWl2ZVJlc3BvbnNlOjpObzsKICAgICAgICAgfQog ICAgIH0K