184739 2018-04-18 11:04:29 -0700 Avoid crash if ITP Debug mode is on, but ResourceLoadStatistics are not being used 2018-04-18 11:56:02 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham ddkilzer wilander oldest_to_newest 1415593 0 bfulgham 2018-04-18 11:04:29 -0700 If a user has the ResourceLoadStatistics logic turned off, but has the ITP Debug experimental flag turned on, you can cause a crash. This is because the WebsiteDataStore for the process doesn't bother creating a ResourceLoadStatisticsStore if the statistics machinery is not running. The ITP debug flag was being blindly set without checking if the statistics store exists or not, which can cause a crash. 1415594 1 bfulgham 2018-04-18 11:07:11 -0700 <rdar://problem/39287964> 1415595 2 338228 bfulgham 2018-04-18 11:07:44 -0700 Created attachment 338228 Patch 1415598 3 wilander 2018-04-18 11:09:19 -0700 Looks good to me. 1415606 4 338228 ddkilzer 2018-04-18 11:29:01 -0700 Comment on attachment 338228 Patch r=me 1415627 5 bfulgham 2018-04-18 11:56:02 -0700 Committed r230771: <https://trac.webkit.org/changeset/230771> 338228 2018-04-18 11:07:44 -0700 2018-04-18 11:29:01 -0700 Patch bug-184739-20180418110744.patch text/plain 2120 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzA3NjkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA0LTE4ICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIGNyYXNoIGlmIElUUCBE ZWJ1ZyBtb2RlIGlzIG9uLCBidXQgUmVzb3VyY2VMb2FkU3RhdGlzdGljcyBhcmUgbm90IGJlaW5n IHVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 NDczOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzkyODc5NjQ+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgYSB1c2VyIGhhcyB0aGUgUmVzb3Vy Y2VMb2FkU3RhdGlzdGljcyBsb2dpYyB0dXJuZWQgb2ZmLCBidXQgaGFzIHRoZSBJVFAgRGVidWcg ZXhwZXJpbWVudGFsCisgICAgICAgIGZsYWcgdHVybmVkIG9uLCB5b3UgY2FuIGNhdXNlIGEgY3Jh c2guCisKKyAgICAgICAgVGhpcyBpcyBiZWNhdXNlIHRoZSBXZWJzaXRlRGF0YVN0b3JlIGZvciB0 aGUgcHJvY2VzcyBkb2Vzbid0IGJvdGhlciBjcmVhdGluZyBhIFJlc291cmNlTG9hZFN0YXRpc3Rp Y3NTdG9yZQorICAgICAgICBpZiB0aGUgc3RhdGlzdGljcyBtYWNoaW5lcnkgaXMgbm90IHJ1bm5p bmcuIFRoZSBJVFAgZGVidWcgZmxhZyB3YXMgYmVpbmcgYmxpbmRseSBzZXQgd2l0aG91dCBjaGVj a2luZworICAgICAgICBpZiB0aGUgc3RhdGlzdGljcyBzdG9yZSBleGlzdHMgb3Igbm90LCB3aGlj aCBjYW4gY2F1c2UgYSBjcmFzaC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJzaXRlRGF0YS9X ZWJzaXRlRGF0YVN0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6 c2V0UmVzb3VyY2VMb2FkU3RhdGlzdGljc0RlYnVnTW9kZSk6IENoZWNrIGlmIHRoZSBzdGF0aXN0 aWNzIHN0b3JlIGV4aXN0cworICAgICAgICBiZWZvcmUgY2FsbGluZyBmdW5jdGlvbnMgb24gaXQu CisKIDIwMTgtMDQtMTggIFBhdWwgS25pZ2h0ICA8cGtuaWdodEBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIC1bX1dLSW5wdXREZWxlZ2F0ZURlbGVnYXRlIHdpbGxTdGFydElucHV0U2Vzc2lvbjpd IGZvciBjbGllbnRzIHRoYXQgd2FudCB0byBjb25maWd1cmUgaW5wdXQgc2Vzc2lvbiBiZWZvcmUg YXNzaXN0aW5nIGZvcm0gbm9kZQpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0 ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAJKHJldmlzaW9uIDIzMDM1 OCkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3Rv cmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDM1LDcgKzE0MzUsOCBAQCBib29sIFdlYnNpdGVE YXRhU3RvcmU6OnJlc291cmNlTG9hZFN0YXRpCiB2b2lkIFdlYnNpdGVEYXRhU3RvcmU6OnNldFJl c291cmNlTG9hZFN0YXRpc3RpY3NEZWJ1Z01vZGUoYm9vbCBlbmFibGVkKQogewogICAgIG1fcmVz b3VyY2VMb2FkU3RhdGlzdGljc0RlYnVnTW9kZSA9IGVuYWJsZWQ7Ci0gICAgbV9yZXNvdXJjZUxv YWRTdGF0aXN0aWNzLT5zZXRSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGVidWdNb2RlKGVuYWJsZWQp OworICAgIGlmIChtX3Jlc291cmNlTG9hZFN0YXRpc3RpY3MpCisgICAgICAgIG1fcmVzb3VyY2VM b2FkU3RhdGlzdGljcy0+c2V0UmVzb3VyY2VMb2FkU3RhdGlzdGljc0RlYnVnTW9kZShlbmFibGVk KTsKIH0KIAogdm9pZCBXZWJzaXRlRGF0YVN0b3JlOjplbmFibGVSZXNvdXJjZUxvYWRTdGF0aXN0 aWNzQW5kU2V0VGVzdGluZ0NhbGxiYWNrKEZ1bmN0aW9uPHZvaWQgKGNvbnN0IFN0cmluZyYpPiYm IGNhbGxiYWNrKQo=