184725 2018-04-18 02:23:33 -0700 REGRESSION(r230748) [WinCairo] 'JSC::JIT::appendCallWithSlowPathReturnType': function does not take 1 arguments 2018-04-18 13:21:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii ross.kirsling commit-queue don.olmstead ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam webkit-bug-importer oldest_to_newest 1415507 0 fujii 2018-04-18 02:23:33 -0700 REGRESSION(r230748) 'JSC::JIT::appendCallWithSlowPathReturnType': function does not take 1 arguments Windows x64 builds are failing. https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/12475 > [115/270] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\__\__\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource80.cpp.obj > FAILED: Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource80.cpp.obj > "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.12.25827\bin\Hostx64\x64\cl.exe" /nologo /TP -DBUILDING_JavaScriptCore -DBUILDING_WITH_CMAKE=1 -DHAVE_CONFIG_H=1 -DJavaScriptCore_EXPORTS -DNOMINMAX -DUCHAR_TYPE=wchar_t -DUNICODE -DWINVER=0x601 -DWTF_PLATFORM_WIN_CAIRO=1 -D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1 -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WIN32_WINNT=0x601 -D_WINDOWS -D_WINSOCKAPI_="" -I..\..\WebKitLibraries\win\include -IDerivedSources\ForwardingHeaders -I. -I..\..\Source\JavaScriptCore -I..\..\Source\JavaScriptCore\API -I..\..\Source\JavaScriptCore\assembler -I..\..\Source\JavaScriptCore\b3 -I..\..\Source\JavaScriptCore\b3\air -I..\..\Source\JavaScriptCore\bindings -I..\..\Source\JavaScriptCore\builtins -I..\..\Source\JavaScriptCore\bytecode -I..\..\Source\JavaScriptCore\bytecompiler -I..\..\Source\JavaScriptCore\dfg -I..\..\Source\JavaScriptCore\disassembler -I..\..\Source\JavaScriptCore\disassembler\ARM64 -I..\..\Source\JavaScriptCore\disassembler\ARMv7 -I..\..\Source\JavaScriptCore\disassembler\udis86 -I..\..\Source\JavaScriptCore\domjit -I..\..\Source\JavaScriptCore\ftl -I..\..\Source\JavaScriptCore\heap -I..\..\Source\JavaScriptCore\debugger -I..\..\Source\JavaScriptCore\inspector -I..\..\Source\JavaScriptCore\inspector\agents -I..\..\Source\JavaScriptCore\inspector\augmentable -I..\..\Source\JavaScriptCore\inspector\remote -I..\..\Source\JavaScriptCore\interpreter -I..\..\Source\JavaScriptCore\jit -I..\..\Source\JavaScriptCore\llint -I..\..\Source\JavaScriptCore\parser -I..\..\Source\JavaScriptCore\profiler -I..\..\Source\JavaScriptCore\runtime -I..\..\Source\JavaScriptCore\tools -I..\..\Source\JavaScriptCore\wasm -I..\..\Source\JavaScriptCore\wasm\js -I..\..\Source\JavaScriptCore\yarr -IDerivedSources\JavaScriptCore -IDerivedSources\JavaScriptCore\inspector -IDerivedSources\JavaScriptCore\runtime -IDerivedSources\JavaScriptCore\yarr -I..\include\private -I..\..\Source\bmalloc -IDerivedSources -I..\..\Source\ThirdParty /DWIN32 /D_WINDOWS /W4 /GR- /EHs- /EHc- /MD /O2 /Ob2 /DNDEBUG /wd4018 /wd4068 /wd4099 /wd4100 /wd4127 /wd4138 /wd4146 /wd4180 /wd4189 /wd4201 /wd4206 /wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291 /wd4305 /wd4309 /wd4344 /wd4355 /wd4389 /wd4396 /wd4456 /wd4457 /wd4458 /wd4459 /wd4481 /wd4503 /wd4505 /wd4510 /wd4512 /wd4530 /wd4610 /wd4611 /wd4646 /wd4702 /wd4706 /wd4722 /wd4800 /wd4819 /wd4951 /wd4952 /wd4996 /wd6011 /wd6031 /wd6211 /wd6246 /wd6255 /wd6387 /Zi /GS /EHa- /EHc- /EHs- /fp:except- /analyze- /bigobj /Gy- /openmp- /GF- /utf-8 /validate-charset /Oy- /showIncludes /FoSource\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\__\__\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource80.cpp.obj /FdSource\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\ /FS -c DerivedSources\JavaScriptCore\unified-sources\UnifiedSource80.cpp > c:\webkit-buildslave\win-cairo-release\build\source\javascriptcore\jit\JITInlines.h(164): error C2660: 'JSC::JIT::appendCallWithSlowPathReturnType': function does not take 1 arguments 1415514 1 338207 fujii 2018-04-18 03:34:53 -0700 Created attachment 338207 WIP patch This patch doesn't solve all problems. >------ Build started: Project: JavaScriptCore (JavaScriptCore\JavaScriptCore), Configuration: Debug x64 ------ >UnifiedSource80.cpp >c:\webkit\ga\source\javascriptcore\jit\ccallhelpers.h(699): error C2338: Basic sanity check >c:\webkit\ga\source\javascriptcore\jit\jit.h(731): note: see reference to function template instantiation 'void JSC::CCallHelpers::setupArguments<OperationType,>(void)' being compiled > with > [ > OperationType=JSC::SlowPathReturnType (__cdecl *)(JSC::ExecState *,uint32_t) > ] >c:\webkit\ga\source\javascriptcore\jit\jit.cpp(112): note: see reference to function template instantiation 'JSC::AbstractMacroAssembler<JSC::Assembler>::Call JSC::JIT::callOperation<JSC::SlowPathReturnType(__cdecl *)(JSC::ExecState *,uint32_t),>(OperationType,int)' being compiled > with > [ > OperationType=JSC::SlowPathReturnType (__cdecl *)(JSC::ExecState *,uint32_t) > ] >c:\webkit\ga\source\javascriptcore\bytecode\codeblock.h(964): note: see reference to class template instantiation 'WTF::Poisoned<JSC::CodeBlockPoison,JSC::VM *,void>' being compiled 1415543 2 338207 mark.lam 2018-04-18 07:40:49 -0700 Comment on attachment 338207 WIP patch Patch looks good but needs a ChangeLog. You can use Tools/Scripts/prepare-ChangeLog to create that, and then fill in the details. 1415614 3 338232 ross.kirsling 2018-04-18 11:39:18 -0700 Created attachment 338232 Patch 1415616 4 338232 mark.lam 2018-04-18 11:44:30 -0700 Comment on attachment 338232 Patch r=me 1415620 5 ross.kirsling 2018-04-18 11:50:01 -0700 (In reply to Mark Lam from comment #4) > Comment on attachment 338232 [details] > Patch > > r=me Thanks. I just wanted to note that the failure to build was reported correctly by WinCairo EWS in the original ticket, though this may have been obscured by the fact that the first patch hit an intermittent failure to apply. I definitely want to make stabilizing WinCairo EWS a priority over here (as it is certainly frustrating for everyone involved), but please note in the meantime that successive red bubbles should indicate legitimate breakage. 1415673 6 338232 commit-queue 2018-04-18 13:20:02 -0700 Comment on attachment 338232 Patch Clearing flags on attachment: 338232 Committed r230776: <https://trac.webkit.org/changeset/230776> 1415674 7 commit-queue 2018-04-18 13:20:03 -0700 All reviewed patches have been landed. Closing bug. 1415676 8 webkit-bug-importer 2018-04-18 13:21:22 -0700 <rdar://problem/39538070> 338207 2018-04-18 03:34:53 -0700 2018-04-18 11:39:16 -0700 WIP patch wip.patch text/plain 781 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmggYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0pJVC5oCmluZGV4IDkzYzVkNDQzOTBmLi41NjRmZTdjNzUyZSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuaAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0pJVC5oCkBAIC0yNzUsOSArMjc1LDkgQEAgbmFtZXNwYWNlIEpTQyB7 CiAgICAgICAgIH0KIAogI2lmIE9TKFdJTkRPV1MpICYmIENQVShYODZfNjQpCi0gICAgICAgIENh bGwgYXBwZW5kQ2FsbFdpdGhTbG93UGF0aFJldHVyblR5cGUoY29uc3QgRnVuY3Rpb25QdHI8Q0Z1 bmN0aW9uUHRyVGFnPiBmdW5jdGlvbiwgUHRyVGFnIHRhZykKKyAgICAgICAgQ2FsbCBhcHBlbmRD YWxsV2l0aFNsb3dQYXRoUmV0dXJuVHlwZShjb25zdCBGdW5jdGlvblB0cjxDRnVuY3Rpb25QdHJU YWc+IGZ1bmN0aW9uKQogICAgICAgICB7Ci0gICAgICAgICAgICBDYWxsIGZ1bmN0aW9uQ2FsbCA9 IGNhbGxXaXRoU2xvd1BhdGhSZXR1cm5UeXBlKHRhZyk7CisgICAgICAgICAgICBDYWxsIGZ1bmN0 aW9uQ2FsbCA9IGNhbGxXaXRoU2xvd1BhdGhSZXR1cm5UeXBlKE9wZXJhdGlvblB0clRhZyk7CiAg ICAgICAgICAgICBtX2NhbGxzLmFwcGVuZChDYWxsUmVjb3JkKGZ1bmN0aW9uQ2FsbCwgbV9ieXRl Y29kZU9mZnNldCwgZnVuY3Rpb24ucmV0YWdnZWQ8T3BlcmF0aW9uUHRyVGFnPigpKSk7CiAgICAg ICAgICAgICByZXR1cm4gZnVuY3Rpb25DYWxsOwogICAgICAgICB9Cg== 338232 2018-04-18 11:39:18 -0700 2018-04-18 13:20:02 -0700 Patch bug-184725-20180418113917.patch text/plain 2134 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NTA0YzNmN2Q4YzYxODVlMDA1MjE0OWQ0Njk4NjEzZTZjN2I5OGYwLi45ZDY0YmU3YmZiZWIxNjll ZTY3NmU5ZWM4YjdiMzE5NjUzZjdiMGIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxOC0wNC0xOCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjMwNzQ4KSBbV2luQ2Fpcm9dICdKU0M6OkpJ VDo6YXBwZW5kQ2FsbFdpdGhTbG93UGF0aFJldHVyblR5cGUnOiBmdW5jdGlvbiBkb2VzIG5vdCB0 YWtlIDEgYXJndW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODQ3MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGppdC9KSVQuaDoKKwogMjAxOC0wNC0xOCAgVG9tYXMgUG9wZWxhICA8dHBvcGVs YUByZWRoYXQuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCBidWlsZCBvbiBBUk0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmggYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0pJVC5oCmluZGV4IDkzYzVkNDQzOTBmMzE5YzdiZGM2YTQyYTlkM2M5NDQy NGIwYmFmNWQuLmUzODJhYWM1NzY0ZmVkMmVhOTA4ODFkYWFlMzdiZmRmYjZjNDliMDIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9KSVQuaApAQCAtMjc1LDkgKzI3NSw5IEBAIG5hbWVzcGFjZSBKU0Mgewog ICAgICAgICB9CiAKICNpZiBPUyhXSU5ET1dTKSAmJiBDUFUoWDg2XzY0KQotICAgICAgICBDYWxs IGFwcGVuZENhbGxXaXRoU2xvd1BhdGhSZXR1cm5UeXBlKGNvbnN0IEZ1bmN0aW9uUHRyPENGdW5j dGlvblB0clRhZz4gZnVuY3Rpb24sIFB0clRhZyB0YWcpCisgICAgICAgIENhbGwgYXBwZW5kQ2Fs bFdpdGhTbG93UGF0aFJldHVyblR5cGUoY29uc3QgRnVuY3Rpb25QdHI8Q0Z1bmN0aW9uUHRyVGFn PiBmdW5jdGlvbikKICAgICAgICAgewotICAgICAgICAgICAgQ2FsbCBmdW5jdGlvbkNhbGwgPSBj YWxsV2l0aFNsb3dQYXRoUmV0dXJuVHlwZSh0YWcpOworICAgICAgICAgICAgQ2FsbCBmdW5jdGlv bkNhbGwgPSBjYWxsV2l0aFNsb3dQYXRoUmV0dXJuVHlwZShPcGVyYXRpb25QdHJUYWcpOwogICAg ICAgICAgICAgbV9jYWxscy5hcHBlbmQoQ2FsbFJlY29yZChmdW5jdGlvbkNhbGwsIG1fYnl0ZWNv ZGVPZmZzZXQsIGZ1bmN0aW9uLnJldGFnZ2VkPE9wZXJhdGlvblB0clRhZz4oKSkpOwogICAgICAg ICAgICAgcmV0dXJuIGZ1bmN0aW9uQ2FsbDsKICAgICAgICAgfQpAQCAtNzMzLDYgKzczMywxNCBA QCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgfQogCiAjaWYgT1MoV0lORE9XUykgJiYgQ1BVKFg4 Nl82NCkKKyAgICAgICAgdGVtcGxhdGU8dHlwZW5hbWUgT3BlcmF0aW9uVHlwZSwgdHlwZW5hbWUu Li4gQXJncz4KKyAgICAgICAgc3RkOjplbmFibGVfaWZfdDxzdGQ6OmlzX3NhbWU8dHlwZW5hbWUg RnVuY3Rpb25UcmFpdHM8T3BlcmF0aW9uVHlwZT46OlJlc3VsdFR5cGUsIFNsb3dQYXRoUmV0dXJu VHlwZT46OnZhbHVlLCBNYWNyb0Fzc2VtYmxlcjo6Q2FsbD4KKyAgICAgICAgY2FsbE9wZXJhdGlv bihPcGVyYXRpb25UeXBlIG9wZXJhdGlvbiwgQXJncy4uLiBhcmdzKQorICAgICAgICB7CisgICAg ICAgICAgICBzZXR1cEFyZ3VtZW50czxPcGVyYXRpb25UeXBlPihhcmdzLi4uKTsKKyAgICAgICAg ICAgIHJldHVybiBhcHBlbmRDYWxsV2l0aEV4Y2VwdGlvbkNoZWNrQW5kU2xvd1BhdGhSZXR1cm5U eXBlKG9wZXJhdGlvbik7CisgICAgICAgIH0KKwogICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBU eXBlPgogICAgICAgICBzdGF0aWMgY29uc3RleHByIGJvb2wgaXM2NEJpdFR5cGUoKSB7IHJldHVy biBzaXplb2YoVHlwZSkgPD0gODsgfQogCg==