184719 2018-04-17 17:07:50 -0700 Don't activate selection on become first responder 2018-04-17 18:04:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner bdakin thorton timothy webkit-bug-importer wenson_hsieh oldest_to_newest 1415365 0 megan_gardner 2018-04-17 17:07:50 -0700 Don't activate selection on become first responder 1415373 1 338164 megan_gardner 2018-04-17 17:13:21 -0700 Created attachment 338164 Patch 1415374 2 megan_gardner 2018-04-17 17:14:06 -0700 I also talked with Morgan and he agrees that this is reasonable to do. 1415388 3 338164 thorton 2018-04-17 17:37:05 -0700 Comment on attachment 338164 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338164&action=review > Source/WebKit/ChangeLog:9 > + as there are not guaranteed to have selection rects immediately due to async/two process architecture. The selection as there? > Source/WebKit/ChangeLog:11 > + in the past because this selection assistant was only for editable text, which would immediately set a carat, which caret! This is not gold. > Source/WebKit/ChangeLog:12 > + counted at a selection. Now that this is for non-editable text as well, activating the selection is problematic. Counted!? 1415406 4 webkit-bug-importer 2018-04-17 18:03:46 -0700 <rdar://problem/39512619> 1415407 5 megan_gardner 2018-04-17 18:04:04 -0700 https://webkit.org/b/184719 1415408 6 megan_gardner 2018-04-17 18:04:19 -0700 https://trac.webkit.org/r230745 338164 2018-04-17 17:13:21 -0700 2018-04-17 17:37:05 -0700 Patch bug-184719-20180417171321.patch text/plain 1977 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzA3NDEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA0LTE3ICBNZWdhbiBHYXJk bmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgYWN0aXZhdGUg c2VsZWN0aW9uIG9uIGJlY29tZSBmaXJzdCByZXNwb25kZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDcxOQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgSWYgd2UgYWN0aXZhdGUgdGhlIHNl bGVjdGlvbiBpbW1lZGlhdGVseSBvbiBiZWNvbWluZyBmaXJzdCByZXNwb25kZXIsIHdlIGNhdXNl IHRoZSBzZWxlY3Rpb24gdmlldyB0byBkZWxldGUgaXRzZWxmCisgICAgICAgIGFzIHRoZXJlIGFy ZSBub3QgZ3VhcmFudGVlZCB0byBoYXZlIHNlbGVjdGlvbiByZWN0cyBpbW1lZGlhdGVseSBkdWUg dG8gYXN5bmMvdHdvIHByb2Nlc3MgYXJjaGl0ZWN0dXJlLiBUaGUgc2VsZWN0aW9uCisgICAgICAg IGlzIGFjdGl2YXRlZCBhbHJlYWR5IHdoZW4gdGhlIHNlbGVjdGlvbiByZWN0cyBjaGFuZ2UsIHNv IHRoZXJlIGlzIG5vIHJlYXNvbiB0byBhY3RpdmF0ZSBpdCBub3cuIFRoaXMgaGFzIGxpa2VseSB3 b3JrZWQKKyAgICAgICAgaW4gdGhlIHBhc3QgYmVjYXVzZSB0aGlzIHNlbGVjdGlvbiBhc3Npc3Rh bnQgd2FzIG9ubHkgZm9yIGVkaXRhYmxlIHRleHQsIHdoaWNoIHdvdWxkIGltbWVkaWF0ZWx5IHNl dCBhIGNhcmF0LCB3aGljaCAKKyAgICAgICAgY291bnRlZCBhdCBhIHNlbGVjdGlvbi4gTm93IHRo YXQgdGhpcyBpcyBmb3Igbm9uLWVkaXRhYmxlIHRleHQgYXMgd2VsbCwgYWN0aXZhdGluZyB0aGUg c2VsZWN0aW9uIGlzIHByb2JsZW1hdGljLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0Nv bnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgYmVjb21l Rmlyc3RSZXNwb25kZXJGb3JXZWJWaWV3XSk6CisKIDIwMTgtMDQtMTcgIEFkcmlhbiBQZXJleiBk ZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIEJ1aWxk IGZhaWx1cmUgZHVlIHRvIHByZXNlbmNlIG9mIEF2YWhpJ3MgPGRuc19zZC5oPiBoZWFkZXIKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbQkocmV2aXNpb24gMjMwNjg2KQorKysgU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkod29ya2luZyBjb3B5KQpAQCAt OTM3LDggKzkzNyw2IEBAIC0gKEJPT0wpYmVjb21lRmlyc3RSZXNwb25kZXJGb3JXZWJWaWV3CiAg ICAgICAgIFNldEZvclNjb3BlPEJPT0w+IGJlY29taW5nRmlyc3RSZXNwb25kZXIgeyBfYmVjb21p bmdGaXJzdFJlc3BvbmRlciwgWUVTIH07CiAgICAgICAgIGRpZEJlY29tZUZpcnN0UmVzcG9uZGVy ID0gW3N1cGVyIGJlY29tZUZpcnN0UmVzcG9uZGVyXTsKICAgICB9Ci0gICAgaWYgKGRpZEJlY29t ZUZpcnN0UmVzcG9uZGVyICYmICFzZWxmLnN1cHByZXNzQXNzaXN0YW50U2VsZWN0aW9uVmlldykK LSAgICAgICAgW190ZXh0U2VsZWN0aW9uQXNzaXN0YW50IGFjdGl2YXRlU2VsZWN0aW9uXTsKIAog ICAgIHJldHVybiBkaWRCZWNvbWVGaXJzdFJlc3BvbmRlcjsKIH0K