184711 2018-04-17 15:15:05 -0700 [GTK][WPE] Build failure due to presence of Avahi's <dns_sd.h> header 2018-04-17 16:42:25 -0700 1 1 1 Unclassified WebKit WebRTC Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=184713 InRadar P2 Normal --- 1 aperez aperez commit-queue eric.carlson ews-watchlist webkit-bug-importer youennf oldest_to_newest 1415297 0 aperez 2018-04-17 15:15:05 -0700 The build failure is: […]/NetworkMDNSRegister.cpp:106:53: error: use of undeclared identifier 'dispatch_get_main_queue' error = DNSServiceSetDispatchQueue(service, dispatch_get_main_queue()); ^ Indeed, on GNU/Linux systems we do not have libdispatch! After a bit of investigation, I have found the following snippet inside “Source/WebKit/webrtc/NetworkProcess/NetworkMDNSRegister.h”: #if defined __has_include && __has_include(<dns_sd.h>) #define ENABLE_MDNS 1 #else #define ENABLE_MDNS 0 #endif It turns our that in systems with Avahi installed, it may optionally supply a <dns_sd.h> header which provides a certain degree of compatibility with Apple's libdns_sd but it is lacks functionality needed by WebKit (see https://github.com/lathiat/avahi/tree/master/avahi-compat-libdns_sd). We should detect when Avahi's version is installed, and if that is the case set ENABLE_MDNS to 0. 1415298 1 youennf 2018-04-17 15:18:10 -0700 Oh I see, maybe the short term fix would be to add a PLATFORM(COCOA) check? 1415304 2 aperez 2018-04-17 15:29:53 -0700 (In reply to youenn fablet from comment #1) > Oh I see, maybe the short term fix would be to add a PLATFORM(COCOA) check? Yes, exactly my plan. Later on down the line we may want to implement MDNS support using Avahi's full API instead of its libdns_sd compatibility API. 1415305 3 338154 aperez 2018-04-17 15:34:35 -0700 Created attachment 338154 Patch 1415310 4 aperez 2018-04-17 15:42:23 -0700 Filed bug #184713 to track implementing the functionality using Avahi, this one is only for the build failure fix. 1415336 5 338154 commit-queue 2018-04-17 16:41:14 -0700 Comment on attachment 338154 Patch Clearing flags on attachment: 338154 Committed r230739: <https://trac.webkit.org/changeset/230739> 1415337 6 commit-queue 2018-04-17 16:41:16 -0700 All reviewed patches have been landed. Closing bug. 1415339 7 webkit-bug-importer 2018-04-17 16:42:25 -0700 <rdar://problem/39509941> 338154 2018-04-17 15:34:35 -0700 2018-04-17 16:41:14 -0700 Patch bug-184711-20180417233434.patch text/plain 1380 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGViNzBkYTQ4NmZhMjA5Zjcy ZTcyM2NhN2MyZGRiOTFjY2YwNTZhZGUuLjJjYmU4MDcwOWY0ZTRiMmQ1NWI2Mzc1NzI5MmE3Njkz NmI0NTA5ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTgtMDQtMTcgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVd IEJ1aWxkIGZhaWx1cmUgZHVlIHRvIHByZXNlbmNlIG9mIEF2YWhpJ3MgPGRuc19zZC5oPiBoZWFk ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDcx MQorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisgICAgICAgICogTmV0d29ya1By b2Nlc3Mvd2VicnRjL05ldHdvcmtNRE5TUmVnaXN0ZXIuaDogU2V0IEVOQUJMRV9NRE5TIG9ubHkg Zm9yIFBMQVRGT1JNKENPQ09BKS4KKwogMjAxOC0wNC0xNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyMjk4MzEpOiBDTUQtY2xpY2tpbmcg YW4gaUNsb3VkIHdlYiBhcHAgbGluayB1bmV4cGVjdGVkbHkgb3BlbnMgdGhhdCBsaW5rIGluIGEg bmV3IHRhYiBhbmQgdGhlIGN1cnJlbnQgdGFiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrTUROU1JlZ2lzdGVyLmggYi9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrTUROU1JlZ2lzdGVyLmgKaW5kZXggOGZlMzk3 ZjQxZDIxOTcxMGZhNjZmM2JlOTVjNmZiYThlZWFiMGVlYi4uMDgxMTM4ODA4YzA3YTA5OTBiNmZj ZTZiODMxNzNkOGU3N2Q2YmQ1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy93ZWJydGMvTmV0d29ya01ETlNSZWdpc3Rlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtNRE5TUmVnaXN0ZXIuaApAQCAtMzMsNyArMzMsNyBA QAogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+CiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KIAot I2lmIGRlZmluZWQgX19oYXNfaW5jbHVkZSAmJiBfX2hhc19pbmNsdWRlKDxkbnNfc2QuaD4pCisj aWYgUExBVEZPUk0oQ09DT0EpICYmIGRlZmluZWQgX19oYXNfaW5jbHVkZSAmJiBfX2hhc19pbmNs dWRlKDxkbnNfc2QuaD4pCiAjZGVmaW5lIEVOQUJMRV9NRE5TIDEKICNlbHNlCiAjZGVmaW5lIEVO QUJMRV9NRE5TIDAK