184707 2018-04-17 13:50:50 -0700 [Curl] Fix timing of reporting error to the client 2018-04-17 15:22:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke achristensen annulen basuke commit-queue ews-watchlist galpeter rniwa webkit-bug-importer youennf oldest_to_newest 1415264 0 basuke 2018-04-17 13:50:50 -0700 If error occurs at the end of transaction and didReceiveResponse is not called at that moment, the header information doesn't reach to the client properly. This fix resolve this situation. 1415266 1 338146 basuke 2018-04-17 13:57:01 -0700 Created attachment 338146 PATCH 1415299 2 338146 commit-queue 2018-04-17 15:21:28 -0700 Comment on attachment 338146 PATCH Clearing flags on attachment: 338146 Committed r230734: <https://trac.webkit.org/changeset/230734> 1415300 3 commit-queue 2018-04-17 15:21:29 -0700 All reviewed patches have been landed. Closing bug. 1415301 4 webkit-bug-importer 2018-04-17 15:22:20 -0700 <rdar://problem/39506741> 338146 2018-04-17 13:57:01 -0700 2018-04-17 15:21:28 -0700 PATCH 184707.diff text/plain 4073 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZDk1MTJlMzI2NS4uMDI2ZmE3NmY1YmEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0wNC0xNyAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29u eS5jb20+CisKKyAgICAgICAgW0N1cmxdIEZpeCB0aW1pbmcgb2YgcmVwb3J0aW5nIGVycm9yIHRv IHRoZSBjbGllbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NDcwNworCisgICAgICAgIEJlZm9yZSBjaGVja2luZyB0aGUgcmVzdWx0IGNvZGUsIGNo ZWNrIHRoZSBzdGF0dXMgb2YgY2FsbGJhY2sgaW52b2NhdGlvbiBhbmQKKyAgICAgICAgZG8gdGhl IHJpZ2h0IHRoaW5nLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlJ3Mgbm8gbmV3IGJlaGF2aW9yLgorCisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkN1cmxSZXF1ZXN0OjpkaWRDb21wbGV0ZVRyYW5zZmVyKToKKyAgICAgICAgKiBw bGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuaDoKKyAgICAgICAgKFdlYkNvcmU6OkN1 cmxSZXF1ZXN0OjpuZWVkVG9JbnZva2VEaWRSZWNlaXZlUmVzcG9uc2UgY29uc3QpOgorCiAyMDE4 LTA0LTE3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVT U0lPTiAocjIyOTgzMSk6IENNRC1jbGlja2luZyBhbiBpQ2xvdWQgd2ViIGFwcCBsaW5rIHVuZXhw ZWN0ZWRseSBvcGVucyB0aGF0IGxpbmsgaW4gYSBuZXcgdGFiIGFuZCB0aGUgY3VycmVudCB0YWIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVx dWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVl c3QuY3BwCmluZGV4IGM5MGViZDBiNWNiLi40N2RkNmY0MzY3MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuY3BwCkBAIC00MTAs MjUgKzQxMCwyNiBAQCB2b2lkIEN1cmxSZXF1ZXN0OjpkaWRDb21wbGV0ZVRyYW5zZmVyKENVUkxj b2RlIHJlc3VsdCkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGlmIChuZWVkVG9JbnZv a2VEaWRSZWNlaXZlUmVzcG9uc2UoKSkgeworICAgICAgICAvLyBQcm9jZXNzaW5nIG9mIGRpZFJl Y2VpdmVSZXNwb25zZSgpIGhhcyBub3QgYmVlbiBjb21wbGV0ZWQuIChGb3IgZXhhbXBsZSwgSEVB RCBtZXRob2QpCisgICAgICAgIC8vIFdoZW4gY29tcGxldGVEaWRSZWNlaXZlUmVzcG9uc2UoKSBp cyBjYWxsZWQsIGRpZENvbXBsZXRlVHJhbnNmZXIoKSB3aWxsIGJlIGNhbGxlZCBhZ2Fpbi4KKwor ICAgICAgICBtX2ZpbmlzaGVkUmVzdWx0Q29kZSA9IHJlc3VsdDsKKyAgICAgICAgaW52b2tlRGlk UmVjZWl2ZVJlc3BvbnNlKG1fcmVzcG9uc2UsIEFjdGlvbjo6RmluaXNoVHJhbnNmZXIpOworICAg ICAgICByZXR1cm47CisgICAgfQorCiAgICAgaWYgKHJlc3VsdCA9PSBDVVJMRV9PSykgewotICAg ICAgICBpZiAobmVlZFRvSW52b2tlRGlkUmVjZWl2ZVJlc3BvbnNlKCkpIHsKLSAgICAgICAgICAg IC8vIFByb2Nlc3Npbmcgb2YgZGlkUmVjZWl2ZVJlc3BvbnNlKCkgaGFzIG5vdCBiZWVuIGNvbXBs ZXRlZC4gKEZvciBleGFtcGxlLCBIRUFEIG1ldGhvZCkKLSAgICAgICAgICAgIC8vIFdoZW4gY29t cGxldGVEaWRSZWNlaXZlUmVzcG9uc2UoKSBpcyBjYWxsZWQsIGRpZENvbXBsZXRlVHJhbnNmZXIo KSB3aWxsIGJlIGNhbGxlZCBhZ2Fpbi4KLQotICAgICAgICAgICAgbV9maW5pc2hlZFJlc3VsdENv ZGUgPSByZXN1bHQ7Ci0gICAgICAgICAgICBpbnZva2VEaWRSZWNlaXZlUmVzcG9uc2UobV9yZXNw b25zZSwgQWN0aW9uOjpGaW5pc2hUcmFuc2Zlcik7Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAg ICAgICBpZiAobV9tdWx0aXBhcnRIYW5kbGUpCi0gICAgICAgICAgICAgICAgbV9tdWx0aXBhcnRI YW5kbGUtPmRpZENvbXBsZXRlKCk7Ci0KLSAgICAgICAgICAgIGlmIChhdXRvIG1ldHJpY3MgPSBt X2N1cmxIYW5kbGUtPmdldE5ldHdvcmtMb2FkTWV0cmljcygpKQotICAgICAgICAgICAgICAgIG1f bmV0d29ya0xvYWRNZXRyaWNzID0gKm1ldHJpY3M7Ci0KLSAgICAgICAgICAgIGZpbmFsaXplVHJh bnNmZXIoKTsKLSAgICAgICAgICAgIGNhbGxDbGllbnQoW10oQ3VybFJlcXVlc3QmIHJlcXVlc3Qs IEN1cmxSZXF1ZXN0Q2xpZW50JiBjbGllbnQpIHsKLSAgICAgICAgICAgICAgICBjbGllbnQuY3Vy bERpZENvbXBsZXRlKHJlcXVlc3QpOwotICAgICAgICAgICAgfSk7Ci0gICAgICAgIH0KKyAgICAg ICAgaWYgKG1fbXVsdGlwYXJ0SGFuZGxlKQorICAgICAgICAgICAgbV9tdWx0aXBhcnRIYW5kbGUt PmRpZENvbXBsZXRlKCk7CisKKyAgICAgICAgaWYgKGF1dG8gbWV0cmljcyA9IG1fY3VybEhhbmRs ZS0+Z2V0TmV0d29ya0xvYWRNZXRyaWNzKCkpCisgICAgICAgICAgICBtX25ldHdvcmtMb2FkTWV0 cmljcyA9ICptZXRyaWNzOworCisgICAgICAgIGZpbmFsaXplVHJhbnNmZXIoKTsKKyAgICAgICAg Y2FsbENsaWVudChbXShDdXJsUmVxdWVzdCYgcmVxdWVzdCwgQ3VybFJlcXVlc3RDbGllbnQmIGNs aWVudCkgeworICAgICAgICAgICAgY2xpZW50LmN1cmxEaWRDb21wbGV0ZShyZXF1ZXN0KTsKKyAg ICAgICAgfSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgYXV0byB0eXBlID0gKHJlc3VsdCA9PSBD VVJMRV9PUEVSQVRJT05fVElNRURPVVQgJiYgbV9yZXF1ZXN0LnRpbWVvdXRJbnRlcnZhbCgpID4g MC4wKSA/IFJlc291cmNlRXJyb3I6OlR5cGU6OlRpbWVvdXQgOiBSZXNvdXJjZUVycm9yOjpUeXBl OjpHZW5lcmFsOwogICAgICAgICBhdXRvIHJlc291cmNlRXJyb3IgPSBSZXNvdXJjZUVycm9yOjpo dHRwRXJyb3IocmVzdWx0LCBtX3JlcXVlc3QudXJsKCksIHR5cGUpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuaAppbmRleCA3YWJmNGJj ZDk3My4uYzJkZjkxOTI2NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvY3VybC9DdXJsUmVxdWVzdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvY3VybC9DdXJsUmVxdWVzdC5oCkBAIC0xMjUsNyArMTI1LDcgQEAgcHJpdmF0ZToKICAg ICB2b2lkIHNldHVwU2VuZERhdGEoYm9vbCBmb3JQdXRNZXRob2QpOwogCiAgICAgLy8gUHJvY2Vz c2luZyBmb3IgRGlkUmVjZWl2ZVJlc3BvbnNlCi0gICAgYm9vbCBuZWVkVG9JbnZva2VEaWRSZWNl aXZlUmVzcG9uc2UoKSBjb25zdCB7IHJldHVybiAhbV9kaWROb3RpZnlSZXNwb25zZSB8fCAhbV9k aWRSZXR1cm5Gcm9tTm90aWZ5OyB9CisgICAgYm9vbCBuZWVkVG9JbnZva2VEaWRSZWNlaXZlUmVz cG9uc2UoKSBjb25zdCB7IHJldHVybiBtX2RpZFJlY2VpdmVSZXNwb25zZSAmJiAoIW1fZGlkTm90 aWZ5UmVzcG9uc2UgfHwgIW1fZGlkUmV0dXJuRnJvbU5vdGlmeSk7IH0KICAgICBib29sIG5lZWRU b0ludm9rZURpZENhbmNlbFRyYW5zZmVyKCkgY29uc3QgeyByZXR1cm4gbV9kaWROb3RpZnlSZXNw b25zZSAmJiAhbV9kaWRSZXR1cm5Gcm9tTm90aWZ5ICYmIG1fYWN0aW9uQWZ0ZXJJbnZva2UgPT0g QWN0aW9uOjpGaW5pc2hUcmFuc2ZlcjsgfQogICAgIHZvaWQgaW52b2tlRGlkUmVjZWl2ZVJlc3Bv bnNlRm9yRmlsZShVUkwmKTsKICAgICB2b2lkIGludm9rZURpZFJlY2VpdmVSZXNwb25zZShjb25z dCBDdXJsUmVzcG9uc2UmLCBBY3Rpb24pOwo=