184705 2018-04-17 11:59:53 -0700 JSGenericTypedArrayView<>::visitChildren has a race condition reading m_mode and m_vector 2018-04-17 13:02:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1415235 0 fpizlo 2018-04-17 11:59:53 -0700 Patch forthcoming. 1415242 1 338140 fpizlo 2018-04-17 12:13:32 -0700 Created attachment 338140 the patch 1415248 2 338140 msaboff 2018-04-17 12:43:25 -0700 Comment on attachment 338140 the patch r=me 1415254 3 fpizlo 2018-04-17 12:56:47 -0700 Landed in https://trac.webkit.org/changeset/230726/webkit 1415256 4 webkit-bug-importer 2018-04-17 13:02:43 -0700 <rdar://problem/39500560> 338140 2018-04-17 12:13:32 -0700 2018-04-17 12:43:25 -0700 the patch blah.patch text/plain 4443 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMwNzIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDE4LTA0LTE3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SlNHZW5lcmljVHlwZWRBcnJheVZpZXc8Pjo6dmlzaXRDaGlsZHJlbiBoYXMgYSByYWNlIGNvbmRp dGlvbiByZWFkaW5nIG1fbW9kZSBhbmQgbV92ZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDcwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgTXkgb2xkIG11bHRpc29ja2V0IE1hYyBQ cm8gaXMgYW1hemluZyBhdCBjYXRjaGluZyByYWNlIGNvbmRpdGlvbnMgaW4gdGhlIEdDLiBFYXJs aWVyIHRvZGF5CisgICAgICAgIHdoaWxlIHRlc3RpbmcgYW4gdW5yZWxhdGVkIHBhdGNoLCBhIGNv bmN1cnJlbnQgR0MgdGhyZWFkIGNyYXNoZWQgaW5zaWRlCisgICAgICAgIEpTR2VuZXJpY1R5cGVk QXJyYXlWaWV3PD46OnZpc2l0Q2hpbGRyZW4oKSBjYWxsaW5nIG1hcmtBdXhpbGlhcnkoKS4gSSdt IHByZXR0eSBzdXJlIGl0J3MKKyAgICAgICAgYmVjYXVzZSBhIHR5cGVkIGFycmF5IGJlY2FtZSB3 YXN0ZWZ1bCBjb25jdXJyZW50bHkgdG8gdGhlIEdDLiBTbywgdmlzaXRDaGlsZHJlbigpIHJlYWQg b25lCisgICAgICAgIG1vZGUgYW5kIGFub3RoZXIgdmVjdG9yLgorICAgICAgICAKKyAgICAgICAg VGhlIGZpeCBpcyB0byBsb2NrIGluc2lkZSB2aXNpdENoaWxkcmVuIGFuZCBhbnlvbmUgd2hvIGNo YW5nZXMgdGhvc2UgZmllbGRzLgorICAgICAgICAKKyAgICAgICAgSSdtIG5vdCBldmVuIGdvaW5n IHRvIHRyeSB0byB3cml0ZSBhIHRlc3QuIEkgdGhpbmsgaXQncyBzdXBlciBsdWNreSB0aGF0IG15 IE1hYyBQcm8gY2F1Z2h0CisgICAgICAgIHRoaXMuCisKKyAgICAgICAgKiBydW50aW1lL0pTQXJy YXlCdWZmZXJWaWV3LmNwcDoKKyAgICAgICAgKEpTQzo6SlNBcnJheUJ1ZmZlclZpZXc6Om5ldXRl cik6CisgICAgICAgICogcnVudGltZS9KU0dlbmVyaWNUeXBlZEFycmF5Vmlld0lubGluZXMuaDoK KyAgICAgICAgKEpTQzo6SlNHZW5lcmljVHlwZWRBcnJheVZpZXc8QWRhcHRvcj46OnZpc2l0Q2hp bGRyZW4pOgorICAgICAgICAoSlNDOjpKU0dlbmVyaWNUeXBlZEFycmF5VmlldzxBZGFwdG9yPjo6 c2xvd0Rvd25BbmRXYXN0ZU1lbW9yeSk6CisKIDIwMTgtMDQtMTcgIEZpbGlwIFBpemxvICA8ZnBp emxvQGFwcGxlLmNvbT4KIAogICAgICAgICBKU1dlYkFzc2VtYmx5Q29kZUJsb2NrIHNob3VsZCBi ZSBpbiBhbiBJc29TdWJzcGFjZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNBcnJheUJ1ZmZlclZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTQXJyYXlCdWZmZXJWaWV3LmNwcAkocmV2aXNpb24gMjMwNzIyKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheUJ1ZmZlclZpZXcuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMy0yMDE3IEFw cGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMy0yMDE4 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBh bmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1v ZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29u ZGl0aW9ucwpAQCAtMjA5LDYgKzIwOSw3IEBAIEpTQXJyYXlCdWZmZXIqIEpTQXJyYXlCdWZmZXJW aWV3Ojpwb3NzaWIKIAogdm9pZCBKU0FycmF5QnVmZmVyVmlldzo6bmV1dGVyKCkKIHsKKyAgICBh dXRvIGxvY2tlciA9IGhvbGRMb2NrKGNlbGxMb2NrKCkpOwogICAgIFJFTEVBU0VfQVNTRVJUKGhh c0FycmF5QnVmZmVyKCkpOwogICAgIFJFTEVBU0VfQVNTRVJUKCFpc1NoYXJlZCgpKTsKICAgICBt X2xlbmd0aCA9IDA7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dlbmVy aWNUeXBlZEFycmF5Vmlld0lubGluZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU0dlbmVyaWNUeXBlZEFycmF5Vmlld0lubGluZXMuaAkocmV2aXNpb24g MjMwNzIyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHZW5lcmljVHlwZWRB cnJheVZpZXdJbmxpbmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICog Q29weXJpZ2h0IChDKSAyMDEzLCAyMDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K KyAqIENvcHlyaWdodCAoQykgMjAxMy0yMDE4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZl ZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZv cm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92 aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNTE1LDE1ICs1MTUsMjYgQEAg dm9pZCBKU0dlbmVyaWNUeXBlZEFycmF5VmlldzxBZGFwdG9yPjo6dgogewogICAgIEpTR2VuZXJp Y1R5cGVkQXJyYXlWaWV3KiB0aGlzT2JqZWN0ID0ganNDYXN0PEpTR2VuZXJpY1R5cGVkQXJyYXlW aWV3Kj4oY2VsbCk7CiAgICAgCi0gICAgc3dpdGNoICh0aGlzT2JqZWN0LT5tX21vZGUpIHsKKyAg ICBUeXBlZEFycmF5TW9kZSBtb2RlOworICAgIHZvaWQqIHZlY3RvcjsKKyAgICBzaXplX3QgYnl0 ZVNpemU7CisgICAgCisgICAgeworICAgICAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKHRoaXNP YmplY3QtPmNlbGxMb2NrKCkpOworICAgICAgICBtb2RlID0gdGhpc09iamVjdC0+bV9tb2RlOwor ICAgICAgICB2ZWN0b3IgPSB0aGlzT2JqZWN0LT5tX3ZlY3Rvci5nZXRNYXlCZU51bGwoKTsKKyAg ICAgICAgYnl0ZVNpemUgPSB0aGlzT2JqZWN0LT5ieXRlU2l6ZSgpOworICAgIH0KKyAgICAKKyAg ICBzd2l0Y2ggKG1vZGUpIHsKICAgICBjYXNlIEZhc3RUeXBlZEFycmF5OiB7Ci0gICAgICAgIGlm ICh2b2lkKiB2ZWN0b3IgPSB0aGlzT2JqZWN0LT5tX3ZlY3Rvci5nZXRNYXlCZU51bGwoKSkKKyAg ICAgICAgaWYgKHZlY3RvcikKICAgICAgICAgICAgIHZpc2l0b3IubWFya0F1eGlsaWFyeSh2ZWN0 b3IpOwogICAgICAgICBicmVhazsKICAgICB9CiAgICAgICAgIAogICAgIGNhc2UgT3ZlcnNpemVU eXBlZEFycmF5OiB7Ci0gICAgICAgIHZpc2l0b3IucmVwb3J0RXh0cmFNZW1vcnlWaXNpdGVkKHRo aXNPYmplY3QtPmJ5dGVTaXplKCkpOworICAgICAgICB2aXNpdG9yLnJlcG9ydEV4dHJhTWVtb3J5 VmlzaXRlZChieXRlU2l6ZSk7CiAgICAgICAgIGJyZWFrOwogICAgIH0KICAgICAgICAgCkBAIC01 ODMsMTAgKzU5NCwxMyBAQCBBcnJheUJ1ZmZlciogSlNHZW5lcmljVHlwZWRBcnJheVZpZXc8QWRh CiAgICAgICAgIGJyZWFrOwogICAgIH0KIAotICAgIHRoaXNPYmplY3QtPmJ1dHRlcmZseSgpLT5p bmRleGluZ0hlYWRlcigpLT5zZXRBcnJheUJ1ZmZlcihidWZmZXIuZ2V0KCkpOwotICAgIHRoaXNP YmplY3QtPm1fdmVjdG9yLnNldFdpdGhvdXRCYXJyaWVyKGJ1ZmZlci0+ZGF0YSgpKTsKLSAgICBX VEY6OnN0b3JlU3RvcmVGZW5jZSgpOwotICAgIHRoaXNPYmplY3QtPm1fbW9kZSA9IFdhc3RlZnVs VHlwZWRBcnJheTsKKyAgICB7CisgICAgICAgIGF1dG8gbG9ja2VyID0gaG9sZExvY2sodGhpc09i amVjdC0+Y2VsbExvY2soKSk7CisgICAgICAgIHRoaXNPYmplY3QtPmJ1dHRlcmZseSgpLT5pbmRl eGluZ0hlYWRlcigpLT5zZXRBcnJheUJ1ZmZlcihidWZmZXIuZ2V0KCkpOworICAgICAgICB0aGlz T2JqZWN0LT5tX3ZlY3Rvci5zZXRXaXRob3V0QmFycmllcihidWZmZXItPmRhdGEoKSk7CisgICAg ICAgIFdURjo6c3RvcmVTdG9yZUZlbmNlKCk7CisgICAgICAgIHRoaXNPYmplY3QtPm1fbW9kZSA9 IFdhc3RlZnVsVHlwZWRBcnJheTsKKyAgICB9CiAgICAgaGVhcC0+YWRkUmVmZXJlbmNlKHRoaXNP YmplY3QsIGJ1ZmZlci5nZXQoKSk7CiAgICAgCiAgICAgcmV0dXJuIGJ1ZmZlci5nZXQoKTsK