184675 2018-04-16 17:20:32 -0700 [iOS] Enable WKPDFView by default 2018-04-16 18:20:49 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes bdakin benjamin cdumez cmarcelo commit-queue darin dbates ews-watchlist thorton timothy webkit-bug-importer wenson_hsieh oldest_to_newest 1414968 0 aestes 2018-04-16 17:20:32 -0700 [iOS] Enable WKPDFView by default 1414969 1 aestes 2018-04-16 17:20:49 -0700 rdar://problem/27885452 1414970 2 338063 aestes 2018-04-16 17:22:56 -0700 Created attachment 338063 Patch 1414975 3 338063 darin 2018-04-16 17:54:32 -0700 Comment on attachment 338063 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338063&action=review > Source/WTF/wtf/FeatureDefines.h:170 > +#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) && !ENABLE(MINIMAL_SIMULATOR) && __IPHONE_OS_VERSION_MIN_REQUIRED < 120000 Another way to do this would be to put this after the ENABLE_WKPDFVIEW paragraph and do it only #if !ENABLE(WKPFDVIEW). I’ll note that if someone sets both ENABLE_WKLEGACYPDFVIEW and ENABLE_WKPDFVIEW, we do allow nonsense combinations like having both enabled. Not sure what our usual style/strategy is for this. Could imagine using #error or something. 1414985 4 338063 commit-queue 2018-04-16 18:20:48 -0700 Comment on attachment 338063 Patch Clearing flags on attachment: 338063 Committed r230694: <https://trac.webkit.org/changeset/230694> 1414986 5 commit-queue 2018-04-16 18:20:49 -0700 All reviewed patches have been landed. Closing bug. 338063 2018-04-16 17:22:56 -0700 2018-04-16 18:20:48 -0700 Patch bug-184675-20180416172255.patch text/plain 4266 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNjY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDkzYTdjOGMwMGU4MjI2ZDBkNzE5ZTUx YmQwYjZmYmZjMzRjMWM3YmUuLjgyNzQyZWI1YWFjOTdmOGI0MDA4NWJiMzE3ODAyZTM1YTMwYjdm MTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDQtMTYgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNA YXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEVuYWJsZSBXS1BERlZpZXcgYnkgZGVmYXVsdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0Njc1Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzg4NTQ1Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9GZWF0dXJlRGVmaW5lcy5oOgorCiAyMDE4 LTA0LTE0ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjMwNjU5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCBjOGI5MWU5NjBm OTM0OGVmYzhhNTAxNzM4NWVlNjJiMTQyMDMyMzFhLi42ODEwMTVlNTY5Zjg1MDFhYTQ4ZGY1Yjkx OGZkNTExN2FiMjJmZTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA0LTE2ICBB bmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBFbmFibGUgV0tQ REZWaWV3IGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NDY3NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjc4ODU0NTI+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv Q29jb2EvV0tXZWJWaWV3Q29udGVudFByb3ZpZGVyUmVnaXN0cnkubW06CisgICAgICAgICgtW1dL V2ViVmlld0NvbnRlbnRQcm92aWRlclJlZ2lzdHJ5IGluaXRdKToKKwogMjAxOC0wNC0xNSAgTWlj aGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0g SW5zdGFsbCBmaWxlcyBuZWVkZWQgZm9yIFdlYktpdFdlYkV4dGVuc2lvbnMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmggYi9Tb3VyY2UvV1RGL3d0Zi9GZWF0dXJl RGVmaW5lcy5oCmluZGV4IDA0ZTE2YTBkZjBlM2I0MzEzNTlmMmY1YjdmYTI4OTM3NzU2Yjk2MDIu LmNjOWYwZGE5ZmVmM2NjNDgzZDI2NWVlODE0Y2Q1YmViZWIyOWZkNzIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgKKysrIGIvU291cmNlL1dURi93dGYvRmVhdHVy ZURlZmluZXMuaApAQCAtMTY3LDcgKzE2Nyw3IEBAIHRoZSBwdWJsaWMgaU9TIFNESy4gU2VlIDxo dHRwczovL3dlYmtpdC5vcmcvYi8xNzkxNjc+LiAqLwogI2VuZGlmCiAKICNpZiAhZGVmaW5lZChF TkFCTEVfV0tMRUdBQ1lQREZWSUVXKQotI2lmIFBMQVRGT1JNKElPUykgJiYgIVBMQVRGT1JNKFdB VENIT1MpICYmICFQTEFURk9STShBUFBMRVRWKSAmJiAhRU5BQkxFKE1JTklNQUxfU0lNVUxBVE9S KQorI2lmIFBMQVRGT1JNKElPUykgJiYgIVBMQVRGT1JNKFdBVENIT1MpICYmICFQTEFURk9STShB UFBMRVRWKSAmJiAhRU5BQkxFKE1JTklNQUxfU0lNVUxBVE9SKSAmJiBfX0lQSE9ORV9PU19WRVJT SU9OX01JTl9SRVFVSVJFRCA8IDEyMDAwMAogI2RlZmluZSBFTkFCTEVfV0tMRUdBQ1lQREZWSUVX IDEKICNlbmRpZgogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9D b2NvYS9XS1dlYlZpZXdDb250ZW50UHJvdmlkZXJSZWdpc3RyeS5tbSBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0NvY29hL1dLV2ViVmlld0NvbnRlbnRQcm92aWRlclJlZ2lzdHJ5Lm1tCmluZGV4 IGVmYjRlYjk4ZjNjZmM2YzBmZmQ3NjgzZjNiODkyYWRhOGM5NjUzNDYuLjIzODkxZmZjNTE4YzQx ZjE2Y2Y3Yjg0NzA1ODlmMzYxZDhmNmJlYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0NvY29hL1dLV2ViVmlld0NvbnRlbnRQcm92aWRlclJlZ2lzdHJ5Lm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLV2ViVmlld0NvbnRlbnRQcm92aWRlclJlZ2lz dHJ5Lm1tCkBAIC0zMSw2ICszMSw3IEBACiAjaWYgUExBVEZPUk0oSU9TKQogCiAjaW1wb3J0ICJX S0xlZ2FjeVBERlZpZXcuaCIKKyNpbXBvcnQgIldLUERGVmlldy5oIgogI2ltcG9ydCAiV0tTeXN0 ZW1QcmV2aWV3Vmlldy5oIgogI2ltcG9ydCAiV0tXZWJWaWV3SW50ZXJuYWwuaCIKICNpbXBvcnQg IldlYlBhZ2VQcm94eS5oIgpAQCAtNTYsNyArNTcsMTAgQEAgLSAoaW5zdGFuY2V0eXBlKWluaXQK ICAgICBpZiAoIShzZWxmID0gW3N1cGVyIGluaXRdKSkKICAgICAgICAgcmV0dXJuIG5pbDsKIAot I2lmIEVOQUJMRShXS0xFR0FDWVBERlZJRVcpCisjaWYgRU5BQkxFKFdLUERGVklFVykKKyAgICBm b3IgKGF1dG8mIG1pbWVUeXBlIDogV2ViQ29yZTo6TUlNRVR5cGVSZWdpc3RyeTo6Z2V0UERGTUlN RVR5cGVzKCkpCisgICAgICAgIFtzZWxmIHJlZ2lzdGVyUHJvdmlkZXI6W1dLUERGVmlldyBjbGFz c10gZm9yTUlNRVR5cGU6bWltZVR5cGVdOworI2VsaWYgRU5BQkxFKFdLTEVHQUNZUERGVklFVykK ICAgICBmb3IgKGF1dG8mIG1pbWVUeXBlIDogV2ViQ29yZTo6TUlNRVR5cGVSZWdpc3RyeTo6Z2V0 UERGTUlNRVR5cGVzKCkpCiAgICAgICAgIFtzZWxmIHJlZ2lzdGVyUHJvdmlkZXI6W1dLTGVnYWN5 UERGVmlldyBjbGFzc10gZm9yTUlNRVR5cGU6bWltZVR5cGVdOwogI2VuZGlmCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGE4OTdiNzc3ZGYwMjEy MGY0YTRlM2NlMTNiN2U2YWQ1NGIxZDIzOC4uODhhMjI4NzA3MzI1YTRjMGVkZGFmNzhmM2ZlNmY1 ZjNhOWQ5Nzk2OSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTA0LTE2ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFw cGxlLmNvbT4KKworICAgICAgICBbaU9TXSBFbmFibGUgV0tQREZWaWV3IGJ5IGRlZmF1bHQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDY3NQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjc4ODU0NTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h L1dLUERGVmlldy5tbToKKwogMjAxOC0wNC0xNSAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5j b20+CiAKICAgICAgICAgW2lPU10gQWRkIEFQSSB0ZXN0cyBmb3IgUERGIGZpbmQtaW4tcGFnZQpk aWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XS1BERlZp ZXcubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLUERGVmlldy5t bQppbmRleCAxM2MyNGQ2Mjc1YzE2MTc1NDY0YzhjYWVmNzE5MDgzNDgwMzQxOWU1Li5jZWE2OGZk ZGVjYjlmMTdlMDY4NTJjYmRiMTcwNzk5Y2JjNGNlNmFjIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLUERGVmlldy5tbQorKysgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLUERGVmlldy5tbQpAQCAtMjYsNyArMjYsOCBA QAogI2ltcG9ydCAiY29uZmlnLmgiCiAjaW1wb3J0IDxXZWJLaXQvV0tGb3VuZGF0aW9uLmg+CiAK LSNpZiBXS19BUElfRU5BQkxFRCAmJiBUQVJHRVRfT1NfSVBIT05FCisvLyBGSVhNRTogRW5hYmxl IHRoZXNlIHRlc3RzIG9uIGlPUyAxMiBvbmNlIHJkYXI6Ly9wcm9ibGVtLzM5NDc1NTQyIGlzIHJl c29sdmVkLgorI2lmIFdLX0FQSV9FTkFCTEVEICYmIFRBUkdFVF9PU19JUEhPTkUgJiYgX19JUEhP TkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMjAwMDAKIAogI2ltcG9ydCAiUGxhdGZvcm1V dGlsaXRpZXMuaCIKICNpbXBvcnQgIlRlc3ROYXZpZ2F0aW9uRGVsZWdhdGUuaCIK