<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>184664</bug_id>
          
          <creation_ts>2018-04-16 13:50:36 -0700</creation_ts>
          <short_desc>[macOS] Don&apos;t establish unneeded Dock connections</short_desc>
          <delta_ts>2018-04-17 09:40:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>aestes</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>mitz</cc>
    
    <cc>pvollan</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1414892</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-16 13:50:36 -0700</bug_when>
    <thetext>The WebContent and Plugin processes don&apos;t need to interact with the dock (this type of stuff is all handled in the UIProcess).

Tell AppKit that we don&apos;t want to use a dock connection so that we never both opening one up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414895</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-16 13:51:08 -0700</bug_when>
    <thetext>&lt;rdar://problem/16863698&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414902</commentid>
    <comment_count>2</comment_count>
      <attachid>338038</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-16 14:00:44 -0700</bug_when>
    <thetext>Created attachment 338038
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414912</commentid>
    <comment_count>3</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-16 14:20:33 -0700</bug_when>
    <thetext>Looks like PluginProcess also needs:

#import &lt;pal/spi/mac/NSApplicationSPI.h&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414918</commentid>
    <comment_count>4</comment_count>
      <attachid>338038</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2018-04-16 14:57:31 -0700</bug_when>
    <thetext>Comment on attachment 338038
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338038&amp;action=review

&gt; Source/WebKit/PluginProcess/mac/PluginProcessMac.mm:527
&gt; +#if PLATFORM(MAC) &amp;&amp; __MAC_OS_X_VERSION_MIN_REQUIRED &gt;= 101400

Is PLATFORM(MAC) needed here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414944</commentid>
    <comment_count>5</comment_count>
      <attachid>338038</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-16 16:04:41 -0700</bug_when>
    <thetext>Comment on attachment 338038
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338038&amp;action=review

&gt;&gt; Source/WebKit/PluginProcess/mac/PluginProcessMac.mm:527
&gt;&gt; +#if PLATFORM(MAC) &amp;&amp; __MAC_OS_X_VERSION_MIN_REQUIRED &gt;= 101400
&gt; 
&gt; Is PLATFORM(MAC) needed here?

Oh, probably not.

It also needs this:
#import &lt;pal/spi/mac/NSApplicationSPI.h&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414947</commentid>
    <comment_count>6</comment_count>
      <attachid>338054</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-16 16:13:35 -0700</bug_when>
    <thetext>Created attachment 338054
Patch (Part 1)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414953</commentid>
    <comment_count>7</comment_count>
      <attachid>338054</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-04-16 16:43:10 -0700</bug_when>
    <thetext>Comment on attachment 338054
Patch (Part 1)

Clearing flags on attachment: 338054

Committed r230689: &lt;https://trac.webkit.org/changeset/230689&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414954</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-04-16 16:43:12 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414976</commentid>
    <comment_count>9</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2018-04-16 17:55:50 -0700</bug_when>
    <thetext>No issue for the network process? Maybe that one doesn’t use NSApplication?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414982</commentid>
    <comment_count>10</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-16 18:05:37 -0700</bug_when>
    <thetext>(In reply to Darin Adler from comment #9)
&gt; No issue for the network process? Maybe that one doesn’t use NSApplication?

Correct. The Network and Storage processes init with &apos;SetApplicationIsDaemon&apos;, which bypass NSApplication and all kinds of other launch cruft.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415037</commentid>
    <comment_count>11</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-16 22:57:43 -0700</bug_when>
    <thetext>Reopened: This isn&apos;t quite right for the Plugin process.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415038</commentid>
    <comment_count>12</comment_count>
      <attachid>338079</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-16 23:00:37 -0700</bug_when>
    <thetext>Created attachment 338079
Patch (Part 2)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415091</commentid>
    <comment_count>13</comment_count>
      <attachid>338079</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2018-04-17 03:31:49 -0700</bug_when>
    <thetext>Comment on attachment 338079
Patch (Part 2)

View in context: https://bugs.webkit.org/attachment.cgi?id=338079&amp;action=review

r- to fix build failure in XPCServiceMain.mm, and fixing WebContentService.xcconfig for non-macOS platforms.

&gt; Source/WebKit/Configurations/PluginService.32.xcconfig:38
&gt; +OTHER_CFLAGS = $(inherited) -D WK_LINKS_TO_APPKIT=1

Nit: missing semi-colon at end of line.

Consider using WK_APPKIT_CFLAGS here as well for consistency.

&gt; Source/WebKit/Configurations/PluginService.64.xcconfig:35
&gt; +OTHER_CFLAGS = $(inherited) -D WK_LINKS_TO_APPKIT=1

Nit: missing semi-colon at end of line.

Consider using WK_APPKIT_CFLAGS here as well for consistency.

&gt; Source/WebKit/Configurations/WebContentService.xcconfig:44
&gt; +OTHER_CFLAGS = $(inherited) -D WK_LINKS_TO_APPKIT=1

Don&apos;t you want something like this since this xcconfig file is used by both iOS and macOS?

WK_APPKIT_CFLAGS = $(WK_APPKIT_CFLAGS_$(WK_PLATFORM_NAME));
WK_APPKIT_CFLAGS_macosx = -D WK_LINKS_TO_APPKIT=1;

OTHER_CFLAGS = $(inherited) $(WK_APPKIT_CFLAGS);

This probably isn&apos;t needed (except for consistency) in the PluginService.NN.xcconfig files.

&gt; Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:34
&gt; +#if __MAC_OS_X_VERSION_MIN_REQUIRED &gt;= 101400 &amp;&amp; defined(WK_LINKS_TO_APPKIT) &amp;&amp; WK_LINKS_TO_APPKIT

You do need PLATFORM(MAC) here according to the EWS build failure because __MAC_OS_X_VERSION_MIN_REQUIRED is undefined on iOS and WebKit builds with -Wundef and -Werror:

#if PLATFORM(MAC) &amp;&amp; __MAC_OS_X_VERSION_MIN_REQUIRED &gt;= 101400 &amp;&amp; defined(WK_LINKS_TO_APPKIT) &amp;&amp; WK_LINKS_TO_APPKIT

You don&apos;t need PLATFORM(MAC) below because it&apos;s already inside an #if PLATFORM(MAC)/#endif pair.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415116</commentid>
    <comment_count>14</comment_count>
      <attachid>338079</attachid>
    <who name="">mitz</who>
    <bug_when>2018-04-17 07:24:05 -0700</bug_when>
    <thetext>Comment on attachment 338079
Patch (Part 2)

View in context: https://bugs.webkit.org/attachment.cgi?id=338079&amp;action=review

&gt;&gt; Source/WebKit/Configurations/PluginService.32.xcconfig:38
&gt;&gt; +OTHER_CFLAGS = $(inherited) -D WK_LINKS_TO_APPKIT=1
&gt; 
&gt; Nit: missing semi-colon at end of line.
&gt; 
&gt; Consider using WK_APPKIT_CFLAGS here as well for consistency.

If you wanted to control this using preprocessor definitions, then the right build setting to use would be GCC_PREPROCESSOR_DEFINITIONS, along the line of
    GCC_PREPROCESSOR_DEFINITIONS = $(inherited) USE_APPKIT;
(which would then allow you to use the USE() macro from WTF. Seeing how this is only used for the one source file, you could also put -DUSE_APPKIT in the Compiler Flags column of the Compile Sources build phase for the relevant targets in Xcode’s project editor.

However, the effort to determine this at build time is probably unnecessary. The most straightforward way I can think of doing this is, under an #if PLATFORM(MAC) guard, to do
    if (Class nsApplicationClass = NSClassFromString(@&quot;NSApplication&quot;))
        [nsApplicationClass _preventDockConnections];</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415142</commentid>
    <comment_count>15</comment_count>
      <attachid>338117</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-17 08:38:15 -0700</bug_when>
    <thetext>Created attachment 338117
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415152</commentid>
    <comment_count>16</comment_count>
      <attachid>338117</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2018-04-17 08:52:40 -0700</bug_when>
    <thetext>Comment on attachment 338117
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338117&amp;action=review

R=me.

&gt; Source/WebKit/PluginProcess/mac/PluginProcessMac.mm:-532
&gt; -#if __MAC_OS_X_VERSION_MIN_REQUIRED &gt;= 101400
&gt; -    // We don&apos;t need to talk to the dock.
&gt; -    if ([NSApplication respondsToSelector:@selector(_preventDockConnections)])
&gt; -        [NSApplication _preventDockConnections];
&gt; -#endif

Should we also remove this code from the WebContent process?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415172</commentid>
    <comment_count>17</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-17 09:17:53 -0700</bug_when>
    <thetext>I don&apos;t understand why I&apos;m getting this error inside a #if PLATFORM(MAC) guard when building for iOS-simulator.

Volumes/Data/EWS/WebKit/Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:34:5: error: &apos;__MAC_OS_X_VERSION_MIN_REQUIRED&apos; is not defined, evaluates to 0 [-Werror,-Wundef]
#if __MAC_OS_X_VERSION_MIN_REQUIRED &gt;= 101400
    ^
1 error generated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415179</commentid>
    <comment_count>18</comment_count>
      <attachid>338117</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2018-04-17 09:29:34 -0700</bug_when>
    <thetext>Comment on attachment 338117
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338117&amp;action=review

&gt; Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:34
&gt; +#if __MAC_OS_X_VERSION_MIN_REQUIRED &gt;= 101400

I think #if PLATFORM(MAC) should be added here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415180</commentid>
    <comment_count>19</comment_count>
      <attachid>338117</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2018-04-17 09:35:31 -0700</bug_when>
    <thetext>Comment on attachment 338117
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338117&amp;action=review

&gt;&gt; Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:34
&gt;&gt; +#if __MAC_OS_X_VERSION_MIN_REQUIRED &gt;= 101400
&gt; 
&gt; I think #if PLATFORM(MAC) should be added here.

It seems this #if directive is not already inside a #if PLATFORM(MAC) directive.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1415181</commentid>
    <comment_count>20</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-17 09:40:44 -0700</bug_when>
    <thetext>Committed r230714: &lt;https://trac.webkit.org/changeset/230714&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>338038</attachid>
            <date>2018-04-16 14:00:44 -0700</date>
            <delta_ts>2018-04-16 16:13:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-184664-20180416140043.patch</filename>
            <type>text/plain</type>
            <size>3936</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjMwNjc5KQorKysgU291cmNlL1dlYkNv
cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA0
LTE2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNP
U10gRG9uJ3QgZXN0YWJsaXNoIHVubmVlZGVkIERvY2sgY29ubmVjdGlvbnMKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDY2NAorICAgICAgICA8cmRh
cjovL3Byb2JsZW0vMTY4NjM2OTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgVGhlcmUgaXMgbm8gcmVhc29uIGZvciB0aGUgV2ViQ29udGVudCBvciBQ
bHVnaW4gcHJvY2Vzc2VzIHRvIGludGVyYWN0IHdpdGgKKyAgICAgICAgdGhlIERvY2suIFdlIHNo
b3VsZCB0ZWxsIEFwcEtpdCB0aGF0IHdlIGRvbid0IHdhbnQgdGhpcyBjb25uZWN0aW9uLCBhbmQg
dG8KKyAgICAgICAgYXZvaWQgY3JlYXRpbmcgc3VjaCBjb25uZWN0aW9ucy4KKworICAgICAgICAq
IHBhbC9zcGkvbWFjL05TQXBwbGljYXRpb25TUEkuaDogQWRkIERvY2sgY29ubmVjdGlvbiBkZWNs
YXJhdGlvbi4KKwogMjAxOC0wNC0wOSAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNv
bT4KIAogICAgICAgICBSZWZhY3RvciBJZ25vcmUgSFNUUyBjb2RlCkluZGV4OiBTb3VyY2UvV2Vi
Q29yZS9QQUwvcGFsL3NwaS9tYWMvTlNBcHBsaWNhdGlvblNQSS5oCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv
dXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0FwcGxpY2F0aW9uU1BJLmgJKHJldmlzaW9u
IDIzMDY3MykKKysrIFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0FwcGxpY2F0aW9u
U1BJLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDcgQEAgQGludGVyZmFjZSBOU0FwcGxp
Y2F0aW9uICgpCiAKICNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTQw
MAogKyAodm9pZClfYWNjZXNzaWJpbGl0eUluaXRpYWxpemU7CisrICh2b2lkKV9wcmV2ZW50RG9j
a0Nvbm5lY3Rpb25zOwogI2VuZGlmCiAKIEBlbmQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdl
TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzA2
NzMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx
LDIxIEBACisyMDE4LTA0LTE2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgor
CisgICAgICAgIFttYWNPU10gRG9uJ3QgZXN0YWJsaXNoIHVubmVlZGVkIERvY2sgY29ubmVjdGlv
bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDY2
NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTY4NjM2OTg+CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgbm8gcmVhc29uIGZvciB0aGUg
V2ViQ29udGVudCBvciBQbHVnaW4gcHJvY2Vzc2VzIHRvIGludGVyYWN0IHdpdGgKKyAgICAgICAg
dGhlIERvY2suIFdlIHNob3VsZCB0ZWxsIEFwcEtpdCB0aGF0IHdlIGRvbid0IHdhbnQgdGhpcyBj
b25uZWN0aW9uLCBhbmQgdG8KKyAgICAgICAgYXZvaWQgY3JlYXRpbmcgc3VjaCBjb25uZWN0aW9u
cy4KKworICAgICAgICAqIFBsdWdpblByb2Nlc3MvbWFjL1BsdWdpblByb2Nlc3NNYWMubW06Cisg
ICAgICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVByb2Nlc3Mp
OiBUZWxsIE5TQXBwbGljYXRpb24gdG8KKyAgICAgICAgbm90IGNyZWF0ZSBhIERvY2sgY29ubmVj
dGlvbi4KKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbToKKyAg
ICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6
IERpdHRvLgorCiAyMDE4LTA0LTE2ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNv
bT4KIAogICAgICAgICBDbGVhbiB1cCBPVEhFUl9MREZMQUdTIGZvciBXZWJLaXQgcHJvY2Vzc2Vz
CkluZGV4OiBTb3VyY2UvV2ViS2l0L1BsdWdpblByb2Nlc3MvbWFjL1BsdWdpblByb2Nlc3NNYWMu
bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9QbHVnaW5Qcm9jZXNzL21hYy9QbHVnaW5Q
cm9jZXNzTWFjLm1tCShyZXZpc2lvbiAyMzA2NzMpCisrKyBTb3VyY2UvV2ViS2l0L1BsdWdpblBy
b2Nlc3MvbWFjL1BsdWdpblByb2Nlc3NNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTUyNCw2ICs1
MjQsMTIgQEAgdm9pZCBQbHVnaW5Qcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVQcgogewogICAg
IGluaXRpYWxpemVTaGltKCk7CiAKKyNpZiBQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVS
U0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNDAwCisgICAgLy8gV2UgZG9uJ3QgbmVlZCB0byB0YWxr
IHRvIHRoZSBkb2NrLgorICAgIGlmIChbTlNBcHBsaWNhdGlvbiByZXNwb25kc1RvU2VsZWN0b3I6
QHNlbGVjdG9yKF9wcmV2ZW50RG9ja0Nvbm5lY3Rpb25zKV0pCisgICAgICAgIFtOU0FwcGxpY2F0
aW9uIF9wcmV2ZW50RG9ja0Nvbm5lY3Rpb25zXTsKKyNlbmRpZgorCiAgICAgaW5pdGlhbGl6ZUNv
Y29hT3ZlcnJpZGVzKCk7CiAKICAgICAvLyBGSVhNRTogSXQgd291bGQgYmUgYmV0dGVyIHRvIHBy
b3h5IFNldEN1cnNvciBjYWxscyBvdmVyIHRvIHRoZSBVSSBwcm9jZXNzIGluc3RlYWQgb2YKSW5k
ZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2Nv
YS5tbQkocmV2aXNpb24gMjMwNjczKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29h
L1dlYlByb2Nlc3NDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtMTcwLDYgKzE3MCwxMCBAQCB2
b2lkIFdlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByCiAjZW5kaWYKICAgICAKICNp
ZiBQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAx
NDAwCisgICAgLy8gV2UgZG9uJ3QgbmVlZCB0byB0YWxrIHRvIHRoZSBkb2NrLgorICAgIGlmIChb
TlNBcHBsaWNhdGlvbiByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF9wcmV2ZW50RG9ja0Nv
bm5lY3Rpb25zKV0pCisgICAgICAgIFtOU0FwcGxpY2F0aW9uIF9wcmV2ZW50RG9ja0Nvbm5lY3Rp
b25zXTsKKwogICAgIC8vIE5lZWQgdG8gaW5pdGlhbGl6ZSBhY2Nlc3NpYmlsaXR5IGZvciBWb2lj
ZU92ZXIgdG8gd29yayB3aGVuIHRoZSBXZWJDb250ZW50IHByb2Nlc3MgaXMgdXNpbmcgTlNSdW5M
b29wLgogICAgIC8vIEN1cnJlbnRseSwgaXQgaXMgYWxzbyBuZWVkZWQgdG8gYWxsb2NhdGUgYW5k
IGluaXRpYWxpemUgYW4gTlNBcHBsaWNhdGlvbiBvYmplY3QuCiAgICAgLy8gRklYTUU6IFJlbW92
ZSB0aGUgZm9sbG93aW5nIGxpbmUgd2hlbiByZGFyOi8vcHJvYmxlbS8zNjMyMzU2OSBpcyBmaXhl
ZC4K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>338054</attachid>
            <date>2018-04-16 16:13:35 -0700</date>
            <delta_ts>2018-04-16 23:03:33 -0700</delta_ts>
            <desc>Patch (Part 1)</desc>
            <filename>bug-184664-20180416161334.patch</filename>
            <type>text/plain</type>
            <size>4186</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjMwNjc5KQorKysgU291cmNlL1dlYkNv
cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA0
LTE2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNP
U10gRG9uJ3QgZXN0YWJsaXNoIHVubmVlZGVkIERvY2sgY29ubmVjdGlvbnMKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDY2NAorICAgICAgICA8cmRh
cjovL3Byb2JsZW0vMTY4NjM2OTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgVGhlcmUgaXMgbm8gcmVhc29uIGZvciB0aGUgV2ViQ29udGVudCBvciBQ
bHVnaW4gcHJvY2Vzc2VzIHRvIGludGVyYWN0IHdpdGgKKyAgICAgICAgdGhlIERvY2suIFdlIHNo
b3VsZCB0ZWxsIEFwcEtpdCB0aGF0IHdlIGRvbid0IHdhbnQgdGhpcyBjb25uZWN0aW9uLCBhbmQg
dG8KKyAgICAgICAgYXZvaWQgY3JlYXRpbmcgc3VjaCBjb25uZWN0aW9ucy4KKworICAgICAgICAq
IHBhbC9zcGkvbWFjL05TQXBwbGljYXRpb25TUEkuaDogQWRkIERvY2sgY29ubmVjdGlvbiBkZWNs
YXJhdGlvbi4KKwogMjAxOC0wNC0wOSAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNv
bT4KIAogICAgICAgICBSZWZhY3RvciBJZ25vcmUgSFNUUyBjb2RlCkluZGV4OiBTb3VyY2UvV2Vi
Q29yZS9QQUwvcGFsL3NwaS9tYWMvTlNBcHBsaWNhdGlvblNQSS5oCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv
dXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0FwcGxpY2F0aW9uU1BJLmgJKHJldmlzaW9u
IDIzMDY3MykKKysrIFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0FwcGxpY2F0aW9u
U1BJLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDcgQEAgQGludGVyZmFjZSBOU0FwcGxp
Y2F0aW9uICgpCiAKICNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTQw
MAogKyAodm9pZClfYWNjZXNzaWJpbGl0eUluaXRpYWxpemU7CisrICh2b2lkKV9wcmV2ZW50RG9j
a0Nvbm5lY3Rpb25zOwogI2VuZGlmCiAKIEBlbmQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdl
TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzA2
NzMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx
LDIxIEBACisyMDE4LTA0LTE2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgor
CisgICAgICAgIFttYWNPU10gRG9uJ3QgZXN0YWJsaXNoIHVubmVlZGVkIERvY2sgY29ubmVjdGlv
bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDY2
NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTY4NjM2OTg+CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgbm8gcmVhc29uIGZvciB0aGUg
V2ViQ29udGVudCBvciBQbHVnaW4gcHJvY2Vzc2VzIHRvIGludGVyYWN0IHdpdGgKKyAgICAgICAg
dGhlIERvY2suIFdlIHNob3VsZCB0ZWxsIEFwcEtpdCB0aGF0IHdlIGRvbid0IHdhbnQgdGhpcyBj
b25uZWN0aW9uLCBhbmQgdG8KKyAgICAgICAgYXZvaWQgY3JlYXRpbmcgc3VjaCBjb25uZWN0aW9u
cy4KKworICAgICAgICAqIFBsdWdpblByb2Nlc3MvbWFjL1BsdWdpblByb2Nlc3NNYWMubW06Cisg
ICAgICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVByb2Nlc3Mp
OiBUZWxsIE5TQXBwbGljYXRpb24gdG8KKyAgICAgICAgbm90IGNyZWF0ZSBhIERvY2sgY29ubmVj
dGlvbi4KKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbToKKyAg
ICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6
IERpdHRvLgorCiAyMDE4LTA0LTE2ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNv
bT4KIAogICAgICAgICBDbGVhbiB1cCBPVEhFUl9MREZMQUdTIGZvciBXZWJLaXQgcHJvY2Vzc2Vz
CkluZGV4OiBTb3VyY2UvV2ViS2l0L1BsdWdpblByb2Nlc3MvbWFjL1BsdWdpblByb2Nlc3NNYWMu
bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9QbHVnaW5Qcm9jZXNzL21hYy9QbHVnaW5Q
cm9jZXNzTWFjLm1tCShyZXZpc2lvbiAyMzA2NzMpCisrKyBTb3VyY2UvV2ViS2l0L1BsdWdpblBy
b2Nlc3MvbWFjL1BsdWdpblByb2Nlc3NNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTQ4LDYgKzQ4
LDcgQEAKICNpbXBvcnQgPHBhbC9zcGkvY2cvQ29yZUdyYXBoaWNzU1BJLmg+CiAjaW1wb3J0IDxw
YWwvc3BpL2NvY29hL0xhdW5jaFNlcnZpY2VzU1BJLmg+CiAjaW1wb3J0IDxwYWwvc3BpL21hYy9I
SVRvb2xib3hTUEkuaD4KKyNpbXBvcnQgPHBhbC9zcGkvbWFjL05TQXBwbGljYXRpb25TUEkuaD4K
ICNpbXBvcnQgPHBhbC9zcGkvbWFjL05TV2luZG93U1BJLmg+CiAjaW1wb3J0IDxzeXNleGl0cy5o
PgogI2ltcG9ydCA8d3RmL0hhc2hTZXQuaD4KQEAgLTUyNCw2ICs1MjUsMTIgQEAgdm9pZCBQbHVn
aW5Qcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVQcgogewogICAgIGluaXRpYWxpemVTaGltKCk7
CiAKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTQwMAorICAgIC8v
IFdlIGRvbid0IG5lZWQgdG8gdGFsayB0byB0aGUgZG9jay4KKyAgICBpZiAoW05TQXBwbGljYXRp
b24gcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihfcHJldmVudERvY2tDb25uZWN0aW9ucyld
KQorICAgICAgICBbTlNBcHBsaWNhdGlvbiBfcHJldmVudERvY2tDb25uZWN0aW9uc107CisjZW5k
aWYKKwogICAgIGluaXRpYWxpemVDb2NvYU92ZXJyaWRlcygpOwogCiAgICAgLy8gRklYTUU6IEl0
IHdvdWxkIGJlIGJldHRlciB0byBwcm94eSBTZXRDdXJzb3IgY2FsbHMgb3ZlciB0byB0aGUgVUkg
cHJvY2VzcyBpbnN0ZWFkIG9mCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2Ev
V2ViUHJvY2Vzc0NvY29hLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz
cy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0JKHJldmlzaW9uIDIzMDY3MykKKysrIFNvdXJjZS9X
ZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0JKHdvcmtpbmcgY29weSkK
QEAgLTE3MCw2ICsxNzAsMTAgQEAgdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVX
ZWJQcgogI2VuZGlmCiAgICAgCiAjaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJ
T05fTUlOX1JFUVVJUkVEID49IDEwMTQwMAorICAgIC8vIFdlIGRvbid0IG5lZWQgdG8gdGFsayB0
byB0aGUgZG9jay4KKyAgICBpZiAoW05TQXBwbGljYXRpb24gcmVzcG9uZHNUb1NlbGVjdG9yOkBz
ZWxlY3RvcihfcHJldmVudERvY2tDb25uZWN0aW9ucyldKQorICAgICAgICBbTlNBcHBsaWNhdGlv
biBfcHJldmVudERvY2tDb25uZWN0aW9uc107CisKICAgICAvLyBOZWVkIHRvIGluaXRpYWxpemUg
YWNjZXNzaWJpbGl0eSBmb3IgVm9pY2VPdmVyIHRvIHdvcmsgd2hlbiB0aGUgV2ViQ29udGVudCBw
cm9jZXNzIGlzIHVzaW5nIE5TUnVuTG9vcC4KICAgICAvLyBDdXJyZW50bHksIGl0IGlzIGFsc28g
bmVlZGVkIHRvIGFsbG9jYXRlIGFuZCBpbml0aWFsaXplIGFuIE5TQXBwbGljYXRpb24gb2JqZWN0
LgogICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhlIGZvbGxvd2luZyBsaW5lIHdoZW4gcmRhcjovL3By
b2JsZW0vMzYzMjM1NjkgaXMgZml4ZWQuCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>338079</attachid>
            <date>2018-04-16 23:00:37 -0700</date>
            <delta_ts>2018-04-17 08:38:14 -0700</delta_ts>
            <desc>Patch (Part 2)</desc>
            <filename>bug-184664-20180416230036.patch</filename>
            <type>text/plain</type>
            <size>5489</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzA3MDEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE4LTA0LTE2ICBCcmVudCBGdWxn
aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gRG9uJ3QgZXN0YWJs
aXNoIHVubmVlZGVkIERvY2sgY29ubmVjdGlvbnMgKEZvbGxvdy11cCkKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDY2NAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJlY2F1c2UgdGhlIFBsdWdpbiBwcm9j
ZXNzIGlzIGRyaXZlbiBieSBOU0FwcGxpY2F0aW9uJ3MgcnVuIGxvb3AsIHdlIGFyZW4ndAorICAg
ICAgICBzZXR0aW5nIHRoZSAnZG9uJ3QgY29ubmVjdCB0byB0aGUgZG9jaycgc2V0dGluZyBlYXJs
eSBlbm91Z2guCisKKyAgICAgICAgVGhpcyBwYXRjaCBzZXRzIHRoZSBmbGFnIGluIFhQQ1NlcnZp
Y2VNYWluIGZvciB0aG9zZSBzZXJ2aWNlcyB0aGF0CisgICAgICAgIGFyZSBsaW5rZWQgdG8gQXBw
S2l0LgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvUGx1Z2luU2VydmljZS4zMi54Y2NvbmZp
ZzogU2V0IGEgZmxhZyB0byBpbmRpY2F0ZSB3ZSB1c2UgQXBwS2l0LgorICAgICAgICAqIENvbmZp
Z3VyYXRpb25zL1BsdWdpblNlcnZpY2UuNjQueGNjb25maWc6IERpdHRvLgorICAgICAgICAqIENv
bmZpZ3VyYXRpb25zL1dlYkNvbnRlbnRTZXJ2aWNlLnhjY29uZmlnOiBEaXR0by4KKyAgICAgICAg
KiBQbHVnaW5Qcm9jZXNzL21hYy9QbHVnaW5Qcm9jZXNzTWFjLm1tOgorICAgICAgICAoV2ViS2l0
OjpQbHVnaW5Qcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVQcm9jZXNzKTogUmVtb3ZlIHVubmVl
ZGVkIGNvZGUuCisgICAgICAgICogU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvbWFjL1hQQ1Nl
cnZpY2UvWFBDU2VydmljZU1haW4ubW06CisgICAgICAgIChtYWluKToKKwogMjAxOC0wNC0xNiAg
VGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl
ZCAzMi1iaXQgYnVpbGQgZml4IGZvciByMjMwNjczLgpJbmRleDogU291cmNlL1dlYktpdC9Db25m
aWd1cmF0aW9ucy9QbHVnaW5TZXJ2aWNlLjMyLnhjY29uZmlnCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMvUGx1Z2luU2VydmljZS4zMi54Y2NvbmZpZwkocmV2aXNp
b24gMjMwNjkzKQorKysgU291cmNlL1dlYktpdC9Db25maWd1cmF0aW9ucy9QbHVnaW5TZXJ2aWNl
LjMyLnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw2ICszNSw4IEBAIElORk9QTElTVF9G
SUxFID0gUGx1Z2luUHJvY2Vzcy9FbnRyeVBvaW4KIFdLX0FQUEtJVF9MREZMQUdTID0gJChXS19B
UFBLSVRfTERGTEFHU18kKFdLX1BMQVRGT1JNX05BTUUpKTsKIFdLX0FQUEtJVF9MREZMQUdTX21h
Y29zeCA9IC1mcmFtZXdvcmsgQXBwS2l0OwogCitPVEhFUl9DRkxBR1MgPSAkKGluaGVyaXRlZCkg
LUQgV0tfTElOS1NfVE9fQVBQS0lUPTEKKwogT1RIRVJfTERGTEFHUyA9ICQoaW5oZXJpdGVkKSAk
KFdLX0FQUEtJVF9MREZMQUdTKSAkKE9USEVSX0xERkxBR1NfUExBVEZPUk0pICQoT1RIRVJfTERG
TEFHU19WRVJTSU9ORURfRlJBTUVXT1JLX1BBVEgpICQoV0tfUkVMT0NBVEFCTEVfRlJBTUVXT1JL
U19MREZMQUdTKTsKIE9USEVSX0xERkxBR1NfUExBVEZPUk1bc2RrPW1hY29zeCpdID0gJChCVUlM
VF9QUk9EVUNUU19ESVIpL1BsdWdpblByb2Nlc3NTaGltLmR5bGliOwogCkluZGV4OiBTb3VyY2Uv
V2ViS2l0L0NvbmZpZ3VyYXRpb25zL1BsdWdpblNlcnZpY2UuNjQueGNjb25maWcKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gU291cmNlL1dlYktpdC9Db25maWd1cmF0aW9ucy9QbHVnaW5TZXJ2aWNlLjY0LnhjY29u
ZmlnCShyZXZpc2lvbiAyMzA2OTMpCisrKyBTb3VyY2UvV2ViS2l0L0NvbmZpZ3VyYXRpb25zL1Bs
dWdpblNlcnZpY2UuNjQueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDggQEAg
SU5GT1BMSVNUX0ZJTEUgPSBQbHVnaW5Qcm9jZXNzL0VudHJ5UG9pbgogV0tfQVBQS0lUX0xERkxB
R1MgPSAkKFdLX0FQUEtJVF9MREZMQUdTXyQoV0tfUExBVEZPUk1fTkFNRSkpOwogV0tfQVBQS0lU
X0xERkxBR1NfbWFjb3N4ID0gLWZyYW1ld29yayBBcHBLaXQ7CiAKK09USEVSX0NGTEFHUyA9ICQo
aW5oZXJpdGVkKSAtRCBXS19MSU5LU19UT19BUFBLSVQ9MQorCiBPVEhFUl9MREZMQUdTID0gJChp
bmhlcml0ZWQpICQoV0tfQVBQS0lUX0xERkxBR1MpICQoT1RIRVJfTERGTEFHU19QTEFURk9STSkg
JChPVEhFUl9MREZMQUdTX1ZFUlNJT05FRF9GUkFNRVdPUktfUEFUSCkgJChXS19SRUxPQ0FUQUJM
RV9GUkFNRVdPUktTX0xERkxBR1MpOwogT1RIRVJfTERGTEFHU19QTEFURk9STVtzZGs9bWFjb3N4
Kl0gPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvUGx1Z2luUHJvY2Vzc1NoaW0uZHlsaWI7CiAKSW5k
ZXg6IFNvdXJjZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMvV2ViQ29udGVudFNlcnZpY2UueGNjb25m
aWcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9Db25maWd1cmF0aW9ucy9XZWJDb250ZW50
U2VydmljZS54Y2NvbmZpZwkocmV2aXNpb24gMjMwNjkzKQorKysgU291cmNlL1dlYktpdC9Db25m
aWd1cmF0aW9ucy9XZWJDb250ZW50U2VydmljZS54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAt
NDEsNiArNDEsOCBAQCBJTkZPUExJU1RfRklMRVtzZGs9bWFjb3N4Kl0gPSBXZWJQcm9jZXNzCiBX
S19BUFBLSVRfTERGTEFHUyA9ICQoV0tfQVBQS0lUX0xERkxBR1NfJChXS19QTEFURk9STV9OQU1F
KSk7CiBXS19BUFBLSVRfTERGTEFHU19tYWNvc3ggPSAtZnJhbWV3b3JrIEFwcEtpdDsKIAorT1RI
RVJfQ0ZMQUdTID0gJChpbmhlcml0ZWQpIC1EIFdLX0xJTktTX1RPX0FQUEtJVD0xCisKIE9USEVS
X0xERkxBR1MgPSAkKGluaGVyaXRlZCkgJChPVEhFUl9MREZMQUdTX1ZFUlNJT05FRF9GUkFNRVdP
UktfUEFUSF8kKFdLX1dFQkNPTlRFTlRfU0VSVklDRV9ORUVEU19WRVJTSU9ORURfRlJBTUVXT1JL
X1BBVEhfTERGTEFHKSkgJChXS19BUFBLSVRfTERGTEFHUykgJChPVEhFUl9MREZMQUdTX1BMQVRG
T1JNKSAkKFdLX1JFTE9DQVRBQkxFX0ZSQU1FV09SS1NfTERGTEFHUyk7CiBPVEhFUl9MREZMQUdT
X1BMQVRGT1JNW3Nkaz1tYWNvc3gqXSA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS9XZWJQcm9jZXNz
U2hpbS5keWxpYjsKIApJbmRleDogU291cmNlL1dlYktpdC9QbHVnaW5Qcm9jZXNzL21hYy9QbHVn
aW5Qcm9jZXNzTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvUGx1Z2luUHJvY2Vz
cy9tYWMvUGx1Z2luUHJvY2Vzc01hYy5tbQkocmV2aXNpb24gMjMwNjkzKQorKysgU291cmNlL1dl
YktpdC9QbHVnaW5Qcm9jZXNzL21hYy9QbHVnaW5Qcm9jZXNzTWFjLm1tCSh3b3JraW5nIGNvcHkp
CkBAIC01MjUsMTIgKzUyNSw2IEBAIHZvaWQgUGx1Z2luUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFs
aXplUHIKIHsKICAgICBpbml0aWFsaXplU2hpbSgpOwogCi0jaWYgX19NQUNfT1NfWF9WRVJTSU9O
X01JTl9SRVFVSVJFRCA+PSAxMDE0MDAKLSAgICAvLyBXZSBkb24ndCBuZWVkIHRvIHRhbGsgdG8g
dGhlIGRvY2suCi0gICAgaWYgKFtOU0FwcGxpY2F0aW9uIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2Vs
ZWN0b3IoX3ByZXZlbnREb2NrQ29ubmVjdGlvbnMpXSkKLSAgICAgICAgW05TQXBwbGljYXRpb24g
X3ByZXZlbnREb2NrQ29ubmVjdGlvbnNdOwotI2VuZGlmCi0KICAgICBpbml0aWFsaXplQ29jb2FP
dmVycmlkZXMoKTsKIAogICAgIC8vIEZJWE1FOiBJdCB3b3VsZCBiZSBiZXR0ZXIgdG8gcHJveHkg
U2V0Q3Vyc29yIGNhbGxzIG92ZXIgdG8gdGhlIFVJIHByb2Nlc3MgaW5zdGVhZCBvZgpJbmRleDog
U291cmNlL1dlYktpdC9TaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9tYWMvWFBDU2VydmljZS9Y
UENTZXJ2aWNlTWFpbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRy
eVBvaW50VXRpbGl0aWVzL21hYy9YUENTZXJ2aWNlL1hQQ1NlcnZpY2VNYWluLm1tCShyZXZpc2lv
biAyMzA2OTMpCisrKyBTb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL21h
Yy9YUENTZXJ2aWNlL1hQQ1NlcnZpY2VNYWluLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2ICsz
MSwxMCBAQAogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogI2ltcG9ydCA8d3RmL3NwaS9kYXJ3
aW4vWFBDU1BJLmg+CiAKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEw
MTQwMCAmJiBkZWZpbmVkKFdLX0xJTktTX1RPX0FQUEtJVCkgJiYgV0tfTElOS1NfVE9fQVBQS0lU
CisjaW1wb3J0IDxwYWwvc3BpL21hYy9OU0FwcGxpY2F0aW9uU1BJLmg+CisjZW5kaWYKKwogbmFt
ZXNwYWNlIFdlYktpdCB7CiAKIHN0YXRpYyB2b2lkIFhQQ1NlcnZpY2VFdmVudEhhbmRsZXIoeHBj
X2Nvbm5lY3Rpb25fdCBwZWVyKQpAQCAtMTQzLDYgKzE0NywxMiBAQCBpbnQgbWFpbihpbnQgYXJn
YywgY2hhcioqIGFyZ3YpCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIC8vIERvbid0IGFsbG93IEFw
cGxlIEV2ZW50cyBpbiBXZWJLaXQgcHJvY2Vzc2VzLiBUaGlzIGNhbiBiZSByZW1vdmVkIHdoZW4g
PHJkYXI6Ly9wcm9ibGVtLzE0MDEyODIzPiBpcyBmaXhlZC4KICAgICBzZXRlbnYoIl9fQVBQTEVF
VkVOVFNTRVJWSUNFTkFNRSIsICIiLCAxKTsKKworI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5f
UkVRVUlSRUQgPj0gMTAxNDAwICYmIGRlZmluZWQoV0tfTElOS1NfVE9fQVBQS0lUKSAmJiBXS19M
SU5LU19UT19BUFBLSVQKKyAgICAvLyBXZSBkb24ndCBuZWVkIHRvIHRhbGsgdG8gdGhlIGRvY2su
CisgICAgaWYgKFtOU0FwcGxpY2F0aW9uIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3By
ZXZlbnREb2NrQ29ubmVjdGlvbnMpXSkKKyAgICAgICAgW05TQXBwbGljYXRpb24gX3ByZXZlbnRE
b2NrQ29ubmVjdGlvbnNdOworI2VuZGlmCiAjZW5kaWYKIAogICAgIHhwY19tYWluKFhQQ1NlcnZp
Y2VFdmVudEhhbmRsZXIpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>338117</attachid>
            <date>2018-04-17 08:38:15 -0700</date>
            <delta_ts>2018-04-17 08:52:40 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-184664-20180417083819.patch</filename>
            <type>text/plain</type>
            <size>3273</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzA3MDkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA0LTE3ICBCcmVudCBGdWxn
aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gRG9uJ3QgZXN0YWJs
aXNoIHVubmVlZGVkIERvY2sgY29ubmVjdGlvbnMgKEZvbGxvdy11cCkKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDY2NAorICAgICAgICA8cmRhcjov
L3Byb2JsZW0vMTY4NjM2OTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgQmVjYXVzZSB0aGUgUGx1Z2luIHByb2Nlc3MgaXMgZHJpdmVuIGJ5IE5TQXBw
bGljYXRpb24ncyBydW4gbG9vcCwgd2UgYXJlbid0CisgICAgICAgIHNldHRpbmcgdGhlICdkb24n
dCBjb25uZWN0IHRvIHRoZSBkb2NrJyBzZXR0aW5nIGVhcmx5IGVub3VnaC4KKworICAgICAgICBU
aGlzIHBhdGNoIHNldHMgdGhlIGZsYWcgaW4gWFBDU2VydmljZU1haW4gZm9yIHRob3NlIHNlcnZp
Y2VzIHRoYXQKKyAgICAgICAgYXJlIGxpbmtlZCB0byBBcHBLaXQuCisKKyAgICAgICAgKiBQbHVn
aW5Qcm9jZXNzL21hYy9QbHVnaW5Qcm9jZXNzTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpQbHVn
aW5Qcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVQcm9jZXNzKTogUmVtb3ZlIHVubmVlZGVkIGNv
ZGUuCisgICAgICAgICogU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvbWFjL1hQQ1NlcnZpY2Uv
WFBDU2VydmljZU1haW4ubW06CisgICAgICAgIChtYWluKToKKwogMjAxOC0wNC0xNiAgVGltb3Ro
eSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCAzMi1i
aXQgYnVpbGQgZml4IGZvciByMjMwNjczLgpJbmRleDogU291cmNlL1dlYktpdC9QbHVnaW5Qcm9j
ZXNzL21hYy9QbHVnaW5Qcm9jZXNzTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv
UGx1Z2luUHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc01hYy5tbQkocmV2aXNpb24gMjMwNzA5KQor
KysgU291cmNlL1dlYktpdC9QbHVnaW5Qcm9jZXNzL21hYy9QbHVnaW5Qcm9jZXNzTWFjLm1tCSh3
b3JraW5nIGNvcHkpCkBAIC01MjUsMTIgKzUyNSw2IEBAIHZvaWQgUGx1Z2luUHJvY2Vzczo6cGxh
dGZvcm1Jbml0aWFsaXplUHIKIHsKICAgICBpbml0aWFsaXplU2hpbSgpOwogCi0jaWYgX19NQUNf
T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDAKLSAgICAvLyBXZSBkb24ndCBuZWVk
IHRvIHRhbGsgdG8gdGhlIGRvY2suCi0gICAgaWYgKFtOU0FwcGxpY2F0aW9uIHJlc3BvbmRzVG9T
ZWxlY3RvcjpAc2VsZWN0b3IoX3ByZXZlbnREb2NrQ29ubmVjdGlvbnMpXSkKLSAgICAgICAgW05T
QXBwbGljYXRpb24gX3ByZXZlbnREb2NrQ29ubmVjdGlvbnNdOwotI2VuZGlmCi0KICAgICBpbml0
aWFsaXplQ29jb2FPdmVycmlkZXMoKTsKIAogICAgIC8vIEZJWE1FOiBJdCB3b3VsZCBiZSBiZXR0
ZXIgdG8gcHJveHkgU2V0Q3Vyc29yIGNhbGxzIG92ZXIgdG8gdGhlIFVJIHByb2Nlc3MgaW5zdGVh
ZCBvZgpJbmRleDogU291cmNlL1dlYktpdC9TaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9tYWMv
WFBDU2VydmljZS9YUENTZXJ2aWNlTWFpbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0
L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL21hYy9YUENTZXJ2aWNlL1hQQ1NlcnZpY2VNYWlu
Lm1tCShyZXZpc2lvbiAyMzA3MDkpCisrKyBTb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50
VXRpbGl0aWVzL21hYy9YUENTZXJ2aWNlL1hQQ1NlcnZpY2VNYWluLm1tCSh3b3JraW5nIGNvcHkp
CkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMy0yMDE3IEFwcGxlIElu
Yy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMy0yMDE4IEFwcGxl
IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl
IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNh
dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u
cwpAQCAtMzEsNiArMzEsMTAgQEAKICNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KICNpbXBvcnQg
PHd0Zi9zcGkvZGFyd2luL1hQQ1NQSS5oPgogCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9S
RVFVSVJFRCA+PSAxMDE0MDAKKyNpbXBvcnQgPHBhbC9zcGkvbWFjL05TQXBwbGljYXRpb25TUEku
aD4KKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogc3RhdGljIHZvaWQgWFBDU2Vydmlj
ZUV2ZW50SGFuZGxlcih4cGNfY29ubmVjdGlvbl90IHBlZXIpCkBAIC0xNDMsNiArMTQ3LDE0IEBA
IGludCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKICNpZiBQTEFURk9STShNQUMpCiAgICAg
Ly8gRG9uJ3QgYWxsb3cgQXBwbGUgRXZlbnRzIGluIFdlYktpdCBwcm9jZXNzZXMuIFRoaXMgY2Fu
IGJlIHJlbW92ZWQgd2hlbiA8cmRhcjovL3Byb2JsZW0vMTQwMTI4MjM+IGlzIGZpeGVkLgogICAg
IHNldGVudigiX19BUFBMRUVWRU5UU1NFUlZJQ0VOQU1FIiwgIiIsIDEpOworCisjaWYgX19NQUNf
T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDAKKyAgICAvLyBXZSBkb24ndCBuZWVk
IHRvIHRhbGsgdG8gdGhlIGRvY2suCisgICAgaWYgKENsYXNzIG5zQXBwbGljYXRpb25DbGFzcyA9
IE5TQ2xhc3NGcm9tU3RyaW5nKEAiTlNBcHBsaWNhdGlvbiIpKSB7CisgICAgICAgIGlmIChbbnNB
cHBsaWNhdGlvbkNsYXNzIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3ByZXZlbnREb2Nr
Q29ubmVjdGlvbnMpXSkKKyAgICAgICAgICAgIFtuc0FwcGxpY2F0aW9uQ2xhc3MgX3ByZXZlbnRE
b2NrQ29ubmVjdGlvbnNdOworICAgIH0KKyNlbmRpZgogI2VuZGlmCiAKICAgICB4cGNfbWFpbihY
UENTZXJ2aWNlRXZlbnRIYW5kbGVyKTsK
</data>
<flag name="review"
          id="356414"
          type_id="1"
          status="+"
          setter="pvollan"
    />
          </attachment>
      

    </bug>

</bugzilla>