184658 2018-04-16 11:01:20 -0700 [WPE][GTK] GObject introspection annotation fixes: BackForwardList, NetworkProxySettings 2018-04-17 10:13:08 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build All All RESOLVED FIXED P2 Trivial --- 1 dylan-webkit mcatanzaro berto bugs-noreply cgarcia commit-queue ews-watchlist gustavo mcatanzaro oldest_to_newest 1414825 0 dylan-webkit 2018-04-16 11:01:20 -0700 The following functions can return NULL but are not marked as (nullable): webkit_back_forward_list_get_current_item webkit_back_forward_list_get_back_item webkit_back_forward_list_get_forward_item webkit_back_forward_list_get_nth_item The @ignoreHosts argument to webkit_network_proxy_settings_new should be marked as (array zero-terminated=1). 1414849 1 338020 mcatanzaro 2018-04-16 11:44:31 -0700 Created attachment 338020 Patch 1414850 2 ews-watchlist 2018-04-16 11:45:56 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1415201 3 338020 commit-queue 2018-04-17 10:13:06 -0700 Comment on attachment 338020 Patch Clearing flags on attachment: 338020 Committed r230718: <https://trac.webkit.org/changeset/230718> 1415202 4 commit-queue 2018-04-17 10:13:08 -0700 All reviewed patches have been landed. Closing bug. 338020 2018-04-16 11:44:31 -0700 2018-04-17 10:13:06 -0700 Patch bug-184658-20180416134430.patch text/plain 4038 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNjc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYyOGNmYWEzYmMwZGUxMjFl NWYyZTY4N2NhNGNjMTJmYmQ4N2E3ZGEuLmY2Y2MwZGZkZjUyYmIyNmUzMmNlMWUzOWNlMzI1NWRl NTg4NjFlM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDQtMTYgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10g R09iamVjdCBpbnRyb3NwZWN0aW9uIGFubm90YXRpb24gZml4ZXM6IEJhY2tGb3J3YXJkTGlzdCwg TmV0d29ya1Byb3h5U2V0dGluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4NDY1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoYW5rcyB0byBEeWxhbiBTaW1vbiBmb3IgcmVjb21tZW5kaW5nIHRoZXNl IGFubm90YXRpb24gZml4ZXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0 QmFja0ZvcndhcmRMaXN0LmNwcDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0 TmV0d29ya1Byb3h5U2V0dGluZ3MuY3BwOgorCiAyMDE4LTA0LTE2ICBUaW1vdGh5IEhhdGNoZXIg IDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbiB1cCBPVEhFUl9MREZMQUdTIGZv ciBXZWJLaXQgcHJvY2Vzc2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ2xpYi9XZWJLaXRCYWNrRm9yd2FyZExpc3QuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL2dsaWIvV2ViS2l0QmFja0ZvcndhcmRMaXN0LmNwcAppbmRleCA4YjU4MGVkMDI3ZDE3 MmJjYTAwZTUxMjUxMjliY2U4ZDA3ZjRlYmQ5Li42ZTFlMmVhMzU3NzhjODVkMTI1ZDMxZDQ5Yjcw MDA3NTg1MTUwY2JhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xp Yi9XZWJLaXRCYWNrRm9yd2FyZExpc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9nbGliL1dlYktpdEJhY2tGb3J3YXJkTGlzdC5jcHAKQEAgLTE1Niw3ICsxNTYsNyBAQCB2 b2lkIHdlYmtpdEJhY2tGb3J3YXJkTGlzdENoYW5nZWQoV2ViS2l0QmFja0ZvcndhcmRMaXN0KiBi YWNrRm9yd2FyZExpc3QsIFdlYkJhYwogICoKICAqIFJldHVybnMgdGhlIGN1cnJlbnQgaXRlbSBp biBAYmFja19mb3J3YXJkX2xpc3QuCiAgKgotICogUmV0dXJuczogKHRyYW5zZmVyIG5vbmUpOiBh ICNXZWJLaXRCYWNrRm9yd2FyZExpc3RJdGVtCisgKiBSZXR1cm5zOiAobnVsbGFibGUpICh0cmFu c2ZlciBub25lKTogYSAjV2ViS2l0QmFja0ZvcndhcmRMaXN0SXRlbQogICogICAgb3IgJU5VTEwg aWYgQGJhY2tfZm9yd2FyZF9saXN0IGlzIGVtcHR5LgogICovCiBXZWJLaXRCYWNrRm9yd2FyZExp c3RJdGVtKiB3ZWJraXRfYmFja19mb3J3YXJkX2xpc3RfZ2V0X2N1cnJlbnRfaXRlbShXZWJLaXRC YWNrRm9yd2FyZExpc3QqIGJhY2tGb3J3YXJkTGlzdCkKQEAgLTE3Miw3ICsxNzIsNyBAQCBXZWJL aXRCYWNrRm9yd2FyZExpc3RJdGVtKiB3ZWJraXRfYmFja19mb3J3YXJkX2xpc3RfZ2V0X2N1cnJl bnRfaXRlbShXZWJLaXRCYWNrRgogICoKICAqIFJldHVybnMgdGhlIGl0ZW0gdGhhdCBwcmVjZWRl cyB0aGUgY3VycmVudCBpdGVtLgogICoKLSAqIFJldHVybnM6ICh0cmFuc2ZlciBub25lKTogdGhl ICNXZWJLaXRCYWNrRm9yd2FyZExpc3RJdGVtCisgKiBSZXR1cm5zOiAobnVsbGFibGUpICh0cmFu c2ZlciBub25lKTogdGhlICNXZWJLaXRCYWNrRm9yd2FyZExpc3RJdGVtCiAgKiAgICBwcmVjZWRp bmcgdGhlIGN1cnJlbnQgaXRlbSBvciAlTlVMTC4KICAqLwogV2ViS2l0QmFja0ZvcndhcmRMaXN0 SXRlbSogd2Via2l0X2JhY2tfZm9yd2FyZF9saXN0X2dldF9iYWNrX2l0ZW0oV2ViS2l0QmFja0Zv cndhcmRMaXN0KiBiYWNrRm9yd2FyZExpc3QpCkBAIC0xODgsNyArMTg4LDcgQEAgV2ViS2l0QmFj a0ZvcndhcmRMaXN0SXRlbSogd2Via2l0X2JhY2tfZm9yd2FyZF9saXN0X2dldF9iYWNrX2l0ZW0o V2ViS2l0QmFja0ZvcncKICAqCiAgKiBSZXR1cm5zIHRoZSBpdGVtIHRoYXQgZm9sbG93cyB0aGUg Y3VycmVudCBpdGVtLgogICoKLSAqIFJldHVybnM6ICh0cmFuc2ZlciBub25lKTogdGhlICNXZWJL aXRCYWNrRm9yd2FyZExpc3RJdGVtCisgKiBSZXR1cm5zOiAobnVsbGFibGUpICh0cmFuc2ZlciBu b25lKTogdGhlICNXZWJLaXRCYWNrRm9yd2FyZExpc3RJdGVtCiAgKiAgICBmb2xsb3dpbmcgdGhl IGN1cnJlbnQgaXRlbSBvciAlTlVMTC4KICAqLwogV2ViS2l0QmFja0ZvcndhcmRMaXN0SXRlbSog d2Via2l0X2JhY2tfZm9yd2FyZF9saXN0X2dldF9mb3J3YXJkX2l0ZW0oV2ViS2l0QmFja0Zvcndh cmRMaXN0KiBiYWNrRm9yd2FyZExpc3QpCkBAIC0yMDUsOCArMjA1LDggQEAgV2ViS2l0QmFja0Zv cndhcmRMaXN0SXRlbSogd2Via2l0X2JhY2tfZm9yd2FyZF9saXN0X2dldF9mb3J3YXJkX2l0ZW0o V2ViS2l0QmFja0YKICAqCiAgKiBSZXR1cm5zIHRoZSBpdGVtIGF0IGEgZ2l2ZW4gaW5kZXggcmVs YXRpdmUgdG8gdGhlIGN1cnJlbnQgaXRlbS4KICAqCi0gKiBSZXR1cm5zOiAodHJhbnNmZXIgbm9u ZSk6IHRoZSAjV2ViS2l0QmFja0ZvcndhcmRMaXN0SXRlbQotICogICAgbG9jYXRlZCBhdCB0aGUg c3BlY2lmaWVkIGluZGV4IHJlbGF0aXZlIHRvIHRoZSBjdXJyZW50IGl0ZW0uCisgKiBSZXR1cm5z OiAobnVsbGFibGUpICh0cmFuc2ZlciBub25lKTogdGhlICNXZWJLaXRCYWNrRm9yd2FyZExpc3RJ dGVtCisgKiAgICBsb2NhdGVkIGF0IHRoZSBzcGVjaWZpZWQgaW5kZXggcmVsYXRpdmUgdG8gdGhl IGN1cnJlbnQgaXRlbSBvciAlTlVMTC4KICAqLwogV2ViS2l0QmFja0ZvcndhcmRMaXN0SXRlbSog d2Via2l0X2JhY2tfZm9yd2FyZF9saXN0X2dldF9udGhfaXRlbShXZWJLaXRCYWNrRm9yd2FyZExp c3QqIGJhY2tGb3J3YXJkTGlzdCwgZ2ludCBpbmRleCkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdE5ldHdvcmtQcm94eVNldHRpbmdzLmNwcCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdE5ldHdvcmtQcm94eVNldHRp bmdzLmNwcAppbmRleCAwZjZlNWZlZmRiOWUxM2IzN2Q4YzY3YjgwMzkzODg0ZTUxYTMzNWE4Li5h ZDFiN2YxMzdhNmY1OGViYmFhZTA5ODBiYjg4MjkzMDdkZTEwNjc0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXROZXR3b3JrUHJveHlTZXR0aW5ncy5j cHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0TmV0d29ya1By b3h5U2V0dGluZ3MuY3BwCkBAIC02Myw3ICs2Myw3IEBAIGNvbnN0IFNvdXBOZXR3b3JrUHJveHlT ZXR0aW5ncyYgd2Via2l0TmV0d29ya1Byb3h5U2V0dGluZ3NHZXROZXR3b3JrUHJveHlTZXR0aW5n CiAvKioKICAqIHdlYmtpdF9uZXR3b3JrX3Byb3h5X3NldHRpbmdzX25ldzoKICAqIEBkZWZhdWx0 X3Byb3h5X3VyaTogKGFsbG93LW5vbmUpOiB0aGUgZGVmYXVsdCBwcm94eSBVUkkgdG8gdXNlLCBv ciAlTlVMTC4KLSAqIEBpZ25vcmVfaG9zdHM6IChhbGxvdy1ub25lKTogYW4gb3B0aW9uYWwgbGlz dCBvZiBob3N0cy9JUCBhZGRyZXNzZXMgdG8gbm90IHVzZSBhIHByb3h5IGZvci4KKyAqIEBpZ25v cmVfaG9zdHM6IChhbGxvdy1ub25lKSAoYXJyYXkgemVyby10ZXJtaW5hdGVkPTEpOiBhbiBvcHRp b25hbCBsaXN0IG9mIGhvc3RzL0lQIGFkZHJlc3NlcyB0byBub3QgdXNlIGEgcHJveHkgZm9yLgog ICoKICAqIENyZWF0ZSBhIG5ldyAjV2ViS2l0TmV0d29ya1Byb3h5U2V0dGluZ3Mgd2l0aCB0aGUg Z2l2ZW4gQGRlZmF1bHRfcHJveHlfdXJpIGFuZCBAaWdub3JlX2hvc3RzLgogICoK