184651 2018-04-16 08:10:22 -0700 [GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible 2018-04-16 09:03:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 tsaunier webkit-unassigned commit-queue philn pnormand tsaunier webkit-bug-importer oldest_to_newest 1414772 0 tsaunier 2018-04-16 08:10:22 -0700 See commit message. 1414773 1 338001 tsaunier 2018-04-16 08:10:31 -0700 Created attachment 338001 [GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible We can't notify the client if none is connected, but still we need to fill our metadatas from the provided GstTagList, especially in the case of playbin3 where the client is not set yet at construct time but the metadata might already be preset (and won't be updated later on). 1414774 2 338002 tsaunier 2018-04-16 08:11:11 -0700 Created attachment 338002 [GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible We can't notify the client if none is connected, but still we need to fill our metadatas from the provided GstTagList, especially in the case of playbin3 where the client is not set yet at construct time but the metadata might already be preset (and won't be updated later on). 1414791 3 338002 commit-queue 2018-04-16 09:02:02 -0700 Comment on attachment 338002 [GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible Clearing flags on attachment: 338002 Committed r230669: <https://trac.webkit.org/changeset/230669> 1414792 4 commit-queue 2018-04-16 09:02:03 -0700 All reviewed patches have been landed. Closing bug. 1414793 5 webkit-bug-importer 2018-04-16 09:03:36 -0700 <rdar://problem/39457984> 338001 2018-04-16 08:10:31 -0700 2018-04-16 08:11:11 -0700 [GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible GStreamer-Set-TrackPrivateBaseGStreamer-metadata-i.patch text/plain 3200 tsaunier RnJvbSA1NGJlMmM3NTJhNDE5N2YxN2NlMmNiYmFjODI0YWRlYjhkZTI4NTIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaGliYXVsdCBTYXVuaWVyIDx0c2F1bmllckBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDE2IEFwciAyMDE4IDEyOjA1OjIwIC0wMzAwClN1YmplY3Q6IFtQQVRDSCB4 c2VydmVyXSBbR1N0cmVhbWVyXSBTZXQgVHJhY2tQcml2YXRlQmFzZUdTdHJlYW1lciBtZXRhZGF0 YQogaW5mb3JtYXRpb24gZXZlbiBpZiBubyBjbGllbnQgaXMgYXZhbGFpYmxlCgpXZSBjYW4ndCBu b3RpZnkgdGhlIGNsaWVudCBpZiBub25lIGlzIGNvbm5lY3RlZCwgYnV0IHN0aWxsIHdlIG5lZWQg dG8gZmlsbCBvdXIgbWV0YWRhdGFzIGZyb20KdGhlIHByb3ZpZGVkIEdzdFRhZ0xpc3QsIGVzcGVj aWFsbHkgaW4gdGhlIGNhc2Ugb2YgcGxheWJpbjMgd2hlcmUgdGhlIGNsaWVudCBpcyBub3Qgc2V0 IHlldAphdCBjb25zdHJ1Y3QgdGltZSBidXQgdGhlIG1ldGFkYXRhIG1pZ2h0IGFscmVhZHkgYmUg cHJlc2V0IChhbmQgd29uJ3QgYmUgdXBkYXRlZCBsYXRlciBvbikuCgpodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0NjUxCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICAgICAgICAgfCAxNyArKysrKysrKysrKysrKysrKwogLi4uL2dz dHJlYW1lci9UcmFja1ByaXZhdGVCYXNlR1N0cmVhbWVyLmNwcCAgICAgfCAgOCArKysrLS0tLQog MiBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCAyNjliOWEzNzc1Ny4uYmIwNmE5YTY5NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MCBAQAorMjAxOC0wNC0xNiAgVGhpYmF1bHQgU2F1bmllciAgPHRzYXVuaWVyQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dTdHJlYW1lcl0gU2V0IFRyYWNrUHJpdmF0ZUJhc2VHU3RyZWFtZXIgbWV0 YWRhdGEgaW5mb3JtYXRpb24gZXZlbiBpZiBubyBjbGllbnQgaXMgYXZhbGFpYmxlCisgICAgICAg IE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMhKS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZSBjYW4ndCBub3RpZnkgdGhlIGNsaWVudCBpZiBub25lIGlz IGNvbm5lY3RlZCwgYnV0IHN0aWxsIHdlIG5lZWQgdG8gZmlsbCBvdXIgbWV0YWRhdGFzIGZyb20K KyAgICAgICAgdGhlIHByb3ZpZGVkIEdzdFRhZ0xpc3QsIGVzcGVjaWFsbHkgaW4gdGhlIGNhc2Ug b2YgcGxheWJpbjMgd2hlcmUgdGhlIGNsaWVudCBpcyBub3Qgc2V0IHlldAorICAgICAgICBhdCBj b25zdHJ1Y3QgdGltZSBidXQgdGhlIG1ldGFkYXRhIG1pZ2h0IGFscmVhZHkgYmUgcHJlc2V0IChh bmQgd29uJ3QgYmUgdXBkYXRlZCBsYXRlciBvbikuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFy ZSBhZGRlZCBhcyB3ZSBhbHJlYWR5IGhhdmUgYSBmZXcgb25lcyB0aGF0IGFyZSBjdXJyZW50bHkg ZGlzYWJsZWQgaW4KKyAgICAgICAgdGhlIG1lZGlhc3RyZWFtIHRlc3RzdWl0ZS4gVGhpcyBwYXRj aCBpcyBwYXJ0IG9mIHRoZSB3b3JrIHRvIGVuYWJsZSB0aGVtLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1RyYWNrUHJpdmF0ZUJhc2VHU3RyZWFtZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6VHJhY2tQcml2YXRlQmFzZUdTdHJlYW1lcjo6bm90aWZ5VHJhY2tPZlRh Z3NDaGFuZ2VkKToKKwogMjAxOC0wNC0xNiAgVGhpYmF1bHQgU2F1bmllciAgPHRzYXVuaWVyQGln YWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gU3RhcnQgaW1wbGVtZW50aW5nIEF1ZGlv L1ZpZGVvVHJhY2tQcml2YXRlR1NUcmVhbWVyOjpraW5kIG1ldGhvZApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1RyYWNrUHJpdmF0ZUJhc2VH U3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L1RyYWNrUHJpdmF0ZUJhc2VHU3RyZWFtZXIuY3BwCmluZGV4IDI1NGRhNzhkYTBjLi4wNWJhMWU1 YjEyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL1RyYWNrUHJpdmF0ZUJhc2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UcmFja1ByaXZhdGVCYXNlR1N0cmVhbWVyLmNwcApA QCAtMTcyLDE4ICsxNzIsMTcgQEAgYm9vbCBUcmFja1ByaXZhdGVCYXNlR1N0cmVhbWVyOjpnZXRU YWcoR3N0VGFnTGlzdCogdGFncywgY29uc3QgZ2NoYXIqIHRhZ05hbWUsIFMKIHZvaWQgVHJhY2tQ cml2YXRlQmFzZUdTdHJlYW1lcjo6bm90aWZ5VHJhY2tPZlRhZ3NDaGFuZ2VkKCkKIHsKICAgICBU cmFja1ByaXZhdGVCYXNlQ2xpZW50KiBjbGllbnQgPSBtX293bmVyLT5jbGllbnQoKTsKLSAgICBp ZiAoIWNsaWVudCkKLSAgICAgICAgcmV0dXJuOwogCiAgICAgR1JlZlB0cjxHc3RUYWdMaXN0PiB0 YWdzOwogICAgIHsKICAgICAgICAgTG9ja0hvbGRlciBsb2NrKG1fdGFnTXV0ZXgpOwogICAgICAg ICB0YWdzLnN3YXAobV90YWdzKTsKICAgICB9CisKICAgICBpZiAoIXRhZ3MpCiAgICAgICAgIHJl dHVybjsKIAotICAgIGlmIChnZXRUYWcodGFncy5nZXQoKSwgR1NUX1RBR19USVRMRSwgbV9sYWJl bCkpCisgICAgaWYgKGdldFRhZyh0YWdzLmdldCgpLCBHU1RfVEFHX1RJVExFLCBtX2xhYmVsKSAm JiBjbGllbnQpCiAgICAgICAgIGNsaWVudC0+bGFiZWxDaGFuZ2VkKG1fbGFiZWwpOwogCiAgICAg QXRvbWljU3RyaW5nIGxhbmd1YWdlOwpAQCAtMTk0LDcgKzE5Myw4IEBAIHZvaWQgVHJhY2tQcml2 YXRlQmFzZUdTdHJlYW1lcjo6bm90aWZ5VHJhY2tPZlRhZ3NDaGFuZ2VkKCkKICAgICAgICAgcmV0 dXJuOwogCiAgICAgbV9sYW5ndWFnZSA9IGxhbmd1YWdlOwotICAgIGNsaWVudC0+bGFuZ3VhZ2VD aGFuZ2VkKG1fbGFuZ3VhZ2UpOworICAgIGlmIChjbGllbnQpCisgICAgICAgIGNsaWVudC0+bGFu Z3VhZ2VDaGFuZ2VkKG1fbGFuZ3VhZ2UpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCi0t IAoyLjE3LjA= 338002 2018-04-16 08:11:11 -0700 2018-04-16 09:02:02 -0700 [GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible GStreamer-Set-TrackPrivateBaseGStreamer-metadata-i.patch text/plain 3221 tsaunier RnJvbSA5NjZjZmJjM2VmMDBiYmE4NjlmN2Q3MWM3Yjg4NWE4NjRmMzYwZTFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaGliYXVsdCBTYXVuaWVyIDx0c2F1bmllckBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDE2IEFwciAyMDE4IDEyOjA1OjIwIC0wMzAwClN1YmplY3Q6IFtQQVRDSCB4 c2VydmVyXSBbR1N0cmVhbWVyXSBTZXQgVHJhY2tQcml2YXRlQmFzZUdTdHJlYW1lciBtZXRhZGF0 YQogaW5mb3JtYXRpb24gZXZlbiBpZiBubyBjbGllbnQgaXMgYXZhbGFpYmxlCgpXZSBjYW4ndCBu b3RpZnkgdGhlIGNsaWVudCBpZiBub25lIGlzIGNvbm5lY3RlZCwgYnV0IHN0aWxsIHdlIG5lZWQg dG8gZmlsbCBvdXIgbWV0YWRhdGFzIGZyb20KdGhlIHByb3ZpZGVkIEdzdFRhZ0xpc3QsIGVzcGVj aWFsbHkgaW4gdGhlIGNhc2Ugb2YgcGxheWJpbjMgd2hlcmUgdGhlIGNsaWVudCBpcyBub3Qgc2V0 IHlldAphdCBjb25zdHJ1Y3QgdGltZSBidXQgdGhlIG1ldGFkYXRhIG1pZ2h0IGFscmVhZHkgYmUg cHJlc2V0IChhbmQgd29uJ3QgYmUgdXBkYXRlZCBsYXRlciBvbikuCgpodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0NjUxCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICAgICAgICAgfCAxNyArKysrKysrKysrKysrKysrKwogLi4uL2dz dHJlYW1lci9UcmFja1ByaXZhdGVCYXNlR1N0cmVhbWVyLmNwcCAgICAgfCAgOCArKysrLS0tLQog MiBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCAyNjliOWEzNzc1Ny4uYzcwMWUxZDU3ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MCBAQAorMjAxOC0wNC0xNiAgVGhpYmF1bHQgU2F1bmllciAgPHRzYXVuaWVyQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dTdHJlYW1lcl0gU2V0IFRyYWNrUHJpdmF0ZUJhc2VHU3RyZWFtZXIgbWV0 YWRhdGEgaW5mb3JtYXRpb24gZXZlbiBpZiBubyBjbGllbnQgaXMgYXZhbGFpYmxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ2NTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBjYW4ndCBub3RpZnkg dGhlIGNsaWVudCBpZiBub25lIGlzIGNvbm5lY3RlZCwgYnV0IHN0aWxsIHdlIG5lZWQgdG8gZmls bCBvdXIgbWV0YWRhdGFzIGZyb20KKyAgICAgICAgdGhlIHByb3ZpZGVkIEdzdFRhZ0xpc3QsIGVz cGVjaWFsbHkgaW4gdGhlIGNhc2Ugb2YgcGxheWJpbjMgd2hlcmUgdGhlIGNsaWVudCBpcyBub3Qg c2V0IHlldAorICAgICAgICBhdCBjb25zdHJ1Y3QgdGltZSBidXQgdGhlIG1ldGFkYXRhIG1pZ2h0 IGFscmVhZHkgYmUgcHJlc2V0IChhbmQgd29uJ3QgYmUgdXBkYXRlZCBsYXRlciBvbikuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIGFyZSBhZGRlZCBhcyB3ZSBhbHJlYWR5IGhhdmUgYSBmZXcgb25l cyB0aGF0IGFyZSBjdXJyZW50bHkgZGlzYWJsZWQgaW4KKyAgICAgICAgdGhlIG1lZGlhc3RyZWFt IHRlc3RzdWl0ZS4gVGhpcyBwYXRjaCBpcyBwYXJ0IG9mIHRoZSB3b3JrIHRvIGVuYWJsZSB0aGVt LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1RyYWNrUHJpdmF0ZUJh c2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VHJhY2tQcml2YXRlQmFzZUdTdHJl YW1lcjo6bm90aWZ5VHJhY2tPZlRhZ3NDaGFuZ2VkKToKKwogMjAxOC0wNC0xNiAgVGhpYmF1bHQg U2F1bmllciAgPHRzYXVuaWVyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gU3Rh cnQgaW1wbGVtZW50aW5nIEF1ZGlvL1ZpZGVvVHJhY2tQcml2YXRlR1NUcmVhbWVyOjpraW5kIG1l dGhvZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL1RyYWNrUHJpdmF0ZUJhc2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1RyYWNrUHJpdmF0ZUJhc2VHU3RyZWFtZXIuY3BwCmluZGV4 IDI1NGRhNzhkYTBjLi4wNWJhMWU1YjEyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1RyYWNrUHJpdmF0ZUJhc2VHU3RyZWFtZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UcmFja1ByaXZh dGVCYXNlR1N0cmVhbWVyLmNwcApAQCAtMTcyLDE4ICsxNzIsMTcgQEAgYm9vbCBUcmFja1ByaXZh dGVCYXNlR1N0cmVhbWVyOjpnZXRUYWcoR3N0VGFnTGlzdCogdGFncywgY29uc3QgZ2NoYXIqIHRh Z05hbWUsIFMKIHZvaWQgVHJhY2tQcml2YXRlQmFzZUdTdHJlYW1lcjo6bm90aWZ5VHJhY2tPZlRh Z3NDaGFuZ2VkKCkKIHsKICAgICBUcmFja1ByaXZhdGVCYXNlQ2xpZW50KiBjbGllbnQgPSBtX293 bmVyLT5jbGllbnQoKTsKLSAgICBpZiAoIWNsaWVudCkKLSAgICAgICAgcmV0dXJuOwogCiAgICAg R1JlZlB0cjxHc3RUYWdMaXN0PiB0YWdzOwogICAgIHsKICAgICAgICAgTG9ja0hvbGRlciBsb2Nr KG1fdGFnTXV0ZXgpOwogICAgICAgICB0YWdzLnN3YXAobV90YWdzKTsKICAgICB9CisKICAgICBp ZiAoIXRhZ3MpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmIChnZXRUYWcodGFncy5nZXQoKSwg R1NUX1RBR19USVRMRSwgbV9sYWJlbCkpCisgICAgaWYgKGdldFRhZyh0YWdzLmdldCgpLCBHU1Rf VEFHX1RJVExFLCBtX2xhYmVsKSAmJiBjbGllbnQpCiAgICAgICAgIGNsaWVudC0+bGFiZWxDaGFu Z2VkKG1fbGFiZWwpOwogCiAgICAgQXRvbWljU3RyaW5nIGxhbmd1YWdlOwpAQCAtMTk0LDcgKzE5 Myw4IEBAIHZvaWQgVHJhY2tQcml2YXRlQmFzZUdTdHJlYW1lcjo6bm90aWZ5VHJhY2tPZlRhZ3ND aGFuZ2VkKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9sYW5ndWFnZSA9IGxhbmd1YWdlOwot ICAgIGNsaWVudC0+bGFuZ3VhZ2VDaGFuZ2VkKG1fbGFuZ3VhZ2UpOworICAgIGlmIChjbGllbnQp CisgICAgICAgIGNsaWVudC0+bGFuZ3VhZ2VDaGFuZ2VkKG1fbGFuZ3VhZ2UpOwogfQogCiB9IC8v IG5hbWVzcGFjZSBXZWJDb3JlCi0tIAoyLjE3LjA=