184595 2018-04-13 09:47:42 -0700 [WPE] [webkitpy] The driver requirements should be checked before starting the tests 2018-04-13 19:14:12 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez bugs-noreply cgarcia clopez ddkilzer ews-watchlist glenn mcatanzaro zan oldest_to_newest 1414447 0 clopez 2018-04-13 09:47:42 -0700 Currently the WPE port doesn't call the driver check_driver() method. So, what happens when the user tries to run layout tests with the wayland driver, from a non wayland environment you get all crashes. Instead, the user should get a meaningful error saying that she should use wayland 1414450 1 337901 clopez 2018-04-13 09:52:05 -0700 Created attachment 337901 Patch 1414451 2 clopez 2018-04-13 09:53:06 -0700 (In reply to Carlos Alberto Lopez Perez from comment #1) > Created attachment 337901 [details] > Patch after this patch, trying to run layout tests on wpe from a non-wayland environment will result in: 18:52:19.121 3274 wptwk successfully started (pid = 3372) 18:52:19.121 3274 18:52:19.121 3274 Running 29948 tests 18:52:19.121 3274 18:52:19.121 3274 Checking build ... 18:52:19.215 3274 "Tools/Scripts/build-dumprendertree --release --wpe" took 0.09s 18:52:19.215 3274 Output of ['Tools/Scripts/build-dumprendertree', '--release', '--wpe']: 18:52:19.287 3274 "Tools/Scripts/build-webkittestrunner --release --wpe" took 0.07s 18:52:19.287 3274 Output of ['Tools/Scripts/build-webkittestrunner', '--release', '--wpe']: 18:52:19.288 3274 Starting helper ... 18:52:19.548 3274 Checking system dependencies ... 18:52:19.581 3274 "/usr/sbin/apache2 -v" took 0.03s 18:52:19.581 3274 WAYLAND_DISPLAY or WAYLAND_SOCKET not found in the environment. Cannot run tests. 18:52:19.582 3274 Testing completed, Exit status: -1 18:52:19.583 3274 Stopping Web Platform Test server ... No handlers could be found for logger "webkitpy.layout_tests.servers.http_server_base" ... instead of thousands of crashes. 1414575 3 337901 clopez 2018-04-13 19:14:08 -0700 Comment on attachment 337901 Patch Clearing flags on attachment: 337901 Committed r230653: <https://trac.webkit.org/changeset/230653> 1414576 4 clopez 2018-04-13 19:14:12 -0700 All reviewed patches have been landed. Closing bug. 337901 2018-04-13 09:52:05 -0700 2018-04-13 19:14:08 -0700 Patch bug-184595-20180413185204.patch text/plain 1527 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNjM0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2E5NDAyZDAxMGUyZDFkZDBiNmEyZDU0YzA3MzFlMzhl MWYzMDVlOC4uNzNlNWJiZWQ4MGU1MDg0MGQ1YjYzMjAyYTY2YmVjMWY2NDFiNGEwMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE4LTA0LTEzICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtXUEVdIFt3ZWJraXRweV0gVGhlIGRyaXZlciByZXF1aXJlbWVu dHMgc2hvdWxkIGJlIGNoZWNrZWQgYmVmb3JlIHN0YXJ0aW5nIHRoZSB0ZXN0cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0NTk1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5zdXJlIERyaXZlci5jaGVj a19kcml2ZXIoKSBpcyBjaGVja2VkIGF0IGNoZWNrX3N5c19kZXBzKCkgdGltZS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC93cGUucHk6CisgICAgICAgIChXUEVQb3J0LmNoZWNr X3N5c19kZXBzKToKKwogMjAxOC0wNC0xMyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJv QGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0geGtiY29tbW9uOiBFUlJPUjogZmFpbGVkIHRv IGFkZCBkZWZhdWx0IGluY2x1ZGUgcGF0aCAvaG9tZS9tY2F0YW56YXJvL1Byb2plY3RzL1dlYktp dC9XZWJLaXRCdWlsZC9EZXBlbmRlbmNpZXNXUEUvUm9vdC9zaGFyZS9YMTEveGtiCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd3BlLnB5IGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L3dwZS5weQppbmRleCAyMGU0YzNkN2RiNTkyMzE5YjRhZGI5ZmY0NTc1Mjc5 M2Q4YTY4M2FlLi4xMDkwNTc4YWRiYjAxNmJlZmE1NGI2NzgxY2I3ZjNjZGRhZjAzMDMwIDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd3BlLnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvcG9ydC93cGUucHkKQEAgLTc3LDYgKzc3LDkgQEAgY2xhc3MgV1BFUG9y dChQb3J0KToKICAgICAgICAgZW52aXJvbm1lbnRbJ1dFQktJVF9FWEVDX1BBVEgnXSA9IHNlbGYu X2J1aWxkX3BhdGgoJ2JpbicpCiAgICAgICAgIHJldHVybiBlbnZpcm9ubWVudAogCisgICAgZGVm IGNoZWNrX3N5c19kZXBzKHNlbGYsIG5lZWRzX2h0dHApOgorICAgICAgICByZXR1cm4gc3VwZXIo V1BFUG9ydCwgc2VsZikuY2hlY2tfc3lzX2RlcHMobmVlZHNfaHR0cCkgYW5kIHNlbGYuX2RyaXZl cl9jbGFzcygpLmNoZWNrX2RyaXZlcihzZWxmKQorCiAgICAgZGVmIF9nZW5lcmF0ZV9hbGxfdGVz dF9jb25maWd1cmF0aW9ucyhzZWxmKToKICAgICAgICAgY29uZmlndXJhdGlvbnMgPSBbXQogICAg ICAgICBmb3IgYnVpbGRfdHlwZSBpbiBzZWxmLkFMTF9CVUlMRF9UWVBFUzoK