<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>184592</bug_id>
          
          <creation_ts>2018-04-13 09:11:49 -0700</creation_ts>
          <short_desc>Inline NetworkLoad::sharedDidReceiveResponse() into NetworkLoad::notifyDidReceiveResponse()</short_desc>
          <delta_ts>2018-04-13 09:50:27 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Local Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Daniel Bates">dbates</assigned_to>
          <cc>achristensen</cc>
    
    <cc>beidson</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1414430</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-04-13 09:11:49 -0700</bug_when>
    <thetext>Following the removal of the pre-Network Session code in &lt;https://trac.webkit.org/changeset/227364&gt; (bug 181944) NetworkLoad::sharedDidReceiveResponse() is now only called from NetworkLoad::notifyDidReceiveResponse(). We should inline it and remove this function.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414431</commentid>
    <comment_count>1</comment_count>
      <attachid>337895</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-04-13 09:12:50 -0700</bug_when>
    <thetext>Created attachment 337895
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414448</commentid>
    <comment_count>2</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-04-13 09:49:14 -0700</bug_when>
    <thetext>Committed r230635: &lt;https://trac.webkit.org/changeset/230635&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1414449</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-04-13 09:50:27 -0700</bug_when>
    <thetext>&lt;rdar://problem/39414674&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>337895</attachid>
            <date>2018-04-13 09:12:50 -0700</date>
            <delta_ts>2018-04-13 09:38:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-184592-20180413091249.patch</filename>
            <type>text/plain</type>
            <size>3712</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVlYWU5YTFjMzI2YWEzMGJm
MTU1YmE5ZTQ0NDYxNWJmZDY1N2JiMTUuLjFhZWU2MDkzODQxZmQ5MThlZGM0ZGY5YThjOTA4N2E4
ODNlNTRhNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDQtMTMgIERhbmllbCBC
YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIElubGluZSBOZXR3b3JrTG9hZDo6
c2hhcmVkRGlkUmVjZWl2ZVJlc3BvbnNlKCkgaW50byBOZXR3b3JrTG9hZDo6bm90aWZ5RGlkUmVj
ZWl2ZVJlc3BvbnNlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTE4NDU5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEZvbGxvd2luZyB0aGUgcmVtb3ZhbCBvZiB0aGUgcHJlLU5ldHdvcmsgU2Vzc2lvbiBj
b2RlIGluIHIyMjczNjQsIE5ldHdvcmtMb2FkOjpzaGFyZWREaWRSZWNlaXZlUmVzcG9uc2UoKQor
ICAgICAgICBpcyBvbmx5IHJlZmVyZW5jZWQgZnJvbSBOZXR3b3JrTG9hZDo6bm90aWZ5RGlkUmVj
ZWl2ZVJlc3BvbnNlKCkuIFdlIHNob3VsZCBpbmxpbmUgaXRzCisgICAgICAgIGltcGxlbWVudGF0
aW9uIGludG8gdGhlIE5ldHdvcmtMb2FkOjpub3RpZnlEaWRSZWNlaXZlUmVzcG9uc2UoKSwgcmVt
b3ZlIGEgZnVuY3Rpb24KKyAgICAgICAgY2FsbCwgYW5kIHRoZSBjb2duaXRpdmUgbG9hZCB0byBm
b2xsb3cgc3VjaCBhIGZ1bmN0aW9uIGNhbGwgd2hlbiByZWFkaW5nIHRoZSBjb2RlLgorCisgICAg
ICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwOgorICAgICAgICAoV2ViS2l0OjpO
ZXR3b3JrTG9hZDo6bm90aWZ5RGlkUmVjZWl2ZVJlc3BvbnNlKTogTW92ZWQgdGhlIGltcGxlbWVu
dGF0aW9uIG9mIE5ldHdvcmtMb2FkOjpzaGFyZWREaWRSZWNlaXZlUmVzcG9uc2UoKQorICAgICAg
ICBpbnRvIHRoaXMgZnVuY3Rpb24uCisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtMb2FkOjpzaGFy
ZWREaWRSZWNlaXZlUmVzcG9uc2UpOiBEZWxldGVkLiBNb3ZlZCBpdHMgaW1wbGVtZW50YXRpb24g
aW50bworICAgICAgICBOZXR3b3JrTG9hZDo6bm90aWZ5RGlkUmVjZWl2ZVJlc3BvbnNlKCkuCisg
ICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuaDoKKwogMjAxOC0wNC0wOSAgTWVn
YW4gR2FyZG5lciAgPG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFN3aXRjaCB0
byBVSVdLVGV4dEludGVyYWN0aW9uQXNzaXN0YW50IGZvciBub24tZWRpdGFibGUgdGV4dApkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5jcHAgYi9T
b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcAppbmRleCBhOTBmY2Zh
MzAwMTBmMzA4Zjg2MzdjOWI4OTJlMjUwNDEzMWQ3Yjk1Li40NzIwOTM4MDM2Y2UzMDFhZjM0ZDZl
MDhkMzVkOTM2M2ZkY2RjYjgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j
ZXNzL05ldHdvcmtMb2FkLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05l
dHdvcmtMb2FkLmNwcApAQCAtMTkxLDE1ICsxOTEsNiBAQCBib29sIE5ldHdvcmtMb2FkOjpzaG91
bGRDYXB0dXJlRXh0cmFOZXR3b3JrTG9hZE1ldHJpY3MoKSBjb25zdAogICAgIHJldHVybiBtX2Ns
aWVudC5nZXQoKS5zaG91bGRDYXB0dXJlRXh0cmFOZXR3b3JrTG9hZE1ldHJpY3MoKTsKIH0KIAot
TmV0d29ya0xvYWRDbGllbnQ6OlNob3VsZENvbnRpbnVlRGlkUmVjZWl2ZVJlc3BvbnNlIE5ldHdv
cmtMb2FkOjpzaGFyZWREaWRSZWNlaXZlUmVzcG9uc2UoUmVzb3VyY2VSZXNwb25zZSYmIHJlc3Bv
bnNlKQotewotICAgIHJlc3BvbnNlLnNldFNvdXJjZShSZXNvdXJjZVJlc3BvbnNlOjpTb3VyY2U6
Ok5ldHdvcmspOwotICAgIGlmIChtX3BhcmFtZXRlcnMubmVlZHNDZXJ0aWZpY2F0ZUluZm8pCi0g
ICAgICAgIHJlc3BvbnNlLmluY2x1ZGVDZXJ0aWZpY2F0ZUluZm8oKTsKLQotICAgIHJldHVybiBt
X2NsaWVudC5nZXQoKS5kaWRSZWNlaXZlUmVzcG9uc2UoV1RGTW92ZShyZXNwb25zZSkpOwotfQot
CiB2b2lkIE5ldHdvcmtMb2FkOjpzaGFyZWRXaWxsU2VuZFJlZGlyZWN0ZWRSZXF1ZXN0KFJlc291
cmNlUmVxdWVzdCYmIHJlcXVlc3QsIFJlc291cmNlUmVzcG9uc2UmJiByZWRpcmVjdFJlc3BvbnNl
KQogewogICAgIC8vIFdlIG9ubHkgZXhwZWN0IHRvIGdldCB0aGUgd2lsbFNlbmRSZXF1ZXN0IGNh
bGxiYWNrIGZyb20gUmVzb3VyY2VIYW5kbGUgYXMgdGhlIHJlc3VsdCBvZiBhIHJlZGlyZWN0LgpA
QCAtMzQzLDcgKzMzNCwxMSBAQCB2b2lkIE5ldHdvcmtMb2FkOjpub3RpZnlEaWRSZWNlaXZlUmVz
cG9uc2UoUmVzb3VyY2VSZXNwb25zZSYmIHJlc3BvbnNlLCBSZXNwb25zZQogICAgICAgICBtX3Jl
Y29yZGVyLT5yZWNvcmRSZXNwb25zZVJlY2VpdmVkKHJlc3BvbnNlKTsKICNlbmRpZgogCi0gICAg
aWYgKHNoYXJlZERpZFJlY2VpdmVSZXNwb25zZShXVEZNb3ZlKHJlc3BvbnNlKSkgPT0gTmV0d29y
a0xvYWRDbGllbnQ6OlNob3VsZENvbnRpbnVlRGlkUmVjZWl2ZVJlc3BvbnNlOjpObykgeworICAg
IHJlc3BvbnNlLnNldFNvdXJjZShSZXNvdXJjZVJlc3BvbnNlOjpTb3VyY2U6Ok5ldHdvcmspOwor
ICAgIGlmIChtX3BhcmFtZXRlcnMubmVlZHNDZXJ0aWZpY2F0ZUluZm8pCisgICAgICAgIHJlc3Bv
bnNlLmluY2x1ZGVDZXJ0aWZpY2F0ZUluZm8oKTsKKworICAgIGlmIChtX2NsaWVudC5nZXQoKS5k
aWRSZWNlaXZlUmVzcG9uc2UoV1RGTW92ZShyZXNwb25zZSkpID09IE5ldHdvcmtMb2FkQ2xpZW50
OjpTaG91bGRDb250aW51ZURpZFJlY2VpdmVSZXNwb25zZTo6Tm8pIHsKICAgICAgICAgbV9yZXNw
b25zZUNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcik7CiAgICAg
ICAgIHJldHVybjsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j
ZXNzL05ldHdvcmtMb2FkLmggYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtM
b2FkLmgKaW5kZXggYTY0ZTEwY2E4NTE0ZjFmMzUwM2NlNDUxMjU5N2RhZGFiMDc4YzU4MC4uMmNh
ZGQyNmIzNjQyNTY2MDdhZWU5MmE5MjY1NGNmMmYwMDkwMjk4ZCAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5oCisrKyBiL1NvdXJjZS9XZWJLaXQv
TmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuaApAQCAtNzksNyArNzksNiBAQCBwcml2YXRlOgog
I2VuZGlmCiAgICAgdm9pZCBpbml0aWFsaXplKE5ldHdvcmtTZXNzaW9uJik7CiAKLSAgICBOZXR3
b3JrTG9hZENsaWVudDo6U2hvdWxkQ29udGludWVEaWRSZWNlaXZlUmVzcG9uc2Ugc2hhcmVkRGlk
UmVjZWl2ZVJlc3BvbnNlKFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmJik7CiAgICAgdm9pZCBz
aGFyZWRXaWxsU2VuZFJlZGlyZWN0ZWRSZXF1ZXN0KFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYm
LCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJiYpOwogCiAgICAgLy8gTmV0d29ya0RhdGFUYXNr
Q2xpZW50Cg==
</data>
<flag name="review"
          id="356237"
          type_id="1"
          status="+"
          setter="achristensen"
    />
          </attachment>
      

    </bug>

</bugzilla>