184508 2018-04-11 10:22:42 -0700 Fix TestInvocation class for newer versions of clang 2018-04-11 13:38:29 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap commit-queue lforschler oldest_to_newest 1413731 0 jbedard 2018-04-11 10:22:42 -0700 Newer versions of clang raise a warning when compiling the TestInvocation class because it is not declared as final and does not have a virtual destructor. 1413732 1 337710 jbedard 2018-04-11 10:24:33 -0700 Created attachment 337710 Patch 1413781 2 ap 2018-04-11 12:54:01 -0700 rdar://problem/39328648 1413792 3 337727 jbedard 2018-04-11 13:19:30 -0700 Created attachment 337727 Patch for landing 1413801 4 337727 commit-queue 2018-04-11 13:38:28 -0700 Comment on attachment 337727 Patch for landing Clearing flags on attachment: 337727 Committed r230545: <https://trac.webkit.org/changeset/230545> 1413802 5 commit-queue 2018-04-11 13:38:29 -0700 All reviewed patches have been landed. Closing bug. 337710 2018-04-11 10:24:33 -0700 2018-04-11 13:19:28 -0700 Patch bug-184508-20180411102433.patch text/plain 1208 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMDUzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTA0LTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggVGVzdEludm9jYXRpb24gY2xhc3MgZm9yIG5ld2VyIHZlcnNpb25z IG9mIGNsYW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg0NTA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRGVjbGFyZSBUZXN0SW52b2NhdGlvbiB0byBiZSBmaW5hbCBzbyBpdCBkb2VzIG5vdCByZXF1 aXJlIGEgdmlydHVhbCBkZXN0cnVjdG9yLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9U ZXN0SW52b2NhdGlvbi5oOgorCiAyMDE4LTA0LTExICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNp ZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtFeHRyYSB6b29tIG1vZGVdIE1pc3NpbmcgbGFiZWwg d2hlbiBmb2N1c2luZyBhIDxzZWxlY3Q+IHdpdGggYSB0aXRsZSBhdHRyaWJ1dGUgYnV0IG5vIGFz c29jaWF0ZWQgPGxhYmVsPgpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2Nh dGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRp b24uaAkocmV2aXNpb24gMjMwNTI2KQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52 b2NhdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw3ICszNiw3IEBACiAKIG5hbWVzcGFjZSBX VFIgewogCi1jbGFzcyBUZXN0SW52b2NhdGlvbiA6IHB1YmxpYyBVSVNjcmlwdENvbnRleHREZWxl Z2F0ZSB7CitjbGFzcyBUZXN0SW52b2NhdGlvbiBmaW5hbCA6IHB1YmxpYyBVSVNjcmlwdENvbnRl eHREZWxlZ2F0ZSB7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoVGVzdEludm9jYXRpb24pOwog cHVibGljOgogICAgIGV4cGxpY2l0IFRlc3RJbnZvY2F0aW9uKFdLVVJMUmVmLCBjb25zdCBUZXN0 T3B0aW9ucyYpOwo= 337727 2018-04-11 13:19:30 -0700 2018-04-11 13:38:28 -0700 Patch for landing bug-184508-20180411131929.patch text/plain 1248 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMDUzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTA0LTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggVGVzdEludm9jYXRpb24gY2xhc3MgZm9yIG5ld2VyIHZlcnNpb25z IG9mIGNsYW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg0NTA4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTMyODY0OD4KKworICAgICAgICBS ZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgorCisgICAgICAgIERlY2xhcmUgVGVzdElu dm9jYXRpb24gdG8gYmUgZmluYWwgc28gaXQgZG9lcyBub3QgcmVxdWlyZSBhIHZpcnR1YWwgZGVz dHJ1Y3Rvci4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uaDoK KwogMjAxOC0wNC0xMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAog ICAgICAgICBbRXh0cmEgem9vbSBtb2RlXSBNaXNzaW5nIGxhYmVsIHdoZW4gZm9jdXNpbmcgYSA8 c2VsZWN0PiB3aXRoIGEgdGl0bGUgYXR0cmlidXRlIGJ1dCBubyBhc3NvY2lhdGVkIDxsYWJlbD4K SW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmgJKHJldmlzaW9uIDIz MDUyNikKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uaAkod29ya2lu ZyBjb3B5KQpAQCAtMzYsNyArMzYsNyBAQAogCiBuYW1lc3BhY2UgV1RSIHsKIAotY2xhc3MgVGVz dEludm9jYXRpb24gOiBwdWJsaWMgVUlTY3JpcHRDb250ZXh0RGVsZWdhdGUgeworY2xhc3MgVGVz dEludm9jYXRpb24gZmluYWwgOiBwdWJsaWMgVUlTY3JpcHRDb250ZXh0RGVsZWdhdGUgewogICAg IFdURl9NQUtFX05PTkNPUFlBQkxFKFRlc3RJbnZvY2F0aW9uKTsKIHB1YmxpYzoKICAgICBleHBs aWNpdCBUZXN0SW52b2NhdGlvbihXS1VSTFJlZiwgY29uc3QgVGVzdE9wdGlvbnMmKTsK