184483 2018-04-10 20:23:34 -0700 Don't have selections get stuck in editable elements 2018-04-12 11:50:40 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner aestes bdakin commit-queue sam timothy wenson_hsieh oldest_to_newest 1413538 0 megan_gardner 2018-04-10 20:23:34 -0700 Don't have selections get stuck in editable elements 1413541 1 337671 megan_gardner 2018-04-10 20:27:09 -0700 Created attachment 337671 Patch 1413542 2 megan_gardner 2018-04-10 20:27:43 -0700 <rdar://problem/35189283> 1413583 3 sam 2018-04-10 22:27:11 -0700 Is this something that can be tested? 1413673 4 337671 timothy 2018-04-11 07:40:59 -0700 Comment on attachment 337671 Patch Same comment as Sam. Maybe testing can be done with an API test? 1413795 5 sam 2018-04-11 13:27:02 -0700 Or a new test type that dumps selection state/info? 1414101 6 megan_gardner 2018-04-12 11:23:57 -0700 The selection tests don't seem to be working right in content editable. I will investigate this soon and add some tests later. 1414118 7 337671 commit-queue 2018-04-12 11:50:38 -0700 Comment on attachment 337671 Patch Clearing flags on attachment: 337671 Committed r230588: <https://trac.webkit.org/changeset/230588> 1414119 8 commit-queue 2018-04-12 11:50:40 -0700 All reviewed patches have been landed. Closing bug. 337671 2018-04-10 20:27:09 -0700 2018-04-12 11:50:38 -0700 Patch bug-184483-20180410202708.patch text/plain 1987 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzA1MTIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA0LTEwICBNZWdhbiBHYXJk bmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgaGF2ZSBzZWxl Y3Rpb25zIGdldCBzdHVjayBpbiBlZGl0YWJsZSBlbGVtZW50cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0NDgzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBXaGVuIHNlbGVjdGluZyBpbiBl ZGl0YWJsZSBlbGVtZW50cywgaWYgdGhlIGtleWJvYXJkIGRvZXMgbm90IGNvbWUgdXAsIHdoaWNo IGlzIG5vdCByZXF1aXJlZCwKKyAgICAgICAgdGhlbiB0aGUgc2VsZWN0aW9ucyBhcmUgc3R1Y2sg aW4gdGhhdCBlbGVtZW50LiBJZiB5b3UgdHJ5IGFuZCBzZWxlY3Qgc29tZXRoaW5nIGluIHdlYiBj b250ZW50LAorICAgICAgICBpdCB3aWxsIG9ubHkgc2VsZWN0IGluIHRoZSBlZGl0YWJsZSBlbGVt ZW50LiBCeSBjbGVhcmluZyB0aGUgYXNzaXN0ZWQgbm9kZSB3aGVuIGNsZWFyaW5nIGEgc2VsZWN0 aW9uLAorICAgICAgICBpdCBubyBsb25nZXIgc3RpY2tzLiBBbHNvLCB0ZXh0U2VsZWN0aW9uQXNz aXN0YW50IHNob3VsZCBub3QgYmUgdXNlZCBhcyBpZiB3ZSBhcmUgY3VycmVudGx5IGVkaXRpbmcu IAorICAgICAgICBDaGFuZ2UgaXQgdG8gdGhlIGZ1bmN0aW9uIHdlIGNyZWF0ZWQgZm9yIHRoYXQg cHVycG9zZSBpbiBhIHBlcnZpb3VzIHBhdGNoLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgY2xl YXJTZWxlY3Rpb25dKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfaXNJbnRlcmFjdGluZ1dp dGhBc3Npc3RlZE5vZGVdKToKKwogMjAxOC0wNC0xMCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFt QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGZvbGxvdy11cCB0byByMjMwNDY4LgpJ bmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tCShyZXZpc2lvbiAyMzA1MTIpCisrKyBTb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBA IC0xOTE3LDYgKzE5MTcsNyBAQCAtICh2b2lkKXVzZVNlbGVjdGlvbkFzc2lzdGFudFdpdGhHcmFu dWxhCiAKIC0gKHZvaWQpY2xlYXJTZWxlY3Rpb24KIHsKKyAgICBbc2VsZiBfc3RvcEFzc2lzdGlu Z05vZGVdOwogICAgIF9wYWdlLT5jbGVhclNlbGVjdGlvbigpOwogfQogCkBAIC0yNjk0LDcgKzI2 OTUsNyBAQCBzdGF0aWMgdm9pZCBzZWxlY3Rpb25DaGFuZ2VkV2l0aFRvdWNoKFdLCiAKIC0gKEJP T0wpX2lzSW50ZXJhY3RpbmdXaXRoQXNzaXN0ZWROb2RlCiB7Ci0gICAgcmV0dXJuIF90ZXh0U2Vs ZWN0aW9uQXNzaXN0YW50ICE9IG5pbDsKKyAgICByZXR1cm4gaGFzQXNzaXN0ZWROb2RlKF9hc3Np c3RlZE5vZGVJbmZvcm1hdGlvbik7CiB9CiAKIC0gKHZvaWQpY2hhbmdlU2VsZWN0aW9uV2l0aEdl c3R1cmVBdDooQ0dQb2ludClwb2ludCB3aXRoR2VzdHVyZTooVUlXS0dlc3R1cmVUeXBlKWdlc3R1 cmVUeXBlIHdpdGhTdGF0ZTooVUlHZXN0dXJlUmVjb2duaXplclN0YXRlKXN0YXRlCg==