18447 2008-04-12 15:54:02 -0700 Setting of CSSStyleDeclaration.prototype.foo on outer window affects prototype of inner window 2011-01-18 22:01:08 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 525.x (Safari 3.1) All All RESOLVED FIXED P2 Normal --- 1 ovafai koz abarth ap commit-queue ian.eng.webkit noel.gordon ojan sam oldest_to_newest 77362 0 ovafai 2008-04-12 15:54:02 -0700 That summary isn't the most clear. Will attach a test case. In short, if I set a prototype property in an outer window and then grab an object from that type from a frame, that property shouldn't be set on the object from the frame. This is how Firefox and Opera work. 77363 1 20495 ovafai 2008-04-12 15:54:57 -0700 Created attachment 20495 Shows that CSSStyleDeclaration and String behave differently. 276127 2 ap 2010-09-08 15:45:05 -0700 This no longer occurs in Safari 5.0.1. Not sure if we need to land a test for this. 276982 3 ojan 2010-09-09 20:24:53 -0700 Ugh, didn't mean to close the bug. Probably worth committing a test for this. 278572 4 67488 koz 2010-09-13 16:46:53 -0700 Created attachment 67488 Patch 278573 5 67488 abarth 2010-09-13 16:48:36 -0700 Comment on attachment 67488 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67488&action=prettypatch > LayoutTests/fast/frames/frame-prototype-inheritance.html:11 > + // alert(win.CSSStyleDeclaration.prototype.foo); Please remove commented out code. 278625 6 67502 koz 2010-09-13 18:28:04 -0700 Created attachment 67502 Patch 278630 7 67502 ojan 2010-09-13 18:33:01 -0700 Comment on attachment 67502 Patch Did you mean to set cq? 279182 8 67502 commit-queue 2010-09-14 14:42:02 -0700 Comment on attachment 67502 Patch Rejecting patch 67502 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20991 test cases. fast/css/visited-link-hang.html -> failed Exiting early after 1 failures. 6198 tests run. 131.28s total testing time 6197 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/4059011 279191 9 abarth 2010-09-14 14:53:32 -0700 > Rejecting patch 67502 from commit-queue. We just change some core logic in the commit-queue. Not sure if we have a bug now. 279241 10 67502 commit-queue 2010-09-14 16:15:52 -0700 Comment on attachment 67502 Patch Clearing flags on attachment: 67502 Committed r67511: <http://trac.webkit.org/changeset/67511> 279242 11 commit-queue 2010-09-14 16:15:58 -0700 All reviewed patches have been landed. Closing bug. 20495 2008-04-12 15:54:57 -0700 2008-04-12 15:54:57 -0700 Shows that CSSStyleDeclaration and String behave differently. prototype.html text/html 507 ovafai 77u/PEhUTUw+ICAKPGJvZHk+IAoKV2ViS2l0IGluY29ycmVjdGx5IGFsZXJ0cyAiZm9vIiBoZXJl IGZvciB0aGUgZmlyc3QgYWxlcnQgYW5kIHVuZGVmaW5lZCBmb3IgdGhlIHNlY29uZC4gRmlyZWZv eC9PcGVyYSBhbGVydCB1bmRlZmluZWQgZm9yIGJvdGguIElFIGRvZXNuJ3QgbGV0IHlvdSBzZXQg dGhlc2UuCgo8aWZyYW1lIGlkPSJpZnIiPjwvaWZyYW1lPgoKPHNjcmlwdD4KQ1NTU3R5bGVEZWNs YXJhdGlvbi5wcm90b3R5cGUuZm9vID0gImZvbyI7CnZhciB3aW4gPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgnaWZyJykuY29udGVudFdpbmRvdzsKYWxlcnQod2luLkNTU1N0eWxlRGVjbGFyYXRp b24ucHJvdG90eXBlLmZvbyk7CgpTdHJpbmcucHJvdG90eXBlLmZvbyA9ICJmb28iOwp2YXIgd2lu ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lmcicpLmNvbnRlbnRXaW5kb3c7CmFsZXJ0KHdp bi5TdHJpbmcucHJvdG90eXBlLmZvbyk7Cjwvc2NyaXB0Pgo8L2JvZHk+CjwvSFRNTD4g 67488 2010-09-13 16:46:53 -0700 2010-09-13 18:27:58 -0700 Patch bug-18447-20100914094650.patch text/plain 2007 koz ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmOTE3ZTFmNjI5OWM4NzBhYTgwY2NlOTBkYzJkMzVmYWVkMmJiMDhlLi42MjMwNThl NWY4NWU3Nzg2OWU0ZmE0OGY5MjYzZjQwZjU3YjVmNGEwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMDktMTMgIEphbWVzIEtvemlhbnNraSAgPHNvdWxwbGFudEBnbWFpbC5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0dGluZyBvZiBD U1NTdHlsZURlY2xhcmF0aW9uLnByb3RvdHlwZS5mb28gb24gb3V0ZXIgd2luZG93IGFmZmVjdHMg cHJvdG90eXBlIG9mIGlubmVyIHdpbmRvdworCisgICAgICAgIEFkZCBhIHRlc3QgZm9yIENTU1N0 eWxlRGVjbGFyYXRpb24ucHJvdG90eXBlLmZvbyBsZWFraW5nIGludG8gaW5uZXIKKyAgICAgICAg d2luZG93cy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg0NDcKKworICAgICAgICAqIGZhc3QvZnJhbWVzL2ZyYW1lLXByb3RvdHlwZS1pbmhlcml0 YW5jZS1leHBlY3RlZC50eHQ6IENvcGllZCBmcm9tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2Vj dXJpdHkvaXNvbGF0ZWRXb3JsZC9ib2R5LXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0LgorICAgICAg ICAqIGZhc3QvZnJhbWVzL2ZyYW1lLXByb3RvdHlwZS1pbmhlcml0YW5jZS5odG1sOiBBZGRlZC4K KwogMjAxMC0wOS0xMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9m cmFtZXMvZnJhbWUtcHJvdG90eXBlLWluaGVyaXRhbmNlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLXByb3RvdHlwZS1pbmhlcml0YW5jZS1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uNDE3YjdiNTM3MGRmODFhNzMxNmVlOWY5ODM0Mzc0NDRhZmRhZTQzMgotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLXByb3RvdHlwZS1p bmhlcml0YW5jZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAordW5kZWZpbmVkCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9mcmFtZS1wcm90b3R5cGUtaW5oZXJpdGFuY2Uu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLXByb3RvdHlwZS1pbmhlcml0YW5j ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjgxNzRkZjc5NGIzYWI3MmI2OTVlNDdjZTIyYzQ5NTYzZTJjOTg5 OTkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9mcmFtZS1wcm90 b3R5cGUtaW5oZXJpdGFuY2UuaHRtbApAQCAtMCwwICsxLDE0IEBACis8Ym9keT4KKyAgPGlmcmFt ZSBpZD0iaWZyIj48L2lmcmFtZT4KKyAgPGRpdiBpZD0icmVzdWx0Ij48L2Rpdj4KKyAgPHNjcmlw dD4KKyAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgCisgIENTU1N0eWxlRGVjbGFyYXRpb24ucHJvdG90 eXBlLmZvbyA9ICJmb28iOworICB2YXIgd2luID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lm cicpLmNvbnRlbnRXaW5kb3c7CisgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQnKS5p bm5lclRleHQgPSB3aW4uQ1NTU3R5bGVEZWNsYXJhdGlvbi5wcm90b3R5cGUuZm9vOworICAvLyBh bGVydCh3aW4uQ1NTU3R5bGVEZWNsYXJhdGlvbi5wcm90b3R5cGUuZm9vKTsKKworICA8L3Njcmlw dD4KKzwvYm9keT4K 67502 2010-09-13 18:28:04 -0700 2010-09-14 16:15:52 -0700 Patch bug-18447-20100914112802.patch text/plain 2256 koz ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmOTE3ZTFmNjI5OWM4NzBhYTgwY2NlOTBkYzJkMzVmYWVkMmJiMDhlLi5hYTIwM2U3 NDZiNzhkNzUwNzM3OWZjZDBiNmI3ZDM3ZDJkYjE1NmVkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDktMTMgIEphbWVzIEtvemlhbnNraSAgPHNvdWxwbGFudEBnbWFpbC5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0dGluZyBvZiBD U1NTdHlsZURlY2xhcmF0aW9uLnByb3RvdHlwZS5mb28gb24gb3V0ZXIgd2luZG93IGFmZmVjdHMg cHJvdG90eXBlIG9mIGlubmVyIHdpbmRvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg0NDcKKworICAgICAgICBBZGQgYSB0ZXN0IGZvciBDU1NTdHls ZURlY2xhcmF0aW9uLnByb3RvdHlwZS5mb28gbGVha2luZyBpbnRvIGlubmVyCisgICAgICAgIHdp bmRvd3MuCisKKyAgICAgICAgKiBmYXN0L2ZyYW1lcy9jc3Mtc3R5bGUtZGVjbGFyYXRpb24taXNv bGF0aW9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mcmFtZXMvY3NzLXN0 eWxlLWRlY2xhcmF0aW9uLWlzb2xhdGlvbi5odG1sOiBBZGRlZC4KKwogMjAxMC0wOS0xMiAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMg U2VpZGVsLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvY3NzLXN0eWxlLWRl Y2xhcmF0aW9uLWlzb2xhdGlvbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1l cy9jc3Mtc3R5bGUtZGVjbGFyYXRpb24taXNvbGF0aW9uLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li41ZWE3MzcyYjI4MGFmNmEwYzgxMzhlNjgxMmRhZGUxYjU5YmI5MWQ3Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvY3NzLXN0eWxlLWRlY2xhcmF0aW9uLWlzb2xh dGlvbi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyIEBACisgVGhpcyB0ZXN0cyB0aGF0IG1vZGlm aWNhdGlvbnMgdG8gdGhlIHByb3RvdHlwZSBvZiBDU1NTdHlsZURlY2xhcmF0aW9uIGRvbid0IG1v ZGlmeSBpdHMgcHJvdG90eXBlIGluIGFub3RoZXIgZG9jdW1lbnQuCitQQVNTCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9jc3Mtc3R5bGUtZGVjbGFyYXRpb24taXNvbGF0aW9u Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9jc3Mtc3R5bGUtZGVjbGFyYXRpb24taXNv bGF0aW9uLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNmI5OTI0ZGQ0ODFlNzY4MGNjYTM1OWI4MmVmY2MxNmEy NmQwNGFjMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2Nzcy1z dHlsZS1kZWNsYXJhdGlvbi1pc29sYXRpb24uaHRtbApAQCAtMCwwICsxLDE3IEBACis8aWZyYW1l IGlkPSJpZnIiPjwvaWZyYW1lPgorICBUaGlzIHRlc3RzIHRoYXQgbW9kaWZpY2F0aW9ucyB0byB0 aGUgcHJvdG90eXBlIG9mIENTU1N0eWxlRGVjbGFyYXRpb24gZG9uJ3QKKyAgbW9kaWZ5IGl0cyBw cm90b3R5cGUgaW4gYW5vdGhlciBkb2N1bWVudC4KKzxkaXYgaWQ9InJlc3VsdCI+PC9kaXY+CisK KzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRl c3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworQ1NTU3R5bGVEZWNsYXJhdGlvbi5wcm90b3R5 cGUuZm9vID0gImZvbyI7Cit2YXIgd2luID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lmcicp LmNvbnRlbnRXaW5kb3c7Cit2YXIgcmVzdWx0ID0gd2luLkNTU1N0eWxlRGVjbGFyYXRpb24ucHJv dG90eXBlLmZvbzsKK2lmIChyZXN1bHQpCisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Jl c3VsdCcpLmlubmVyVGV4dCA9ICJGQUlMOiBleHBlY3RlZCAndW5kZWZpbmVkJywgZ290ICciICsg cmVzdWx0ICsgIiciOworZWxzZQorICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQn KS5pbm5lclRleHQgPSAnUEFTUyc7Cis8L3NjcmlwdD4K