184451 2018-04-10 09:10:11 -0700 Deactivate the WindowServer connection for the WebContent process. 2018-09-27 15:09:47 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 184633 184484 190056 1 pvollan pvollan benjamin bfulgham cdumez cmarcelo commit-queue darin dbates ews-watchlist sabouhallawa simon.fraser thorton webkit-bug-importer oldest_to_newest 1413279 0 pvollan 2018-04-10 09:10:11 -0700 Defining ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING as 1 will deactivate the WindowServer connection for the WebContent process. 1413280 1 pvollan 2018-04-10 09:10:45 -0700 <rdar://problem/38313938> 1413284 2 337612 pvollan 2018-04-10 09:17:33 -0700 Created attachment 337612 Patch 1413561 3 337612 bfulgham 2018-04-10 21:24:58 -0700 Comment on attachment 337612 Patch r=me, but don't land until the build bots are ready. 1413662 4 337612 pvollan 2018-04-11 07:02:54 -0700 Comment on attachment 337612 Patch Thanks for reviewing! 1413668 5 337612 commit-queue 2018-04-11 07:29:45 -0700 Comment on attachment 337612 Patch Clearing flags on attachment: 337612 Committed r230523: <https://trac.webkit.org/changeset/230523> 1413669 6 commit-queue 2018-04-11 07:29:46 -0700 All reviewed patches have been landed. Closing bug. 1413884 7 sabouhallawa 2018-04-11 18:09:17 -0700 Reverted r230523 for reason: Introduced MotionMark regression Committed r230552: <https://trac.webkit.org/changeset/230552> 1414641 8 337612 pvollan 2018-04-14 10:13:55 -0700 Comment on attachment 337612 Patch I am not able to reproduce the MotionMark regression now. 1414642 9 337612 commit-queue 2018-04-14 10:15:13 -0700 Comment on attachment 337612 Patch Rejecting attachment 337612 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 337612, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WTF/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/7316375 1414643 10 337960 pvollan 2018-04-14 10:19:39 -0700 Created attachment 337960 Patch 1414644 11 337960 commit-queue 2018-04-14 10:57:58 -0700 Comment on attachment 337960 Patch Clearing flags on attachment: 337960 Committed r230659: <https://trac.webkit.org/changeset/230659> 1414645 12 commit-queue 2018-04-14 10:58:00 -0700 All reviewed patches have been landed. Closing bug. 1414667 13 commit-queue 2018-04-14 18:40:16 -0700 Re-opened since this is blocked by bug 184633 1414669 14 ap 2018-04-14 18:41:10 -0700 > r=me, but don't land until the build bots are ready. What Brent said. Rolling back now. 1414855 15 bfulgham 2018-04-16 12:00:55 -0700 (In reply to Alexey Proskuryakov from comment #14) > > r=me, but don't land until the build bots are ready. > > What Brent said. Rolling back now. This should be okay to land now. The performance bots are now running the fixed QuartzCore, so this should be safe. 1414856 16 bfulgham 2018-04-16 12:01:35 -0700 (In reply to Brent Fulgham from comment #15) > (In reply to Alexey Proskuryakov from comment #14) > > > r=me, but don't land until the build bots are ready. > > > > What Brent said. Rolling back now. > > This should be okay to land now. The performance bots are now running the > fixed QuartzCore, so this should be safe. ... and this does not introduce any build or test correctness issues. 1414863 17 337960 commit-queue 2018-04-16 12:20:22 -0700 Comment on attachment 337960 Patch Clearing flags on attachment: 337960 Committed r230677: <https://trac.webkit.org/changeset/230677> 1414864 18 commit-queue 2018-04-16 12:20:24 -0700 All reviewed patches have been landed. Closing bug. 1414974 19 337960 darin 2018-04-16 17:50:44 -0700 Comment on attachment 337960 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337960&action=review > Source/WTF/wtf/FeatureDefines.h:241 > +#define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 Are you sure this pattern works? I seem to recall that this form does not work correctly. I think it needs to be more like: #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 #define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING 1 #else #define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING 0 #endif 1414989 20 pvollan 2018-04-16 18:44:09 -0700 (In reply to Darin Adler from comment #19) > Comment on attachment 337960 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337960&action=review > > > Source/WTF/wtf/FeatureDefines.h:241 > > +#define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 > > Are you sure this pattern works? I seem to recall that this form does not > work correctly. I think it needs to be more like: > > #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 > #define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING 1 > #else > #define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING 0 > #endif I believe it works since I have tested this by building for several macOS versions. However, I will double-check. 1416003 21 pvollan 2018-04-19 11:28:09 -0700 Reverted r230677 for reason: Introduced Netflix problems. Committed r230811: <https://trac.webkit.org/changeset/230811> 1416998 22 337960 commit-queue 2018-04-23 15:41:40 -0700 Comment on attachment 337960 Patch Clearing flags on attachment: 337960 Committed r230930: <https://trac.webkit.org/changeset/230930> 1416999 23 commit-queue 2018-04-23 15:41:42 -0700 All reviewed patches have been landed. Closing bug. 337612 2018-04-10 09:17:33 -0700 2018-04-14 10:15:13 -0700 Patch bug-184451-20180410091731.patch text/plain 1542 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzA0ODApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA0LTEwICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBEZWFjdGl2YXRlIHRoZSBXaW5kb3dTZXJ2ZXIg Y29ubmVjdGlvbiBmb3IgdGhlIFdlYkNvbnRlbnQgcHJvY2Vzcy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDQ1MQorICAgICAgICA8cmRhcjovL3By b2JsZW0vMzgzMTM5Mzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRGVmaW5pbmcgRU5BQkxFX1dFQlBST0NFU1NfV0lORE9XU0VSVkVSX0JMT0NLSU5H IGFzIDEgd2lsbCBkZWFjdGl2YXRlIHRoZSBXaW5kb3dTZXJ2ZXIgY29ubmVjdGlvbgorICAgICAg ICBmb3IgdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyBieSBlbmFibGluZyB0aGUgY2FsbCB0byAnQ0dT U2V0RGVueVdpbmRvd1NlcnZlckNvbm5lY3Rpb25zKHRydWUpJyBvbgorICAgICAgICBwcm9jZXNz IHN0YXJ0dXAuIEFmdGVyIGNhbGxpbmcgdGhpcyBmdW5jdGlvbiwgZXZlcnkgYXR0ZW1wdCB0byBl c3RhYmxpc2ggYSBjb25uZWN0aW9uIHRvIHRoZQorICAgICAgICBXaW5kb3dTZXJ2ZXIgZnJvbSB0 aGUgV2ViQ29udGVudCBwcm9jZXNzIHdpbGwgZmFpbCwgZXhjZXB0IGZvciBDQSByZW5kZXIgc2Vy dmVyIGNvbm5lY3Rpb25zLgorCisgICAgICAgICogd3RmL0ZlYXR1cmVEZWZpbmVzLmg6CisKIDIw MTgtMDQtMDkgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIERlY29y YXRlIG1ldGhvZCB0YWJsZSBlbnRyaWVzIHRvIHN1cHBvcnQgcG9pbnRlciBwcm9maWxpbmcuCklu ZGV4OiBTb3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgJKHJldmlzaW9uIDIzMDQ3OSkKKysrIFNvdXJjZS9X VEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTIzMiw3ICsyMzIsNyBA QCB0aGUgcHVibGljIGlPUyBTREsuIFNlZSA8aHR0cHM6Ly93ZWJraXQuCiAjZW5kaWYKIAogI2lm ICFkZWZpbmVkKEVOQUJMRV9XRUJQUk9DRVNTX1dJTkRPV1NFUlZFUl9CTE9DS0lORykKLSNkZWZp bmUgRU5BQkxFX1dFQlBST0NFU1NfV0lORE9XU0VSVkVSX0JMT0NLSU5HIDAKKyNkZWZpbmUgRU5B QkxFX1dFQlBST0NFU1NfV0lORE9XU0VSVkVSX0JMT0NLSU5HIF9fTUFDX09TX1hfVkVSU0lPTl9N SU5fUkVRVUlSRUQgPj0gMTAxNDAwCiAjZW5kaWYKIAogI2VuZGlmIC8qIFBMQVRGT1JNKE1BQykg Ki8K 337960 2018-04-14 10:19:39 -0700 2018-04-23 15:41:40 -0700 Patch bug-184451-20180414101938.patch text/plain 1577 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzA2NTgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA0LTE0ICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBEZWFjdGl2YXRlIHRoZSBXaW5kb3dTZXJ2ZXIg Y29ubmVjdGlvbiBmb3IgdGhlIFdlYkNvbnRlbnQgcHJvY2Vzcy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDQ1MQorICAgICAgICA8cmRhcjovL3By b2JsZW0vMzgzMTM5Mzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQnJlbnQgRnVsZ2hhbS4KKwor ICAgICAgICBEZWZpbmluZyBFTkFCTEVfV0VCUFJPQ0VTU19XSU5ET1dTRVJWRVJfQkxPQ0tJTkcg YXMgMSB3aWxsIGRlYWN0aXZhdGUgdGhlIFdpbmRvd1NlcnZlciBjb25uZWN0aW9uCisgICAgICAg IGZvciB0aGUgV2ViQ29udGVudCBwcm9jZXNzIGJ5IGVuYWJsaW5nIHRoZSBjYWxsIHRvICdDR1NT ZXREZW55V2luZG93U2VydmVyQ29ubmVjdGlvbnModHJ1ZSknIG9uCisgICAgICAgIHByb2Nlc3Mg c3RhcnR1cC4gQWZ0ZXIgY2FsbGluZyB0aGlzIGZ1bmN0aW9uLCBldmVyeSBhdHRlbXB0IHRvIGVz dGFibGlzaCBhIGNvbm5lY3Rpb24gdG8gdGhlCisgICAgICAgIFdpbmRvd1NlcnZlciBmcm9tIHRo ZSBXZWJDb250ZW50IHByb2Nlc3Mgd2lsbCBmYWlsLCBleGNlcHQgZm9yIENBIHJlbmRlciBzZXJ2 ZXIgY29ubmVjdGlvbnMuCisKKyAgICAgICAgKiB3dGYvRmVhdHVyZURlZmluZXMuaDoKKwogMjAx OC0wNC0xMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFNwbGl0 IFdpbmRvd1Byb3h5IGhhbmRsaW5nIG91dCBvZiBTY3JpcHRDb250cm9sbGVyIGFuZCBpbnRvIGEg bmV3IGNsYXNzIG93bmVkIGJ5IEFic3RyYWN0RnJhbWUKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0Zl YXR1cmVEZWZpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvRmVhdHVyZURlZmlu ZXMuaAkocmV2aXNpb24gMjMwNjU4KQorKysgU291cmNlL1dURi93dGYvRmVhdHVyZURlZmluZXMu aAkod29ya2luZyBjb3B5KQpAQCAtMjM4LDcgKzIzOCw3IEBAIHRoZSBwdWJsaWMgaU9TIFNESy4g U2VlIDxodHRwczovL3dlYmtpdC4KICNlbmRpZgogCiAjaWYgIWRlZmluZWQoRU5BQkxFX1dFQlBS T0NFU1NfV0lORE9XU0VSVkVSX0JMT0NLSU5HKQotI2RlZmluZSBFTkFCTEVfV0VCUFJPQ0VTU19X SU5ET1dTRVJWRVJfQkxPQ0tJTkcgMAorI2RlZmluZSBFTkFCTEVfV0VCUFJPQ0VTU19XSU5ET1dT RVJWRVJfQkxPQ0tJTkcgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDAK ICNlbmRpZgogCiAjZW5kaWYgLyogUExBVEZPUk0oTUFDKSAqLwo=