184423 2018-04-09 11:55:08 -0700 Fix the selection assistant selectionView build 2018-04-09 12:58:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble bdakin commit-queue megan_gardner webkit-bug-importer wenson_hsieh oldest_to_newest 1412942 0 jer.noble 2018-04-09 11:55:08 -0700 Fix the selection assistant selectionView build 1412943 1 webkit-bug-importer 2018-04-09 11:55:56 -0700 <rdar://problem/39288235> 1412944 2 337516 jer.noble 2018-04-09 11:58:11 -0700 Created attachment 337516 Patch 1412953 3 337516 wenson_hsieh 2018-04-09 12:07:37 -0700 Comment on attachment 337516 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337516&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4498 > [[_webSelectionAssistant selectionView] setHidden:NO]; You might want to consider guarding the declaration of the selectionView property in UIKitSPI.h with ENABLE(MINIMAL_SIMULATOR) as well. 1412955 4 jer.noble 2018-04-09 12:10:27 -0700 (In reply to Wenson Hsieh from comment #3) > Comment on attachment 337516 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337516&action=review > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4498 > > [[_webSelectionAssistant selectionView] setHidden:NO]; > > You might want to consider guarding the declaration of the selectionView > property in UIKitSPI.h with ENABLE(MINIMAL_SIMULATOR) as well. Will do. 1412958 5 337522 jer.noble 2018-04-09 12:18:28 -0700 Created attachment 337522 Patch for landing 1412983 6 337522 commit-queue 2018-04-09 12:58:22 -0700 Comment on attachment 337522 Patch for landing Clearing flags on attachment: 337522 Committed r230448: <https://trac.webkit.org/changeset/230448> 1412984 7 commit-queue 2018-04-09 12:58:23 -0700 All reviewed patches have been landed. Closing bug. 337516 2018-04-09 11:58:11 -0700 2018-04-09 12:18:26 -0700 Patch bug-184423-20180409115810.patch text/plain 2430 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVhMWVlY2NhNmRmYzMzZWMw NTliZDA1YjZmMWE2ZGZjZjgzOWM3YTIuLjU3ZDU0YzhlYThlNjUzOWJmZWUzMTYwY2VlYjJkZTNh NjIzNmJjZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDQtMDkgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHRoZSBzZWxlY3Rpb24gYXNz aXN0YW50IHNlbGVjdGlvblZpZXcgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4NDQyMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzkyODgy MzU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcg X2RpZEV4aXRTdGFibGVTdGF0ZV0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF91cGRhdGVDaGFu Z2VkU2VsZWN0aW9uOl0pOgorCiAyMDE4LTA0LTA5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh bnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBtb3ZlICd1c2luZyBuYW1l c3BhY2UnIGJhY2sgdG8gdGhlIHJpZ2h0IHBsYWNlIGFmdGVyIHIyMzA0MjkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0KaW5kZXggZTkxZWI5YjMwYmZjMmI2 NDdkMDg0NmJlYmRmMzE5MzMzYjU3NjdjMC4uMGZhMDc4ODFkY2MyMmIyMDljZDIzMGEzZjI0MmUy YWM1N2EzNTg0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXcubW0KQEAgLTM0OCw3ICszNDgsOSBAQCAtICh2b2lkKV9kaWRFeGl0U3RhYmxlU3RhdGUKICAg ICAgICAgcmV0dXJuOwogCiAgICAgW190ZXh0U2VsZWN0aW9uQXNzaXN0YW50IGRlYWN0aXZhdGVT ZWxlY3Rpb25dOworI2lmICFFTkFCTEUoTUlOSU1BTF9TSU1VTEFUT1IpCiAgICAgW1tfd2ViU2Vs ZWN0aW9uQXNzaXN0YW50IHNlbGVjdGlvblZpZXddIHNldEhpZGRlbjpZRVNdOworI2VuZGlmCiB9 CiAKIC0gKENHUmVjdClfY29tcHV0ZVVub2JzY3VyZWRDb250ZW50UmVjdFJlc3BlY3RpbmdJbnB1 dFZpZXdCb3VuZHM6KENHUmVjdCl1bm9ic2N1cmVkQ29udGVudFJlY3QgaW5wdXRWaWV3Qm91bmRz OihDR1JlY3QpaW5wdXRWaWV3Qm91bmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCBmZGNmODAxZWMxMGFi MWUzNWMzNTk2MWZkNDA1NjA3YzU0ZTFhZjAxLi45YTdmNzhkMDQ4YzliNDJjZTZjYmYyYzMzNTFk ZjcwMmE5NmViMTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTQ0OTQsNyArNDQ5NCw5IEBAIC0gKHZv aWQpX3VwZGF0ZUNoYW5nZWRTZWxlY3Rpb246KEJPT0wpZm9yY2UKICAgICBpZiAoIXN0YXRlLmlz TWlzc2luZ1Bvc3RMYXlvdXREYXRhICYmIHN0YXRlLnBvc3RMYXlvdXREYXRhKCkuaXNTdGFibGVT dGF0ZVVwZGF0ZSAmJiBfbmVlZHNEZWZlcnJlZEVuZFNjcm9sbGluZ1NlbGVjdGlvblVwZGF0ZSAm JiBfcGFnZS0+aW5TdGFibGVTdGF0ZSgpKSB7CiAgICAgICAgIFtbc2VsZiBzZWxlY3Rpb25JbnRl cmFjdGlvbkFzc2lzdGFudF0gc2hvd1NlbGVjdGlvbkNvbW1hbmRzXTsKICAgICAgICAgW193ZWJT ZWxlY3Rpb25Bc3Npc3RhbnQgZGlkRW5kU2Nyb2xsaW5nT3Jab29taW5nUGFnZV07CisjaWYgIUVO QUJMRShNSU5JTUFMX1NJTVVMQVRPUikKICAgICAgICAgW1tfd2ViU2VsZWN0aW9uQXNzaXN0YW50 IHNlbGVjdGlvblZpZXddIHNldEhpZGRlbjpOT107CisjZW5kaWYKIAogICAgICAgICBpZiAoIXNl bGYuc3VwcHJlc3NBc3Npc3RhbnRTZWxlY3Rpb25WaWV3KQogICAgICAgICAgICAgW190ZXh0U2Vs ZWN0aW9uQXNzaXN0YW50IGFjdGl2YXRlU2VsZWN0aW9uXTsK 337522 2018-04-09 12:18:28 -0700 2018-04-09 12:58:22 -0700 Patch for landing bug-184423-20180409121827.patch text/plain 3116 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVhMWVlY2NhNmRmYzMzZWMw NTliZDA1YjZmMWE2ZGZjZjgzOWM3YTIuLmNkNTQ3MDI4YjQ0ZWRhMjJhM2FkYmQ0NzMxZmUxN2Q1 MGYwYzZjYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDQtMDkgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHRoZSBzZWxlY3Rpb24gYXNz aXN0YW50IHNlbGVjdGlvblZpZXcgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4NDQyMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzkyODgy MzU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgV2Vuc29uIEhzaWVoLgorCisgICAgICAgICogUGxh dGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlldy5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfZGlkRXhpdFN0YWJsZVN0YXRl XSk6CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06 CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX3VwZGF0ZUNoYW5nZWRTZWxlY3Rpb246XSk6CisK IDIwMTgtMDQtMDkgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIG1vdmUgJ3VzaW5nIG5hbWVzcGFjZScgYmFjayB0byB0aGUg cmlnaHQgcGxhY2UgYWZ0ZXIgcjIzMDQyOQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0 Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3Mv VUlLaXRTUEkuaAppbmRleCAyZGZhNzMyYzUxM2M4YWViOGM4ZmI1YTNlMDljOWE0MjkxMjNkYzI2 Li5kNTE2YmRlZDVlOTMxZjcyMzUwMTg0N2YyNmNiZTNiZmI5ZTFjODY5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaApAQCAtNDk3LDcgKzQ5Nyw5IEBAIHR5cGVk ZWYgTlNfRU5VTSAoTlNJbnRlZ2VyLCBfVUlCYWNrZHJvcE1hc2tWaWV3RmxhZ3MpIHsKIC0gKHZv aWQpc2V0R2VzdHVyZVJlY29nbml6ZXJzOwogLSAodm9pZCl3aWxsU3RhcnRTY3JvbGxpbmdPclpv b21pbmdQYWdlOwogLSAodm9pZCl3aWxsU3RhcnRTY3JvbGxpbmdPdmVyZmxvdzsKKyNpZiAhRU5B QkxFKE1JTklNQUxfU0lNVUxBVE9SKQogQHByb3BlcnR5IChub25hdG9taWMsIHJldGFpbikgVUlX ZWJTZWxlY3Rpb25WaWV3ICpzZWxlY3Rpb25WaWV3OworI2VuZGlmCiBAcHJvcGVydHkgKG5vbmF0 b21pYywgcmVhZG9ubHkpIENHUmVjdCBzZWxlY3Rpb25GcmFtZTsKIEBlbmQKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0gYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbQppbmRleCBlOTFlYjliMzBiZmMy YjY0N2QwODQ2YmViZGYzMTkzMzNiNTc2N2MwLi4wZmEwNzg4MWRjYzIyYjIwOWNkMjMwYTNmMjQy ZTJhYzU3YTM1ODQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlldy5tbQpAQCAtMzQ4LDcgKzM0OCw5IEBAIC0gKHZvaWQpX2RpZEV4aXRTdGFibGVTdGF0ZQog ICAgICAgICByZXR1cm47CiAKICAgICBbX3RleHRTZWxlY3Rpb25Bc3Npc3RhbnQgZGVhY3RpdmF0 ZVNlbGVjdGlvbl07CisjaWYgIUVOQUJMRShNSU5JTUFMX1NJTVVMQVRPUikKICAgICBbW193ZWJT ZWxlY3Rpb25Bc3Npc3RhbnQgc2VsZWN0aW9uVmlld10gc2V0SGlkZGVuOllFU107CisjZW5kaWYK IH0KIAogLSAoQ0dSZWN0KV9jb21wdXRlVW5vYnNjdXJlZENvbnRlbnRSZWN0UmVzcGVjdGluZ0lu cHV0Vmlld0JvdW5kczooQ0dSZWN0KXVub2JzY3VyZWRDb250ZW50UmVjdCBpbnB1dFZpZXdCb3Vu ZHM6KENHUmVjdClpbnB1dFZpZXdCb3VuZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGZkY2Y4MDFlYzEw YWIxZTM1YzM1OTYxZmQ0MDU2MDdjNTRlMWFmMDEuLjlhN2Y3OGQwNDhjOWI0MmNlNmNiZjJjMzM1 MWRmNzAyYTk2ZWIxNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtNDQ5NCw3ICs0NDk0LDkgQEAgLSAo dm9pZClfdXBkYXRlQ2hhbmdlZFNlbGVjdGlvbjooQk9PTClmb3JjZQogICAgIGlmICghc3RhdGUu aXNNaXNzaW5nUG9zdExheW91dERhdGEgJiYgc3RhdGUucG9zdExheW91dERhdGEoKS5pc1N0YWJs ZVN0YXRlVXBkYXRlICYmIF9uZWVkc0RlZmVycmVkRW5kU2Nyb2xsaW5nU2VsZWN0aW9uVXBkYXRl ICYmIF9wYWdlLT5pblN0YWJsZVN0YXRlKCkpIHsKICAgICAgICAgW1tzZWxmIHNlbGVjdGlvbklu dGVyYWN0aW9uQXNzaXN0YW50XSBzaG93U2VsZWN0aW9uQ29tbWFuZHNdOwogICAgICAgICBbX3dl YlNlbGVjdGlvbkFzc2lzdGFudCBkaWRFbmRTY3JvbGxpbmdPclpvb21pbmdQYWdlXTsKKyNpZiAh RU5BQkxFKE1JTklNQUxfU0lNVUxBVE9SKQogICAgICAgICBbW193ZWJTZWxlY3Rpb25Bc3Npc3Rh bnQgc2VsZWN0aW9uVmlld10gc2V0SGlkZGVuOk5PXTsKKyNlbmRpZgogCiAgICAgICAgIGlmICgh c2VsZi5zdXBwcmVzc0Fzc2lzdGFudFNlbGVjdGlvblZpZXcpCiAgICAgICAgICAgICBbX3RleHRT ZWxlY3Rpb25Bc3Npc3RhbnQgYWN0aXZhdGVTZWxlY3Rpb25dOwo=