184408 2018-04-08 20:50:41 -0700 CRASH() should call abort() except on Darwin and in developer builds 2018-11-25 10:22:40 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro benjamin bugs-noreply cdumez cmarcelo commit-queue dbates ews-watchlist mcatanzaro webkit-bug-importer oldest_to_newest 1412799 0 mcatanzaro 2018-04-08 20:50:41 -0700 CRASH() should call abort() except on Darwin and in developer builds, as discussed at https://lists.webkit.org/pipermail/webkit-dev/2018-March/029903.html. This should be slightly nicer than dereferencing 0xbadbeef. On Darwin, CRASH() uses a breakpoint trap, which seems to corrupt the stack on Linux, so we can't do that. Continue to call WTFCrash() in developer mode, and make no changes to WTFCrash(), since it is reportedly useful in nightmare scenarios where core dumps are unavailable: https://lists.webkit.org/pipermail/webkit-dev/2018-March/029907.html 1412800 1 337478 mcatanzaro 2018-04-08 20:53:57 -0700 Created attachment 337478 Patch 1412801 2 337478 mcatanzaro 2018-04-08 20:55:34 -0700 Comment on attachment 337478 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337478&action=review > Source/WTF/wtf/Assertions.h:234 > +#elif !ENABLE(DEVELOPER_MODE) && !OS(DARWIN) Note that I don't check NDEBUG here specifically in order to allow Adrian to use WTFCrash() in "release" builds. 1425653 3 mcatanzaro 2018-05-21 08:26:24 -0700 Pinging GTK/WPE reviewers. 1481175 4 mcatanzaro 2018-11-23 11:52:46 -0800 (In reply to Michael Catanzaro from comment #0) > CRASH() should call abort() except on Darwin and in developer builds, as > discussed at > https://lists.webkit.org/pipermail/webkit-dev/2018-March/029903.html. This > should be slightly nicer than dereferencing 0xbadbeef. Ping any reviewers. 1481242 5 337478 dbates 2018-11-23 20:13:54 -0800 Comment on attachment 337478 Patch OK 1481297 6 337478 commit-queue 2018-11-24 07:13:24 -0800 Comment on attachment 337478 Patch Clearing flags on attachment: 337478 Committed r238469: <https://trac.webkit.org/changeset/238469> 1481298 7 commit-queue 2018-11-24 07:13:25 -0800 All reviewed patches have been landed. Closing bug. 1481299 8 webkit-bug-importer 2018-11-24 07:14:27 -0800 <rdar://problem/46228007> 1481386 9 mcatanzaro 2018-11-25 08:22:52 -0800 Reverted r238469 for reason: Broke the build Committed r238477: <https://trac.webkit.org/changeset/238477> 1481387 10 355596 mcatanzaro 2018-11-25 08:27:50 -0800 Created attachment 355596 Patch 1481392 11 355596 commit-queue 2018-11-25 10:22:38 -0800 Comment on attachment 355596 Patch Clearing flags on attachment: 355596 Committed r238478: <https://trac.webkit.org/changeset/238478> 1481393 12 commit-queue 2018-11-25 10:22:40 -0800 All reviewed patches have been landed. Closing bug. 337478 2018-04-08 20:53:57 -0700 2018-11-25 08:27:47 -0800 Patch bug-184408-20180408225357.patch text/plain 1752 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDkyODQzZTBlMzI0YTU0NTJhNzA2NjNk N2UzMjdmMmI1OGYyYzU5ZDcuLmNjNGZjMmQ5MmM1ZTRiZWFhMTE2ZDFiMjBjMDZmNDZlNGJiOWEx YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDQtMDggIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIENSQVNIKCkgc2hvdWxkIGNhbGwgYWJv cnQoKSBleGNlcHQgb24gRGFyd2luIGFuZCBpbiBkZXZlbG9wZXIgYnVpbGRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ0MDgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDUkFTSCgpIHNob3VsZCBjYWxs IGFib3J0KCkgZXhjZXB0IG9uIERhcndpbiBhbmQgaW4gZGV2ZWxvcGVyIGJ1aWxkcywgYXMgZGlz Y3Vzc2VkIG9uCisgICAgICAgIHdlYmtpdC1kZXYuIFRoaXMgc2hvdWxkIGJlIHNsaWdodGx5IG5p Y2VyIHRoYW4gZGVyZWZlcmVuY2luZyAweGJhZGJlZWYuCisKKyAgICAgICAgT24gRGFyd2luLCBD UkFTSCgpIHVzZXMgYSBicmVha3BvaW50IHRyYXAsIHdoaWNoIHNlZW1zIHRvIGNvcnJ1cHQgdGhl IHN0YWNrIG9uIExpbnV4LCBzbyB3ZQorICAgICAgICBjYW4ndCBkbyB0aGF0LgorCisgICAgICAg IENvbnRpbnVlIHRvIGNhbGwgV1RGQ3Jhc2goKSBpbiBkZXZlbG9wZXIgbW9kZSwgYW5kIG1ha2Ug bm8gY2hhbmdlcyB0byBXVEZDcmFzaCgpLCBzaW5jZSBpdAorICAgICAgICBpcyByZXBvcnRlZGx5 IHVzZWZ1bCBpbiBuaWdodG1hcmUgc2NlbmFyaW9zIHdoZXJlIGNvcmUgZHVtcHMgYXJlIHVuYXZh aWxhYmxlLgorCisgICAgICAgICogd3RmL0Fzc2VydGlvbnMuaDoKKwogMjAxOC0wNC0wOCAgWXVz dWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LCB1c2UgYWxpZ25hcyh2b2lkKikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlv bnMuaCBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAppbmRleCBiNmM4NTJmYTVmNmE3M2Ji MWYxOTA1MjUwNDBhYTIxYWY1MDU2YjI3Li5lMjAxMWFjNTZmY2Q2N2FiYWFjNTJiODdjNGE1Nzhk MjE1OTczMzBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKKysrIGIv U291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCkBAIC00NSw2ICs0NSw3IEBACiAjaW5jbHVkZSA8 c3RkYXJnLmg+CiAjaW5jbHVkZSA8c3RkYm9vbC5oPgogI2luY2x1ZGUgPHN0ZGRlZi5oPgorI2lu Y2x1ZGUgPHN0ZGxpYi5oPgogI2luY2x1ZGUgPHd0Zi9FeHBvcnRNYWNyb3MuaD4KIAogI2lmIFVT RShPU19MT0cpCkBAIC0yMzAsNiArMjMxLDggQEAgV1RGX0VYUE9SVF9QUklWQVRFIGJvb2wgV1RG SXNEZWJ1Z2dlckF0dGFjaGVkKHZvaWQpOwogICAgIFdURkJyZWFrcG9pbnRUcmFwKCk7IFwKICAg ICBfX2J1aWx0aW5fdW5yZWFjaGFibGUoKTsgXAogfSB3aGlsZSAoMCkKKyNlbGlmICFFTkFCTEUo REVWRUxPUEVSX01PREUpICYmICFPUyhEQVJXSU4pCisjZGVmaW5lIENSQVNIKCkgYWJvcnQoKQog I2Vsc2UKICNkZWZpbmUgQ1JBU0goKSBXVEZDcmFzaCgpCiAjZW5kaWYK 355596 2018-11-25 08:27:50 -0800 2018-11-25 10:22:38 -0800 Patch bug-184408-20181125102749.patch text/plain 2110 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGFmYjNkZGU5ZTg3NDJiZGViZDYwMTk0 YzVmMzRjMmI3ZDRmYzczNzUuLjc1NTUzMGNkYmFkM2Q3ZmI1YTgxNmY4MDY5ODE2YmM3ZmNmNWUz NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMTEtMjUgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIENSQVNIKCkgc2hvdWxkIGNhbGwgYWJv cnQoKSBleGNlcHQgb24gRGFyd2luIGFuZCBpbiBkZXZlbG9wZXIgYnVpbGRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ0MDgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDUkFTSCgpIHNob3VsZCBjYWxs IGFib3J0KCkgZXhjZXB0IG9uIERhcndpbiBhbmQgaW4gZGV2ZWxvcGVyIGJ1aWxkcywgYXMgZGlz Y3Vzc2VkIG9uCisgICAgICAgIHdlYmtpdC1kZXYuIFRoaXMgc2hvdWxkIGJlIHNsaWdodGx5IG5p Y2VyIHRoYW4gZGVyZWZlcmVuY2luZyAweGJhZGJlZWYuCisKKyAgICAgICAgT24gRGFyd2luLCBD UkFTSCgpIHVzZXMgYSBicmVha3BvaW50IHRyYXAsIHdoaWNoIHNlZW1zIHRvIGNvcnJ1cHQgdGhl IHN0YWNrIG9uIExpbnV4LCBzbyB3ZQorICAgICAgICBjYW4ndCBkbyB0aGF0LgorCisgICAgICAg IENvbnRpbnVlIHRvIGNhbGwgV1RGQ3Jhc2goKSBpbiBkZXZlbG9wZXIgbW9kZSwgYW5kIG1ha2Ug bm8gY2hhbmdlcyB0byBXVEZDcmFzaCgpLCBzaW5jZSBpdAorICAgICAgICBpcyByZXBvcnRlZGx5 IHVzZWZ1bCBpbiBuaWdodG1hcmUgc2NlbmFyaW9zIHdoZXJlIGNvcmUgZHVtcHMgYXJlIHVuYXZh aWxhYmxlLgorCisgICAgICAgIFdlIGFsc28gaGF2ZSB0byBkZWZpbmUgQ1JBU0hfVU5ERVJfQ09O U1RFWFBSX0NPTlRFWFQoKS4gSXQncyBhIGJpdCBvZGQgdGhhdCBpdCdzIHBvc3NpYmxlIHRvCisg ICAgICAgIHVzZSBhIG5vbi1jb25zdGV4cHIgZnVuY3Rpb24gaGVyZSwgYnV0IGl0IHdvcmtzLiBD dXJyZW50bHkgdGhpcyBtYWNybyB1c2VzIFdURkNyYXNoKCksIHdoaWNoCisgICAgICAgIGlzIGFs c28gbm9uLWNvbnN0ZXhwci4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmg6CisKIDIwMTgt MTEtMjUgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMzg0NjkuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi9Bc3NlcnRpb25zLmggYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKaW5kZXgg MDE0NGYzMzE2NjQ2YjhkYTg2OGEwZWY4YTQ0NGU1NzkxMWY2MWJlYi4uZWJhYWEwNTZkNTYzYzcw NzhiMWQxYmUxOTBmYzkxMzllNjVjZTRlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQXNz ZXJ0aW9ucy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaApAQCAtNDQsNiArNDQs NyBAQAogI2luY2x1ZGUgPHN0ZGFyZy5oPgogI2luY2x1ZGUgPHN0ZGJvb2wuaD4KICNpbmNsdWRl IDxzdGRkZWYuaD4KKyNpbmNsdWRlIDxzdGRsaWIuaD4KICNpbmNsdWRlIDx3dGYvRXhwb3J0TWFj cm9zLmg+CiAKICNpZiBVU0UoT1NfTE9HKQpAQCAtMjM5LDYgKzI0MCw5IEBAIFdURl9FWFBPUlRf UFJJVkFURSBib29sIFdURklzRGVidWdnZXJBdHRhY2hlZCh2b2lkKTsKICAgICBXVEZCcmVha3Bv aW50VHJhcFVuZGVyQ29uc3RleHByQ29udGV4dCgpOyBcCiAgICAgX19idWlsdGluX3VucmVhY2hh YmxlKCk7IFwKIH0gd2hpbGUgKDApCisjZWxpZiAhRU5BQkxFKERFVkVMT1BFUl9NT0RFKSAmJiAh T1MoREFSV0lOKQorI2RlZmluZSBDUkFTSCgpIGFib3J0KCkKKyNkZWZpbmUgQ1JBU0hfVU5ERVJf Q09OU1RFWFBSX0NPTlRFWFQoKSBhYm9ydCgpCiAjZWxzZQogI2RlZmluZSBDUkFTSCgpIFdURkNy YXNoKCkKICNkZWZpbmUgQ1JBU0hfVU5ERVJfQ09OU1RFWFBSX0NPTlRFWFQoKSBXVEZDcmFzaCgp Cg==