184407 2018-04-08 20:19:12 -0700 [GTK] check target looks broken 2018-04-23 18:08:04 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1412795 0 mcatanzaro 2018-04-08 20:19:12 -0700 I see in Source/PlatformGTK.cmake: add_custom_target(check COMMAND ${TOOLS_DIR}/Scripts/run-gtk-tests COMMAND ${TOOLS_DIR}/gtk/check-for-webkitdom-api-breaks ) But we got rid of check-for-webkitdom-api-breaks a long time ago, when we stopped autogenerating the DOM API. So that probably does not work. 1412894 1 337500 mcatanzaro 2018-04-09 09:24:00 -0700 Created attachment 337500 Patch 1417048 2 337500 commit-queue 2018-04-23 18:08:02 -0700 Comment on attachment 337500 Patch Clearing flags on attachment: 337500 Committed r230937: <https://trac.webkit.org/changeset/230937> 1417049 3 commit-queue 2018-04-23 18:08:04 -0700 All reviewed patches have been landed. Closing bug. 337500 2018-04-09 09:24:00 -0700 2018-04-23 18:08:02 -0700 Patch bug-184407-20180409112359.patch text/plain 1526 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm1H VEsuY21ha2UgYi9Tb3VyY2UvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggYzQyY2UzNDY5NTU0NzNj NjI5YmNmN2JiM2IzYTYxYWM1ZmUzZTFiYy4uMDY1MTIyODM2NTEyNGIyNTIyOTJmMTZkMTU3Zjll NTg3ZjE2MDM2NSAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1Nv dXJjZS9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtNTAsNyArNTAsOCBAQCBlbmRpZiAoKQogCiBhZGRf Y3VzdG9tX3RhcmdldChjaGVjawogICAgIENPTU1BTkQgJHtUT09MU19ESVJ9L1NjcmlwdHMvcnVu LWd0ay10ZXN0cwotICAgIENPTU1BTkQgJHtUT09MU19ESVJ9L2d0ay9jaGVjay1mb3Itd2Via2l0 ZG9tLWFwaS1icmVha3MKKyAgICBXT1JLSU5HX0RJUkVDVE9SWSAiJHtDTUFLRV9CSU5BUllfRElS fSIKKyAgICBWRVJCQVRJTQogKQogCiBpZiAoREVWRUxPUEVSX01PREUpCmRpZmYgLS1naXQgYS9D aGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggZTNjMTZiOWM2YTQzYzNhOTBkOTM0ZDY3ZjRkNmVh M2NiZmE3NGI2MS4uZGM5YTJhZjIwZGVjOGJhYzNmOThjMDJlNDA3NTY3MGVhMjY5Y2EyOSAxMDA2 NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4 LTA0LTA5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAg ICAgICBbR1RLXSBjaGVjayB0YXJnZXQgbG9va3MgYnJva2VuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ0MDcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCdzIHByZXR0eSBjbGVhciB0aGF0IG5vYm9k eSBoYXMgYmVlbiB1c2luZyBjaGVjayBmb3IgYSBsb25nIHRpbWUuCisKKyAgICAgICAgV2UgZ290 IHJpZCBvZiBjaGVjay1mb3Itd2Via2l0ZG9tLWFwaS1icmVha3MgYSBsb25nIHRpbWUgYWdvLCB3 aGVuIHdlIHN0b3BwZWQgYXV0b2dlbmVyYXRpbmcKKyAgICAgICAgdGhlIERPTSBBUEksIGJ1dCBp dCdzIHN0aWxsIHVzZWQgaW4gdGhlIGNoZWNrIHRhcmdldC4gRml4IHRoaXMuCisKKyAgICAgICAg QWxzbywgdGhlIGNoZWNrIHRhcmdldCBmb3Igc29tZSByZWFzb24gcnVucyBpdHNlbGYgZnJvbSB0 aGUgU291cmNlIHN1YmRpcmVjdG9yeSBvZiB0aGUKKyAgICAgICAgYnVpbGRkaXIsIGJ1dCB0aGUg dGVzdCBzY3JpcHQgZXhwZWN0cyB0byBiZSBydW4gZnJvbSB0aGUgdG9wbGV2ZWwgYnVpbGQgZGly ZWN0b3J5LiBGaXggdGhpcworICAgICAgICB0b28uCisKKyAgICAgICAgQWRkIFZFUkJBVElNIGZv ciBnb29kIG1lYXN1cmUuCisKKyAgICAgICAgKiBTb3VyY2UvUGxhdGZvcm1HVEsuY21ha2U6CisK IDIwMTgtMDQtMDkgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgog CiAgICAgICAgIFtXUEVdIFVzZSBHTlUgaW5zdGFsbCBkaXJlY3Rvcmllcwo=