184398 2018-04-08 09:06:15 -0700 [JSC] Fix incorrect assertion for VM's regexp buffer lock 2018-04-08 10:34:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue darin fpizlo jfbastien keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1412718 0 ysuzuki 2018-04-08 09:06:15 -0700 [JSC] Fix incorrect assertion for VM's regexp buffer lock 1412719 1 337458 ysuzuki 2018-04-08 09:06:55 -0700 Created attachment 337458 Patch 1412722 2 337458 mark.lam 2018-04-08 09:21:05 -0700 Comment on attachment 337458 Patch r=me 1412726 3 337458 commit-queue 2018-04-08 09:47:25 -0700 Comment on attachment 337458 Patch Clearing flags on attachment: 337458 Committed r230377: <https://trac.webkit.org/changeset/230377> 1412727 4 commit-queue 2018-04-08 09:47:26 -0700 All reviewed patches have been landed. Closing bug. 1412728 5 webkit-bug-importer 2018-04-08 09:48:12 -0700 <rdar://problem/39266425> 1412734 6 337458 darin 2018-04-08 10:30:41 -0700 Comment on attachment 337458 Patch What is the value of this assertion? Why assert something is locked right after calling "lock"? 1412735 7 ysuzuki 2018-04-08 10:34:38 -0700 (In reply to Darin Adler from comment #6) > Comment on attachment 337458 [details] > Patch > > What is the value of this assertion? Why assert something is locked right > after calling "lock"? This assertion is a corresponding one to the releaseRegExpPatternContexBuffer's assertion. Both would not be required. 337458 2018-04-08 09:06:55 -0700 2018-04-08 09:47:25 -0700 Patch bug-184398-20180409010654.patch text/plain 1498 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj YjQwZmNiM2VmMWVhMWQ3YWExZjcwMDc4MGIyZDZmMGQzMTc4NmEyLi45YzU0NDllYmFkNTcxNmZi MGNmMjQ0NWIzYzZmN2NiMTYzNGNhYzVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wNC0wOCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBGaXggaW5jb3JyZWN0IGFzc2VydGlvbiBmb3IgVk0ncyBy ZWdleHAgYnVmZmVyIGxvY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NDM5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGlzTG9ja2VkIGNoZWNrIGJlZm9yZSB0YWtpbmcgYSBsb2NrIGlzIGluY29ycmVj dC4KKworICAgICAgICAqIHJ1bnRpbWUvVk0uY3BwOgorICAgICAgICAoSlNDOjpWTTo6YWNxdWly ZVJlZ0V4cFBhdHRlcm5Db250ZXhCdWZmZXIpOgorCiAyMDE4LTA0LTA3ICBZdXN1a2UgU3V6dWtp ICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtKU0NdIFJlbW92ZSBzZXZlcmFs IGFzWFhYIGZ1bmN0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvVk0uY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCmluZGV4IDdh ZDUxMGZlZGM1ZGU4MTI0ODlkYTgzZmZhNWM5MTZhNjExNmUwZGYuLmM5YTI0ZWM0NWJiOWMzNDBl Y2FjZjEzYjVkNDU3NTQzMGFhNzM5MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL1ZNLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5j cHAKQEAgLTkwMSw5ICs5MDEsOCBAQCB2b2lkIGxvZ1Nhbml0aXplU3RhY2soVk0qIHZtKQogI2lm IEVOQUJMRShZQVJSX0pJVF9BTExfUEFSRU5TX0VYUFJFU1NJT05TKQogY2hhciogVk06OmFjcXVp cmVSZWdFeHBQYXR0ZXJuQ29udGV4QnVmZmVyKCkKIHsKLSAgICBBU1NFUlQoIW1fcmVnRXhwUGF0 dGVybkNvbnRleHRMb2NrLmlzTG9ja2VkKCkpOwotCiAgICAgbV9yZWdFeHBQYXR0ZXJuQ29udGV4 dExvY2subG9jaygpOworICAgIEFTU0VSVChtX3JlZ0V4cFBhdHRlcm5Db250ZXh0TG9jay5pc0xv Y2tlZCgpKTsKICAgICBpZiAoIW1fcmVnRXhwUGF0dGVybkNvbnRleEJ1ZmZlcikKICAgICAgICAg bV9yZWdFeHBQYXR0ZXJuQ29udGV4QnVmZmVyID0gbWFrZVVuaXF1ZUFycmF5PGNoYXI+KFZNOjpw YXR0ZXJuQ29udGV4dEJ1ZmZlclNpemUpOwogICAgIHJldHVybiBtX3JlZ0V4cFBhdHRlcm5Db250 ZXhCdWZmZXIuZ2V0KCk7Cg==