184388 2018-04-07 12:53:37 -0700 [WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb 2018-04-13 09:29:15 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 178894 1 mcatanzaro mcatanzaro aperez bugs-noreply clopez commit-queue ews-watchlist mcatanzaro oldest_to_newest 1412634 0 mcatanzaro 2018-04-07 12:53:37 -0700 I'm trying to run dinghy in WPE's JHBuild environment, but WPEBackend-mesa is crashing on startup in libxkbcommon: xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb Problem is all the data files are missing. We need to either (a) add them to the jhbuild, or (b) remove xkbcommon. I kinda think (b) makes more sense, because nothing else in the jhbuild depends on it, and we can surely add it to install-dependencies instead. Right? But here's a patch for (a) anyway. 1412636 1 337431 mcatanzaro 2018-04-07 12:56:38 -0700 Created attachment 337431 Patch 1414211 2 mcatanzaro 2018-04-12 16:05:11 -0700 Since nobody said anything, let's remove xkbcommon. 1414227 3 337847 mcatanzaro 2018-04-12 16:25:10 -0700 Created attachment 337847 Patch 1414248 4 clopez 2018-04-12 17:27:36 -0700 dyz seems to depend on this. dyz (master) $ git log -1 --oneline 74a368c Add wpebackend.lua to LUA_SRCS list. dyz (master) $ git grep -i xkbc src/Makefile:WLGLUE_CFLAGS := $(shell pkg-config egl glib-2.0 wayland-client wayland-egl glesv2 wpe xkbcommon --cflags) src/Makefile:WLGLUE_LDLIBS := $(shell pkg-config egl glib-2.0 wayland-client wayland-egl glesv2 wpe xkbcommon --libs) src/wlglue.cpp:#include <xkbcommon/xkbcommon.h> src/wlglue.cpp:#include <xkbcommon/xkbcommon-compose.h> 1414407 5 mcatanzaro 2018-04-13 08:53:53 -0700 That's why I added it to install-dependencies. I did test to verify that I can run dyz if and only if libxkbcommon is removed from the jhbuild environment. Adding xkeyboard-config also works, but there seems to be no reason to keep libxkbcommon there, so.... 1414415 6 337847 clopez 2018-04-13 09:00:56 -0700 Comment on attachment 337847 Patch ok, let's try 1414438 7 337847 commit-queue 2018-04-13 09:29:13 -0700 Comment on attachment 337847 Patch Clearing flags on attachment: 337847 Committed r230634: <https://trac.webkit.org/changeset/230634> 1414439 8 commit-queue 2018-04-13 09:29:15 -0700 All reviewed patches have been landed. Closing bug. 337431 2018-04-07 12:56:38 -0700 2018-04-12 16:25:08 -0700 Patch bug-184388-20180407145638.patch text/plain 1948 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMzU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTFlNGFiNTM2N2MwODI4NTkyYTdlYWI2NWIxNDM4NGFh MzIxM2E5MS4uOGVjZmVhMmJhZDg4YmIwYTRiNjI3MTI5ZjAyMGY2NjkyYzM0NDU5NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE4LTA0LTA3ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbV1BFXSB4a2Jjb21tb246IEVSUk9SOiBmYWlsZWQgdG8gYWRkIGRlZmF1 bHQgaW5jbHVkZSBwYXRoIC9ob21lL21jYXRhbnphcm8vUHJvamVjdHMvV2ViS2l0L1dlYktpdEJ1 aWxkL0RlcGVuZGVuY2llc1dQRS9Sb290L3NoYXJlL1gxMS94a2IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDM4OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBKSEJ1aWxkIGVudmlyb25tZW50IGlz IG1pc3NpbmcgYWxsIHRoZSB4a2IgZGF0YSBmaWxlcy4gQWRkIHRoZW0uCisKKyAgICAgICAgKiB3 cGUvamhidWlsZC5tb2R1bGVzOgorCiAyMDE4LTA0LTA2ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9u b3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5dW1dlYkNvcmVdIEV4cG9zZSBhIGNv bnN0YW50IGZvciBzY3JvbGxiYXIgcGl4ZWxzIHBlciBsaW5lIChjU2Nyb2xsYmFyUGl4ZWxzUGVy TGluZSkKZGlmZiAtLWdpdCBhL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy93cGUv amhidWlsZC5tb2R1bGVzCmluZGV4IDBmOGJmZWEzN2RjNDEyODBhNjgwNWVjOTY1YjVlNGIxMjZm NzBjMzcuLmQ0ZDRhMWQ1ZjgzOGNjMjdmOTZlMjRkNDY2NGY5NmVkZWE2NTI4YmMgMTAwNjQ0Ci0t LSBhL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMvd3BlL2poYnVpbGQubW9k dWxlcwpAQCAtNDEsNiArNDEsOCBAQAogICAgICAgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tIi8+ CiAgIDxyZXBvc2l0b3J5IHR5cGU9InRhcmJhbGwiIG5hbWU9ImdpdGh1Yi10YXJiYWxsIgogICAg ICAgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tLyIvPgorICA8cmVwb3NpdG9yeSB0eXBlPSJ0YXJi YWxsIiBuYW1lPSJ4b3JnLmZyZWVkZXNrdG9wLm9yZyIKKyAgICAgIGhyZWY9Imh0dHBzOi8vd3d3 Lngub3JnL2FyY2hpdmUvIi8+CiAgIDxyZXBvc2l0b3J5IHR5cGU9InRhcmJhbGwiIG5hbWU9Inhr YmNvbW1vbi5vcmciCiAgICAgICBocmVmPSJodHRwOi8veGtiY29tbW9uLm9yZyIvPgogICA8cmVw b3NpdG9yeSB0eXBlPSJ0YXJiYWxsIiBuYW1lPSJzYXZhbm5haC5nbnUub3JnIgpAQCAtMTcwLDYg KzE3MiwxNSBAQAogICAgIDxicmFuY2ggbW9kdWxlPSJkb3dubG9hZC9saWJ4a2Jjb21tb24tMC41 LjAudGFyLnh6IiB2ZXJzaW9uPSIwLjUuMCIKICAgICAgICAgICAgIHJlcG89InhrYmNvbW1vbi5v cmciCiAgICAgICAgICAgICBoYXNoPSJzaGExOjcxMjc5OTNiZmI2OWUxM2NkZmYyNWZiOGIzYzhm MjZjZTZiZTViZmEiLz4KKyAgICA8ZGVwZW5kZW5jaWVzPgorICAgICAgPGRlcCBwYWNrYWdlPSJ4 a2V5Ym9hcmQtY29uZmlnIi8+CisgICAgPC9kZXBlbmRlbmNpZXM+CisgIDwvYXV0b3Rvb2xzPgor CisgIDxhdXRvdG9vbHMgaWQ9InhrZXlib2FyZC1jb25maWciPgorICAgIDxicmFuY2ggbW9kdWxl PSJpbmRpdmlkdWFsL2RhdGEveGtleWJvYXJkLWNvbmZpZy94a2V5Ym9hcmQtY29uZmlnLSR7dmVy c2lvbn0udGFyLmJ6MiIKKyAgICAgICAgICAgIHJlcG89InhvcmcuZnJlZWRlc2t0b3Aub3JnIgor ICAgICAgICAgICAgdmVyc2lvbj0iMi4yMyIvPgogICA8L2F1dG90b29scz4KIAogICA8Y21ha2Ug aWQ9IndwZSI+Cg== 337847 2018-04-12 16:25:10 -0700 2018-04-13 09:29:13 -0700 Patch bug-184388-20180412182509.patch text/plain 3612 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNTk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjYzYTY0NjFmOWQ5ZTdlNDUwZjE0ODM0NTEyMjQzZmI5 Njk2Mzk5Ny4uZmRjNDNkZWMxZTE4ZTZjZWE4NGRkODc3YTEwYzIzNmFmZGJkZjk5YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE4LTA0LTEyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbV1BFXSB4a2Jjb21tb246IEVSUk9SOiBmYWlsZWQgdG8gYWRkIGRlZmF1 bHQgaW5jbHVkZSBwYXRoIC9ob21lL21jYXRhbnphcm8vUHJvamVjdHMvV2ViS2l0L1dlYktpdEJ1 aWxkL0RlcGVuZGVuY2llc1dQRS9Sb290L3NoYXJlL1gxMS94a2IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDM4OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBsaWJ4a2Jjb21tb24gZnJvbSB0 aGUgSkhCdWlsZCBlbnZpcm9ubWVudC4gV2UgY291bGQgYWx0ZXJuYXRpdmVseSBhZGQKKyAgICAg ICAgeGtleWJvYXJkLWNvbmZpZywgYnV0IHRoZXJlIGRvZXNuJ3Qgc2VlbSB0byBiZSBhbnkgbmVl ZCB0byBidWlsZCBsaWJ4a2Jjb21tb24gYmVjYXVzZSBJIGRvCisgICAgICAgIG5vdCBiZWxpZXZl IGl0IGRlcGVuZHMgb24gYW55dGhpbmcgZWxzZSBpbiB0aGUgSkhCdWlsZCBlbnZpcm9ubWVudC4K KworICAgICAgICAqIHdwZS9pbnN0YWxsLWRlcGVuZGVuY2llczoKKyAgICAgICAgKiB3cGUvamhi dWlsZC5tb2R1bGVzOgorCiAyMDE4LTA0LTEyICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGlu Z0Bzb255LmNvbT4KIAogICAgICAgICBwZW1maWxlLnB5IHNob3VsZCBub3QgYXNzdW1lIFBPU0lY IGxpbmUgZW5kaW5ncwpkaWZmIC0tZ2l0IGEvVG9vbHMvd3BlL2luc3RhbGwtZGVwZW5kZW5jaWVz IGIvVG9vbHMvd3BlL2luc3RhbGwtZGVwZW5kZW5jaWVzCmluZGV4IGFkNWEyYTJmMTQ3MTM5Y2Q3 ZTMyM2UzMGFiZjBlYjZjNTg1YjMyZmQuLjM2NmJiZThjYzNmYmY5OTQ1NDdjYTRiNTNiYWI3YjNk M2U5YzgyZDIgMTAwNzU1Ci0tLSBhL1Rvb2xzL3dwZS9pbnN0YWxsLWRlcGVuZGVuY2llcworKysg Yi9Ub29scy93cGUvaW5zdGFsbC1kZXBlbmRlbmNpZXMKQEAgLTEyMyw2ICsxMjMsNyBAQCBmdW5j dGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aEFwdCB7CiAgICAgICAgIGxpYnZvcmJpcy1kZXYg XAogICAgICAgICBsaWJ2cHgtZGV2IFwKICAgICAgICAgbGlieGNiLXhrYi1kZXYgXAorICAgICAg ICBsaWJ4a2Jjb21tb24tZGV2IFwKICAgICAgICAgbGlieG1sLWxpYnhtbC1wZXJsIFwKICAgICAg ICAgbGlid2F5bGFuZC1kZXYgXAogICAgICAgICBsdWFqaXQgXApAQCAtMjA5LDYgKzIxMCw3IEBA IGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoUGFjbWFuIHsKICAgICAgICAgbGlidm9y YmlzIFwKICAgICAgICAgbGlidnB4IFwKICAgICAgICAgbGlieGNiIFwKKyAgICAgICAgbGlieGti Y29tbW9uIFwKICAgICAgICAgbHVhaml0IFwKICAgICAgICAgbWVzYSBcCiAgICAgICAgIG1lc2Et bGliZ2wgXApAQCAtMjk1LDYgKzI5Nyw3IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNX aXRoRG5mIHsKICAgICAgICAgbGlidm9yYmlzLWRldmVsIFwKICAgICAgICAgbGlidnB4LWRldmVs IFwKICAgICAgICAgbGlieGNiLWRldmVsIFwKKyAgICAgICAgbGlieGtiY29tbW9uLWRldmVsIFwK ICAgICAgICAgbGliWHJhbmRyLWRldmVsIFwKICAgICAgICAgbHVhaml0IFwKICAgICAgICAgbHVh aml0LWRldmVsIFwKZGlmZiAtLWdpdCBhL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29s cy93cGUvamhidWlsZC5tb2R1bGVzCmluZGV4IDIwODdiY2JjMzZkM2UyODk3ZmY1MzhiNGNmNTM0 Y2I0MGI3ODUzZjMuLjE1NTZiOGRlM2EyYTRmZWQ2OTNhZGNhYThlNDM3MzkxYTNlNWZlOTIgMTAw NjQ0Ci0tLSBhL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMvd3BlL2poYnVp bGQubW9kdWxlcwpAQCAtMTYsNyArMTYsNiBAQAogICAgICAgPGRlcCBwYWNrYWdlPSJmb250Y29u ZmlnIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImZyZWV0eXBlNiIvPgogICAgICAgPGRlcCBwYWNr YWdlPSJoYXJmYnV6eiIvPgotICAgICAgPGRlcCBwYWNrYWdlPSJ4a2Jjb21tb24iLz4KICAgICAg IDxkZXAgcGFja2FnZT0id2Via2l0LWdzdHJlYW1lci10ZXN0aW5nLWRlcGVuZGVuY2llcyIvPgog ICAgICAgPGRlcCBwYWNrYWdlPSJ3b2ZmMiIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJ3cGViYWNr ZW5kIi8+CkBAIC00MSw4ICs0MCw2IEBACiAgICAgICBocmVmPSJodHRwczovL2dpdGh1Yi5jb20i Lz4KICAgPHJlcG9zaXRvcnkgdHlwZT0idGFyYmFsbCIgbmFtZT0iZ2l0aHViLXRhcmJhbGwiCiAg ICAgICBocmVmPSJodHRwczovL2dpdGh1Yi5jb20vIi8+Ci0gIDxyZXBvc2l0b3J5IHR5cGU9InRh cmJhbGwiIG5hbWU9InhrYmNvbW1vbi5vcmciCi0gICAgICBocmVmPSJodHRwOi8veGtiY29tbW9u Lm9yZyIvPgogICA8cmVwb3NpdG9yeSB0eXBlPSJ0YXJiYWxsIiBuYW1lPSJzYXZhbm5haC5nbnUu b3JnIgogICAgICAgaHJlZj0iaHR0cDovL2Rvd25sb2FkLnNhdmFubmFoLmdudS5vcmcvcmVsZWFz ZXMvIi8+CiAgIDxyZXBvc2l0b3J5IHR5cGU9InRhcmJhbGwiIG5hbWU9ImdudXBnLm9yZyIKQEAg LTE2NSwxMyArMTYyLDYgQEAKICAgICAgICAgICAgIGhhc2g9InNoYTE6YzZmN2I5OTk4NmY5M2M5 ZGY3ODY1M2MzZTZhM2I1MDQzZjY1MTQ1ZSIvPgogICA8L2F1dG90b29scz4KIAotICA8YXV0b3Rv b2xzIGlkPSJ4a2Jjb21tb24iCi0gICAgICAgICAgICAgYXV0b2dlbi1zaD0iY29uZmlndXJlIj4K LSAgICA8YnJhbmNoIG1vZHVsZT0iZG93bmxvYWQvbGlieGtiY29tbW9uLTAuNS4wLnRhci54eiIg dmVyc2lvbj0iMC41LjAiCi0gICAgICAgICAgICByZXBvPSJ4a2Jjb21tb24ub3JnIgotICAgICAg ICAgICAgaGFzaD0ic2hhMTo3MTI3OTkzYmZiNjllMTNjZGZmMjVmYjhiM2M4ZjI2Y2U2YmU1YmZh Ii8+Ci0gIDwvYXV0b3Rvb2xzPgotCiAgIDxjbWFrZSBpZD0id3BlYmFja2VuZCI+CiAgICAgPGJy YW5jaCByZXBvPSJnaXRodWIuY29tIiBtb2R1bGU9IldlYlBsYXRmb3JtRm9yRW1iZWRkZWQvV1BF QmFja2VuZC5naXQiCiAgICAgICAgICAgICB0YWc9IjMwMTNmYWFlYmFiNDJlN2VmNzQ5N2IzODUw YTI5MDI5NzhlYjNkNmYiIC8+CkBAIC0xODEsNyArMTcxLDYgQEAKICAgICA8ZGVwZW5kZW5jaWVz PgogICAgICAgPGRlcCBwYWNrYWdlPSJ3cGViYWNrZW5kIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9 ImdsaWIiLz4KLSAgICAgIDxkZXAgcGFja2FnZT0ieGtiY29tbW9uIi8+CiAgICAgPC9kZXBlbmRl bmNpZXM+CiAgICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29tIiBtb2R1bGU9IklnYWxpYS9XUEVC YWNrZW5kLWZkby5naXQiCiAgICAgICAgICAgICB0YWc9IjA2NGM2MDgwNjQyMmZmMWJiMzJjZWY3 ZmIxZGU2ODkyM2FlY2JhODIiLz4K