184358 2018-04-06 08:39:14 -0700 Adopt non-deprecated CGColorSpace API 2019-08-07 17:02:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham katherine_cheney bfulgham commit-queue darin katherine_cheney simon.fraser webkit-bug-importer zalan oldest_to_newest 1412365 0 bfulgham 2018-04-06 08:39:14 -0700 We are using a deprecated CGColorSpace creation method: #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wdeprecated-declarations" cgColorSpace = adoptCF(CGColorSpaceCreateWithICCProfile(colorSpaceData.get())); #pragma clang diagnostic pop We should adopt the newer API (I think this is CGColorSpaceCreateICCBased) 1412374 1 webkit-bug-importer 2018-04-06 09:17:51 -0700 <rdar://problem/39239671> 1559362 2 375762 katherine_cheney 2019-08-07 16:11:41 -0700 Created attachment 375762 Patch 1559382 3 375762 commit-queue 2019-08-07 16:52:26 -0700 Comment on attachment 375762 Patch Clearing flags on attachment: 375762 Committed r248396: <https://trac.webkit.org/changeset/248396> 1559383 4 commit-queue 2019-08-07 16:52:28 -0700 All reviewed patches have been landed. Closing bug. 1559388 5 simon.fraser 2019-08-07 17:02:18 -0700 Yay first bug! 375762 2019-08-07 16:11:41 -0700 2019-08-07 16:52:26 -0700 Patch bug-184358-20190807161141.patch text/plain 3248 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4Mzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTk2YmRjNzRkZjE4MTRj YzQ4YmNhN2Y4ZmQyMjVhZjI1ZTZiYjIwNS4uNTk1MTI3OGIyYWI1YzgwZGFkMmVhZTBjMmQxNjdi MWU2OWE3NGMwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA4LTA3ICBLYXRl IENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIEFkb3B0IG5v bi1kZXByZWNhdGVkIENHQ29sb3JTcGFjZSBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDM1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vU2NyZWVuUHJvcGVydGllcy5oOgorICAg ICAgICAoV2ViQ29yZTo6U2NyZWVuRGF0YTo6ZGVjb2RlKToKKworICAgICAgICBXZSBjaGFuZ2Vk IHRoZSBkZXByZWNhdGVkIENHQ29sb3JTcGFjZUNyZWF0ZVdpdGhJQ0NQcm9maWxlIGZ1bmN0aW9u IHRvIAorICAgICAgICBDR0NvbG9yU3BhY2VDcmVhdGVXaXRoSUNDRGF0YS4gCisgCiAyMDE5LTA4 LTA3ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CiAKICAgICAgICAgW1dI TFNMXSBTaW1wbGlmeSBhbmQgZWxpbWluYXRlIHJlZHVuZGFudCB3b3JrIGluIFdITFNMRnVuY3Rp b25Xcml0ZXIuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAyMDEzY2ZlMzM3Mjk0ZTExNTdkMzBjZGMwYmFmNjA5 ZTQzMTc3ODcuLjJmYWQwOTE3N2M2ZmI5NWQ5MDExNzE4NzZkNDY5YjZiYWE5MDhjNzIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDgtMDcgIEthdGUgQ2hlbmV5ICA8a2F0aGVyaW5l X2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRvcHQgbm9uLWRlcHJlY2F0ZWQgQ0dDb2xv clNwYWNlIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg0MzU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTaGFyZWQvbWFjL0NvbG9yU3BhY2VEYXRhLm1tOgorICAgICAgICAoV2ViS2l0OjpDb2xv clNwYWNlRGF0YTo6ZGVjb2RlKToKKworICAgICAgICBXZSBjaGFuZ2VkIHRoZSBkZXByZWNhdGVk IENHQ29sb3JTcGFjZUNyZWF0ZVdpdGhJQ0NQcm9maWxlIGZ1bmN0aW9uIHRvIAorICAgICAgICBD R0NvbG9yU3BhY2VDcmVhdGVXaXRoSUNDRGF0YS4gCisKIDIwMTktMDgtMDYgIERlYW4gSmFja3Nv biAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIENvbnRleHQgbWVudSBvbiBhIHVuaXZlcnNh bCBsaW5rIHByb2R1Y2VzIGEgYmxhbmsgcHJldmlldwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vU2NyZWVuUHJvcGVydGllcy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v U2NyZWVuUHJvcGVydGllcy5oCmluZGV4IDU2ZDE5NGZiM2MyMjYzM2I1YmQ1MTAzNWVlODk5OGY0 OWUxYjlkOTIuLjI0ODUyODBmMDM5MmVmNmI3ZTQ5NWNmNWVhNWRjNGRmYjBkYjA4ZWUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NjcmVlblByb3BlcnRpZXMuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JlZW5Qcm9wZXJ0aWVzLmgKQEAgLTE5NCwxMCArMTk0 LDcgQEAgT3B0aW9uYWw8U2NyZWVuRGF0YT4gU2NyZWVuRGF0YTo6ZGVjb2RlKERlY29kZXImIGRl Y29kZXIpCiAgICAgICAgICAgICByZXR1cm4gV1RGOjpudWxsb3B0OwogCiAgICAgICAgIGF1dG8g Y29sb3JTcGFjZURhdGEgPSBhZG9wdENGKENGRGF0YUNyZWF0ZShrQ0ZBbGxvY2F0b3JEZWZhdWx0 LCBpY2NEYXRhLT5kYXRhKCksIGljY0RhdGEtPnNpemUoKSkpOwotICAgICAgICAvLyBGSVhNRTog PGh0dHA6Ly93ZWJraXQub3JnL2IvMTg0MzU4PiBXZSBzaG91bGQgc3dpdGNoIHRvIENHQ29sb3JT cGFjZUNyZWF0ZUlDQ0Jhc2VkLgotICAgICAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9O U19CRUdJTgotICAgICAgICBjZ0NvbG9yU3BhY2UgPSBhZG9wdENGKENHQ29sb3JTcGFjZUNyZWF0 ZVdpdGhJQ0NQcm9maWxlKGNvbG9yU3BhY2VEYXRhLmdldCgpKSk7Ci0gICAgICAgIEFMTE9XX0RF UFJFQ0FURURfREVDTEFSQVRJT05TX0VORAorICAgICAgICBjZ0NvbG9yU3BhY2UgPSBhZG9wdENG KENHQ29sb3JTcGFjZUNyZWF0ZVdpdGhJQ0NEYXRhKGNvbG9yU3BhY2VEYXRhLmdldCgpKSk7CiAg ICAgICAgIGJyZWFrOwogICAgIH0KICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1No YXJlZC9tYWMvQ29sb3JTcGFjZURhdGEubW0gYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9tYWMvQ29s b3JTcGFjZURhdGEubW0KaW5kZXggMzkxYzhkZGY1NDU2ZDQ0ZDEwMTJkMWZmOGIzY2NjMTQxMTFm NzIzMi4uMmNmMDEyNzNkOTNjYzlhZmZkYThkN2IwOTgyM2U1OTIxMThmZDY4NSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9TaGFyZWQvbWFjL0NvbG9yU3BhY2VEYXRhLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL21hYy9Db2xvclNwYWNlRGF0YS5tbQpAQCAtODMsOSArODMsNyBAQCBi b29sIENvbG9yU3BhY2VEYXRhOjpkZWNvZGUoSVBDOjpEZWNvZGVyJiBkZWNvZGVyLCBDb2xvclNw YWNlRGF0YSYgY29sb3JTcGFjZURhdAogICAgICAgICBpZiAoIUlQQzo6ZGVjb2RlKGRlY29kZXIs IGRhdGEpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgIEFMTE9XX0RFUFJF Q0FURURfREVDTEFSQVRJT05TX0JFR0lOCi0gICAgICAgIGNvbG9yU3BhY2VEYXRhLmNnQ29sb3JT cGFjZSA9IGFkb3B0Q0YoQ0dDb2xvclNwYWNlQ3JlYXRlV2l0aElDQ1Byb2ZpbGUoZGF0YS5nZXQo KSkpOwotICAgICAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19FTkQKKyAgICAgICAg Y29sb3JTcGFjZURhdGEuY2dDb2xvclNwYWNlID0gYWRvcHRDRihDR0NvbG9yU3BhY2VDcmVhdGVX aXRoSUNDRGF0YShkYXRhLmdldCgpKSk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIAo=