184334 2018-04-05 11:05:05 -0700 REGRESSION(r228371): WebAutomationSession::deleteAllCookies doesn't delete some cookies 2019-04-24 18:58:01 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 182328 197268 1 bburg bburg bburg cgarcia clopez commit-queue hi mcatanzaro thorton timothy webkit-bug-importer oldest_to_newest 1412104 0 bburg 2018-04-05 11:05:05 -0700 It appears we added a dot to some domain names when adding a cookie via WebDriver API, but we don't try to add the dot back when looking for cookies to delete. 1412105 1 webkit-bug-importer 2018-04-05 11:05:29 -0700 <rdar://problem/39212863> 1412120 2 337284 bburg 2018-04-05 11:53:48 -0700 Created attachment 337284 Patch 1412571 3 337284 commit-queue 2018-04-06 21:08:56 -0700 Comment on attachment 337284 Patch Clearing flags on attachment: 337284 Committed r230367: <https://trac.webkit.org/changeset/230367> 1412572 4 commit-queue 2018-04-06 21:08:57 -0700 All reviewed patches have been landed. Closing bug. 337284 2018-04-05 11:53:48 -0700 2018-04-06 21:08:56 -0700 Patch bug-184334-20180405115348.patch text/plain 4129 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY4ZmNmYmEyODk1ZjRkYTAx OTYyNTgzNDQyYmYwNjZkZDM5MjExYTkuLjBkMzAxNjczYzYyZTg2MjU5NWY3M2Y0NDJkNjNjYWRj ZGZlNzZkODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDQtMDUgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjI4MzcxKTogV2Vi QXV0b21hdGlvblNlc3Npb246OmRlbGV0ZUFsbENvb2tpZXMgZG9lc24ndCBkZWxldGUgc29tZSBj b29raWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODQzMzQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM5MjEyODYzPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gV2ViRHJpdmVyIGFkZHMgYSBj b29raWUgZm9yICdsb2NhbGhvc3QnLCBpdCBhY3R1YWxseSB1c2VzIHRoZSBkb21haW4gJy5sb2Nh bGhvc3QnIHBlciBSRkMuCisgICAgICAgIFdoZW4gZGVsZXRpbmcgY29va2llcywgd2UgZmlyc3Qg ZmV0Y2ggYWxsIGNvb2tpZXMgbWF0Y2hpbmcgdGhlIGRvY3VtZW50J3MgaG9zdG5hbWUsIGFuZAor ICAgICAgICB0aGVuIGRlbGV0ZSB0aGVtIG9uZSBieSBvbmUuIEhvd2V2ZXIsIHRoaXMgY29kZSBw YXRoIGRvZXMgbm90IGFkZCB0aGUgZG90IHByZWZpeC4gVGhpcyBjYXVzZXMKKyAgICAgICAgbm8g Y29va2llcyB0byBtYXRjaCB0aGUgcmVxdWVzdGVkIGRvbWFpbiwgYW5kIHRodXMgbm9uZSBvZiB0 aGVtIGFyZSBkZWxldGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0 b21hdGlvblNlc3Npb24uY3BwOgorICAgICAgICAoV2ViS2l0Ojpkb21haW5CeUFkZGluZ0RvdFBy ZWZpeElmTmVlZGVkKTogRXh0cmFjdCB0aGlzIGhlbHBlciBtZXRob2QuCisgICAgICAgIChXZWJL aXQ6OldlYkF1dG9tYXRpb25TZXNzaW9uOjphZGRTaW5nbGVDb29raWUpOiBVc2UgaGVscGVyIG1l dGhvZC4KKyAgICAgICAgKFdlYktpdDo6V2ViQXV0b21hdGlvblNlc3Npb246OmRlbGV0ZUFsbENv b2tpZXMpOiBBZGQgYSBkb3QgcHJlZml4IHdoZW4KKyAgICAgICAgcmVxdWVzdGluZyB0byBkZWxl dGUgYWxsIGNvb2tpZXMgZm9yIGEgaG9zdG5hbWUuCisKIDIwMTgtMDQtMDUgIFlvdWVubiBGYWJs ZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYlJUQyBkYXRhIGNoYW5uZWwgb25s eSBhcHBsaWNhdGlvbnMgcmVxdWlyZSBjYXB0dXJlIHBlcm1pc3Npb25zIGZvciBkaXJlY3QgY29u bmVjdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1dG9tYXRpb24v V2ViQXV0b21hdGlvblNlc3Npb24uY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21h dGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKaW5kZXggZmRlMmY2YjYxOGZjZmMyYzk5Yzkx OGMzZWMwY2YxNTZlZjA0NjYwMy4uNDg1ZDc1NTc0MTA2YjJmODYwNWVjZWFhZGU4N2MyYzMzZWE4 YjE0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJB dXRvbWF0aW9uU2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21h dGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKQEAgLTEyMDcsNiArMTIwNywxOCBAQCB2b2lk IFdlYkF1dG9tYXRpb25TZXNzaW9uOjpkaWREZWxldGVDb29raWUodWludDY0X3QgY2FsbGJhY2tJ RCwgY29uc3QgU3RyaW5nJiBlcgogICAgIGNhbGxiYWNrLT5zZW5kU3VjY2VzcygpOwogfQogCitz dGF0aWMgU3RyaW5nIGRvbWFpbkJ5QWRkaW5nRG90UHJlZml4SWZOZWVkZWQoU3RyaW5nIGRvbWFp bikKK3sKKyAgICBpZiAoZG9tYWluWzBdICE9ICcuJykgeworICAgICAgICAvLyBSRkMgMjk2NTog SWYgYW4gZXhwbGljaXRseSBzcGVjaWZpZWQgdmFsdWUgZG9lcyBub3Qgc3RhcnQgd2l0aCBhIGRv dCwgdGhlIHVzZXIgYWdlbnQgc3VwcGxpZXMgYSBsZWFkaW5nIGRvdC4KKyAgICAgICAgLy8gQXNz dW1lIHRoYXQgYW55IGhvc3QgdGhhdCBlbmRzIHdpdGggYSBkaWdpdCBpcyB0cnlpbmcgdG8gYmUg YW4gSVAgYWRkcmVzcy4KKyAgICAgICAgaWYgKCFXZWJDb3JlOjpVUkw6Omhvc3RJc0lQQWRkcmVz cyhkb21haW4pKQorICAgICAgICAgICAgcmV0dXJuIG1ha2VTdHJpbmcoJy4nLCBkb21haW4pOwor ICAgIH0KKyAgICAKKyAgICByZXR1cm4gZG9tYWluOworfQorICAgIAogdm9pZCBXZWJBdXRvbWF0 aW9uU2Vzc2lvbjo6YWRkU2luZ2xlQ29va2llKGNvbnN0IFN0cmluZyYgYnJvd3NpbmdDb250ZXh0 SGFuZGxlLCBjb25zdCBKU09OOjpPYmplY3QmIGNvb2tpZU9iamVjdCwgUmVmPEFkZFNpbmdsZUNv b2tpZUNhbGxiYWNrPiYmIGNhbGxiYWNrKQogewogICAgIFdlYlBhZ2VQcm94eSogcGFnZSA9IHdl YlBhZ2VQcm94eUZvckhhbmRsZShicm93c2luZ0NvbnRleHRIYW5kbGUpOwpAQCAtMTIzMSwxMyAr MTI0Myw4IEBAIHZvaWQgV2ViQXV0b21hdGlvblNlc3Npb246OmFkZFNpbmdsZUNvb2tpZShjb25z dCBTdHJpbmcmIGJyb3dzaW5nQ29udGV4dEhhbmRsZSwKICAgICAvLyBJbmhlcml0IHRoZSBkb21h aW4vaG9zdCBmcm9tIHRoZSBtYWluIGZyYW1lJ3MgVVJMIGlmIGl0IGlzIG5vdCBleHBsaWNpdGx5 IHNldC4KICAgICBpZiAoZG9tYWluLmlzRW1wdHkoKSkKICAgICAgICAgZG9tYWluID0gYWN0aXZl VVJMLmhvc3QoKTsKLSAgICBlbHNlIGlmIChkb21haW5bMF0gIT0gJy4nKSB7Ci0gICAgICAgIC8v IFJGQyAyOTY1OiBJZiBhbiBleHBsaWNpdGx5IHNwZWNpZmllZCB2YWx1ZSBkb2VzIG5vdCBzdGFy dCB3aXRoIGEgZG90LCB0aGUgdXNlciBhZ2VudCBzdXBwbGllcyBhIGxlYWRpbmcgZG90LgotICAg ICAgICAvLyBBc3N1bWUgdGhhdCBhbnkgaG9zdCB0aGF0IGVuZHMgd2l0aCBhIGRpZ2l0IGlzIHRy eWluZyB0byBiZSBhbiBJUCBhZGRyZXNzLgotICAgICAgICBpZiAoIVdlYkNvcmU6OlVSTDo6aG9z dElzSVBBZGRyZXNzKGRvbWFpbikpCi0gICAgICAgICAgICBkb21haW4gPSBtYWtlU3RyaW5nKCcu JywgZG9tYWluKTsKLSAgICB9Ci0gICAgY29va2llLmRvbWFpbiA9IGRvbWFpbjsKKworICAgIGNv b2tpZS5kb21haW4gPSBkb21haW5CeUFkZGluZ0RvdFByZWZpeElmTmVlZGVkKGRvbWFpbik7CiAK ICAgICBpZiAoIWNvb2tpZU9iamVjdC5nZXRTdHJpbmcoV1RGOjpBU0NJSUxpdGVyYWwoInBhdGgi KSwgY29va2llLnBhdGgpKQogICAgICAgICBBU1lOQ19GQUlMX1dJVEhfUFJFREVGSU5FRF9FUlJP Ul9BTkRfREVUQUlMUyhNaXNzaW5nUGFyYW1ldGVyLCAiVGhlIHBhcmFtZXRlciAncGF0aCcgd2Fz IG5vdCBmb3VuZC4iKTsKQEAgLTEyNzksNyArMTI4Niw3IEBAIHZvaWQgV2ViQXV0b21hdGlvblNl c3Npb246OmRlbGV0ZUFsbENvb2tpZXMoRXJyb3JTdHJpbmcmIGVycm9yU3RyaW5nLCBjb25zdCBT dHJpCiAgICAgQVNTRVJUKGFjdGl2ZVVSTC5pc1ZhbGlkKCkpOwogCiAgICAgV2ViQ29va2llTWFu YWdlclByb3h5KiBjb29raWVNYW5hZ2VyID0gbV9wcm9jZXNzUG9vbC0+c3VwcGxlbWVudDxXZWJD b29raWVNYW5hZ2VyUHJveHk+KCk7Ci0gICAgY29va2llTWFuYWdlci0+ZGVsZXRlQ29va2llc0Zv ckhvc3RuYW1lKHBhZ2UtPndlYnNpdGVEYXRhU3RvcmUoKS5zZXNzaW9uSUQoKSwgYWN0aXZlVVJM Lmhvc3QoKSk7CisgICAgY29va2llTWFuYWdlci0+ZGVsZXRlQ29va2llc0Zvckhvc3RuYW1lKHBh Z2UtPndlYnNpdGVEYXRhU3RvcmUoKS5zZXNzaW9uSUQoKSwgZG9tYWluQnlBZGRpbmdEb3RQcmVm aXhJZk5lZWRlZChhY3RpdmVVUkwuaG9zdCgpKSk7CiB9CiAKIHZvaWQgV2ViQXV0b21hdGlvblNl c3Npb246OmdldFNlc3Npb25QZXJtaXNzaW9ucyhFcnJvclN0cmluZyYsIFJlZlB0cjxKU09OOjpB cnJheU9mPEluc3BlY3Rvcjo6UHJvdG9jb2w6OkF1dG9tYXRpb246OlNlc3Npb25QZXJtaXNzaW9u RGF0YT4+JiBvdXRfcGVybWlzc2lvbnMpCg==