<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>184320</bug_id>
          
          <creation_ts>2018-04-04 16:40:08 -0700</creation_ts>
          <short_desc>WebCore::LocalDefaultSystemAppearance talks to NSApp</short_desc>
          <delta_ts>2018-04-19 13:09:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=184322</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>pvollan</cc>
    
    <cc>timothy</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1411939</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-04-04 16:40:08 -0700</bug_when>
    <thetext>WebCore::LocalDefaultSystemAppearance talks to NSApp to get information about the current system appearance (colors, fonts, etc.). This code path is getting hit while computing styles in the WebContent process.

It would be nice if we could either broker these calls to the UIProcess, or perhaps cache these values on the WebProcess side, updating when user settings change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1411940</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-04-04 16:40:39 -0700</bug_when>
    <thetext>&lt;rdar://problem/39193372&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1416033</commentid>
    <comment_count>2</comment_count>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2018-04-19 13:09:54 -0700</bug_when>
    <thetext>We do cache the system colors, for each color, when it is not in the cache yet. The cache is cleared when the user appearance settings change.

https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/rendering/RenderThemeMac.mm#L453</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>