184301 2018-04-04 06:56:32 -0700 Enable Gigacage unconditionally when building JSCOnly on macOS (build fix) 2018-04-04 08:02:19 -0700 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 annulen annulen commit-queue ggaren jfbastien webkit-bug-importer ysuzuki oldest_to_newest 1411704 0 annulen 2018-04-04 06:56:32 -0700 bmalloc/ProcessCheck.mm implements specific behavior for Mac and iOS ports, which is guarded with BPLATFORM(COCOA). We should not enable BPLATFORM(MAC) or BPLATFORM(IOS) in JSCOnly, then BPLATFORM(COCOA) won't be defined as well, and code path from ProcessCheck.mm will not be taken 1411705 1 337162 annulen 2018-04-04 07:00:56 -0700 Created attachment 337162 Patch 1411706 2 337162 ysuzuki 2018-04-04 07:02:19 -0700 Comment on attachment 337162 Patch r=me 1411707 3 annulen 2018-04-04 07:03:06 -0700 Should fix GTK/macOS too. 1411708 4 337163 annulen 2018-04-04 07:17:05 -0700 Created attachment 337163 Patch 1411709 5 annulen 2018-04-04 07:17:32 -0700 Now it should actually fix GTK/macOS 1411713 6 337163 ysuzuki 2018-04-04 07:28:48 -0700 Comment on attachment 337163 Patch r=me since Mac does not have maintained CMake port right now. 1411714 7 annulen 2018-04-04 07:31:20 -0700 Note that I've defined BPLATFORM_MAC in PlatformMac, so it should not make things worse for Mac/CMake 1411718 8 annulen 2018-04-04 08:00:29 -0700 Committed r230255: <https://trac.webkit.org/changeset/230255> 1411719 9 webkit-bug-importer 2018-04-04 08:02:19 -0700 <rdar://problem/39174671> 337162 2018-04-04 07:00:56 -0700 2018-04-04 07:17:02 -0700 Patch bug-184301-20180404170054.patch text/plain 2712 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggN2EyNDVmMjQzMTkxNzAw OGE5MWIwZDc3YmNkYjFlMGQyZDM3ZmE5Ny4uOWMyZWIyNDU3OTIyOGMxNjYwMDAwZTlmZjE2OTNi YWEzN2ZhNzEzOSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA0LTA0ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBFbmFibGUgR2ln YWNhZ2UgdW5jb25kaXRpb25hbGx5IHdoZW4gYnVpbGRpbmcgSlNDT25seSBvbiBtYWNPUyAoYnVp bGQgZml4KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTg0MzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Ym1hbGxvYy9Qcm9jZXNzQ2hlY2subW0gaW1wbGVtZW50cyBzcGVjaWZpYyBiZWhhdmlvciBmb3Ig TWFjIGFuZCBpT1MgcG9ydHMsCisgICAgICAgIHdoaWNoIGlzIGd1YXJkZWQgd2l0aCBCUExBVEZP Uk0oQ09DT0EpLiBpZiB3ZSBkb24ndCBlbmFibGUgQlBMQVRGT1JNKE1BQykKKyAgICAgICAgb3Ig QlBMQVRGT1JNKElPUykgaW4gSlNDT25seSwgdGhlbiBCUExBVEZPUk0oQ09DT0EpIHdvbid0IGJl IGRlZmluZWQKKyAgICAgICAgYXMgd2VsbCwgYW5kIGNvZGUgcGF0aCBmcm9tIFByb2Nlc3NDaGVj ay5tbSB3aWxsIG5vdCBiZSB0YWtlbi4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OiBFeGNs dWRlIFByb2Nlc3NDaGVjay5tbSBmcm9tIHBvcnQtaW5kZXBlbmRlbnQgZmlsZQorICAgICAgICBs aXN0LgorICAgICAgICAqIFBsYXRmb3JtTWFjLmNtYWtlOiBCdWlsZCBQcm9jZXNzQ2hlY2subW0g Zm9yIE1hYyBwb3J0LgorICAgICAgICAqIGJtYWxsb2MvQlBsYXRmb3JtLmg6IERvbid0IGVuYWJs ZSBCUExBVEZPUk0oTUFDKSBvciBCUExBVEZPUk0oSU9TKQorICAgICAgICB3aGVuIGJ1aWxkaW5n IEpTQ09ubHkgcG9ydC4KKwogMjAxOC0wNC0wMyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxl LmNvbT4KIAogICAgICAgICB0b3RhbFBoeXNpY2FsU2l6ZSBjYWxjdWxhdGlvbiB3aGVuIHNwbGl0 dGluZyBhIHJhbmdlIG11c3QgYWNjb3VudCBmb3IgZG91YmxlIHJvdW5kaW5nIGVmZmVjdHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL2JtYWxsb2Mv Q01ha2VMaXN0cy50eHQKaW5kZXggYTE2NDlhYmVjNDVkNDRlNDBmYTZhMWVhZjM3MDk2MzRiOTMy YWEwMy4uYjgxNjEwYzVlM2YyZDdmYTUzYzUwMDhkN2UyMDAzMDEzZDMzZjA0NiAxMDA2NDQKLS0t IGEvU291cmNlL2JtYWxsb2MvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL2JtYWxsb2MvQ01h a2VMaXN0cy50eHQKQEAgLTM1LDcgKzM1LDYgQEAgc2V0KGJtYWxsb2NfU09VUkNFUwogCiBpZiAo Q01BS0VfU1lTVEVNX05BTUUgTUFUQ0hFUyAiRGFyd2luIikKICAgICBsaXN0KEFQUEVORCBibWFs bG9jX1NPVVJDRVMKLSAgICAgICAgYm1hbGxvYy9Qcm9jZXNzQ2hlY2subW0KICAgICAgICAgYm1h bGxvYy9ab25lLmNwcAogICAgICkKIGVuZGlmICgpCkBAIC00NCw2ICs0Myw4IEBAIHNldChibWFs bG9jX0xJQlJBUklFUwogICAgICR7Q01BS0VfRExfTElCU30KICkKIAorV0VCS0lUX0lOQ0xVREVf Q09ORklHX0ZJTEVTX0lGX0VYSVNUUygpCisKIFdFQktJVF9XUkFQX1NPVVJDRUxJU1QoJHtibWFs bG9jX1NPVVJDRVN9KQogaW5jbHVkZV9kaXJlY3Rvcmllcygke2JtYWxsb2NfSU5DTFVERV9ESVJF Q1RPUklFU30pCiBhZGRfbGlicmFyeShibWFsbG9jIFNUQVRJQyAke2JtYWxsb2NfU09VUkNFU30p CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9QbGF0Zm9ybU1hYy5jbWFrZSBiL1NvdXJjZS9i bWFsbG9jL1BsYXRmb3JtTWFjLmNtYWtlCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmNlOWUwZDk5YWUxZTVmOGRhMTky N2UzNDM4YjVlMWJlNjcyYjBhZWMKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvYm1hbGxvYy9Q bGF0Zm9ybU1hYy5jbWFrZQpAQCAtMCwwICsxLDMgQEAKK2xpc3QoQVBQRU5EIGJtYWxsb2NfU09V UkNFUworICAgIGJtYWxsb2MvUHJvY2Vzc0NoZWNrLm1tCispCmRpZmYgLS1naXQgYS9Tb3VyY2Uv Ym1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9CUGxh dGZvcm0uaAppbmRleCA1YWVmYTA1MWUyYTdkOTZkODM4ODRlODljMDI0ZTc4MDE0MmQ4ZTU0Li43 NDJiZWM5OWU4YmVkYmVmYThmZGIyNWUxYjEwM2VhOTA3MjBkMjgxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvYm1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxs b2MvQlBsYXRmb3JtLmgKQEAgLTUyLDcgKzUyLDcgQEAKICNkZWZpbmUgQk9TX1dJTkRPV1MgMQog I2VuZGlmCiAKLSNpZiBCT1MoREFSV0lOKQorI2lmIEJPUyhEQVJXSU4pICYmICFkZWZpbmVkKEJV SUxESU5HX0pTQ09OTFlfXykKICNpZiBUQVJHRVRfT1NfSVBIT05FCiAjZGVmaW5lIEJQTEFURk9S TV9JT1MgMQogI2lmIFRBUkdFVF9PU19TSU1VTEFUT1IK 337163 2018-04-04 07:17:05 -0700 2018-04-04 07:55:37 -0700 Patch bug-184301-20180404171704.patch text/plain 2751 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggN2EyNDVmMjQzMTkxNzAw OGE5MWIwZDc3YmNkYjFlMGQyZDM3ZmE5Ny4uOWMyZWIyNDU3OTIyOGMxNjYwMDAwZTlmZjE2OTNi YWEzN2ZhNzEzOSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA0LTA0ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBFbmFibGUgR2ln YWNhZ2UgdW5jb25kaXRpb25hbGx5IHdoZW4gYnVpbGRpbmcgSlNDT25seSBvbiBtYWNPUyAoYnVp bGQgZml4KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTg0MzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Ym1hbGxvYy9Qcm9jZXNzQ2hlY2subW0gaW1wbGVtZW50cyBzcGVjaWZpYyBiZWhhdmlvciBmb3Ig TWFjIGFuZCBpT1MgcG9ydHMsCisgICAgICAgIHdoaWNoIGlzIGd1YXJkZWQgd2l0aCBCUExBVEZP Uk0oQ09DT0EpLiBpZiB3ZSBkb24ndCBlbmFibGUgQlBMQVRGT1JNKE1BQykKKyAgICAgICAgb3Ig QlBMQVRGT1JNKElPUykgaW4gSlNDT25seSwgdGhlbiBCUExBVEZPUk0oQ09DT0EpIHdvbid0IGJl IGRlZmluZWQKKyAgICAgICAgYXMgd2VsbCwgYW5kIGNvZGUgcGF0aCBmcm9tIFByb2Nlc3NDaGVj ay5tbSB3aWxsIG5vdCBiZSB0YWtlbi4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OiBFeGNs dWRlIFByb2Nlc3NDaGVjay5tbSBmcm9tIHBvcnQtaW5kZXBlbmRlbnQgZmlsZQorICAgICAgICBs aXN0LgorICAgICAgICAqIFBsYXRmb3JtTWFjLmNtYWtlOiBCdWlsZCBQcm9jZXNzQ2hlY2subW0g Zm9yIE1hYyBwb3J0LgorICAgICAgICAqIGJtYWxsb2MvQlBsYXRmb3JtLmg6IERvbid0IGVuYWJs ZSBCUExBVEZPUk0oTUFDKSBvciBCUExBVEZPUk0oSU9TKQorICAgICAgICB3aGVuIGJ1aWxkaW5n IEpTQ09ubHkgcG9ydC4KKwogMjAxOC0wNC0wMyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxl LmNvbT4KIAogICAgICAgICB0b3RhbFBoeXNpY2FsU2l6ZSBjYWxjdWxhdGlvbiB3aGVuIHNwbGl0 dGluZyBhIHJhbmdlIG11c3QgYWNjb3VudCBmb3IgZG91YmxlIHJvdW5kaW5nIGVmZmVjdHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL2JtYWxsb2Mv Q01ha2VMaXN0cy50eHQKaW5kZXggYTE2NDlhYmVjNDVkNDRlNDBmYTZhMWVhZjM3MDk2MzRiOTMy YWEwMy4uYjgxNjEwYzVlM2YyZDdmYTUzYzUwMDhkN2UyMDAzMDEzZDMzZjA0NiAxMDA2NDQKLS0t IGEvU291cmNlL2JtYWxsb2MvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL2JtYWxsb2MvQ01h a2VMaXN0cy50eHQKQEAgLTM1LDcgKzM1LDYgQEAgc2V0KGJtYWxsb2NfU09VUkNFUwogCiBpZiAo Q01BS0VfU1lTVEVNX05BTUUgTUFUQ0hFUyAiRGFyd2luIikKICAgICBsaXN0KEFQUEVORCBibWFs bG9jX1NPVVJDRVMKLSAgICAgICAgYm1hbGxvYy9Qcm9jZXNzQ2hlY2subW0KICAgICAgICAgYm1h bGxvYy9ab25lLmNwcAogICAgICkKIGVuZGlmICgpCkBAIC00NCw2ICs0Myw4IEBAIHNldChibWFs bG9jX0xJQlJBUklFUwogICAgICR7Q01BS0VfRExfTElCU30KICkKIAorV0VCS0lUX0lOQ0xVREVf Q09ORklHX0ZJTEVTX0lGX0VYSVNUUygpCisKIFdFQktJVF9XUkFQX1NPVVJDRUxJU1QoJHtibWFs bG9jX1NPVVJDRVN9KQogaW5jbHVkZV9kaXJlY3Rvcmllcygke2JtYWxsb2NfSU5DTFVERV9ESVJF Q1RPUklFU30pCiBhZGRfbGlicmFyeShibWFsbG9jIFNUQVRJQyAke2JtYWxsb2NfU09VUkNFU30p CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9QbGF0Zm9ybU1hYy5jbWFrZSBiL1NvdXJjZS9i bWFsbG9jL1BsYXRmb3JtTWFjLmNtYWtlCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmM1M2M0OGU2YjM3Y2FmZDJjZjJi OTk1NDE2ZDhlMzdlMTY3M2Q0YzcKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvYm1hbGxvYy9Q bGF0Zm9ybU1hYy5jbWFrZQpAQCAtMCwwICsxLDUgQEAKK2FkZF9kZWZpbml0aW9ucygtREJQTEFU Rk9STV9NQUM9MSkKKworbGlzdChBUFBFTkQgYm1hbGxvY19TT1VSQ0VTCisgICAgYm1hbGxvYy9Q cm9jZXNzQ2hlY2subW0KKykKZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQlBs YXRmb3JtLmggYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oCmluZGV4IDVhZWZh MDUxZTJhN2Q5NmQ4Mzg4NGU4OWMwMjRlNzgwMTQyZDhlNTQuLjAyODYyM2UwYjdlYTRmZmQ4ZGQ5 YWJlNDM3MzVkYjViNzc5NTA5NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2Mv QlBsYXRmb3JtLmgKKysrIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9CUGxhdGZvcm0uaApAQCAt NTIsNyArNTIsNyBAQAogI2RlZmluZSBCT1NfV0lORE9XUyAxCiAjZW5kaWYKIAotI2lmIEJPUyhE QVJXSU4pCisjaWYgQk9TKERBUldJTikgJiYgIWRlZmluZWQoQlVJTERJTkdfV0lUSF9DTUFLRSkK ICNpZiBUQVJHRVRfT1NfSVBIT05FCiAjZGVmaW5lIEJQTEFURk9STV9JT1MgMQogI2lmIFRBUkdF VF9PU19TSU1VTEFUT1IK