184293 2018-04-04 02:17:22 -0700 REGRESSION(r229831): Test WebKit2.ProvisionalURLAfterWillSendRequestCallback times out since r229831 2018-04-05 02:02:54 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 cgarcia webkit-unassigned achristensen bugs-noreply cdumez mcatanzaro webkit-bug-importer oldest_to_newest 1411678 0 cgarcia 2018-04-04 02:17:22 -0700 The problem is that after willSendRequest callback changes the request, the load is cancelled while transitioning to committed state. This happens because the load is not waiting for the response policy check, so it continues and when transitioning to committed, FrameLoader::closeURL() invalidates the current policy check that causes a load failure. The new request returned by the API doesn't have any requester, so it's no longer considered a main resource load. In the network process the resource load task doesn't wait for the response policy and continues the load, sending the data to the web process. Once the first data is received the load transitions to commit, but the response policy check is still ongoing. This can only happen when using the C API (I don't know about the Cocoa API), but not with the GLib API because it doesn't allow to create a new request, only to modify the passed in one. With the C API we loss other internal things of the request like the priority, but I guess the most important one is the requester. 1411679 1 337153 cgarcia 2018-04-04 02:24:58 -0700 Created attachment 337153 Patch 1411765 2 337153 achristensen 2018-04-04 10:09:00 -0700 Comment on attachment 337153 Patch We should probably run that API test on Mac, too. 1411772 3 mcatanzaro 2018-04-04 10:19:29 -0700 (In reply to Alex Christensen from comment #2) > Comment on attachment 337153 [details] > Patch > > We should probably run that API test on Mac, too. Right now, I believe we have a bunch of cross-platform API tests that are run only with XCode, when most of them should really be run on all ports. I did not realize that the reverse was true as well. It would be good to comprehensively improve this situation. 1412025 4 cgarcia 2018-04-05 01:44:30 -0700 (In reply to Alex Christensen from comment #2) > Comment on attachment 337153 [details] > Patch > > We should probably run that API test on Mac, too. Indeed, I was surprised it was still prefixed WebKit2, then I realized it was because it's not run in Mac. We should rename it and add it to xcode in a follow up, but I prefer if someone with a mac can do it, it's painful process for me. 1412029 5 cgarcia 2018-04-05 02:01:37 -0700 Committed r230298: <https://trac.webkit.org/changeset/230298> 1412031 6 webkit-bug-importer 2018-04-05 02:02:54 -0700 <rdar://problem/39202609> 337153 2018-04-04 02:24:58 -0700 2018-04-04 10:09:00 -0700 Patch wk2-will-send-request-requester.diff text/plain 2918 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNmQ3ODY0OTZkYTQuLmJlM2MzYzdiNjlmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDI0IEBACisyMDE4LTA0LTA0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMjk4MzEpOiBUZXN0IFdlYktpdDIuUHJvdmlz aW9uYWxVUkxBZnRlcldpbGxTZW5kUmVxdWVzdENhbGxiYWNrIHRpbWVzIG91dCBzaW5jZSByMjI5 ODMxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQy OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg cHJvYmxlbSBpcyB0aGF0IGFmdGVyIHdpbGxTZW5kUmVxdWVzdCBjYWxsYmFjayBjaGFuZ2VzIHRo ZSByZXF1ZXN0LCB0aGUgbG9hZCBpcyBjYW5jZWxsZWQgd2hpbGUKKyAgICAgICAgdHJhbnNpdGlv bmluZyB0byBjb21taXR0ZWQgc3RhdGUuIFRoaXMgaGFwcGVucyBiZWNhdXNlIHRoZSBsb2FkIGlz IG5vdCB3YWl0aW5nIGZvciB0aGUgcmVzcG9uc2UgcG9saWN5IGNoZWNrLCBzbworICAgICAgICBp dCBjb250aW51ZXMgYW5kIHdoZW4gdHJhbnNpdGlvbmluZyB0byBjb21taXR0ZWQsIEZyYW1lTG9h ZGVyOjpjbG9zZVVSTCgpIGludmFsaWRhdGVzIHRoZSBjdXJyZW50IHBvbGljeSBjaGVjaworICAg ICAgICB0aGF0IGNhdXNlcyBhIGxvYWQgZmFpbHVyZS4gVGhlIG5ldyByZXF1ZXN0IHJldHVybmVk IGJ5IHRoZSBBUEkgZG9lc24ndCBoYXZlIGFueSByZXF1ZXN0ZXIsIHNvIGl0J3Mgbm8gbG9uZ2Vy CisgICAgICAgIGNvbnNpZGVyZWQgYSBtYWluIHJlc291cmNlIGxvYWQuIEluIHRoZSBuZXR3b3Jr IHByb2Nlc3MgdGhlIHJlc291cmNlIGxvYWQgdGFzayBkb2Vzbid0IHdhaXQgZm9yIHRoZSByZXNw b25zZQorICAgICAgICBwb2xpY3kgYW5kIGNvbnRpbnVlcyB0aGUgbG9hZCwgc2VuZGluZyB0aGUg ZGF0YSB0byB0aGUgd2ViIHByb2Nlc3MuIE9uY2UgdGhlIGZpcnN0IGRhdGEgaXMgcmVjZWl2ZWQs IHRoZSBsb2FkCisgICAgICAgIHRyYW5zaXRpb25zIHRvIGNvbW1pdCwgYnV0IHRoZSByZXNwb25z ZSBwb2xpY3kgY2hlY2sgaXMgc3RpbGwgb25nb2luZy4gVGhpcyBjYW4gb25seSBoYXBwZW4gd2hl biB1c2luZyB0aGUgQyBBUEkKKyAgICAgICAgKEkgZG9uJ3Qga25vdyBhYm91dCB0aGUgQ29jb2Eg QVBJKSwgYnV0IG5vdCB3aXRoIHRoZSBHTGliIEFQSSBiZWNhdXNlIGl0IGRvZXNuJ3QgYWxsb3cg dG8gY3JlYXRlIGEgbmV3IHJlcXVlc3QsCisgICAgICAgIG9ubHkgdG8gbW9kaWZ5IHRoZSBwYXNz ZWQgaW4gb25lLiBXaXRoIHRoZSBDIEFQSSB3ZSBsb3NzIG90aGVyIGludGVybmFsIHRoaW5ncyBv ZiB0aGUgcmVxdWVzdCBsaWtlIHRoZSBwcmlvcml0eSwKKyAgICAgICAgYnV0IEkgZ3Vlc3MgdGhl IG1vc3QgaW1wb3J0YW50IG9uZSBpcyB0aGUgcmVxdWVzdGVyLgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaFdpbGxTZW5kUmVxdWVzdCk6CisK IDIwMTgtMDQtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6ICFtX21haW5GcmFtZS0+Y29yZUZyYW1lKCktPmxv YWRlcigpLmZyYW1lSGFzTG9hZGVkKCkgfHwgIW1fcGVuZGluZ05hdmlnYXRpb25JRCB3aGVuIHJl bG9hZGluZyBwYWdlIHdoaWxlIGEgcGFnZSBpcyBsb2FkaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3Bw IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVy Q2xpZW50LmNwcAppbmRleCAxZTJhOTJmY2NjZC4uYTBmOGQ4Njc0NDkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVu dC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZy YW1lTG9hZGVyQ2xpZW50LmNwcApAQCAtMjA4LDcgKzIwOCwxMiBAQCB2b2lkIFdlYkZyYW1lTG9h ZGVyQ2xpZW50OjpkaXNwYXRjaFdpbGxTZW5kUmVxdWVzdChEb2N1bWVudExvYWRlciosIHVuc2ln bmVkIGxvbgogICAgIGlmICghd2ViUGFnZSkKICAgICAgICAgcmV0dXJuOwogCisgICAgLy8gVGhl IEFQSSBjYW4gcmV0dXJuIGEgY29tcGxldGVseSBuZXcgcmVxdWVzdC4gV2Ugc2hvdWxkIGVuc3Vy ZSB0aGF0IGF0IGxlYXN0IHRoZSByZXF1ZXN0ZXIKKyAgICAvLyBpcyBrZXB0LCBzbyB0aGF0IGlm IHRoaXMgaXMgYSBtYWluIHJlc291cmNlIGxvYWQgaXQncyBzdGlsbCBjb25zaWRlcmVkIGFzIHN1 Y2guCisgICAgYXV0byByZXF1ZXN0ZXIgPSByZXF1ZXN0LnJlcXVlc3RlcigpOwogICAgIHdlYlBh Z2UtPmluamVjdGVkQnVuZGxlUmVzb3VyY2VMb2FkQ2xpZW50KCkud2lsbFNlbmRSZXF1ZXN0Rm9y RnJhbWUoKndlYlBhZ2UsICptX2ZyYW1lLCBpZGVudGlmaWVyLCByZXF1ZXN0LCByZWRpcmVjdFJl c3BvbnNlKTsKKyAgICBpZiAoIXJlcXVlc3QuaXNOdWxsKCkpCisgICAgICAgIHJlcXVlc3Quc2V0 UmVxdWVzdGVyKHJlcXVlc3Rlcik7CiB9CiAKIGJvb2wgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OnNo b3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdlKERvY3VtZW50TG9hZGVyKiwgdW5zaWduZWQgbG9uZyBp ZGVudGlmaWVyKQo=