184275 2018-04-03 12:04:19 -0700 totalPhysicalSize calculation when splitting a range must account for double rounding effects 2018-04-03 13:42:25 -0700 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin ews-watchlist fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ryanhaddad ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1411509 0 saam 2018-04-03 12:04:19 -0700 ... 1411511 1 337100 saam 2018-04-03 12:16:45 -0700 Created attachment 337100 patch 1411512 2 ews-watchlist 2018-04-03 12:17:55 -0700 Attachment 337100 did not pass style-queue: ERROR: Source/bmalloc/bmalloc/LargeRange.h:137: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1411513 3 337100 mark.lam 2018-04-03 12:19:58 -0700 Comment on attachment 337100 patch View in context: https://bugs.webkit.org/attachment.cgi?id=337100&action=review I see. When you detect the rounding error, you re-attribute the error back over to the left side. r=me. > Source/bmalloc/ChangeLog:10 > + rounding may cause the left size to loose a byte, and the right typo: /loose/lose/. 1411552 4 saam 2018-04-03 13:41:57 -0700 landed in: https://trac.webkit.org/changeset/230222/webkit 1411553 5 webkit-bug-importer 2018-04-03 13:42:25 -0700 <rdar://problem/39152668> 337100 2018-04-03 12:16:45 -0700 2018-04-03 12:19:58 -0700 patch c-backup.diff text/plain 2443 saam SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMDIxNikKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA0LTAzICBTYWFtIEJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIHRvdGFsUGh5c2ljYWxTaXplIGNh bGN1bGF0aW9uIHdoZW4gc3BsaXR0aW5nIGEgcmFuZ2UgbXVzdCBhY2NvdW50IGZvciBkb3VibGUg cm91bmRpbmcgZWZmZWN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg0Mjc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIHJvdW5kaW5nIGVycm9yIGNvdWxkIGhhcHBlbiB3aGVuIHdlIHNwbGl0IGEg cmFuZ2Ugd2hlcmUgdGhlCisgICAgICAgIHJhbmdlJ3MgdG90YWwgcGh5c2ljYWwgc2l6ZSBlcXVh bHMgdGhlIHJhbmdlJ3MgdG90YWwgc2l6ZS4gVGhlCisgICAgICAgIHJvdW5kaW5nIG1heSBjYXVz ZSB0aGUgbGVmdCBzaXplIHRvIGxvb3NlIGEgYnl0ZSwgYW5kIHRoZSByaWdodAorICAgICAgICBz aXplIHRvIGdhaW4gYSBieXRlLiBUaGlzIGNhdXNlZCB0aGUgcmlnaHQgc2lkZSB0byBiZSBhIGJ5 dGUKKyAgICAgICAgbGFyZ2UgdGhhbiBpdHMgc2l6ZS4KKworICAgICAgICAqIGJtYWxsb2MvTGFy Z2VSYW5nZS5oOgorICAgICAgICAoYm1hbGxvYzo6TGFyZ2VSYW5nZTo6TGFyZ2VSYW5nZSk6Cisg ICAgICAgIChibWFsbG9jOjpMYXJnZVJhbmdlOjpzcGxpdCBjb25zdCk6CisKIDIwMTgtMDQtMDIg IFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgYm1hbGxvYyBzaG91 bGQgY29tcHV0ZSBpdHMgb3duIGVzdGltYXRlIG9mIGl0cyBmb290cHJpbnQKSW5kZXg6IFNvdXJj ZS9ibWFsbG9jL2JtYWxsb2MvTGFyZ2VSYW5nZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFs bG9jL2JtYWxsb2MvTGFyZ2VSYW5nZS5oCShyZXZpc2lvbiAyMzAyMTYpCisrKyBTb3VyY2UvYm1h bGxvYy9ibWFsbG9jL0xhcmdlUmFuZ2UuaAkod29ya2luZyBjb3B5KQpAQCAtNDUsNyArNDUsNyBA QCBwdWJsaWM6CiAgICAgICAgICwgbV9zdGFydFBoeXNpY2FsU2l6ZShzdGFydFBoeXNpY2FsU2l6 ZSkKICAgICAgICAgLCBtX3RvdGFsUGh5c2ljYWxTaXplKHRvdGFsUGh5c2ljYWxTaXplKQogICAg IHsKLSAgICAgICAgQkFTU0VSVChzaXplKCkgPj0gdGhpcy0+dG90YWxQaHlzaWNhbFNpemUoKSk7 CisgICAgICAgIEJBU1NFUlQodGhpcy0+c2l6ZSgpID49IHRoaXMtPnRvdGFsUGh5c2ljYWxTaXpl KCkpOwogICAgICAgICBCQVNTRVJUKHRoaXMtPnRvdGFsUGh5c2ljYWxTaXplKCkgPj0gdGhpcy0+ c3RhcnRQaHlzaWNhbFNpemUoKSk7CiAgICAgfQogCkBAIC0xMzEsOCArMTMxLDE0IEBAIGlubGlu ZSBzdGQ6OnBhaXI8TGFyZ2VSYW5nZSwgTGFyZ2VSYW5nZT4KIAogICAgIGRvdWJsZSByYXRpbyA9 IHN0YXRpY19jYXN0PGRvdWJsZT4obGVmdFNpemUpIC8gc3RhdGljX2Nhc3Q8ZG91YmxlPih0aGlz LT5zaXplKCkpOwogICAgIHNpemVfdCBsZWZ0VG90YWxQaHlzaWNhbFNpemUgPSBzdGF0aWNfY2Fz dDxzaXplX3Q+KHJhdGlvICogdG90YWxQaHlzaWNhbFNpemUoKSk7CisgICAgQkFTU0VSVChsZWZ0 VG90YWxQaHlzaWNhbFNpemUgPD0gbGVmdFNpemUpOwogICAgIGxlZnRUb3RhbFBoeXNpY2FsU2l6 ZSA9IHN0ZDo6bWF4KHN0YXJ0UGh5c2ljYWxTaXplKCksIGxlZnRUb3RhbFBoeXNpY2FsU2l6ZSk7 CiAgICAgc2l6ZV90IHJpZ2h0VG90YWxQaHlzaWNhbFNpemUgPSB0b3RhbFBoeXNpY2FsU2l6ZSgp IC0gbGVmdFRvdGFsUGh5c2ljYWxTaXplOworICAgIGlmIChyaWdodFRvdGFsUGh5c2ljYWxTaXpl ID4gcmlnaHRTaXplKSB7IC8vIFRoaXMgbWF5IGhhcHBlbiBiZWNhdXNlIG9mIHJvdW5kaW5nLgor ICAgICAgICBsZWZ0VG90YWxQaHlzaWNhbFNpemUgKz0gcmlnaHRUb3RhbFBoeXNpY2FsU2l6ZSAt IHJpZ2h0U2l6ZTsKKyAgICAgICAgQkFTU0VSVChsZWZ0VG90YWxQaHlzaWNhbFNpemUgPD0gbGVm dFNpemUpOworICAgICAgICByaWdodFRvdGFsUGh5c2ljYWxTaXplID0gcmlnaHRTaXplOworICAg IH0KIAogICAgIExhcmdlUmFuZ2UgbGVmdChiZWdpbigpLCBsZWZ0U2l6ZSwgc3RhcnRQaHlzaWNh bFNpemUoKSwgbGVmdFRvdGFsUGh5c2ljYWxTaXplKTsKICAgICBMYXJnZVJhbmdlIHJpZ2h0KGxl ZnQuZW5kKCksIHJpZ2h0U2l6ZSwgMCwgcmlnaHRUb3RhbFBoeXNpY2FsU2l6ZSk7Cg==