184267 2018-04-03 10:00:04 -0700 Array.prototype.concat with Proxy 2020-05-08 17:02:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore Safari 11 Mac macOS 10.13 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211643 InRadar P2 Normal --- 1 p.dartus caitp caitp commit-queue erights ews-watchlist joepeck keith_miller mark.lam msaboff realdawei saam sunlili webkit-bug-importer ysuzuki oldest_to_newest 1411436 0 p.dartus 2018-04-03 10:00:04 -0700 **Step to reproduce:** const proxy = new Proxy([3, 4], {}); const res = [1, 2].concat(proxy); console.log(res[0]); console.log(res[1]); console.log(res[2]); console.log(res[3]); **Expected output:** 1 2 3 4 **Actual output:** 1 2 Proxy {0: 3, 1: 4} undefined **Observation:** Works in Chrome 65 and Firefox 58 1412565 1 webkit-bug-importer 2018-04-06 20:58:13 -0700 <rdar://problem/39256680> 1427971 2 341460 caitp 2018-05-28 15:34:53 -0700 Created attachment 341460 Patch 1428076 3 341460 saam 2018-05-29 08:59:57 -0700 Comment on attachment 341460 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341460&action=review > Source/JavaScriptCore/ChangeLog:11 > + This incorrectly treated prevented Proxy objects from being spread when “treated prevented” => prevented > Source/JavaScriptCore/ChangeLog:12 > + they were the only argument passed to A.p.concat(), violating ECMA-262. Nit: I’d just spell out Array.prototype.concat > JSTests/ChangeLog:8 > + Before this patch, the fast case for Array.prototype.concat was taken if Don’t think you need to repeat the same text in this changelog here 1428081 4 341489 caitp 2018-05-29 09:17:43 -0700 Created attachment 341489 Patch for landing 1428086 5 341489 caitp 2018-05-29 09:24:04 -0700 Comment on attachment 341489 Patch for landing I think this patch is still slightly wrong, going to verify a bit.. 1428087 6 341489 caitp 2018-05-29 09:26:47 -0700 Comment on attachment 341489 Patch for landing nevermind, I guess it was ok after all.. 1428092 7 341489 commit-queue 2018-05-29 09:56:35 -0700 Comment on attachment 341489 Patch for landing Clearing flags on attachment: 341489 Committed r232261: <https://trac.webkit.org/changeset/232261> 1428093 8 commit-queue 2018-05-29 09:56:36 -0700 All reviewed patches have been landed. Closing bug. 1428221 9 caitp 2018-05-29 14:49:16 -0700 Reopening to attach new patch. 1428222 10 341520 caitp 2018-05-29 14:49:17 -0700 Created attachment 341520 Patch 1428224 11 caitp 2018-05-29 14:50:05 -0700 I didn't know we had a new test262 runner in the tree. This patch fixed some failures, so here's another patch to fix the test262 expectations. 1428234 12 341520 saam 2018-05-29 15:13:02 -0700 Comment on attachment 341520 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341520&action=review > JSTests/ChangeLog:3 > + > + Only need one new line here 1428285 13 341538 caitp 2018-05-29 17:02:08 -0700 Created attachment 341538 Patch for landing 1428305 14 341538 commit-queue 2018-05-29 17:40:33 -0700 Comment on attachment 341538 Patch for landing Clearing flags on attachment: 341538 Committed r232282: <https://trac.webkit.org/changeset/232282> 1428306 15 commit-queue 2018-05-29 17:40:35 -0700 All reviewed patches have been landed. Closing bug. 1650364 16 ashvayka 2020-05-07 15:11:25 -0700 *** Bug 186991 has been marked as a duplicate of this bug. *** 1650370 17 ashvayka 2020-05-07 15:20:06 -0700 *** Bug 186993 has been marked as a duplicate of this bug. *** 1650386 18 ashvayka 2020-05-07 15:40:13 -0700 *** Bug 186992 has been marked as a duplicate of this bug. *** 341460 2018-05-28 15:34:53 -0700 2018-05-29 09:17:40 -0700 Patch bug-184267-20180528183452.patch text/plain 4965 caitp U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj NjRlZTk1MGY5YWIwNTI5NzI1OTFmY2IyODc5ZTFkYTU2ZmZlM2I1Li40ZTVjNmRlMTBjMWE0MjAz NmZkNTAzOTk4ZDg3N2RjYWQyYWRiYWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOC0wNS0yOCAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29t PgorCisgICAgICAgIFtKU0NdIEZpeCBBcnJheS5wcm90b3R5cGUuY29uY2F0IGZhc3QgY2FzZSB3 aGVuIHNpbmdsZSBhcmd1bWVudCBpcyBQcm94eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0MjY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQmVmb3JlIHRoaXMgcGF0Y2gsIHRoZSBmYXN0IGNhc2UgZm9y IEFycmF5LnByb3RvdHlwZS5jb25jYXQgd2FzIHRha2VuIGlmCisgICAgICAgIHRoZXJlIHdhcyBh IHNpbmdsZSBhcmd1bWVudCBwYXNzZWQgdG8gdGhlIGZ1bmN0aW9uLCB3aGljaCBpcyBlaXRoZXIg YQorICAgICAgICBub24tSlNDZWxsLCBvciBhbiBPYmplY3RUeXBlIEpTQ2VsbCBub3QgbWFya2Vk IGFzIGNvbmNhdC1zcHJlYWRhYmxlLgorICAgICAgICBUaGlzIGluY29ycmVjdGx5IHRyZWF0ZWQg cHJldmVudGVkIFByb3h5IG9iamVjdHMgZnJvbSBiZWluZyBzcHJlYWQgd2hlbgorICAgICAgICB0 aGV5IHdlcmUgdGhlIG9ubHkgYXJndW1lbnQgcGFzc2VkIHRvIEEucC5jb25jYXQoKSwgdmlvbGF0 aW5nIEVDTUEtMjYyLgorCisgICAgICAgICogYnVpbHRpbnMvQXJyYXlQcm90b3R5cGUuanM6Cisg ICAgICAgIChjb25jYXQpOgorCiAyMDE4LTA1LTI3ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50 ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtXVEZdIEFkZCBjbHozMiAvIGNsejY0IGZvciBNU1ZD CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQXJyYXlQcm90b3R5 cGUuanMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQXJyYXlQcm90b3R5cGUuanMK aW5kZXggODcwZTU1N2RlYjg1YzI3NDBkZWM2OTQ2NmFjNzhmMWFkMzQwOWQzMC4uZTZkNGYxMDRh MmE1NWI1MmU0NjYwMjc2OGNmY2Y1MDI3NmEzNzE4ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2J1aWx0aW5zL0FycmF5UHJvdG90eXBlLmpzCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9idWlsdGlucy9BcnJheVByb3RvdHlwZS5qcwpAQCAtNjc4LDcgKzY3OCw3IEBAIGZ1 bmN0aW9uIGNvbmNhdChmaXJzdCkKICAgICBpZiAoQGFyZ3VtZW50Q291bnQoKSA9PT0gMQogICAg ICAgICAmJiBAaXNKU0FycmF5KHRoaXMpCiAgICAgICAgICYmIHRoaXMuQGlzQ29uY2F0U3ByZWFk YWJsZVN5bWJvbCA9PT0gQHVuZGVmaW5lZAotICAgICAgICAmJiAoIUBpc09iamVjdChmaXJzdCkg fHwgZmlyc3QuQGlzQ29uY2F0U3ByZWFkYWJsZVN5bWJvbCA9PT0gQHVuZGVmaW5lZCkpIHsKKyAg ICAgICAgJiYgKCFAaXNPYmplY3QoZmlyc3QpIHx8ICghQGlzUHJveHlPYmplY3QoZmlyc3QpICYm IGZpcnN0LkBpc0NvbmNhdFNwcmVhZGFibGVTeW1ib2wgPT09IEB1bmRlZmluZWQpKSkgewogCiAg ICAgICAgIGxldCByZXN1bHQgPSBAY29uY2F0TWVtY3B5KHRoaXMsIGZpcnN0KTsKICAgICAgICAg aWYgKHJlc3VsdCAhPT0gbnVsbCkKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNU ZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDk3NTc1ODdkOTAxYmE2ZDg4MGNmZTllMGU2MDY3N2JiYzM0 OGQ5NC4uODM1MGY1MjI5ZWJlMjhmMTMwNWVlMmM0MzE3MmYzNzRjN2M2YWM1YSAxMDA2NDQKLS0t IGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MSBAQAorMjAxOC0wNS0yOCAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtKU0NdIEZpeCBBcnJheS5wcm90b3R5cGUuY29uY2F0IGZhc3QgY2FzZSB3aGVuIHNp bmdsZSBhcmd1bWVudCBpcyBQcm94eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg0MjY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQmVmb3JlIHRoaXMgcGF0Y2gsIHRoZSBmYXN0IGNhc2UgZm9yIEFycmF5 LnByb3RvdHlwZS5jb25jYXQgd2FzIHRha2VuIGlmCisgICAgICAgIHRoZXJlIHdhcyBhIHNpbmds ZSBhcmd1bWVudCBwYXNzZWQgdG8gdGhlIGZ1bmN0aW9uLCB3aGljaCBpcyBlaXRoZXIgYQorICAg ICAgICBub24tSlNDZWxsLCBvciBhbiBPYmplY3RUeXBlIEpTQ2VsbCBub3QgbWFya2VkIGFzIGNv bmNhdC1zcHJlYWRhYmxlLgorICAgICAgICBUaGlzIGluY29ycmVjdGx5IHRyZWF0ZWQgcHJldmVu dGVkIFByb3h5IG9iamVjdHMgZnJvbSBiZWluZyBzcHJlYWQgd2hlbgorICAgICAgICB0aGV5IHdl cmUgdGhlIG9ubHkgYXJndW1lbnQgcGFzc2VkIHRvIEEucC5jb25jYXQoKSwgdmlvbGF0aW5nIEVD TUEtMjYyLgorCisgICAgICAgICogc3RyZXNzL2FycmF5LWNvbmNhdC1mYXN0LXNwcmVhZC1wcm94 eS5qczogQ29waWVkIGZyb20gSlNUZXN0cy9zdHJlc3MvYXJyYXktY29uY2F0LXNwcmVhZC1wcm94 eS5qcy4KKyAgICAgICAgKGFycmF5RXEpOgorICAgICAgICAoY2F0Y2gpOgorICAgICAgICAqIHN0 cmVzcy9hcnJheS1jb25jYXQtc3ByZWFkLXByb3h5LmpzOgorCiAyMDE4LTA1LTI3ICBDYWlvIExp bWEgIDx0aWNhaW9saW1hQGdtYWlsLmNvbT4KIAogICAgICAgICBbRVNOZXh0XVtCaWdJbnRdIElt cGxlbWVudCAiKyIgYW5kICItIiB1bmFyeSBvcGVyYXRpb24KZGlmZiAtLWdpdCBhL0pTVGVzdHMv c3RyZXNzL2FycmF5LWNvbmNhdC1mYXN0LXNwcmVhZC1wcm94eS5qcyBiL0pTVGVzdHMvc3RyZXNz L2FycmF5LWNvbmNhdC1mYXN0LXNwcmVhZC1wcm94eS5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lYjZlZTA2NjVl YzUxZGRlMWY0YzFhN2FlNTQ5ODkyNGZhYzE0ZWJlCi0tLSAvZGV2L251bGwKKysrIGIvSlNUZXN0 cy9zdHJlc3MvYXJyYXktY29uY2F0LWZhc3Qtc3ByZWFkLXByb3h5LmpzCkBAIC0wLDAgKzEsNDEg QEAKKy8vIFRoaXMgZmlsZSB0ZXN0cyBpcyBjb25jYXQgc3ByZWFkYWJsZSB3aGVuIHRha2luZyB0 aGUgZmFzdCBwYXRoCisvLyAoc2luZ2xlIGFyZ3VtZW50LCBKU0FycmF5IHJlY2VpdmVyKQorCitm dW5jdGlvbiBhcnJheUVxKGEsIGIpIHsKKyAgICBpZiAoYS5sZW5ndGggIT09IGIubGVuZ3RoKQor ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgZm9yIChsZXQgaSA9IDA7IGkgPCBhLmxlbmd0aDsg aSsrKSB7CisgICAgICAgIGlmIChhW2ldICE9PSBiW2ldKQorICAgICAgICAgICAgcmV0dXJuIGZh bHNlOworICAgIH0KKyAgICByZXR1cm4gdHJ1ZTsKK30KKworCit7CisgICAgbGV0IGFycmF5ID0g WzEsMiwzXTsKKyAgICBsZXQge3Byb3h5OnAsIHJldm9rZX0gPSBQcm94eS5yZXZvY2FibGUoWzQs IDVdLCB7fSk7CisKKyAgICAvLyBUZXN0IGl0IHdvcmtzIHdpdGggcHJveGllcyBieSBkZWZhdWx0 CisgICAgZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDsgaSsrKSB7CisgICAgICAgIGlmICghYXJy YXlFcShBcnJheS5wcm90b3R5cGUuY29uY2F0LmNhbGwoYXJyYXksIHApLCBbMSwyLDMsNCw1XSkp CisgICAgICAgICAgICB0aHJvdyAiZmFpbGVkIG5vcm1hbGx5IHdpdGggYSBwcm94eSIKKyAgICB9 CisKKyAgICAvLyBUZXN0IGl0IHdvcmtzIHdpdGggc3ByZWFkYWJsZSBmYWxzZS4KKyAgICBwW1N5 bWJvbC5pc0NvbmNhdFNwcmVhZGFibGVdID0gZmFsc2U7CisgICAgZm9yIChsZXQgaSA9IDA7IGkg PCAxMDAwMDsgaSsrKSB7CisgICAgICAgIGlmICghYXJyYXlFcShBcnJheS5wcm90b3R5cGUuY29u Y2F0LmNhbGwoYXJyYXkscCksIFsxLDIsMyxwXSkpCisgICAgICAgICAgICB0aHJvdyAiZmFpbGVk IHdpdGggbm8gc3ByZWFkIgorICAgIH0KKworICAgIHBbU3ltYm9sLmlzQ29uY2F0U3ByZWFkYWJs ZV0gPSB1bmRlZmluZWQ7CisgICAgcmV2b2tlKCk7CisgICAgcGFzc2VkID0gdHJ1ZTsKKyAgICB0 cnkgeworICAgICAgICBBcnJheS5wcm90b3R5cGUuY29uY2F0LmNhbGwoYXJyYXkscCk7CisgICAg ICAgIHBhc3NlZCA9IGZhbHNlOworICAgIH0gY2F0Y2ggKGUpIHsgfQorICAgIGlmICghcGFzc2Vk KQorICAgICAgICB0aHJvdyAiZmFpbGVkIHRvIHRocm93IHNwcmVhZGluZyByZXZva2VkIHByb3h5 IjsKK30KZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2FycmF5LWNvbmNhdC1zcHJlYWQtcHJv eHkuanMgYi9KU1Rlc3RzL3N0cmVzcy9hcnJheS1jb25jYXQtc3ByZWFkLXByb3h5LmpzCmluZGV4 IGUyY2JkNDhlYzI5NjM1NTBlMWIxMThkYzM2ZDQ1MmQ4NzdhMmQzZjYuLjA3MjZmNjJhZWVkYmUy NDZjYTEwZTU5ZmZmZDA3OTllYWUxMWFhZWEgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL2Fy cmF5LWNvbmNhdC1zcHJlYWQtcHJveHkuanMKKysrIGIvSlNUZXN0cy9zdHJlc3MvYXJyYXktY29u Y2F0LXNwcmVhZC1wcm94eS5qcwpAQCAtMzUsNSArMzUsNiBAQCBmdW5jdGlvbiBhcnJheUVxKGEs IGIpIHsKICAgICAgICAgQXJyYXkucHJvdG90eXBlLmNvbmNhdC5jYWxsKHAsW10pOwogICAgICAg ICBwYXNzZWQgPSBmYWxzZTsKICAgICB9IGNhdGNoIChlKSB7IH0KLQorICAgIGlmICghcGFzc2Vk KQorICAgICAgICB0aHJvdyAiZmFpbGVkIHRvIHRocm93IHNwcmVhZGluZyByZXZva2VkIHByb3h5 IjsKIH0K 341489 2018-05-29 09:17:43 -0700 2018-05-29 14:49:13 -0700 Patch for landing bug-184267-20180529121742.patch text/plain 4556 caitp U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj NjRlZTk1MGY5YWIwNTI5NzI1OTFmY2IyODc5ZTFkYTU2ZmZlM2I1Li5lOGY5OGMyOTZlM2Q2NjJl OWRiMjYxM2YxM2Y4MTc5ODg1MTIyZDE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOC0wNS0yOSAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29t PgorCisgICAgICAgIFtKU0NdIEZpeCBBcnJheS5wcm90b3R5cGUuY29uY2F0IGZhc3QgY2FzZSB3 aGVuIHNpbmdsZSBhcmd1bWVudCBpcyBQcm94eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0MjY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2FhbSBC YXJhdGkuCisKKyAgICAgICAgQmVmb3JlIHRoaXMgcGF0Y2gsIHRoZSBmYXN0IGNhc2UgZm9yIEFy cmF5LnByb3RvdHlwZS5jb25jYXQgd2FzIHRha2VuIGlmCisgICAgICAgIHRoZXJlIHdhcyBhIHNp bmdsZSBhcmd1bWVudCBwYXNzZWQgdG8gdGhlIGZ1bmN0aW9uLCB3aGljaCBpcyBlaXRoZXIgYQor ICAgICAgICBub24tSlNDZWxsLCBvciBhbiBPYmplY3RUeXBlIEpTQ2VsbCBub3QgbWFya2VkIGFz IGNvbmNhdC1zcHJlYWRhYmxlLgorICAgICAgICBUaGlzIGluY29ycmVjdGx5IHByZXZlbnRlZCBQ cm94eSBvYmplY3RzIGZyb20gYmVpbmcgc3ByZWFkIHdoZW4KKyAgICAgICAgdGhleSB3ZXJlIHRo ZSBvbmx5IGFyZ3VtZW50IHBhc3NlZCB0byBBLnByb3RvdHlwZS5jb25jYXQoKSwgdmlvbGF0aW5n IEVDTUEtMjYyLgorCisgICAgICAgICogYnVpbHRpbnMvQXJyYXlQcm90b3R5cGUuanM6CisgICAg ICAgIChjb25jYXQpOgorCiAyMDE4LTA1LTI3ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFA Z21haWwuY29tPgogCiAgICAgICAgIFtXVEZdIEFkZCBjbHozMiAvIGNsejY0IGZvciBNU1ZDCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQXJyYXlQcm90b3R5cGUu anMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQXJyYXlQcm90b3R5cGUuanMKaW5k ZXggODcwZTU1N2RlYjg1YzI3NDBkZWM2OTQ2NmFjNzhmMWFkMzQwOWQzMC4uZTZkNGYxMDRhMmE1 NWI1MmU0NjYwMjc2OGNmY2Y1MDI3NmEzNzE4ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2J1aWx0aW5zL0FycmF5UHJvdG90eXBlLmpzCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9idWlsdGlucy9BcnJheVByb3RvdHlwZS5qcwpAQCAtNjc4LDcgKzY3OCw3IEBAIGZ1bmN0 aW9uIGNvbmNhdChmaXJzdCkKICAgICBpZiAoQGFyZ3VtZW50Q291bnQoKSA9PT0gMQogICAgICAg ICAmJiBAaXNKU0FycmF5KHRoaXMpCiAgICAgICAgICYmIHRoaXMuQGlzQ29uY2F0U3ByZWFkYWJs ZVN5bWJvbCA9PT0gQHVuZGVmaW5lZAotICAgICAgICAmJiAoIUBpc09iamVjdChmaXJzdCkgfHwg Zmlyc3QuQGlzQ29uY2F0U3ByZWFkYWJsZVN5bWJvbCA9PT0gQHVuZGVmaW5lZCkpIHsKKyAgICAg ICAgJiYgKCFAaXNPYmplY3QoZmlyc3QpIHx8ICghQGlzUHJveHlPYmplY3QoZmlyc3QpICYmIGZp cnN0LkBpc0NvbmNhdFNwcmVhZGFibGVTeW1ib2wgPT09IEB1bmRlZmluZWQpKSkgewogCiAgICAg ICAgIGxldCByZXN1bHQgPSBAY29uY2F0TWVtY3B5KHRoaXMsIGZpcnN0KTsKICAgICAgICAgaWYg KHJlc3VsdCAhPT0gbnVsbCkKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggZDk3NTc1ODdkOTAxYmE2ZDg4MGNmZTllMGU2MDY3N2JiYzM0OGQ5 NC4uNjhlZjg4YmE5NTk4YjlmMzVjNmIxZTQ1YjY3OWUwYWIxN2I3NzNlNSAxMDA2NDQKLS0tIGEv SlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBA QAorMjAxOC0wNS0yOSAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtKU0NdIEZpeCBBcnJheS5wcm90b3R5cGUuY29uY2F0IGZhc3QgY2FzZSB3aGVuIHNpbmds ZSBhcmd1bWVudCBpcyBQcm94eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg0MjY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2FhbSBCYXJhdGkuCisK KyAgICAgICAgKiBzdHJlc3MvYXJyYXktY29uY2F0LWZhc3Qtc3ByZWFkLXByb3h5LmpzOiBDb3Bp ZWQgZnJvbSBKU1Rlc3RzL3N0cmVzcy9hcnJheS1jb25jYXQtc3ByZWFkLXByb3h5LmpzLgorICAg ICAgICAoYXJyYXlFcSk6CisgICAgICAgIChjYXRjaCk6CisgICAgICAgICogc3RyZXNzL2FycmF5 LWNvbmNhdC1zcHJlYWQtcHJveHkuanM6CisKIDIwMTgtMDUtMjcgIENhaW8gTGltYSAgPHRpY2Fp b2xpbWFAZ21haWwuY29tPgogCiAgICAgICAgIFtFU05leHRdW0JpZ0ludF0gSW1wbGVtZW50ICIr IiBhbmQgIi0iIHVuYXJ5IG9wZXJhdGlvbgpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvYXJy YXktY29uY2F0LWZhc3Qtc3ByZWFkLXByb3h5LmpzIGIvSlNUZXN0cy9zdHJlc3MvYXJyYXktY29u Y2F0LWZhc3Qtc3ByZWFkLXByb3h5LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmViNmVlMDY2NWVjNTFkZGUxZjRj MWE3YWU1NDk4OTI0ZmFjMTRlYmUKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9h cnJheS1jb25jYXQtZmFzdC1zcHJlYWQtcHJveHkuanMKQEAgLTAsMCArMSw0MSBAQAorLy8gVGhp cyBmaWxlIHRlc3RzIGlzIGNvbmNhdCBzcHJlYWRhYmxlIHdoZW4gdGFraW5nIHRoZSBmYXN0IHBh dGgKKy8vIChzaW5nbGUgYXJndW1lbnQsIEpTQXJyYXkgcmVjZWl2ZXIpCisKK2Z1bmN0aW9uIGFy cmF5RXEoYSwgYikgeworICAgIGlmIChhLmxlbmd0aCAhPT0gYi5sZW5ndGgpCisgICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICBmb3IgKGxldCBpID0gMDsgaSA8IGEubGVuZ3RoOyBpKyspIHsKKyAg ICAgICAgaWYgKGFbaV0gIT09IGJbaV0pCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAg fQorICAgIHJldHVybiB0cnVlOworfQorCisKK3sKKyAgICBsZXQgYXJyYXkgPSBbMSwyLDNdOwor ICAgIGxldCB7cHJveHk6cCwgcmV2b2tlfSA9IFByb3h5LnJldm9jYWJsZShbNCwgNV0sIHt9KTsK KworICAgIC8vIFRlc3QgaXQgd29ya3Mgd2l0aCBwcm94aWVzIGJ5IGRlZmF1bHQKKyAgICBmb3Ig KGxldCBpID0gMDsgaSA8IDEwMDAwOyBpKyspIHsKKyAgICAgICAgaWYgKCFhcnJheUVxKEFycmF5 LnByb3RvdHlwZS5jb25jYXQuY2FsbChhcnJheSwgcCksIFsxLDIsMyw0LDVdKSkKKyAgICAgICAg ICAgIHRocm93ICJmYWlsZWQgbm9ybWFsbHkgd2l0aCBhIHByb3h5IgorICAgIH0KKworICAgIC8v IFRlc3QgaXQgd29ya3Mgd2l0aCBzcHJlYWRhYmxlIGZhbHNlLgorICAgIHBbU3ltYm9sLmlzQ29u Y2F0U3ByZWFkYWJsZV0gPSBmYWxzZTsKKyAgICBmb3IgKGxldCBpID0gMDsgaSA8IDEwMDAwOyBp KyspIHsKKyAgICAgICAgaWYgKCFhcnJheUVxKEFycmF5LnByb3RvdHlwZS5jb25jYXQuY2FsbChh cnJheSxwKSwgWzEsMiwzLHBdKSkKKyAgICAgICAgICAgIHRocm93ICJmYWlsZWQgd2l0aCBubyBz cHJlYWQiCisgICAgfQorCisgICAgcFtTeW1ib2wuaXNDb25jYXRTcHJlYWRhYmxlXSA9IHVuZGVm aW5lZDsKKyAgICByZXZva2UoKTsKKyAgICBwYXNzZWQgPSB0cnVlOworICAgIHRyeSB7CisgICAg ICAgIEFycmF5LnByb3RvdHlwZS5jb25jYXQuY2FsbChhcnJheSxwKTsKKyAgICAgICAgcGFzc2Vk ID0gZmFsc2U7CisgICAgfSBjYXRjaCAoZSkgeyB9CisgICAgaWYgKCFwYXNzZWQpCisgICAgICAg IHRocm93ICJmYWlsZWQgdG8gdGhyb3cgc3ByZWFkaW5nIHJldm9rZWQgcHJveHkiOworfQpkaWZm IC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvYXJyYXktY29uY2F0LXNwcmVhZC1wcm94eS5qcyBiL0pT VGVzdHMvc3RyZXNzL2FycmF5LWNvbmNhdC1zcHJlYWQtcHJveHkuanMKaW5kZXggZTJjYmQ0OGVj Mjk2MzU1MGUxYjExOGRjMzZkNDUyZDg3N2EyZDNmNi4uMDcyNmY2MmFlZWRiZTI0NmNhMTBlNTlm ZmZkMDc5OWVhZTExYWFlYSAxMDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3MvYXJyYXktY29uY2F0 LXNwcmVhZC1wcm94eS5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9hcnJheS1jb25jYXQtc3ByZWFk LXByb3h5LmpzCkBAIC0zNSw1ICszNSw2IEBAIGZ1bmN0aW9uIGFycmF5RXEoYSwgYikgewogICAg ICAgICBBcnJheS5wcm90b3R5cGUuY29uY2F0LmNhbGwocCxbXSk7CiAgICAgICAgIHBhc3NlZCA9 IGZhbHNlOwogICAgIH0gY2F0Y2ggKGUpIHsgfQotCisgICAgaWYgKCFwYXNzZWQpCisgICAgICAg IHRocm93ICJmYWlsZWQgdG8gdGhyb3cgc3ByZWFkaW5nIHJldm9rZWQgcHJveHkiOwogfQo= 341520 2018-05-29 14:49:17 -0700 2018-05-29 17:02:05 -0700 Patch bug-184267-20180529174916.patch text/plain 1947 caitp U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjc0CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDZiODAxYjAxNWZiYTg2OTFhYTIwNjllYzcyNjZm ODA3NDRhNTE0OGUuLmQ3MGExYWRlODBiNmFhY2M5ZmIyMzgyNDNmZjFiMjIwOWJkZTVjZTggMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTgtMDUtMjkgIENhaXRsaW4gUG90dGVyICA8Y2FpdHBAaWdhbGlhLmNv bT4KKworCisgICAgICAgIFtKU1Rlc3RzXSB1cGRhdGUgdGVzdDI2MiBleHBlY3RhdGlvbnMgYWZ0 ZXIgcjIzMjI2MQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg0MjY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiB0ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sOgorCiAyMDE4LTA1LTI5ICBDYWlvIExpbWEg IDx0aWNhaW9saW1hQGdtYWlsLmNvbT4KIAogICAgICAgICBbRVNOZXh0XVtCaWdJbnRdIEltcGxl bWVudCBzdXBwb3J0IGZvciAiPCIgYW5kICI+IiByZWxhdGlvbmFsIG9wZXJhdGlvbgpkaWZmIC0t Z2l0IGEvSlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sIGIvSlNUZXN0cy90ZXN0MjYy L2V4cGVjdGF0aW9ucy55YW1sCmluZGV4IDAxZWUyMmNjYTdkOTAyODFjNDU0OTFmNWIzMzgzM2Ri NzJhMGJjMTYuLjM0ZWNlODE4YzJjOGUwZWRhNWRiMmZlMWI1Y2MxYjEzYzAxN2EzN2YgMTAwNjQ0 Ci0tLSBhL0pTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbAorKysgYi9KU1Rlc3RzL3Rl c3QyNjIvZXhwZWN0YXRpb25zLnlhbWwKQEAgLTYyNCwxMiArNjI0LDYgQEAgdGVzdC9idWlsdC1p bnMvQXJyYXkvb2YvcmV0dXJuLWFicnVwdC1mcm9tLWRhdGEtcHJvcGVydHkuanM6CiB0ZXN0L2J1 aWx0LWlucy9BcnJheS9wcm90by1mcm9tLWN0b3ItcmVhbG0uanM6CiAgIGRlZmF1bHQ6ICdUZXN0 MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjDgsKrw4LCuywgw4LCq8OCwrspIHRvIGJlIHRy dWUnCiAgIHN0cmljdCBtb2RlOiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUow4LC q8OCwrssIMOCwqvDgsK7KSB0byBiZSB0cnVlJwotdGVzdC9idWlsdC1pbnMvQXJyYXkvcHJvdG90 eXBlL2NvbmNhdC9pcy1jb25jYXQtc3ByZWFkYWJsZS1pcy1hcnJheS1wcm94eS1yZXZva2VkLmpz OgotICBkZWZhdWx0OiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBhIFR5cGVFcnJvciB0byBiZSB0 aHJvd24gYnV0IG5vIGV4Y2VwdGlvbiB3YXMgdGhyb3duIGF0IGFsbCcKLSAgc3RyaWN0IG1vZGU6 ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIGEgVHlwZUVycm9yIHRvIGJlIHRocm93biBidXQgbm8g ZXhjZXB0aW9uIHdhcyB0aHJvd24gYXQgYWxsJwotdGVzdC9idWlsdC1pbnMvQXJyYXkvcHJvdG90 eXBlL2NvbmNhdC9pcy1jb25jYXQtc3ByZWFkYWJsZS1wcm94eS5qczoKLSAgZGVmYXVsdDogJ1Rl c3QyNjJFcnJvcjogUHJveHkgZm9yIGFuIGFycmF5IEV4cGVjdGVkIFNhbWVWYWx1ZSjDgsKrMcOC wrssIMOCwqsww4LCuykgdG8gYmUgdHJ1ZScKLSAgc3RyaWN0IG1vZGU6ICdUZXN0MjYyRXJyb3I6 IFByb3h5IGZvciBhbiBhcnJheSBFeHBlY3RlZCBTYW1lVmFsdWUow4LCqzHDgsK7LCDDgsKrMMOC wrspIHRvIGJlIHRydWUnCiB0ZXN0L2J1aWx0LWlucy9BcnJheS9wcm90b3R5cGUvZmlsdGVyL3Rh cmdldC1hcnJheS13aXRoLW5vbi13cml0YWJsZS1wcm9wZXJ0eS5qczoKICAgZGVmYXVsdDogJ1R5 cGVFcnJvcjogQXR0ZW1wdGVkIHRvIGFzc2lnbiB0byByZWFkb25seSBwcm9wZXJ0eS4nCiAgIHN0 cmljdCBtb2RlOiAnVHlwZUVycm9yOiBBdHRlbXB0ZWQgdG8gYXNzaWduIHRvIHJlYWRvbmx5IHBy b3BlcnR5LicK 341538 2018-05-29 17:02:08 -0700 2018-05-29 17:40:33 -0700 Patch for landing bug-184267-20180529200207.patch text/plain 1942 caitp U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjc0CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDZiODAxYjAxNWZiYTg2OTFhYTIwNjllYzcyNjZm ODA3NDRhNTE0OGUuLmE2OGZkMjk5OTJmOWM2OTI4YzcwNmY4ZmRhZmU3Nzc4ZjllM2E3OGIgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTgtMDUtMjkgIENhaXRsaW4gUG90dGVyICA8Y2FpdHBAaWdhbGlhLmNv bT4KKworICAgICAgICBbSlNUZXN0c10gdXBkYXRlIHRlc3QyNjIgZXhwZWN0YXRpb25zIGFmdGVy IHIyMzIyNjEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NDI2NworCisgICAgICAgIFJldmlld2VkIGJ5IFNhYW0gQmFyYXRpLgorCisgICAgICAgICog dGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbDoKKwogMjAxOC0wNS0yOSAgQ2FpbyBMaW1hICA8dGlj YWlvbGltYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0VTTmV4dF1bQmlnSW50XSBJbXBsZW1lbnQg c3VwcG9ydCBmb3IgIjwiIGFuZCAiPiIgcmVsYXRpb25hbCBvcGVyYXRpb24KZGlmZiAtLWdpdCBh L0pTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbCBiL0pTVGVzdHMvdGVzdDI2Mi9leHBl Y3RhdGlvbnMueWFtbAppbmRleCAwMWVlMjJjY2E3ZDkwMjgxYzQ1NDkxZjViMzM4MzNkYjcyYTBi YzE2Li4zNGVjZTgxOGMyYzhlMGVkYTVkYjJmZTFiNWNjMWIxM2MwMTdhMzdmIDEwMDY0NAotLS0g YS9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwKKysrIGIvSlNUZXN0cy90ZXN0MjYy L2V4cGVjdGF0aW9ucy55YW1sCkBAIC02MjQsMTIgKzYyNCw2IEBAIHRlc3QvYnVpbHQtaW5zL0Fy cmF5L29mL3JldHVybi1hYnJ1cHQtZnJvbS1kYXRhLXByb3BlcnR5LmpzOgogdGVzdC9idWlsdC1p bnMvQXJyYXkvcHJvdG8tZnJvbS1jdG9yLXJlYWxtLmpzOgogICBkZWZhdWx0OiAnVGVzdDI2MkVy cm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUow4LCq8OCwrssIMOCwqvDgsK7KSB0byBiZSB0cnVlJwog ICBzdHJpY3QgbW9kZTogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgU2FtZVZhbHVlKMOCwqvDgsK7 LCDDgsKrw4LCuykgdG8gYmUgdHJ1ZScKLXRlc3QvYnVpbHQtaW5zL0FycmF5L3Byb3RvdHlwZS9j b25jYXQvaXMtY29uY2F0LXNwcmVhZGFibGUtaXMtYXJyYXktcHJveHktcmV2b2tlZC5qczoKLSAg ZGVmYXVsdDogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgYSBUeXBlRXJyb3IgdG8gYmUgdGhyb3du IGJ1dCBubyBleGNlcHRpb24gd2FzIHRocm93biBhdCBhbGwnCi0gIHN0cmljdCBtb2RlOiAnVGVz dDI2MkVycm9yOiBFeHBlY3RlZCBhIFR5cGVFcnJvciB0byBiZSB0aHJvd24gYnV0IG5vIGV4Y2Vw dGlvbiB3YXMgdGhyb3duIGF0IGFsbCcKLXRlc3QvYnVpbHQtaW5zL0FycmF5L3Byb3RvdHlwZS9j b25jYXQvaXMtY29uY2F0LXNwcmVhZGFibGUtcHJveHkuanM6Ci0gIGRlZmF1bHQ6ICdUZXN0MjYy RXJyb3I6IFByb3h5IGZvciBhbiBhcnJheSBFeHBlY3RlZCBTYW1lVmFsdWUow4LCqzHDgsK7LCDD gsKrMMOCwrspIHRvIGJlIHRydWUnCi0gIHN0cmljdCBtb2RlOiAnVGVzdDI2MkVycm9yOiBQcm94 eSBmb3IgYW4gYXJyYXkgRXhwZWN0ZWQgU2FtZVZhbHVlKMOCwqsxw4LCuywgw4LCqzDDgsK7KSB0 byBiZSB0cnVlJwogdGVzdC9idWlsdC1pbnMvQXJyYXkvcHJvdG90eXBlL2ZpbHRlci90YXJnZXQt YXJyYXktd2l0aC1ub24td3JpdGFibGUtcHJvcGVydHkuanM6CiAgIGRlZmF1bHQ6ICdUeXBlRXJy b3I6IEF0dGVtcHRlZCB0byBhc3NpZ24gdG8gcmVhZG9ubHkgcHJvcGVydHkuJwogICBzdHJpY3Qg bW9kZTogJ1R5cGVFcnJvcjogQXR0ZW1wdGVkIHRvIGFzc2lnbiB0byByZWFkb25seSBwcm9wZXJ0 eS4nCg==