184255 2018-04-02 23:20:50 -0700 Revealing find results fails in pages containing more than one subframe 2018-11-12 15:15:06 -0800 1 1 1 Unclassified WebKit Frames WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=178789 https://bugs.webkit.org/show_bug.cgi?id=184297 InRadar P2 Normal --- 1 fred.wang webkit-unassigned dvoytenko malte simon.fraser thorton webkit-bug-importer oldest_to_newest 1411359 0 337061 fred.wang 2018-04-02 23:20:50 -0700 Created attachment 337061 testcase Attached testcase is similar to attachment 312006 but using subframes instead of "overflow: auto" nodes. If you find "text" with the Find UI, the result will be highlighted in that order: * Main frame: text5a, text5b, text5c, text10a text10b text10c * Subframe 1: text1a, text1b, text1c, ... text4a, text4b, text4c * Subframe 2: text6a, text6b, text6c, ... text9a text9b text9c Some remarks: - The result from the main frame are returned first. Although this is different from "overflow: auto" node, it is the same behavior as on desktop and other browsers. - Scrolling and smart magnification work for the main frame and the first subframe. For the second subframe, text6a, text6b, text6c, ... text9a text9b text9c are highlighted as expected BUT the scrolling / magnification reveals the *first* subframe (you can scroll down to check that the expected text is highlighted). 1411360 1 webkit-bug-importer 2018-04-02 23:21:11 -0700 <rdar://problem/39132221> 1477745 2 simon.fraser 2018-11-12 14:57:45 -0800 Relevant stack trace: * frame #0: 0x0000000319330158 WebCore`WebCore::FrameSelection::revealSelection(this=0x0000000341628c60, revealMode=RevealUpToMainFrame, alignment=0x000000031bf29608, revealExtentOption=DoNotRevealExtent) at FrameSelection.cpp:2366 frame #1: 0x0000000308bda05a WebKit`WebKit::FindController::didFindString(this=0x00007f8cf8001770) at FindControllerIOS.mm:165 frame #2: 0x0000000308f028bb WebKit`WebKit::FindController::findString(this=0x00007f8cf8001770, string={ length = 4, contents = 'text' }, options=343, maxMatchCount=100) at FindController.cpp:237 frame #3: 0x000000030900e089 WebKit`WebKit::WebPage::findString(this=0x00007f8cfd000008, string={ length = 4, contents = 'text' }, options=343, maxMatchCount=100) at WebPage.cpp:3790 337061 2018-04-02 23:20:50 -0700 2018-04-02 23:20:50 -0700 testcase find-text-in-subframe-complex.html text/html 1411 fred.wang PCFET0NUWVBFIGh0bWw+CjxoZWFkPgogIDxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KICA8dGl0bGU+ V2ViS2l0IGZpbmQgaWZyYW1lPC90aXRsZT4KICA8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVu dD0id2lkdGg9ZGV2aWNlLXdpZHRoIj4KICA8c3R5bGU+CiAgICBpZnJhbWUgewogICAgICBiYWNr Z3JvdW5kOiBncmF5OwogICAgICB3aWR0aDogMjAwcHg7CiAgICAgIGhlaWdodDogMjAwcHg7CiAg ICB9CiAgPC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4KICA8cD5Vc2UgIkZpbmQgaW4gcGFnZSIgdG8g c2VhcmNoICJ0ZXh0Ii48L3A+CiAgPGlmcmFtZSBzcmNkb2M9IjxkaXYgc3R5bGU9J3dpZHRoOiAx MDBweDsgaGVpZ2h0OiA1MDBweDsgYmFja2dyb3VuZDogbGluZWFyLWdyYWRpZW50KDEzNWRlZywg cmVkLCBncmVlbiknPjwvZGl2PnRleHQxYSB0ZXh0MWIgdGV4dDFjPGRpdiBzdHlsZT0nd2lkdGg6 IDEwMHB4OyBoZWlnaHQ6IDUwMHB4OyBiYWNrZ3JvdW5kOiBsaW5lYXItZ3JhZGllbnQoMTM1ZGVn LCBncmVlbiwgYmx1ZSknPjwvZGl2PnRleHQyYSB0ZXh0MmIgdGV4dDJjPGRpdiBzdHlsZT0nd2lk dGg6IDEwMHB4OyBoZWlnaHQ6IDUwMHB4OyBiYWNrZ3JvdW5kOiBsaW5lYXItZ3JhZGllbnQoMTM1 ZGVnLCBibHVlLCBtYWdlbnRhKSc+PC9kaXY+dGV4dDNhIHRleHQzYiB0ZXh0M2M8ZGl2IHN0eWxl PSd3aWR0aDogMTAwcHg7IGhlaWdodDogNTAwcHg7IGJhY2tncm91bmQ6IGxpbmVhci1ncmFkaWVu dCgxMzVkZWcsIG1hZ2VudGEsIHllbGxvdyknPjwvZGl2PnRleHQ0YSB0ZXh0NGIgdGV4dDRjIj48 L2lmcmFtZT4KICA8ZGl2IHN0eWxlPSJoZWlnaHQ6IDUwMHB4Ij50ZXh0NWEgdGV4dDViIHRleHQ1 YzwvZGl2PgogIDxpZnJhbWUgc3JjZG9jPSI8ZGl2IHN0eWxlPSd3aWR0aDogMTAwcHg7IGhlaWdo dDogNTAwcHg7IGJhY2tncm91bmQ6IGxpbmVhci1ncmFkaWVudCgxMzVkZWcsIHJlZCwgZ3JlZW4p Jz48L2Rpdj50ZXh0NmEgdGV4dDZiIHRleHQ2YzxkaXYgc3R5bGU9J3dpZHRoOiAxMDBweDsgaGVp Z2h0OiA1MDBweDsgYmFja2dyb3VuZDogbGluZWFyLWdyYWRpZW50KDEzNWRlZywgZ3JlZW4sIGJs dWUpJz48L2Rpdj50ZXh0N2EgdGV4dDdiIHRleHQ3YzxkaXYgc3R5bGU9J3dpZHRoOiAxMDBweDsg aGVpZ2h0OiA1MDBweDsgYmFja2dyb3VuZDogbGluZWFyLWdyYWRpZW50KDEzNWRlZywgYmx1ZSwg bWFnZW50YSknPjwvZGl2PnRleHQ4YSB0ZXh0OGIgdGV4dDhjPGRpdiBzdHlsZT0nd2lkdGg6IDEw MHB4OyBoZWlnaHQ6IDUwMHB4OyBiYWNrZ3JvdW5kOiBsaW5lYXItZ3JhZGllbnQoMTM1ZGVnLCBt YWdlbnRhLCB5ZWxsb3cpJz48L2Rpdj50ZXh0OWEgdGV4dDliIHRleHQ5YyI+PC9pZnJhbWU+CiAg PGRpdj50ZXh0MTBhIHRleHQxMGIgdGV4dDEwYzwvZGl2Pgo8L2JvZHk+Cg==