184241 2018-04-02 11:38:50 -0700 Define AVKit softlink macro 2018-04-02 13:34:15 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue jer.noble webkit-bug-importer oldest_to_newest 1411172 0 eric.carlson 2018-04-02 11:38:50 -0700 Define AVKit softlink macro 1411199 1 337014 eric.carlson 2018-04-02 12:46:54 -0700 Created attachment 337014 Patch 1411200 2 webkit-bug-importer 2018-04-02 12:47:56 -0700 <rdar://problem/39115023> 1411214 3 337014 jer.noble 2018-04-02 13:03:21 -0700 Comment on attachment 337014 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337014&action=review > Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h:39 > +#if ENABLE(EXTRA_ZOOM_MODE) > +#define SOFTLINK_AVKIT_FRAMEWORK() SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL(AVKit) > +#else > +#define SOFTLINK_AVKIT_FRAMEWORK() SOFT_LINK_FRAMEWORK_OPTIONAL(AVKit) > +#endif > + Nit: We should eventually move this into an "AVKitSoftLink.h" header and matching source file. 1411236 4 337014 commit-queue 2018-04-02 13:34:13 -0700 Comment on attachment 337014 Patch Clearing flags on attachment: 337014 Committed r230177: <https://trac.webkit.org/changeset/230177> 1411237 5 commit-queue 2018-04-02 13:34:15 -0700 All reviewed patches have been landed. Closing bug. 337014 2018-04-02 12:46:54 -0700 2018-04-02 13:34:13 -0700 Patch bug-184241-20180402124654.patch text/plain 6679 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQyMDNhZTI4NTI3YTFm YzQzNDEyMjM1MjFiMzliZTEyOTk5YmUyNC4uYzU2MWJlYWM3MThiY2Y5OTYyZmQ5ZGRkNTgxZmNj OTRkMDMwZmNmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA0LTAyICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIERlZmluZSBBVktp dCBzb2Z0bGluayBtYWNybworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg0MjQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBmdW5jdGlvbmFsIGNoYW5nZS4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWJhY2tUYXJnZXRQ aWNrZXJNYWMubW06CisgICAgICAgICogcGxhdGZvcm0vaW9zL1BsYXliYWNrU2Vzc2lvbkludGVy ZmFjZUFWS2l0Lm1tOgorICAgICAgICAqIHBsYXRmb3JtL2lvcy9WaWRlb0Z1bGxzY3JlZW5JbnRl cmZhY2VBVktpdC5tbToKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvV2ViQVZQbGF5ZXJDb250cm9s bGVyLm1tOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9QbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VN YWMubW06CisgICAgICAgICogcGxhdGZvcm0vbWFjL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU1h Yy5tbToKKwogMjAxOC0wNC0wMiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAog ICAgICAgICBBdWRpb0J1ZmZlclNvdXJjZU5vZGUgc3RhcnQgbWV0aG9kIGNhdXNlcyBPZmZsaW5l QXVkaW9Db250ZXh0IHRvIHN0YXJ0IHJ1bm5pbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L1BBTC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCmluZGV4IDU2YjU5 N2ZhNDRlNzBkNzY4ZDc2OThiYmM1MDA4NDgxYmNkNjllZTAuLjdjZjE2YjRmOWZhZTFlZTQxMzIy NDI1ZWM3MDQ5YzA2YzA1OTRjOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBA CisyMDE4LTA0LTAyICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisg ICAgICAgIERlZmluZSBBVktpdCBzb2Z0bGluayBtYWNybworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0MjQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWwvY2YvQ29yZU1lZGlhU29mdExpbmsuaDoK KwogMjAxOC0wMy0yMyAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAog ICAgICAgICBGaXggdGhlICFIQVZFKEFQUF9MSU5LUykgYnVpbGQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL1BBTC9wYWwvY2YvQ29yZU1lZGlhU29mdExpbmsuaCBiL1NvdXJjZS9XZWJDb3Jl L1BBTC9wYWwvY2YvQ29yZU1lZGlhU29mdExpbmsuaAppbmRleCAyNTFjZWFmZTY5OGFmN2VmMGJi NjZkYmViZTBkZWI3NzYwMTk0NDMyLi5jOTMzYjVlOWViYzAyM2VmNzU5NjVmYWI4MjgxNzFhY2Zm MzRjNWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL2NmL0NvcmVNZWRpYVNv ZnRMaW5rLmgKKysrIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9jZi9Db3JlTWVkaWFTb2Z0TGlu ay5oCkBAIC0zMSw2ICszMSwxMiBAQAogI2luY2x1ZGUgPHBhbC9zcGkvY2YvQ29yZU1lZGlhU1BJ Lmg+CiAjaW5jbHVkZSA8d3RmL1NvZnRMaW5raW5nLmg+CiAKKyNpZiBFTkFCTEUoRVhUUkFfWk9P TV9NT0RFKQorI2RlZmluZSBTT0ZUTElOS19BVktJVF9GUkFNRVdPUksoKSBTT0ZUX0xJTktfUFJJ VkFURV9GUkFNRVdPUktfT1BUSU9OQUwoQVZLaXQpCisjZWxzZQorI2RlZmluZSBTT0ZUTElOS19B VktJVF9GUkFNRVdPUksoKSBTT0ZUX0xJTktfRlJBTUVXT1JLX09QVElPTkFMKEFWS2l0KQorI2Vu ZGlmCisKIFNPRlRfTElOS19GUkFNRVdPUktfRk9SX0hFQURFUihQQUwsIENvcmVNZWRpYSkKIAog U09GVF9MSU5LX0ZVTkNUSU9OX0ZPUl9IRUFERVIoUEFMLCBDb3JlTWVkaWEsIENNQmxvY2tCdWZm ZXJDb3B5RGF0YUJ5dGVzLCBPU1N0YXR1cywgKENNQmxvY2tCdWZmZXJSZWYgdGhlU291cmNlQnVm ZmVyLCBzaXplX3Qgb2Zmc2V0VG9EYXRhLCBzaXplX3QgZGF0YUxlbmd0aCwgdm9pZCogZGVzdGlu YXRpb24pLCAodGhlU291cmNlQnVmZmVyLCBvZmZzZXRUb0RhdGEsIGRhdGFMZW5ndGgsIGRlc3Rp bmF0aW9uKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2 Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWJhY2tUYXJnZXRQaWNrZXJNYWMubW0gYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXliYWNr VGFyZ2V0UGlja2VyTWFjLm1tCmluZGV4IDRhNDk2YTVkNWZiYmUyZThkNWY2OTU2MDBmYzU4NWUy M2ZmYjczNzEuLjA4MDRiMDJlODM1YTcwYmQxYzZkMWMyNTNjNDM0ZTliZTllN2EwZjkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpj L01lZGlhUGxheWJhY2tUYXJnZXRQaWNrZXJNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5YmFja1RhcmdldFBpY2tl ck1hYy5tbQpAQCAtMzIsMTYgKzMyLDE2IEBACiAjaW1wb3J0IDxXZWJDb3JlL0Zsb2F0UmVjdC5o PgogI2ltcG9ydCA8V2ViQ29yZS9NZWRpYVBsYXliYWNrVGFyZ2V0TWFjLmg+CiAjaW1wb3J0IDxv YmpjL3J1bnRpbWUuaD4KKyNpbXBvcnQgPHBhbC9jZi9Db3JlTWVkaWFTb2Z0TGluay5oPgogI2lt cG9ydCA8cGFsL3NwaS9jb2NvYS9BVktpdFNQSS5oPgogI2ltcG9ydCA8cGFsL3NwaS9tYWMvQVZG b3VuZGF0aW9uU1BJLmg+CiAjaW1wb3J0IDx3dGYvTWFpblRocmVhZC5oPgotI2ltcG9ydCA8d3Rm L1NvZnRMaW5raW5nLmg+CiAKIHR5cGVkZWYgQVZPdXRwdXRDb250ZXh0IEFWT3V0cHV0Q29udGV4 dFR5cGU7CiB0eXBlZGVmIEFWT3V0cHV0RGV2aWNlTWVudUNvbnRyb2xsZXIgQVZPdXRwdXREZXZp Y2VNZW51Q29udHJvbGxlclR5cGU7CiAKK1NPRlRMSU5LX0FWS0lUX0ZSQU1FV09SSygpCiBTT0ZU X0xJTktfRlJBTUVXT1JLX09QVElPTkFMKEFWRm91bmRhdGlvbikKLVNPRlRfTElOS19GUkFNRVdP UktfT1BUSU9OQUwoQVZLaXQpCiAKIFNPRlRfTElOS19DTEFTU19PUFRJT05BTChBVkZvdW5kYXRp b24sIEFWT3V0cHV0Q29udGV4dCkKIFNPRlRfTElOS19DTEFTU19PUFRJT05BTChBVktpdCwgQVZP dXRwdXREZXZpY2VNZW51Q29udHJvbGxlcikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2lvcy9QbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VBVktpdC5tbSBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2lvcy9QbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VBVktpdC5tbQppbmRleCAw YTM2OTVhNzBiNTgyYWRlNzRkMGM0ZDNjOWMzYzVlOTJhMTlkMzE5Li4zZjFkY2RhMDgyZjYzZGEw YjFkNTdjNmIxYTgzYTdjZjljZmJjZDA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZLaXQubW0KKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW9zL1BsYXliYWNrU2Vzc2lvbkludGVyZmFjZUFWS2l0Lm1tCkBAIC00 Myw3ICs0Myw3IEBACiAKICNpbXBvcnQgPHBhbC9jZi9Db3JlTWVkaWFTb2Z0TGluay5oPgogCi1T T0ZUX0xJTktfRlJBTUVXT1JLX09QVElPTkFMKEFWS2l0KQorU09GVExJTktfQVZLSVRfRlJBTUVX T1JLKCkKIFNPRlRfTElOS19DTEFTU19PUFRJT05BTChBVktpdCwgQVZWYWx1ZVRpbWluZykKIAog bmFtZXNwYWNlIFdlYkNvcmUgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vaW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCmluZGV4IDVlOTljMWYz YjUyMDZkYWU5NGYxZGI0OTVkMTkxY2U2NGIzZDQyYTguLjNjZDhmYmYwZjQ4NmY3OTc3NmMwMjE3 MDc4YzZhZGZkMzhiZjM3ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lv cy9WaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KQEAgLTYwLDcgKzYw LDcgQEAgU09GVF9MSU5LX0NPTlNUQU5UKEFWRm91bmRhdGlvbiwgQVZMYXllclZpZGVvR3Jhdml0 eVJlc2l6ZSwgTlNTdHJpbmcgKikKIFNPRlRfTElOS19DT05TVEFOVChBVkZvdW5kYXRpb24sIEFW TGF5ZXJWaWRlb0dyYXZpdHlSZXNpemVBc3BlY3QsIE5TU3RyaW5nICopCiBTT0ZUX0xJTktfQ09O U1RBTlQoQVZGb3VuZGF0aW9uLCBBVkxheWVyVmlkZW9HcmF2aXR5UmVzaXplQXNwZWN0RmlsbCwg TlNTdHJpbmcgKikKIAotU09GVF9MSU5LX0ZSQU1FV09SS19PUFRJT05BTChBVktpdCkKK1NPRlRM SU5LX0FWS0lUX0ZSQU1FV09SSygpCiBTT0ZUX0xJTktfQ0xBU1NfT1BUSU9OQUwoQVZLaXQsIEFW UGljdHVyZUluUGljdHVyZUNvbnRyb2xsZXIpCiBTT0ZUX0xJTktfQ0xBU1NfT1BUSU9OQUwoQVZL aXQsIEFWUGxheWVyVmlld0NvbnRyb2xsZXIpCiBTT0ZUX0xJTktfQ0xBU1NfT1BUSU9OQUwoQVZL aXQsIF9fQVZQbGF5ZXJMYXllclZpZXcpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvV2ViQVZQbGF5ZXJDb250cm9sbGVyLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vaW9zL1dlYkFWUGxheWVyQ29udHJvbGxlci5tbQppbmRleCBhMWU3NGYzMWYzNGYwOTU0Yzg2 OTczNzg4OGVlY2YyYjI2OTY3NWZkLi5mYzliYWFkN2RkZmQzZGNjMjU2ODc4ZTIzMDRiMzQxYTU0 MDk3N2FkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViQVZQbGF5 ZXJDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJBVlBs YXllckNvbnRyb2xsZXIubW0KQEAgLTQwLDcgKzQwLDcgQEAKIAogI2ltcG9ydCA8cGFsL2NmL0Nv cmVNZWRpYVNvZnRMaW5rLmg+CiAKLVNPRlRfTElOS19GUkFNRVdPUktfT1BUSU9OQUwoQVZLaXQp CitTT0ZUTElOS19BVktJVF9GUkFNRVdPUksoKQogU09GVF9MSU5LX0NMQVNTX09QVElPTkFMKEFW S2l0LCBBVlBsYXllckNvbnRyb2xsZXIpCiBTT0ZUX0xJTktfQ0xBU1NfT1BUSU9OQUwoQVZLaXQs IEFWVmFsdWVUaW1pbmcpCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21h Yy9QbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tYWMvUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlTWFjLm1tCmluZGV4IDhlZThjNzcxMDk1Y2Zl NTFiZDZlODU1ZmNmNzljOGFmYjUyOWY2ZGMuLmI0MzIxOWQxNzMwZDUxMDI1ZDUzNGIxMGQzMjUy OWZjZDUwNmRiZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QbGF5 YmFja1Nlc3Npb25JbnRlcmZhY2VNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWFjL1BsYXliYWNrU2Vzc2lvbkludGVyZmFjZU1hYy5tbQpAQCAtMzksNyArMzksNyBAQAogCiAj aW1wb3J0IDxwYWwvY2YvQ29yZU1lZGlhU29mdExpbmsuaD4KIAotU09GVF9MSU5LX0ZSQU1FV09S S19PUFRJT05BTChBVktpdCkKK1NPRlRMSU5LX0FWS0lUX0ZSQU1FV09SSygpCiBTT0ZUX0xJTktf Q0xBU1NfT1BUSU9OQUwoQVZLaXQsIEFWVmFsdWVUaW1pbmcpCiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9WaWRlb0Z1bGxzY3Jl ZW5JbnRlcmZhY2VNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVmlkZW9GdWxs c2NyZWVuSW50ZXJmYWNlTWFjLm1tCmluZGV4IGM3MGQ0MDBlMzU4MWMxNjMzYjVhNThjZTZhOTQ0 NDc2YTAyMzgxYTUuLjQ0MWM3NmVhMjE1ZmIzOTU4Nzg3OTU2NmE0YTQ2ODljN2MwNjlkMWYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9WaWRlb0Z1bGxzY3JlZW5JbnRl cmZhY2VNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1ZpZGVvRnVsbHNj cmVlbkludGVyZmFjZU1hYy5tbQpAQCAtNDIsNyArNDIsNyBAQAogCiAjaW1wb3J0IDxwYWwvY2Yv Q29yZU1lZGlhU29mdExpbmsuaD4KIAotU09GVF9MSU5LX0ZSQU1FV09SS19PUFRJT05BTChBVktp dCkKK1NPRlRMSU5LX0FWS0lUX0ZSQU1FV09SSygpCiBTT0ZUX0xJTktfQ0xBU1NfT1BUSU9OQUwo QVZLaXQsIEFWVmFsdWVUaW1pbmcpCiAKIFNPRlRfTElOS19QUklWQVRFX0ZSQU1FV09SS19PUFRJ T05BTChQSVApCg==