184232 2018-04-02 05:28:56 -0700 Typed array constructor behaves differently when length is not passed or when undefined is passed 2020-06-19 21:06:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore Safari 11 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 209518 1 koby.b jdarpinian dino ews-watchlist fpizlo jdarpinian kbr keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1411049 0 koby.b 2018-04-02 05:28:56 -0700 Hi I've noticed that when I create a typed array, the resulting array's byteLength is different if I'm not passing a length, or if I'm passing an undefined length: const buffer = new ArrayBuffer(8); const view1 = new Uint8Array(buffer); // byteLength == 8 const view2 = new Uint8Array(buffer, undefined, undefined); // byteLength == 0 Tested with the JSC shell from my WebKit fork, forked on github on February, and with Safari on iOS 11.2.6. According to to the ecma standard (https://www.ecma-international.org/ecma-262/6.0/#sec-%typedarray%-buffer-byteoffset-length) I think they should produce typed arrays with the same byteLength. I've verified it with Firefox nightly and Chrome nightly (both on Windows), both producing a Uint8Array with the same byteLength(8). Going through JSC's source, I think the issue is in constructGenericTypedArrayView in runtime/JSGenericTypedArrayViewConstructorInlines.h. It handles undefined byteLength for DataViews, but not the "length" for other typed arrays. Thanks, Koby 1411453 1 webkit-bug-importer 2018-04-03 10:32:01 -0700 <rdar://problem/39145280> 1411670 2 koby.b 2018-04-03 23:58:05 -0700 Also, if you think that my suggested fix in constructGenericTypedArrayView is OK, I'll be happy to send a patch. 1662233 3 jdarpinian 2020-06-12 16:48:12 -0700 Thanks for the investigation, I think you are right about the fix. This is causing some WebGL conformance tests to fail so I will make a patch. 1662243 4 401806 jdarpinian 2020-06-12 17:00:03 -0700 Created attachment 401806 Patch 1662266 5 401806 ysuzuki 2020-06-12 17:34:16 -0700 Comment on attachment 401806 Patch Nice, can you add a test in `JSTests/stress/`? 1662268 6 ysuzuki 2020-06-12 17:36:01 -0700 And let's wait for EWS results. If it affects on WebGL conformance tests, it is possible that these tests in LayoutTests start showing "PASS" or something. In that case, this patch needs to update -expect files too. 1662273 7 ysuzuki 2020-06-12 17:52:44 -0700 Seems that it is not used in LayoutTests for now. So, adding a test to JSTests/stress/ and that's all :) 1662280 8 401806 ysuzuki 2020-06-12 18:14:14 -0700 Comment on attachment 401806 Patch The patch looks good. Can you add a test to JSTests/stress? 1664664 9 402364 jdarpinian 2020-06-19 17:58:38 -0700 Created attachment 402364 add test 1664668 10 402364 ysuzuki 2020-06-19 18:16:03 -0700 Comment on attachment 402364 add test r=me 1664698 11 ews-feeder 2020-06-19 21:06:42 -0700 Committed r263315: <https://trac.webkit.org/changeset/263315> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402364. 401806 2020-06-12 17:00:03 -0700 2020-06-19 17:58:36 -0700 Patch bug-184232-20200612170003.patch text/plain 2526 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi ZGU5YzM0OWU2ZmM2NjM0NzA4N2NhYzJmYTBhMDdiMGM4MWZhODY0Li5hZTQzYWU2OTkxMjE2MWJk ODcyZDlhMGNlMzg4OTc2Y2JhNGIwZDI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNi0xMiAgSmFtZXMgRGFycGluaWFuICA8amRhcnBpbmlhbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgVHlwZWQgYXJyYXkgY29uc3RydWN0b3IgYmVoYXZlcyBkaWZm ZXJlbnRseSB3aGVuIGxlbmd0aCBpcyBub3QgcGFzc2VkIG9yIHdoZW4gdW5kZWZpbmVkIGlzIHBh c3NlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0 MjMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFz c2luZyB1bmRlZmluZWQgZm9yIGxlbmd0aCBzaG91bGQgaGF2ZSB0aGUgc2FtZSBlZmZlY3QgYXMg b21pdHRpbmcgdGhlIGFyZ3VtZW50LiBJdCB3YXMgYmVpbmcKKyAgICAgICAgdHJlYXRlZCBhcyAw IGluc3RlYWQuCisKKyAgICAgICAgKiBydW50aW1lL0pTR2VuZXJpY1R5cGVkQXJyYXlWaWV3Q29u c3RydWN0b3JJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OmNvbnN0cnVjdEdlbmVyaWNUeXBlZEFy cmF5Vmlldyk6CisKIDIwMjAtMDYtMDggIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBs ZS5jb20+CiAKICAgICAgICAgUmVtb3ZlZCB1bm5lZWRlZCBQT0lOVEVSX1dJRFRIIG1hY3JvIGZy b20gYjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2VuZXJp Y1R5cGVkQXJyYXlWaWV3Q29uc3RydWN0b3JJbmxpbmVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0dlbmVyaWNUeXBlZEFycmF5Vmlld0NvbnN0cnVjdG9ySW5saW5lcy5oCmlu ZGV4IGNmMDY3ZmFiMjZjOWFkNjBhMDEwZTAwYjU1Y2JmMTg0NDY3NjA1ZjUuLjM5NWEwYWZmNjMx ZGQwOWZlMjNhODUyZjI2YTFhNDJjN2U0MTc4MGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTR2VuZXJpY1R5cGVkQXJyYXlWaWV3Q29uc3RydWN0b3JJbmxpbmVz LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHZW5lcmljVHlwZWRBcnJh eVZpZXdDb25zdHJ1Y3RvcklubGluZXMuaApAQCAtMjM0LDE1ICsyMzQsMTAgQEAgRW5jb2RlZEpT VmFsdWUgSlNDX0hPU1RfQ0FMTCBjb25zdHJ1Y3RHZW5lcmljVHlwZWRBcnJheVZpZXcoSlNHbG9i YWxPYmplY3QqIGdsb2IKICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2Rl ZEpTVmFsdWUoKSk7CiAKICAgICAgICAgaWYgKGFyZ0NvdW50ID4gMikgewotICAgICAgICAgICAg aWYgKFZpZXdDbGFzczo6VHlwZWRBcnJheVN0b3JhZ2VUeXBlID09IFR5cGVEYXRhVmlldykgewot ICAgICAgICAgICAgICAgIC8vIElmIHRoZSBEYXRhVmlldyBieXRlTGVuZ3RoIGlzIHByZXNlbnQg YnV0IHVuZGVmaW5lZCwgdHJlYXQgaXQgYXMgbWlzc2luZy4KLSAgICAgICAgICAgICAgICBKU1Zh bHVlIGJ5dGVMZW5ndGhWYWx1ZSA9IGNhbGxGcmFtZS0+dW5jaGVja2VkQXJndW1lbnQoMik7Ci0g ICAgICAgICAgICAgICAgaWYgKCFieXRlTGVuZ3RoVmFsdWUuaXNVbmRlZmluZWQoKSkgewotICAg ICAgICAgICAgICAgICAgICBsZW5ndGggPSBieXRlTGVuZ3RoVmFsdWUudG9JbmRleChnbG9iYWxP YmplY3QsICJieXRlTGVuZ3RoIik7Ci0gICAgICAgICAgICAgICAgICAgIFJFVFVSTl9JRl9FWENF UFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwotICAgICAgICAgICAgICAgIH0KLSAgICAg ICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgbGVuZ3RoID0gY2FsbEZyYW1lLT51bmNo ZWNrZWRBcmd1bWVudCgyKS50b0luZGV4KGdsb2JhbE9iamVjdCwgImxlbmd0aCIpOworICAgICAg ICAgICAgLy8gSWYgdGhlIGxlbmd0aCB2YWx1ZSBpcyBwcmVzZW50IGJ1dCB1bmRlZmluZWQsIHRy ZWF0IGl0IGFzIG1pc3NpbmcuCisgICAgICAgICAgICBKU1ZhbHVlIGxlbmd0aFZhbHVlID0gY2Fs bEZyYW1lLT51bmNoZWNrZWRBcmd1bWVudCgyKTsKKyAgICAgICAgICAgIGlmICghbGVuZ3RoVmFs dWUuaXNVbmRlZmluZWQoKSkgeworICAgICAgICAgICAgICAgIGxlbmd0aCA9IGxlbmd0aFZhbHVl LnRvSW5kZXgoZ2xvYmFsT2JqZWN0LCBWaWV3Q2xhc3M6OlR5cGVkQXJyYXlTdG9yYWdlVHlwZSA9 PSBUeXBlRGF0YVZpZXcgPyAiYnl0ZUxlbmd0aCIgOiAibGVuZ3RoIik7CiAgICAgICAgICAgICAg ICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0K 402364 2020-06-19 17:58:38 -0700 2020-06-19 21:06:42 -0700 add test bug-184232-20200619175837.patch text/plain 3144 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi ZGU5YzM0OWU2ZmM2NjM0NzA4N2NhYzJmYTBhMDdiMGM4MWZhODY0Li5hZTQzYWU2OTkxMjE2MWJk ODcyZDlhMGNlMzg4OTc2Y2JhNGIwZDI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNi0xMiAgSmFtZXMgRGFycGluaWFuICA8amRhcnBpbmlhbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgVHlwZWQgYXJyYXkgY29uc3RydWN0b3IgYmVoYXZlcyBkaWZm ZXJlbnRseSB3aGVuIGxlbmd0aCBpcyBub3QgcGFzc2VkIG9yIHdoZW4gdW5kZWZpbmVkIGlzIHBh c3NlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0 MjMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFz c2luZyB1bmRlZmluZWQgZm9yIGxlbmd0aCBzaG91bGQgaGF2ZSB0aGUgc2FtZSBlZmZlY3QgYXMg b21pdHRpbmcgdGhlIGFyZ3VtZW50LiBJdCB3YXMgYmVpbmcKKyAgICAgICAgdHJlYXRlZCBhcyAw IGluc3RlYWQuCisKKyAgICAgICAgKiBydW50aW1lL0pTR2VuZXJpY1R5cGVkQXJyYXlWaWV3Q29u c3RydWN0b3JJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OmNvbnN0cnVjdEdlbmVyaWNUeXBlZEFy cmF5Vmlldyk6CisKIDIwMjAtMDYtMDggIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBs ZS5jb20+CiAKICAgICAgICAgUmVtb3ZlZCB1bm5lZWRlZCBQT0lOVEVSX1dJRFRIIG1hY3JvIGZy b20gYjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2VuZXJp Y1R5cGVkQXJyYXlWaWV3Q29uc3RydWN0b3JJbmxpbmVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0dlbmVyaWNUeXBlZEFycmF5Vmlld0NvbnN0cnVjdG9ySW5saW5lcy5oCmlu ZGV4IGNmMDY3ZmFiMjZjOWFkNjBhMDEwZTAwYjU1Y2JmMTg0NDY3NjA1ZjUuLjM5NWEwYWZmNjMx ZGQwOWZlMjNhODUyZjI2YTFhNDJjN2U0MTc4MGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTR2VuZXJpY1R5cGVkQXJyYXlWaWV3Q29uc3RydWN0b3JJbmxpbmVz LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHZW5lcmljVHlwZWRBcnJh eVZpZXdDb25zdHJ1Y3RvcklubGluZXMuaApAQCAtMjM0LDE1ICsyMzQsMTAgQEAgRW5jb2RlZEpT VmFsdWUgSlNDX0hPU1RfQ0FMTCBjb25zdHJ1Y3RHZW5lcmljVHlwZWRBcnJheVZpZXcoSlNHbG9i YWxPYmplY3QqIGdsb2IKICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2Rl ZEpTVmFsdWUoKSk7CiAKICAgICAgICAgaWYgKGFyZ0NvdW50ID4gMikgewotICAgICAgICAgICAg aWYgKFZpZXdDbGFzczo6VHlwZWRBcnJheVN0b3JhZ2VUeXBlID09IFR5cGVEYXRhVmlldykgewot ICAgICAgICAgICAgICAgIC8vIElmIHRoZSBEYXRhVmlldyBieXRlTGVuZ3RoIGlzIHByZXNlbnQg YnV0IHVuZGVmaW5lZCwgdHJlYXQgaXQgYXMgbWlzc2luZy4KLSAgICAgICAgICAgICAgICBKU1Zh bHVlIGJ5dGVMZW5ndGhWYWx1ZSA9IGNhbGxGcmFtZS0+dW5jaGVja2VkQXJndW1lbnQoMik7Ci0g ICAgICAgICAgICAgICAgaWYgKCFieXRlTGVuZ3RoVmFsdWUuaXNVbmRlZmluZWQoKSkgewotICAg ICAgICAgICAgICAgICAgICBsZW5ndGggPSBieXRlTGVuZ3RoVmFsdWUudG9JbmRleChnbG9iYWxP YmplY3QsICJieXRlTGVuZ3RoIik7Ci0gICAgICAgICAgICAgICAgICAgIFJFVFVSTl9JRl9FWENF UFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwotICAgICAgICAgICAgICAgIH0KLSAgICAg ICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgbGVuZ3RoID0gY2FsbEZyYW1lLT51bmNo ZWNrZWRBcmd1bWVudCgyKS50b0luZGV4KGdsb2JhbE9iamVjdCwgImxlbmd0aCIpOworICAgICAg ICAgICAgLy8gSWYgdGhlIGxlbmd0aCB2YWx1ZSBpcyBwcmVzZW50IGJ1dCB1bmRlZmluZWQsIHRy ZWF0IGl0IGFzIG1pc3NpbmcuCisgICAgICAgICAgICBKU1ZhbHVlIGxlbmd0aFZhbHVlID0gY2Fs bEZyYW1lLT51bmNoZWNrZWRBcmd1bWVudCgyKTsKKyAgICAgICAgICAgIGlmICghbGVuZ3RoVmFs dWUuaXNVbmRlZmluZWQoKSkgeworICAgICAgICAgICAgICAgIGxlbmd0aCA9IGxlbmd0aFZhbHVl LnRvSW5kZXgoZ2xvYmFsT2JqZWN0LCBWaWV3Q2xhc3M6OlR5cGVkQXJyYXlTdG9yYWdlVHlwZSA9 PSBUeXBlRGF0YVZpZXcgPyAiYnl0ZUxlbmd0aCIgOiAibGVuZ3RoIik7CiAgICAgICAgICAgICAg ICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3R5cGVkLWFycmF5 LWNvbnN0cnVjdG9yLXVuZGVmaW5lZC5qcyBiL0pTVGVzdHMvc3RyZXNzL3R5cGVkLWFycmF5LWNv bnN0cnVjdG9yLXVuZGVmaW5lZC5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kYjc1MGUzODc2ZWZjZWM2NTQ1YWM2 ZmRjZmFiM2RhYTY1ODA0ZjE3Ci0tLSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvdHlw ZWQtYXJyYXktY29uc3RydWN0b3ItdW5kZWZpbmVkLmpzCkBAIC0wLDAgKzEsNCBAQAorLy8gVW5k ZWZpbmVkIGZvciBsZW5ndGggYXJndW1lbnQgb2YgdHlwZWQgYXJyYXkgY29uc3RydWN0b3Igc2hv dWxkIGJlIHRyZWF0ZWQKKy8vIHRoZSBzYW1lIGFzIGlmIHRoZSBhcmd1bWVudCB3YXMgb21pdHRl ZCwgbWVhbmluZyB0aGUgd2hvbGUgYnVmZmVyIGlzIHVzZWQuCitpZiAobmV3IFVpbnQ4QXJyYXko bmV3IEFycmF5QnVmZmVyKDMpLCAwLCB1bmRlZmluZWQpLmxlbmd0aCAhPSAzKQorICAgIHRocm93 ICJ1bmRlZmluZWQgbGVuZ3RoIHNob3VsZCByZXN1bHQgaW4gdGhlIHdob2xlIGJ1ZmZlciBiZWlu ZyB1c2VkIjsK