184229 2018-04-01 17:37:13 -0700 Remove Options constructor and use internal linkage for option handlers 2018-04-02 11:10:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aestes lforschler webkit-bug-importer oldest_to_newest 1410983 0 dbates 2018-04-01 17:37:13 -0700 Remove Options constructor and use internal linkage for option handlers. 1410984 1 336966 dbates 2018-04-01 17:37:57 -0700 Created attachment 336966 Patch 1411157 2 336966 dbates 2018-04-02 11:09:09 -0700 Comment on attachment 336966 Patch Clearing flags on attachment: 336966 Committed r230166: <https://trac.webkit.org/changeset/230166> 1411158 3 dbates 2018-04-02 11:09:10 -0700 All reviewed patches have been landed. Closing bug. 1411161 4 webkit-bug-importer 2018-04-02 11:10:21 -0700 <rdar://problem/39111501> 336966 2018-04-01 17:37:57 -0700 2018-04-02 11:09:09 -0700 Patch bug-184229-20180401173757.patch text/plain 7291 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDc3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2M1NmMxMmZmNjAxMDYwOTMxMmVmMGYwMjAzOGJiNTNl ZjlmNDgwMy4uMzc5ZWExYmE3ZGQ2MTZlN2RiMTdiNmVhN2QwYWZiYWFkZGVkZjZhMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMw IEBACisyMDE4LTA0LTAxICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBSZW1vdmUgT3B0aW9ucyBjb25zdHJ1Y3RvciBhbmQgdXNlIGludGVybmFsIGxpbmthZ2Ug Zm9yIG9wdGlvbiBoYW5kbGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg0MjI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXNlIEMrKzExIGRlZmF1bHQgaW5pdGlhbGl6ZXIgc3ludGF4IHRvIHJlbW92 ZSB0aGUgbmVlZCB0byBleHBsaWNpdGx5IGhhdmUgYSBjb25zdHJ1Y3RvcgorICAgICAgICBmb3Ig dGhlIHN0cnVjdCBPcHRpb25zLiBVc2UgaW50ZXJuYWwgbGlua2FnZSBmb3Igb3B0aW9uIGhhbmRs ZXIgZnVuY3Rpb25zIGFzIHRoZXNlCisgICAgICAgIGFyZSBuZXZlciBpbnZva2VkIG91dHNpZGUg dGhlIHRyYW5zbGF0aW9uIHVuaXQgdGhleSBhcmUgZGVmaW5lZCBpbi4KKworICAgICAgICAqIFdl YktpdFRlc3RSdW5uZXIvT3B0aW9ucy5jcHA6CisgICAgICAgIChXVFI6OmhhbmRsZU9wdGlvbk5v VGltZW91dCk6CisgICAgICAgIChXVFI6OmhhbmRsZU9wdGlvblZlcmJvc2UpOgorICAgICAgICAo V1RSOjpoYW5kbGVPcHRpb25HY0JldHdlZW5UZXN0cyk6CisgICAgICAgIChXVFI6OmhhbmRsZU9w dGlvblBpeGVsVGVzdHMpOgorICAgICAgICAoV1RSOjpoYW5kbGVPcHRpb25QcmludFN1cHBvcnRl ZEZlYXR1cmVzKToKKyAgICAgICAgKFdUUjo6aGFuZGxlT3B0aW9uQ29tcGxleFRleHQpOgorICAg ICAgICAoV1RSOjpoYW5kbGVPcHRpb25BY2NlbGVyYXRlZERyYXdpbmcpOgorICAgICAgICAoV1RS OjpoYW5kbGVPcHRpb25SZW1vdGVMYXllclRyZWUpOgorICAgICAgICAoV1RSOjpoYW5kbGVPcHRp b25TaG93V2ViVmlldyk6CisgICAgICAgIChXVFI6OmhhbmRsZU9wdGlvblNob3dUb3VjaGVzKToK KyAgICAgICAgKFdUUjo6aGFuZGxlT3B0aW9uQWxsb3dlZEhvc3QpOgorICAgICAgICAoV1RSOjpo YW5kbGVPcHRpb25Vbm1hdGNoZWQpOgorICAgICAgICAoV1RSOjpPcHRpb25zOjpPcHRpb25zKTog RGVsZXRlZC4KKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL09wdGlvbnMuaDoKKwogMjAxOC0w My0yOSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMYXlvdXRS ZWxvYWRlZF0gRGVjb3VwbGUgZm9ybWF0dGluZyBzdGF0ZSBhbmQgY29udGV4dCBsaWZldGltZS4K ZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvT3B0aW9ucy5jcHAgYi9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL09wdGlvbnMuY3BwCmluZGV4IDQ1MDhjZjJhZjk2MDgyMjRkNjlmOTRl MzIwMDFhYmVjYTM4MTJkNjMuLmUyNjkwNzE2N2NmNjFiMjNiY2JjNGEyMTgwNDRhM2VmNGVhODMy ODAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvT3B0aW9ucy5jcHAKKysrIGIv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9PcHRpb25zLmNwcApAQCAtMSw3ICsxLDcgQEAKIC8qCiAg KiBDb3B5cmlnaHQgKEMpIDIwMTMgVW5pdmVyc2l0eSBvZiBTemVnZWQuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAgKiBDb3B5cmlnaHQgKEMpIDIwMTMgU2Ftc3VuZyBFbGVjdHJvbmljcy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KLSAqIENvcHlyaWdodCAoQykgMjAxNSBBcHBsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTUtMjAxOCBBcHBsZSBJbmMuIEFsbCBy aWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2Ug YW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBw ZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTMyLDg5 ICszMiw3NCBAQAogCiBuYW1lc3BhY2UgV1RSIHsKIAotT3B0aW9uczo6T3B0aW9ucygpCi0gICAg OiB1c2VXYWl0VG9EdW1wV2F0Y2hkb2dUaW1lcih0cnVlKQotICAgICwgZm9yY2VOb1RpbWVvdXQo ZmFsc2UpCi0gICAgLCB2ZXJib3NlKGZhbHNlKQotICAgICwgZ2NCZXR3ZWVuVGVzdHMoZmFsc2Up Ci0gICAgLCBzaG91bGREdW1wUGl4ZWxzRm9yQWxsVGVzdHMoZmFsc2UpCi0gICAgLCBwcmludFN1 cHBvcnRlZEZlYXR1cmVzKGZhbHNlKQotICAgICwgZm9yY2VDb21wbGV4VGV4dChmYWxzZSkKLSAg ICAsIHNob3VsZFVzZUFjY2VsZXJhdGVkRHJhd2luZyhmYWxzZSkKLSAgICAsIHNob3VsZFVzZVJl bW90ZUxheWVyVHJlZShmYWxzZSkKLSAgICAsIHNob3VsZFNob3dXZWJWaWV3KGZhbHNlKQotICAg ICwgc2hvdWxkU2hvd1RvdWNoZXMoZmFsc2UpCi17Ci19Ci0KLWJvb2wgaGFuZGxlT3B0aW9uTm9U aW1lb3V0KE9wdGlvbnMmIG9wdGlvbnMsIGNvbnN0IGNoYXIqLCBjb25zdCBjaGFyKikKK3N0YXRp YyBib29sIGhhbmRsZU9wdGlvbk5vVGltZW91dChPcHRpb25zJiBvcHRpb25zLCBjb25zdCBjaGFy KiwgY29uc3QgY2hhciopCiB7CiAgICAgb3B0aW9ucy51c2VXYWl0VG9EdW1wV2F0Y2hkb2dUaW1l ciA9IGZhbHNlOwogICAgIG9wdGlvbnMuZm9yY2VOb1RpbWVvdXQgPSB0cnVlOwogICAgIHJldHVy biB0cnVlOwogfQogCi1ib29sIGhhbmRsZU9wdGlvblZlcmJvc2UoT3B0aW9ucyYgb3B0aW9ucywg Y29uc3QgY2hhciosIGNvbnN0IGNoYXIqKQorc3RhdGljIGJvb2wgaGFuZGxlT3B0aW9uVmVyYm9z ZShPcHRpb25zJiBvcHRpb25zLCBjb25zdCBjaGFyKiwgY29uc3QgY2hhciopCiB7CiAgICAgb3B0 aW9ucy52ZXJib3NlID0gdHJ1ZTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotYm9vbCBoYW5kbGVP cHRpb25HY0JldHdlZW5UZXN0cyhPcHRpb25zJiBvcHRpb25zLCBjb25zdCBjaGFyKiwgY29uc3Qg Y2hhciopCitzdGF0aWMgYm9vbCBoYW5kbGVPcHRpb25HY0JldHdlZW5UZXN0cyhPcHRpb25zJiBv cHRpb25zLCBjb25zdCBjaGFyKiwgY29uc3QgY2hhciopCiB7CiAgICAgb3B0aW9ucy5nY0JldHdl ZW5UZXN0cyA9IHRydWU7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLWJvb2wgaGFuZGxlT3B0aW9u UGl4ZWxUZXN0cyhPcHRpb25zJiBvcHRpb25zLCBjb25zdCBjaGFyKiwgY29uc3QgY2hhciopCitz dGF0aWMgYm9vbCBoYW5kbGVPcHRpb25QaXhlbFRlc3RzKE9wdGlvbnMmIG9wdGlvbnMsIGNvbnN0 IGNoYXIqLCBjb25zdCBjaGFyKikKIHsKICAgICBvcHRpb25zLnNob3VsZER1bXBQaXhlbHNGb3JB bGxUZXN0cyA9IHRydWU7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLWJvb2wgaGFuZGxlT3B0aW9u UHJpbnRTdXBwb3J0ZWRGZWF0dXJlcyhPcHRpb25zJiBvcHRpb25zLCBjb25zdCBjaGFyKiwgY29u c3QgY2hhciopCitzdGF0aWMgYm9vbCBoYW5kbGVPcHRpb25QcmludFN1cHBvcnRlZEZlYXR1cmVz KE9wdGlvbnMmIG9wdGlvbnMsIGNvbnN0IGNoYXIqLCBjb25zdCBjaGFyKikKIHsKICAgICBvcHRp b25zLnByaW50U3VwcG9ydGVkRmVhdHVyZXMgPSB0cnVlOwogICAgIHJldHVybiB0cnVlOwogfQog Ci1ib29sIGhhbmRsZU9wdGlvbkNvbXBsZXhUZXh0KE9wdGlvbnMmIG9wdGlvbnMsIGNvbnN0IGNo YXIqLCBjb25zdCBjaGFyKikKK3N0YXRpYyBib29sIGhhbmRsZU9wdGlvbkNvbXBsZXhUZXh0KE9w dGlvbnMmIG9wdGlvbnMsIGNvbnN0IGNoYXIqLCBjb25zdCBjaGFyKikKIHsKICAgICBvcHRpb25z LmZvcmNlQ29tcGxleFRleHQgPSB0cnVlOwogICAgIHJldHVybiB0cnVlOwogfQogCi1ib29sIGhh bmRsZU9wdGlvbkFjY2VsZXJhdGVkRHJhd2luZyhPcHRpb25zJiBvcHRpb25zLCBjb25zdCBjaGFy KiwgY29uc3QgY2hhciopCitzdGF0aWMgYm9vbCBoYW5kbGVPcHRpb25BY2NlbGVyYXRlZERyYXdp bmcoT3B0aW9ucyYgb3B0aW9ucywgY29uc3QgY2hhciosIGNvbnN0IGNoYXIqKQogewogICAgIG9w dGlvbnMuc2hvdWxkVXNlQWNjZWxlcmF0ZWREcmF3aW5nID0gdHJ1ZTsKICAgICByZXR1cm4gdHJ1 ZTsKIH0KIAotYm9vbCBoYW5kbGVPcHRpb25SZW1vdGVMYXllclRyZWUoT3B0aW9ucyYgb3B0aW9u cywgY29uc3QgY2hhciosIGNvbnN0IGNoYXIqKQorc3RhdGljIGJvb2wgaGFuZGxlT3B0aW9uUmVt b3RlTGF5ZXJUcmVlKE9wdGlvbnMmIG9wdGlvbnMsIGNvbnN0IGNoYXIqLCBjb25zdCBjaGFyKikK IHsKICAgICBvcHRpb25zLnNob3VsZFVzZVJlbW90ZUxheWVyVHJlZSA9IHRydWU7CiAgICAgcmV0 dXJuIHRydWU7CiB9CiAKLWJvb2wgaGFuZGxlT3B0aW9uU2hvd1dlYlZpZXcoT3B0aW9ucyYgb3B0 aW9ucywgY29uc3QgY2hhciosIGNvbnN0IGNoYXIqKQorc3RhdGljIGJvb2wgaGFuZGxlT3B0aW9u U2hvd1dlYlZpZXcoT3B0aW9ucyYgb3B0aW9ucywgY29uc3QgY2hhciosIGNvbnN0IGNoYXIqKQog ewogICAgIG9wdGlvbnMuc2hvdWxkU2hvd1dlYlZpZXcgPSB0cnVlOwogICAgIHJldHVybiB0cnVl OwogfQotICAgIAotYm9vbCBoYW5kbGVPcHRpb25TaG93VG91Y2hlcyhPcHRpb25zJiBvcHRpb25z LCBjb25zdCBjaGFyKiwgY29uc3QgY2hhciopCisKK3N0YXRpYyBib29sIGhhbmRsZU9wdGlvblNo b3dUb3VjaGVzKE9wdGlvbnMmIG9wdGlvbnMsIGNvbnN0IGNoYXIqLCBjb25zdCBjaGFyKikKIHsK ICAgICBvcHRpb25zLnNob3VsZFNob3dUb3VjaGVzID0gdHJ1ZTsKICAgICByZXR1cm4gdHJ1ZTsK IH0KIAotYm9vbCBoYW5kbGVPcHRpb25BbGxvd2VkSG9zdChPcHRpb25zJiBvcHRpb25zLCBjb25z dCBjaGFyKiwgY29uc3QgY2hhciogaG9zdCkKK3N0YXRpYyBib29sIGhhbmRsZU9wdGlvbkFsbG93 ZWRIb3N0KE9wdGlvbnMmIG9wdGlvbnMsIGNvbnN0IGNoYXIqLCBjb25zdCBjaGFyKiBob3N0KQog ewogICAgIG9wdGlvbnMuYWxsb3dlZEhvc3RzLnB1c2hfYmFjayhob3N0KTsKICAgICByZXR1cm4g dHJ1ZTsKIH0KIAotYm9vbCBoYW5kbGVPcHRpb25Vbm1hdGNoZWQoT3B0aW9ucyYgb3B0aW9ucywg Y29uc3QgY2hhciogb3B0aW9uLCBjb25zdCBjaGFyKikKK3N0YXRpYyBib29sIGhhbmRsZU9wdGlv blVubWF0Y2hlZChPcHRpb25zJiBvcHRpb25zLCBjb25zdCBjaGFyKiBvcHRpb24sIGNvbnN0IGNo YXIqKQogewogICAgIGlmIChvcHRpb25bMF0gJiYgb3B0aW9uWzFdICYmIG9wdGlvblswXSA9PSAn LScgJiYgb3B0aW9uWzFdID09ICctJykKICAgICAgICAgcmV0dXJuIHRydWU7CmRpZmYgLS1naXQg YS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL09wdGlvbnMuaCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvT3B0aW9ucy5oCmluZGV4IDlmMDcxN2M5YTY2OTVmOTlhMDkyNTFhM2VlYTM1YWMyZTk3YTdh OTQuLmQzODhmYzE3MjlhZGQ1NzczZjY0MmIyNTgzMTk2MGVhYTQ3MzgwOTMgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvT3B0aW9ucy5oCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvT3B0aW9ucy5oCkBAIC0xLDcgKzEsNyBAQAogLyoKICAqIENvcHlyaWdodCAoQykgMjAx MyBVbml2ZXJzaXR5IG9mIFN6ZWdlZC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdo dCAoQykgMjAxMyBTYW1zdW5nIEVsZWN0cm9uaWNzLiBBbGwgcmlnaHRzIHJlc2VydmVkLgotICog Q29weXJpZ2h0IChDKSAyMDE1IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENv cHlyaWdodCAoQykgMjAxNS0yMDE4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAq CiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3 aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0 aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMjUsOCArMjUsNyBAQAogICogT0YgVEhJ UyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERB TUFHRS4KICAqLwogCi0jaWZuZGVmIE9wdGlvbnNfaAotI2RlZmluZSBPcHRpb25zX2gKKyNwcmFn bWEgb25jZQogCiAjaW5jbHVkZSA8ZnVuY3Rpb25hbD4KICNpbmNsdWRlIDxzdGRpby5oPgpAQCAt MzcsMTggKzM2LDE3IEBACiBuYW1lc3BhY2UgV1RSIHsKIAogc3RydWN0IE9wdGlvbnMgewotICAg IE9wdGlvbnMoKTsKLSAgICBib29sIHVzZVdhaXRUb0R1bXBXYXRjaGRvZ1RpbWVyOwotICAgIGJv b2wgZm9yY2VOb1RpbWVvdXQ7Ci0gICAgYm9vbCB2ZXJib3NlOwotICAgIGJvb2wgZ2NCZXR3ZWVu VGVzdHM7Ci0gICAgYm9vbCBzaG91bGREdW1wUGl4ZWxzRm9yQWxsVGVzdHM7Ci0gICAgYm9vbCBw cmludFN1cHBvcnRlZEZlYXR1cmVzOwotICAgIGJvb2wgZm9yY2VDb21wbGV4VGV4dDsKLSAgICBi b29sIHNob3VsZFVzZUFjY2VsZXJhdGVkRHJhd2luZzsKLSAgICBib29sIHNob3VsZFVzZVJlbW90 ZUxheWVyVHJlZTsKLSAgICBib29sIHNob3VsZFNob3dXZWJWaWV3OwotICAgIGJvb2wgc2hvdWxk U2hvd1RvdWNoZXM7CisgICAgYm9vbCB1c2VXYWl0VG9EdW1wV2F0Y2hkb2dUaW1lciB7IHRydWUg fTsKKyAgICBib29sIGZvcmNlTm9UaW1lb3V0IHsgZmFsc2UgfTsKKyAgICBib29sIHZlcmJvc2Ug eyBmYWxzZSB9OworICAgIGJvb2wgZ2NCZXR3ZWVuVGVzdHMgeyBmYWxzZSB9OworICAgIGJvb2wg c2hvdWxkRHVtcFBpeGVsc0ZvckFsbFRlc3RzIHsgZmFsc2UgfTsKKyAgICBib29sIHByaW50U3Vw cG9ydGVkRmVhdHVyZXMgeyBmYWxzZSB9OworICAgIGJvb2wgZm9yY2VDb21wbGV4VGV4dCB7IGZh bHNlIH07CisgICAgYm9vbCBzaG91bGRVc2VBY2NlbGVyYXRlZERyYXdpbmcgeyBmYWxzZSB9Owor ICAgIGJvb2wgc2hvdWxkVXNlUmVtb3RlTGF5ZXJUcmVlIHsgZmFsc2UgfTsKKyAgICBib29sIHNo b3VsZFNob3dXZWJWaWV3IHsgZmFsc2UgfTsKKyAgICBib29sIHNob3VsZFNob3dUb3VjaGVzIHsg ZmFsc2UgfTsKICAgICBzdGQ6OnZlY3RvcjxzdGQ6OnN0cmluZz4gcGF0aHM7CiAgICAgc3RkOjp2 ZWN0b3I8c3RkOjpzdHJpbmc+IGFsbG93ZWRIb3N0czsKIH07CkBAIC03Nyw0ICs3NSwzIEBAIHBy aXZhdGU6CiAKIH0gLy8gbmFtZXNwYWNlIFdUUgogCi0jZW5kaWYgLy8gT3B0aW9uc19oCg==