184224 2018-04-01 00:05:36 -0700 [CMake] gperf path should be given when WebCore/css/makevalues.pl is executed 2018-04-03 11:15:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 Yousuke.Kimoto webkit-unassigned achristensen annulen commit-queue don.olmstead lforschler webkit-bug-importer oldest_to_newest 1410946 0 Yousuke.Kimoto 2018-04-01 00:05:36 -0700 WebCore/css/makevalues.pl uses gperf to generate derived sources but it expects gperf should be found in "Path", an environment value. When a path to gperf is required to be specified with a concrete path depending building environments, the generating process fails. To solve this issue, a full path for "gperf" should be given to the CMake rule, like a CMake rule for WebCore/css/makeprop.pl 1410988 1 336968 Yousuke.Kimoto 2018-04-01 18:41:55 -0700 Created attachment 336968 Patch 1411153 2 336968 annulen 2018-04-02 11:07:21 -0700 Comment on attachment 336968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336968&action=review > Source/WebCore/css/makevalues.pl:34 > +my $customGperf; You can reduce complexity here my $gperf = $ENV{GPERF} ? $ENV{GPERF} : "gperf"; > Source/WebCore/css/makevalues.pl:37 > + 'gperf-executable=s' => \$customGperf); 'gperf-executable=s' => \$gperf > Source/WebCore/css/makevalues.pl:177 > +my $gperf = $ENV{GPERF} ? $ENV{GPERF} : ($customGperf ? $customGperf : "gperf"); ... and remove this line 1411401 3 Yousuke.Kimoto 2018-04-03 06:37:55 -0700 Thank you for your review. (In reply to Konstantin Tokarev from comment #2) > Comment on attachment 336968 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=336968&action=review > > > Source/WebCore/css/makevalues.pl:34 > > +my $customGperf; > > You can reduce complexity here > > my $gperf = $ENV{GPERF} ? $ENV{GPERF} : "gperf"; > > > Source/WebCore/css/makevalues.pl:37 > > + 'gperf-executable=s' => \$customGperf); > > 'gperf-executable=s' => \$gperf I'll follow your comment. > > Source/WebCore/css/makevalues.pl:177 > > +my $gperf = $ENV{GPERF} ? $ENV{GPERF} : ($customGperf ? $customGperf : "gperf"); > > ... and remove this line Also, I'll do it. 1411402 4 337075 Yousuke.Kimoto 2018-04-03 06:38:20 -0700 Created attachment 337075 Patch 1411486 5 337075 commit-queue 2018-04-03 11:14:48 -0700 Comment on attachment 337075 Patch Clearing flags on attachment: 337075 Committed r230212: <https://trac.webkit.org/changeset/230212> 1411487 6 commit-queue 2018-04-03 11:14:49 -0700 All reviewed patches have been landed. Closing bug. 1411490 7 webkit-bug-importer 2018-04-03 11:15:24 -0700 <rdar://problem/39147341> 336968 2018-04-01 18:41:55 -0700 2018-04-03 06:38:13 -0700 Patch bug-184224-20180402104251.patch text/plain 3107 Yousuke.Kimoto U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU1MzE2NDI0MjUzYjFl NmUyOGUwY2Q5MTA0NTZmZjhmZTljZGRjMC4uZDczOTdmMWJmNTIzMGJkMjQyM2IxMmM3MGM4MTMz NmM0OGE0YWY0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA0LTAxICBZb3Vz dWtlIEtpbW90byAgPHlvdXN1a2Uua2ltb3RvQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV0g Z3BlcmYgcGF0aCBzaG91bGQgYmUgZ2l2ZW4gd2hlbiBXZWJDb3JlL2Nzcy9tYWtldmFsdWVzLnBs IGlzIGV4ZWN1dGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODQyMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXaGVuIGEgYnVpbGRpbmcgZXZpcm9ubWVudCBkb2Vucyd0IGluY2x1ZGUgYSBwYXRoIHRv IGdwZXJmLAorICAgICAgICBXZWJDb3JlL2Nzcy9tYWtldmFsdWUucGwgZmFpbGVzIGR1ZSB0byBm YWlsaW5nIHRvIGV4ZWN1dGUgZ3BlcmYsCisgICAgICAgIHNvIHRoZSBmdWxsIHBhdGggdG8gZ3Bl cmYgc2hvdWxkIGJlIGdpdmVuIGxpa2UgV2ViQ29yZS9jc3MvbWFrZXByb3AucGwuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCBubyBXZWItZmFjaW5nIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAg ICAqIENNYWtlTGlzdHMudHh0OiBncGVyZiBwYXRoIGlzIGdpdmVuIHRvIGNzcy9tYWtldmFsdWVz LnBsLgorICAgICAgICAqIGNzcy9tYWtldmFsdWVzLnBsOiBBZGRlZCBhbiBhcmd1bWVudCB0byBo YW5kbGUgYSBnaXZlbiBncGVyZiBwYXRoLgorCiAyMDE4LTAzLTMwICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBOZXR3b3JrTG9hZENoZWNrZXIgc2hvdWxkIHVw Z3JhZGUgcmVkaXJlY3RzIGlmIG5lZWRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ01h a2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCA1MDYzZDI3 YjE2YTBjODIyOGFiMTZhYTgxNDkyNjBmNTM1MmZmZDAwLi40Y2JlMTNjODhkMDI5NGFiYzFiMDE3 OWUwYTc4Mzg1YmIwNDI4YzdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3Rz LnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMTcxNCw3ICsxNzE0 LDcgQEAgYWRkX2N1c3RvbV9jb21tYW5kKAogICAgIERFUEVORFMgJHtXZWJDb3JlX0NTU19WQUxV RV9LRVlXT1JEU30KICAgICBXT1JLSU5HX0RJUkVDVE9SWSAke0RFUklWRURfU09VUkNFU19XRUJD T1JFX0RJUn0KICAgICBDT01NQU5EICR7UEVSTF9FWEVDVVRBQkxFfSAtbmUgInByaW50IiAke1dl YkNvcmVfQ1NTX1ZBTFVFX0tFWVdPUkRTfSA+ICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElS fS9DU1NWYWx1ZUtleXdvcmRzLmluCi0gICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gJHtX RUJDT1JFX0RJUn0vY3NzL21ha2V2YWx1ZXMucGwgLS1kZWZpbmVzICIke0ZFQVRVUkVfREVGSU5F U19XSVRIX1NQQUNFX1NFUEFSQVRPUn0iIC0tcHJlcHJvY2Vzc29yICIke0NPREVfR0VORVJBVE9S X1BSRVBST0NFU1NPUn0iCisgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gJHtXRUJDT1JF X0RJUn0vY3NzL21ha2V2YWx1ZXMucGwgLS1kZWZpbmVzICIke0ZFQVRVUkVfREVGSU5FU19XSVRI X1NQQUNFX1NFUEFSQVRPUn0iIC0tcHJlcHJvY2Vzc29yICIke0NPREVfR0VORVJBVE9SX1BSRVBS T0NFU1NPUn0iIC0tZ3BlcmYtZXhlY3V0YWJsZSAiJHtHUEVSRl9FWEVDVVRBQkxFfSIKICAgICBW RVJCQVRJTSkKIGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUyAke0RFUklWRURfU09VUkNFU19X RUJDT1JFX0RJUn0vQ1NTVmFsdWVLZXl3b3Jkcy5jcHApCiBBRERfU09VUkNFX1dFQkNPUkVfREVS SVZFRF9ERVBFTkRFTkNJRVMoJHtXRUJDT1JFX0RJUn0vY3NzL0NTU1BhcnNlci5jcHAgQ1NTVmFs dWVLZXl3b3Jkcy5oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL21ha2V2YWx1ZXMu cGwgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXZhbHVlcy5wbAppbmRleCBiMWIxNDRmZDExNzcw Mzg4ZWM2MmYwY2EzNzQyOTNmMWQ2Y2I2ZmRiLi4wNGQ2YTdjZjU3MmM4Y2ZlNTI0ZjE4YmUxNWNj YjdmN2UzMjhlN2NlIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXZhbHVlcy5w bAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXZhbHVlcy5wbApAQCAtMzEsOCArMzEsMTAg QEAgdXNlIHdhcm5pbmdzOwogCiBteSAkZGVmaW5lczsKIG15ICRwcmVwcm9jZXNzb3I7CitteSAk Y3VzdG9tR3BlcmY7CiBHZXRPcHRpb25zKCdkZWZpbmVzPXMnID0+IFwkZGVmaW5lcywKLSAgICAg ICAgICAgJ3ByZXByb2Nlc3Nvcj1zJyA9PiBcJHByZXByb2Nlc3Nvcik7CisgICAgICAgICAgICdw cmVwcm9jZXNzb3I9cycgPT4gXCRwcmVwcm9jZXNzb3IsCisgICAgICAgICAgICdncGVyZi1leGVj dXRhYmxlPXMnID0+IFwkY3VzdG9tR3BlcmYpOwogCiBteSBATkFNRVMgPSBhcHBseVByZXByb2Nl c3NvcigiQ1NTVmFsdWVLZXl3b3Jkcy5pbiIsICRkZWZpbmVzLCAkcHJlcHJvY2Vzc29yKTsKIApA QCAtMTcyLDUgKzE3NCw1IEBAIGNvbnN0IGNoYXIqIGdldFZhbHVlTmFtZSh1bnNpZ25lZCBzaG9y dCBpZCk7CiBFT0YKIGNsb3NlIEhFQURFUjsKIAotbXkgJGdwZXJmID0gJEVOVntHUEVSRn0gPyAk RU5We0dQRVJGfSA6ICJncGVyZiI7CitteSAkZ3BlcmYgPSAkRU5We0dQRVJGfSA/ICRFTlZ7R1BF UkZ9IDogKCRjdXN0b21HcGVyZiA/ICRjdXN0b21HcGVyZiA6ICJncGVyZiIpOwogc3lzdGVtKCJc IiRncGVyZlwiIC0ta2V5LXBvc2l0aW9ucz1cIipcIiAtRCAtbiAtcyAyIENTU1ZhbHVlS2V5d29y ZHMuZ3BlcmYgLS1vdXRwdXQtZmlsZT1DU1NWYWx1ZUtleXdvcmRzLmNwcCIpID09IDAgfHwgZGll ICJjYWxsaW5nIGdwZXJmIGZhaWxlZDogJD8iOwo= 337075 2018-04-03 06:38:20 -0700 2018-04-03 11:14:48 -0700 Patch bug-184224-20180403223926.patch text/plain 3121 Yousuke.Kimoto U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDFmNzA0Mjc2MGJmMjc2 Mjk1NjNjZDBhYmE1ZjMzMTBjY2EzOWY0Zi4uNTE0MGM4NGQyYjkyNWZlY2UwNGM5ZDFjY2E5OWQ1 ZDY0YjViMjhhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA0LTAzICBZb3Vz dWtlIEtpbW90byAgPHlvdXN1a2Uua2ltb3RvQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV0g Z3BlcmYgcGF0aCBzaG91bGQgYmUgZ2l2ZW4gd2hlbiBXZWJDb3JlL2Nzcy9tYWtldmFsdWVzLnBs IGlzIGV4ZWN1dGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODQyMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXaGVuIGEgYnVpbGRpbmcgZXZpcm9ubWVudCBkb2Vucyd0IGluY2x1ZGUgYSBwYXRoIHRv IGdwZXJmLAorICAgICAgICBXZWJDb3JlL2Nzcy9tYWtldmFsdWUucGwgZmFpbGVzIGR1ZSB0byBm YWlsaW5nIHRvIGV4ZWN1dGUgZ3BlcmYsCisgICAgICAgIHNvIHRoZSBmdWxsIHBhdGggdG8gZ3Bl cmYgc2hvdWxkIGJlIGdpdmVuIGxpa2UgV2ViQ29yZS9jc3MvbWFrZXByb3AucGwuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCBubyBXZWItZmFjaW5nIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAg ICAqIENNYWtlTGlzdHMudHh0OiBncGVyZiBwYXRoIGlzIGdpdmVuIHRvIGNzcy9tYWtldmFsdWVz LnBsLgorICAgICAgICAqIGNzcy9tYWtldmFsdWVzLnBsOiBBZGQgYW4gYXJndW1lbnQgdG8gaGFu ZGxlIGEgZ2l2ZW4gZ3BlcmYgcGF0aC4KKwogMjAxOC0wNC0wMiAgRXJpYyBDYXJsc29uICA8ZXJp Yy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBbRXh0cmEgem9vbSBtb2RlXSBSZXBsYWNl IHZpZGVvIHdpdGggYSBwbGFjZWhvbGRlciBpbWFnZSBkdXJpbmcgZnVsbHNjcmVlbiB0cmFuc2l0 aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9X ZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IDJiZWZjYzQ2NGNlMjI2NTc3NTNjYTdjMWU1MDcw N2I4ZTQ0MWZmMTIuLjBkMWVlN2Y5NjkyMjA4ZmEzMGZmMzhmOWY2NWIzZWU4MDY1NTYyMjAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJD b3JlL0NNYWtlTGlzdHMudHh0CkBAIC0xNzI2LDcgKzE3MjYsNyBAQCBhZGRfY3VzdG9tX2NvbW1h bmQoCiAgICAgREVQRU5EUyAke1dlYkNvcmVfQ1NTX1ZBTFVFX0tFWVdPUkRTfQogICAgIFdPUktJ TkdfRElSRUNUT1JZICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfQogICAgIENPTU1BTkQg JHtQRVJMX0VYRUNVVEFCTEV9IC1uZSAicHJpbnQiICR7V2ViQ29yZV9DU1NfVkFMVUVfS0VZV09S RFN9ID4gJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L0NTU1ZhbHVlS2V5d29yZHMuaW4K LSAgICBDT01NQU5EICR7UEVSTF9FWEVDVVRBQkxFfSAke1dFQkNPUkVfRElSfS9jc3MvbWFrZXZh bHVlcy5wbCAtLWRlZmluZXMgIiR7RkVBVFVSRV9ERUZJTkVTX1dJVEhfU1BBQ0VfU0VQQVJBVE9S fSIgLS1wcmVwcm9jZXNzb3IgIiR7Q09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SfSIKKyAgICBD T01NQU5EICR7UEVSTF9FWEVDVVRBQkxFfSAke1dFQkNPUkVfRElSfS9jc3MvbWFrZXZhbHVlcy5w bCAtLWRlZmluZXMgIiR7RkVBVFVSRV9ERUZJTkVTX1dJVEhfU1BBQ0VfU0VQQVJBVE9SfSIgLS1w cmVwcm9jZXNzb3IgIiR7Q09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SfSIgLS1ncGVyZi1leGVj dXRhYmxlICIke0dQRVJGX0VYRUNVVEFCTEV9IgogICAgIFZFUkJBVElNKQogbGlzdChBUFBFTkQg V2ViQ29yZV9TT1VSQ0VTICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9DU1NWYWx1ZUtl eXdvcmRzLmNwcCkKIEFERF9TT1VSQ0VfV0VCQ09SRV9ERVJJVkVEX0RFUEVOREVOQ0lFUygke1dF QkNPUkVfRElSfS9jc3MvQ1NTUGFyc2VyLmNwcCBDU1NWYWx1ZUtleXdvcmRzLmgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXZhbHVlcy5wbCBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9tYWtldmFsdWVzLnBsCmluZGV4IGIxYjE0NGZkMTE3NzAzODhlYzYyZjBjYTM3NDI5M2YxZDZj YjZmZGIuLjU1YzRlNzUwOTdhN2ZhNTRhNGFiNmExMjZlMzliYTQzMzk4YmE1NWYgMTAwNzU1Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtldmFsdWVzLnBsCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9tYWtldmFsdWVzLnBsCkBAIC0zMSw4ICszMSwxMCBAQCB1c2Ugd2FybmluZ3M7CiAKIG15 ICRkZWZpbmVzOwogbXkgJHByZXByb2Nlc3NvcjsKK215ICRncGVyZjsKIEdldE9wdGlvbnMoJ2Rl ZmluZXM9cycgPT4gXCRkZWZpbmVzLAotICAgICAgICAgICAncHJlcHJvY2Vzc29yPXMnID0+IFwk cHJlcHJvY2Vzc29yKTsKKyAgICAgICAgICAgJ3ByZXByb2Nlc3Nvcj1zJyA9PiBcJHByZXByb2Nl c3NvciwKKyAgICAgICAgICAgJ2dwZXJmLWV4ZWN1dGFibGU9cycgPT4gXCRncGVyZik7CiAKIG15 IEBOQU1FUyA9IGFwcGx5UHJlcHJvY2Vzc29yKCJDU1NWYWx1ZUtleXdvcmRzLmluIiwgJGRlZmlu ZXMsICRwcmVwcm9jZXNzb3IpOwogCkBAIC0xNzIsNSArMTc0LDcgQEAgY29uc3QgY2hhciogZ2V0 VmFsdWVOYW1lKHVuc2lnbmVkIHNob3J0IGlkKTsKIEVPRgogY2xvc2UgSEVBREVSOwogCi1teSAk Z3BlcmYgPSAkRU5We0dQRVJGfSA/ICRFTlZ7R1BFUkZ9IDogImdwZXJmIjsKK2lmIChub3QgJGdw ZXJmKSB7CisgICAgJGdwZXJmID0gJEVOVntHUEVSRn0gPyAkRU5We0dQRVJGfSA6ICJncGVyZiI7 Cit9CiBzeXN0ZW0oIlwiJGdwZXJmXCIgLS1rZXktcG9zaXRpb25zPVwiKlwiIC1EIC1uIC1zIDIg Q1NTVmFsdWVLZXl3b3Jkcy5ncGVyZiAtLW91dHB1dC1maWxlPUNTU1ZhbHVlS2V5d29yZHMuY3Bw IikgPT0gMCB8fCBkaWUgImNhbGxpbmcgZ3BlcmYgZmFpbGVkOiAkPyI7Cg==