184196 2018-03-30 15:03:44 -0700 REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK 2018-05-04 11:52:55 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad wenson_hsieh aestes ap commit-queue frederik.riedel thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1410743 0 ryanhaddad 2018-03-30 15:03:44 -0700 The following API tests fail when run on iOS Simulator using the 11.3 SDK: WKWebViewAutofillTests.StandalonePasswordField WKWebViewAutofillTests.UsernameAndPasswordField WKWebViewAutofillTests.UsernameAndPasswordFieldSeparatedByRadioButton FAIL WKWebViewAutofillTests.StandalonePasswordField /Volumes/Data/slave/ios-simulator-11-debug/build/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:178 Value of: [webView stringByEvaluatingJavaScript:@"password.value"] Actual: "" Expected: "famos" FAIL WKWebViewAutofillTests.UsernameAndPasswordField /Volumes/Data/slave/ios-simulator-11-debug/build/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:131 Value of: [webView stringByEvaluatingJavaScript:@"password.value"] Actual: "" Expected: "famos" FAIL WKWebViewAutofillTests.UsernameAndPasswordFieldSeparatedByRadioButton /Volumes/Data/slave/ios-simulator-11-debug/build/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:150 Value of: [webView stringByEvaluatingJavaScript:@"user.value"] Actual: "" Expected: "frederik" /Volumes/Data/slave/ios-simulator-11-debug/build/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:151 Value of: [webView stringByEvaluatingJavaScript:@"password.value"] Actual: "" Expected: "famos" 1410744 1 webkit-bug-importer 2018-03-30 15:04:03 -0700 <rdar://problem/39054481> 1411967 2 ryanhaddad 2018-04-04 18:03:47 -0700 Disabled tests in https://trac.webkit.org/r230288 1413634 3 frederik.riedel 2018-04-11 03:59:30 -0700 Any idea what the reason for the test failure in the simulator is in comparison to testing on a real device? I'm not sure why the tests fail there... 1413664 4 wenson_hsieh 2018-04-11 07:19:33 -0700 (In reply to Frederik Riedel from comment #3) > Any idea what the reason for the test failure in the simulator is in > comparison to testing on a real device? I'm not sure why the tests fail > there... Unsure, as of yet. I'll take a look! 1420772 5 wenson_hsieh 2018-05-04 11:24:02 -0700 (In reply to Wenson Hsieh from comment #4) > (In reply to Frederik Riedel from comment #3) > > Any idea what the reason for the test failure in the simulator is in > > comparison to testing on a real device? I'm not sure why the tests fail > > there... > > Unsure, as of yet. I'll take a look! Finally took a peek at this. -insertTextSuggestion: requires that the UITextSuggestion is a UITextAutofillSuggestion. However, the UITextAutofillSuggestion @implementation hack in WKWebViewAutofillTests is being used since developer SDKs do not have the private header, so we fail the class check. We no longer need the compatibility hack in WKWebViewAutofillTests since our bots don't run these tests on < iOS 11.3 anymore, so we can just fix these tests by removing it. 1420777 6 339572 wenson_hsieh 2018-05-04 11:29:32 -0700 Created attachment 339572 Patch 1420797 7 339572 commit-queue 2018-05-04 11:52:53 -0700 Comment on attachment 339572 Patch Clearing flags on attachment: 339572 Committed r231369: <https://trac.webkit.org/changeset/231369> 1420798 8 commit-queue 2018-05-04 11:52:55 -0700 All reviewed patches have been landed. Closing bug. 339572 2018-05-04 11:29:32 -0700 2018-05-04 11:52:53 -0700 Patch bug-184196-20180504112931.patch text/plain 5555 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdjM2U3ZTYzMzg5YmFlN2Yx OWE1ZjQyYjZhODRmNTlmYjg2NjNiOTEuLjY4MGM2NzhhOGMxYjIyYWUxNjkwMTRkYTVlYWYxNzJi NjJjN2Q4ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDUtMDQgIFdlbnNvbiBI c2llaCAgPHdoc2llaEBiZXJrZWxleS5lZHU+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW2lvcy1z aW11bGF0b3JdIDMgV0tXZWJWaWV3QXV0b2ZpbGxUZXN0cyBBUEkgdGVzdCBmYWlsdXJlcyBzZWVu IHdpdGggMTEuMyBTREsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4NDE5NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzkwNTQ0ODE+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGFuIHVubmVj ZXNzYXJ5IGNhbGwgdG8gTlNDbGFzc0Zyb21TdHJpbmcsIG5vdyB0aGF0IHRydW5rIFdlYktpdCBv bmx5IHN1cHBvcnRzIGlPUyAxMS4zKy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGluc2VydFRl eHRTdWdnZXN0aW9uOl0pOgorCiAyMDE4LTA1LTAzICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50 ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFVzZSBkZWZhdWx0IHN0ZDo6b3B0aW9uYWwgaWYgaXQg aXMgcHJvdmlkZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0Nv bnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGMyYTNiYWRlMTEzMzFiOGFmMGFjZjU0MGFj ZmQ4ZDE5YWY2YzU2YzQuLmM2YmYwYTk3Mjk2ZjZiMWMxMzNjYjZlOWZmNTU3OTMwNWRlNmUzZDgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbQpAQCAtMzE0OSw3ICszMTQ5LDcgQEAgc3RhdGljIHZvaWQgc2VsZWN0 aW9uQ2hhbmdlZFdpdGhUb3VjaChXS0NvbnRlbnRWaWV3ICp2aWV3LCBjb25zdCBXZWJDb3JlOjpJ bnRQb2kKIC0gKHZvaWQpaW5zZXJ0VGV4dFN1Z2dlc3Rpb246KFVJVGV4dFN1Z2dlc3Rpb24gKil0 ZXh0U3VnZ2VzdGlvbgogewogICAgIC8vIEZJWE1FOiBSZXBsYWNlIE5TQ2xhc3NGcm9tU3RyaW5n IHdpdGggYWN0dWFsIGNsYXNzIGFzIHNvb24gYXMgVUlLaXQgc3VibWl0dGVkIHRoZSBuZXcgY2xh c3MgaW50byB0aGUgaU9TIFNESy4KLSAgICBpZiAoW3RleHRTdWdnZXN0aW9uIGlzS2luZE9mQ2xh c3M6TlNDbGFzc0Zyb21TdHJpbmcoQCJVSVRleHRBdXRvZmlsbFN1Z2dlc3Rpb24iKV0pIHsKKyAg ICBpZiAoW3RleHRTdWdnZXN0aW9uIGlzS2luZE9mQ2xhc3M6W1VJVGV4dEF1dG9maWxsU3VnZ2Vz dGlvbiBjbGFzc11dKSB7CiAgICAgICAgIF9wYWdlLT5hdXRvZmlsbExvZ2luQ3JlZGVudGlhbHMo WyhVSVRleHRBdXRvZmlsbFN1Z2dlc3Rpb24gKil0ZXh0U3VnZ2VzdGlvbiB1c2VybmFtZV0sIFso VUlUZXh0QXV0b2ZpbGxTdWdnZXN0aW9uICopdGV4dFN1Z2dlc3Rpb24gcGFzc3dvcmRdKTsKICAg ICAgICAgcmV0dXJuOwogICAgIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz L0NoYW5nZUxvZwppbmRleCAxYWVjNjNjNzdkZWJlNzMwZDdlOTJiYzA0YjNiYjQ0YzAzNDczMDA2 Li40NmZjNWRhNjQ0ZGRiMmIyZTMzYjk5MmE0YzYzZmQ1NWVhZDA5ZjJjIDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIw MTgtMDUtMDQgIFdlbnNvbiBIc2llaCAgPHdoc2llaEBiZXJrZWxleS5lZHU+CisKKyAgICAgICAg UkVHUkVTU0lPTjogW2lvcy1zaW11bGF0b3JdIDMgV0tXZWJWaWV3QXV0b2ZpbGxUZXN0cyBBUEkg dGVzdCBmYWlsdXJlcyBzZWVuIHdpdGggMTEuMyBTREsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDE5NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MzkwNTQ0ODE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlcyBzb21lIHVubmVjZXNzYXJ5IHdvcmthcm91bmRzIHRvIGVuYWJsZSBydW5uaW5n IGFwcCBhdXRvZmlsbCB0ZXN0cyBhZ2FpbnN0IGlPUyB2ZXJzaW9ucworICAgICAgICBlYXJsaWVy IHRoYW4gMTEuMy4gQWxzbyByZS1lbmFibGVzIHRoZXNlIHRlc3RzLgorCisgICAgICAgICogVGVz dFdlYktpdEFQSS9UZXN0cy9pb3MvV0tXZWJWaWV3QXV0b2ZpbGxUZXN0cy5tbToKKyAgICAgICAg KFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorICAgICAgICAoLVtVSVRleHRBdXRvZmlsbFN1Z2dlc3Rp b24gaW5pdFdpdGhVc2VybmFtZTpwYXNzd29yZDpdKTogRGVsZXRlZC4KKyAgICAgICAgKCtbVUlU ZXh0QXV0b2ZpbGxTdWdnZXN0aW9uIGF1dG9maWxsU3VnZ2VzdGlvbldpdGhVc2VybmFtZTpwYXNz d29yZDpdKTogRGVsZXRlZC4KKwogMjAxOC0wNS0wMyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2ly c2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgW1dpbkNhaXJvXSBUZXN0IGFyY2hpdmUgbXVzdCB1 c2UgUHl0aG9uIHppcGZpbGUsIGp1c3QgbGlrZSBidWlsZCBwcm9kdWN0LgpkaWZmIC0tZ2l0IGEv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvV0tXZWJWaWV3QXV0b2ZpbGxUZXN0cy5tbSBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL1dLV2ViVmlld0F1dG9maWxsVGVzdHMubW0K aW5kZXggMTczMDUzMmM0OGExNzRmNmEwOTM4ZGM5ODY4MDI5NWYyNmVmMDEyZS4uYmEzNzVhN2Yz YjUzNDVhNzBkOGE0YTYyYWJmODkxN2I3NmU2OWNjNSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9pb3MvV0tXZWJWaWV3QXV0b2ZpbGxUZXN0cy5tbQorKysgYi9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9XS1dlYlZpZXdBdXRvZmlsbFRlc3RzLm1tCkBAIC0zNSwy NiArMzUsNiBAQAogI2ltcG9ydCA8V2ViS2l0L19XS0lucHV0RGVsZWdhdGUuaD4KICNpbXBvcnQg PHd0Zi9CbG9ja1B0ci5oPgogCi0jaWYgIV9faGFzX2luY2x1ZGUoPFVJS2l0L1VJVGV4dEF1dG9m aWxsU3VnZ2VzdGlvbi5oPikKLS8vIEZJWE1FOiBUaGlzIGNhbiBiZSBzYWZlbHkgcmVtb3ZlZCBv bmNlIDxyZGFyOi8vcHJvYmxlbS8zNDU4MzYyOD4gbGFuZHMgaW4gdGhlIFNESy4KLUBpbXBsZW1l bnRhdGlvbiBVSVRleHRBdXRvZmlsbFN1Z2dlc3Rpb24KLS0gKGluc3RhbmNldHlwZSlpbml0V2l0 aFVzZXJuYW1lOihOU1N0cmluZyAqKXVzZXJuYW1lIHBhc3N3b3JkOihOU1N0cmluZyAqKXBhc3N3 b3JkCi17Ci0gICAgc2VsZiA9IFtzdXBlciBpbml0XTsKLSAgICBpZiAoc2VsZikgewotICAgICAg ICBfdXNlcm5hbWUgPSB1c2VybmFtZTsKLSAgICAgICAgX3Bhc3N3b3JkID0gcGFzc3dvcmQ7Ci0g ICAgfQotICAgIHJldHVybiBzZWxmOwotfQotCi0rIChpbnN0YW5jZXR5cGUpYXV0b2ZpbGxTdWdn ZXN0aW9uV2l0aFVzZXJuYW1lOihOU1N0cmluZyAqKXVzZXJuYW1lIHBhc3N3b3JkOihOU1N0cmlu ZyAqKXBhc3N3b3JkCi17Ci0gICAgcmV0dXJuIFtbc2VsZiBhbGxvY10gaW5pdFdpdGhVc2VybmFt ZTp1c2VybmFtZSBwYXNzd29yZDpwYXNzd29yZF07Ci19Ci1AZW5kCi0jZW5kaWYKLQogdHlwZWRl ZiBVSVZpZXcgPFVJVGV4dElucHV0VHJhaXRzX1ByaXZhdGVfUHJvcG9zZWRfU1BJXzM0NTgzNjI4 PiBBdXRvZmlsbElucHV0VmlldzsKIAogQGludGVyZmFjZSBUZXN0SW5wdXREZWxlZ2F0ZSA6IE5T T2JqZWN0IDxfV0tJbnB1dERlbGVnYXRlPgpAQCAtMTE1LDcgKzk1LDcgQEAgdHlwZWRlZiBVSVZp ZXcgPFVJVGV4dElucHV0VHJhaXRzX1ByaXZhdGVfUHJvcG9zZWRfU1BJXzM0NTgzNjI4PiBBdXRv ZmlsbElucHV0VmkKIAogbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkgewogCi1URVNUKFdLV2ViVmll d0F1dG9maWxsVGVzdHMsIERJU0FCTEVEX1VzZXJuYW1lQW5kUGFzc3dvcmRGaWVsZCkKK1RFU1Qo V0tXZWJWaWV3QXV0b2ZpbGxUZXN0cywgVXNlcm5hbWVBbmRQYXNzd29yZEZpZWxkKQogewogICAg IGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tBdXRvZmlsbFRlc3RWaWV3IGFsbG9jXSBpbml0V2l0 aEZyYW1lOkNHUmVjdE1ha2UoMCwgMCwgMzIwLCA1MDApXSk7CiAgICAgW3dlYlZpZXcgc3luY2hy b25vdXNseUxvYWRIVE1MU3RyaW5nOkAiPGlucHV0IGlkPSd1c2VyJyB0eXBlPSdlbWFpbCc+PGlu cHV0IGlkPSdwYXNzd29yZCcgdHlwZT0ncGFzc3dvcmQnPiJdOwpAQCAtMTM0LDcgKzExNCw3IEBA IFRFU1QoV0tXZWJWaWV3QXV0b2ZpbGxUZXN0cywgRElTQUJMRURfVXNlcm5hbWVBbmRQYXNzd29y ZEZpZWxkKQogICAgIEVYUEVDVF9GQUxTRShbd2ViVmlldyB0ZXh0SW5wdXRIYXNBdXRvZmlsbENv bnRleHRdKTsKIH0KIAotVEVTVChXS1dlYlZpZXdBdXRvZmlsbFRlc3RzLCBESVNBQkxFRF9Vc2Vy bmFtZUFuZFBhc3N3b3JkRmllbGRTZXBhcmF0ZWRCeVJhZGlvQnV0dG9uKQorVEVTVChXS1dlYlZp ZXdBdXRvZmlsbFRlc3RzLCBVc2VybmFtZUFuZFBhc3N3b3JkRmllbGRTZXBhcmF0ZWRCeVJhZGlv QnV0dG9uKQogewogICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tBdXRvZmlsbFRlc3RWaWV3 IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1ha2UoMCwgMCwgMzIwLCA1MDApXSk7CiAgICAg W3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRIVE1MU3RyaW5nOkAiPGlucHV0IGlkPSd1c2VyJyB0 eXBlPSdlbWFpbCc+PGlucHV0IHR5cGU9J3JhZGlvJyBuYW1lPSdyYWRpb19idXR0b24nIHZhbHVl PSdyYWRpbyc+PGlucHV0IGlkPSdwYXNzd29yZCcgdHlwZT0ncGFzc3dvcmQnPiJdOwpAQCAtMTY1 LDcgKzE0NSw3IEBAIFRFU1QoV0tXZWJWaWV3QXV0b2ZpbGxUZXN0cywgVHdvVGV4dEZpZWxkcykK ICAgICBFWFBFQ1RfRkFMU0UoW3dlYlZpZXcgdGV4dElucHV0SGFzQXV0b2ZpbGxDb250ZXh0XSk7 CiB9CiAKLVRFU1QoV0tXZWJWaWV3QXV0b2ZpbGxUZXN0cywgRElTQUJMRURfU3RhbmRhbG9uZVBh c3N3b3JkRmllbGQpCitURVNUKFdLV2ViVmlld0F1dG9maWxsVGVzdHMsIFN0YW5kYWxvbmVQYXNz d29yZEZpZWxkKQogewogICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tBdXRvZmlsbFRlc3RW aWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1ha2UoMCwgMCwgMzIwLCA1MDApXSk7CiAg ICAgW3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRIVE1MU3RyaW5nOkAiPGlucHV0IGlkPSdwYXNz d29yZCcgdHlwZT0ncGFzc3dvcmQnPiJdOwo=