184190 2018-03-30 13:05:11 -0700 WorkQueueWin: don't move rvalues 2018-03-30 13:47:05 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 184167 1 jfbastien jfbastien benjamin cdumez cmarcelo commit-queue dbates ews-watchlist jfbastien mark.lam ryanhaddad webkit-bug-importer ysuzuki oldest_to_newest 1410711 0 jfbastien 2018-03-30 13:05:11 -0700 As part of #184167 optional is now more frequently an rvalue reference, and moving its .value() is not a thing that should be done anymore. 1410713 1 webkit-bug-importer 2018-03-30 13:05:41 -0700 <rdar://problem/39049850> 1410715 2 336883 jfbastien 2018-03-30 13:07:51 -0700 Created attachment 336883 patch Fixes a Windows build failure (because the file is Windows specific). 1410716 3 336883 mark.lam 2018-03-30 13:09:08 -0700 Comment on attachment 336883 patch r=me 1410721 4 336883 commit-queue 2018-03-30 13:47:03 -0700 Comment on attachment 336883 patch Clearing flags on attachment: 336883 Committed r230116: <https://trac.webkit.org/changeset/230116> 1410722 5 commit-queue 2018-03-30 13:47:05 -0700 All reviewed patches have been landed. Closing bug. 336883 2018-03-30 13:07:51 -0700 2018-03-30 13:47:03 -0700 patch 0001-WorkQueueWin-don-t-move-rvalues.patch text/plain 2090 jfbastien RnJvbSBlZDhhNzFhN2E1OWY0ODIyNDhkZTVlZTMwMGIyMzNlNWI3Mjg4M2Y0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBGcmksIDMwIE1hciAyMDE4IDEzOjA3OjE3IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gV29ya1F1 ZXVlV2luOiBkb24ndCBtb3ZlIHJ2YWx1ZXMKCi0tLQogU291cmNlL1dURi9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgfCAxNSArKysrKysrKysrKysrKysKIFNvdXJjZS9XVEYvd3RmL3dpbi9Xb3Jr UXVldWVXaW4uY3BwIHwgIDQgKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291 cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggOGFhZjYwZS4uM2Q2Yjc0OSAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwy MCBAQAogMjAxOC0wMy0zMCAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CiAKKyAg ICAgICAgV29ya1F1ZXVlV2luOiBkb24ndCBtb3ZlIHJ2YWx1ZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDE5MAorICAgICAgICA8cmRhcjovL3By b2JsZW0vMzkwNDk4NTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQXMgcGFydCBvZiAjMTg0MTY3IG9wdGlvbmFsIGlzIG5vdyBtb3JlIGZyZXF1ZW50 bHkgYW4gcnZhbHVlCisgICAgICAgIHJlZmVyZW5jZSwgYW5kIG1vdmluZyBpdHMgLnZhbHVlKCkg aXMgbm90IGEgdGhpbmcgdGhhdCBzaG91bGQgYmUKKyAgICAgICAgZG9uZSBhbnltb3JlLgorCisg ICAgICAgICogd3RmL3dpbi9Xb3JrUXVldWVXaW4uY3BwOgorICAgICAgICAoV1RGOjpXb3JrUXVl dWU6OnVucmVnaXN0ZXJBbmRDbG9zZUhhbmRsZSk6CisKKzIwMTgtMDMtMzAgIEpGIEJhc3RpZW4g IDxqZmJhc3RpZW5AYXBwbGUuY29tPgorCiAgICAgICAgIFJlbW92ZSBDWFhfUkVGRVJFTkNFX1FV QUxJRklFRF9GVU5DVElPTlMgYW5kIG9wdGlvbmFsJ3MgZXF1aXZhbGVudAogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0MTY3CiAgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zOTAyMzEzMD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3dpbi9Xb3Jr UXVldWVXaW4uY3BwIGIvU291cmNlL1dURi93dGYvd2luL1dvcmtRdWV1ZVdpbi5jcHAKaW5kZXgg MmY4MTUyYi4uNDFiZmRlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvd2luL1dvcmtRdWV1 ZVdpbi5jcHAKKysrIGIvU291cmNlL1dURi93dGYvd2luL1dvcmtRdWV1ZVdpbi5jcHAKQEAgLTEs NSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDEwLCAyMDE1IEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMC0yMDE4IEFwcGxlIEluYy4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAxNyBTb255IEludGVyYWN0 aXZlIEVudGVydGFpbm1lbnQgSW5jLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4g c291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dApAQCAtNjQsNyArNjQsNyBA QCB2b2lkIFdvcmtRdWV1ZTo6dW5yZWdpc3RlckFuZENsb3NlSGFuZGxlKEhBTkRMRSBoYW5kbGUp CiAgICAgYXV0byBsb2NrZXIgPSBob2xkTG9jayhtX2l0ZW1zTWFwTG9jayk7CiAgICAgQVNTRVJU X0FSRyhoYW5kbGUsIG1faXRlbXNNYXAuY29udGFpbnMoaGFuZGxlKSk7CiAKLSAgICB1bnJlZ2lz dGVyV2FpdEFuZERlc3Ryb3lJdGVtU29vbihXVEZNb3ZlKG1faXRlbXNNYXAudGFrZShoYW5kbGUp LnZhbHVlKCkpKTsKKyAgICB1bnJlZ2lzdGVyV2FpdEFuZERlc3Ryb3lJdGVtU29vbihtX2l0ZW1z TWFwLnRha2UoaGFuZGxlKS52YWx1ZSgpKTsKIH0KIAogRFdPUkQgV29ya1F1ZXVlOjp3b3JrVGhy ZWFkQ2FsbGJhY2sodm9pZCogY29udGV4dCkKLS0gCjIuOS4zCgo=