184189 2018-03-30 12:36:02 -0700 Bytecode generator should not get_from_scope something that may be a hole into a variable that is already live 2018-03-31 11:26:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo ews-watchlist jfbastien keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1410701 0 fpizlo 2018-03-30 12:36:02 -0700 Patch forthcoming. 1410702 1 336878 fpizlo 2018-03-30 12:39:52 -0700 Created attachment 336878 the patch 1410703 2 336878 jfbastien 2018-03-30 12:41:19 -0700 Comment on attachment 336878 the patch r=me 1410704 3 336879 fpizlo 2018-03-30 12:43:39 -0700 Created attachment 336879 patch for landing 1410727 4 fpizlo 2018-03-30 14:03:04 -0700 Landed in https://trac.webkit.org/changeset/230115/webkit 1410728 5 webkit-bug-importer 2018-03-30 14:04:22 -0700 <rdar://problem/39051685> 1410866 6 ddkilzer 2018-03-31 11:26:25 -0700 <rdar://problem/38367452> 336878 2018-03-30 12:39:52 -0700 2018-03-30 12:43:39 -0700 the patch blah.patch text/plain 3036 fpizlo SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzAxMTMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE4LTAzLTMwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CisKKyAgICAgICAgQnl0ZWNvZGUgZ2VuZXJhdG9yIHNob3VsZCBub3QgZ2V0X2Zyb21fc2Nv cGUgc29tZXRoaW5nIHRoYXQgbWF5IGJlIGEgaG9sZSBpbnRvIGEgdmFyaWFibGUgdGhhdCBpcyBh bHJlYWR5IGxpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NDE4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogc3RyZXNzL2xvYWQtaG9sZS1mcm9tLXNjb3BlLWludG8tbGl2ZS12YXIuanM6IEFkZGVk LgorICAgICAgICAocmVzdWx0LmV2YWwudHJ5LnN3aXRjaCk6CisgICAgICAgIChjYXRjaCk6CisK IDIwMTgtMDMtMzAgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIzMDEwMi4KSW5kZXg6IEpTVGVzdHMvc3RyZXNz L2xvYWQtaG9sZS1mcm9tLXNjb3BlLWludG8tbGl2ZS12YXIuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNU ZXN0cy9zdHJlc3MvbG9hZC1ob2xlLWZyb20tc2NvcGUtaW50by1saXZlLXZhci5qcwkobm9uZXhp c3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9sb2FkLWhvbGUtZnJvbS1zY29wZS1pbnRvLWxpdmUt dmFyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTQgQEAKKy8vQCBydW5EZWZhdWx0Cit2 YXIgcmVzdWx0ID0gZXZhbChgCit0cnkgeworICAgIHN3aXRjaCAoMCkgeworICAgIGNhc2UgMToK KyAgICAgICAgbGV0IHggPSBldmFsKCk7CisgICAgZGVmYXVsdDoKKyAgICAgICAgeDsKKyAgICB9 Cit9IGNhdGNoIChlKSB7Cit9CitgKTsKK2lmIChyZXN1bHQgIT09IHZvaWQgMCkKKyAgICB0aHJv dyAiQmFkIHJlc3VsdDogIiArIHJlc3VsdDsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwko cmV2aXNpb24gMjMwMDg3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTAzLTMwICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgQnl0ZWNvZGUgZ2VuZXJhdG9yIHNob3VsZCBub3Qg Z2V0X2Zyb21fc2NvcGUgc29tZXRoaW5nIHRoYXQgbWF5IGJlIGEgaG9sZSBpbnRvIGEgdmFyaWFi bGUgdGhhdCBpcyBhbHJlYWR5IGxpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4NDE4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHA6CisgICAgICAg IChKU0M6OlJlc29sdmVOb2RlOjplbWl0Qnl0ZWNvZGUpOgorCiAyMDE4LTAzLTI5ICBLZWl0aCBN aWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFycmF5TW9kZSBzaG91 bGQgbm90IHRyeSB0byBnZXQgdGhlIERGRyB0byB0aGluayBpdCBjYW4gY29udmVydCBUeXBlZEFy cmF5cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0NvZGVn ZW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIv Tm9kZXNDb2RlZ2VuLmNwcAkocmV2aXNpb24gMjMwMDg3KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTIs OCArMjUyLDEwIEBAIFJlZ2lzdGVySUQqIFJlc29sdmVOb2RlOjplbWl0Qnl0ZWNvZGUoQnkKICAg ICBnZW5lcmF0b3IuZW1pdEV4cHJlc3Npb25JbmZvKGRpdm90LCBtX3N0YXJ0LCBkaXZvdCk7CiAg ICAgUmVmUHRyPFJlZ2lzdGVySUQ+IHNjb3BlID0gZ2VuZXJhdG9yLmVtaXRSZXNvbHZlU2NvcGUo ZHN0LCB2YXIpOwogICAgIFJlZ2lzdGVySUQqIGZpbmFsRGVzdCA9IGdlbmVyYXRvci5maW5hbERl c3RpbmF0aW9uKGRzdCk7Ci0gICAgUmVnaXN0ZXJJRCogcmVzdWx0ID0gZ2VuZXJhdG9yLmVtaXRH ZXRGcm9tU2NvcGUoZmluYWxEZXN0LCBzY29wZS5nZXQoKSwgdmFyLCBUaHJvd0lmTm90Rm91bmQp OwotICAgIGdlbmVyYXRvci5lbWl0VERaQ2hlY2tJZk5lY2Vzc2FyeSh2YXIsIGZpbmFsRGVzdCwg bnVsbHB0cik7CisgICAgUmVmUHRyPFJlZ2lzdGVySUQ+IHVuY2hlY2tlZFJlc3VsdCA9IGdlbmVy YXRvci5uZXdUZW1wb3JhcnkoKTsKKyAgICBSZWdpc3RlcklEKiByZXN1bHQgPSBnZW5lcmF0b3Iu ZW1pdEdldEZyb21TY29wZSh1bmNoZWNrZWRSZXN1bHQuZ2V0KCksIHNjb3BlLmdldCgpLCB2YXIs IFRocm93SWZOb3RGb3VuZCk7CisgICAgZ2VuZXJhdG9yLmVtaXRURFpDaGVja0lmTmVjZXNzYXJ5 KHZhciwgdW5jaGVja2VkUmVzdWx0LmdldCgpLCBudWxscHRyKTsKKyAgICBnZW5lcmF0b3IuZW1p dE1vdmUoZmluYWxEZXN0LCB1bmNoZWNrZWRSZXN1bHQuZ2V0KCkpOwogICAgIGdlbmVyYXRvci5l bWl0UHJvZmlsZVR5cGUoZmluYWxEZXN0LCB2YXIsIG1fcG9zaXRpb24sIEpTVGV4dFBvc2l0aW9u KC0xLCBtX3Bvc2l0aW9uLm9mZnNldCArIG1faWRlbnQubGVuZ3RoKCksIC0xKSk7CiAgICAgcmV0 dXJuIHJlc3VsdDsKIH0K 336879 2018-03-30 12:43:39 -0700 2018-03-30 12:43:39 -0700 patch for landing blah.patch text/plain 3123 fpizlo SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzAxMTMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE4LTAzLTMwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CisKKyAgICAgICAgQnl0ZWNvZGUgZ2VuZXJhdG9yIHNob3VsZCBub3QgZ2V0X2Zyb21fc2Nv cGUgc29tZXRoaW5nIHRoYXQgbWF5IGJlIGEgaG9sZSBpbnRvIGEgdmFyaWFibGUgdGhhdCBpcyBh bHJlYWR5IGxpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NDE4OQorCisgICAgICAgIFJldmlld2VkIGJ5IEpGIEJhc3RpZW4uCisKKyAgICAgICAg KiBzdHJlc3MvbG9hZC1ob2xlLWZyb20tc2NvcGUtaW50by1saXZlLXZhci5qczogQWRkZWQuCisg ICAgICAgIChyZXN1bHQuZXZhbC50cnkuc3dpdGNoKToKKyAgICAgICAgKGNhdGNoKToKKwogMjAx OC0wMy0zMCAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByMjMwMTAyLgpJbmRleDogSlNUZXN0cy9zdHJlc3MvbG9h ZC1ob2xlLWZyb20tc2NvcGUtaW50by1saXZlLXZhci5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3Rz L3N0cmVzcy9sb2FkLWhvbGUtZnJvbS1zY29wZS1pbnRvLWxpdmUtdmFyLmpzCShub25leGlzdGVu dCkKKysrIEpTVGVzdHMvc3RyZXNzL2xvYWQtaG9sZS1mcm9tLXNjb3BlLWludG8tbGl2ZS12YXIu anMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxNCBAQAorLy9AIHJ1bkRlZmF1bHQKK3ZhciBy ZXN1bHQgPSBldmFsKGAKK3RyeSB7CisgICAgc3dpdGNoICgwKSB7CisgICAgY2FzZSAxOgorICAg ICAgICBsZXQgeCA9IGV2YWwoKTsKKyAgICBkZWZhdWx0OgorICAgICAgICB4OworICAgIH0KK30g Y2F0Y2ggKGUpIHsKK30KK2ApOworaWYgKHJlc3VsdCAhPT0gdm9pZCAwKQorICAgIHRocm93ICJC YWQgcmVzdWx0OiAiICsgcmVzdWx0OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZp c2lvbiAyMzAwODcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDMtMzAgIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KKworICAgICAgICBCeXRlY29kZSBnZW5lcmF0b3Igc2hvdWxkIG5vdCBnZXRf ZnJvbV9zY29wZSBzb21ldGhpbmcgdGhhdCBtYXkgYmUgYSBob2xlIGludG8gYSB2YXJpYWJsZSB0 aGF0IGlzIGFscmVhZHkgbGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg0MTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSkYgQmFzdGllbi4KKwor ICAgICAgICAqIGJ5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwOgorICAgICAgICAoSlNDOjpS ZXNvbHZlTm9kZTo6ZW1pdEJ5dGVjb2RlKToKKwogMjAxOC0wMy0yOSAgS2VpdGggTWlsbGVyICA8 a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBBcnJheU1vZGUgc2hvdWxkIG5vdCB0 cnkgdG8gZ2V0IHRoZSBERkcgdG8gdGhpbmsgaXQgY2FuIGNvbnZlcnQgVHlwZWRBcnJheXMKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29k ZWdlbi5jcHAJKHJldmlzaW9uIDIzMDA4NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjUyLDEwICsyNTIs MTIgQEAgUmVnaXN0ZXJJRCogUmVzb2x2ZU5vZGU6OmVtaXRCeXRlY29kZShCeQogICAgIGdlbmVy YXRvci5lbWl0RXhwcmVzc2lvbkluZm8oZGl2b3QsIG1fc3RhcnQsIGRpdm90KTsKICAgICBSZWZQ dHI8UmVnaXN0ZXJJRD4gc2NvcGUgPSBnZW5lcmF0b3IuZW1pdFJlc29sdmVTY29wZShkc3QsIHZh cik7CiAgICAgUmVnaXN0ZXJJRCogZmluYWxEZXN0ID0gZ2VuZXJhdG9yLmZpbmFsRGVzdGluYXRp b24oZHN0KTsKLSAgICBSZWdpc3RlcklEKiByZXN1bHQgPSBnZW5lcmF0b3IuZW1pdEdldEZyb21T Y29wZShmaW5hbERlc3QsIHNjb3BlLmdldCgpLCB2YXIsIFRocm93SWZOb3RGb3VuZCk7Ci0gICAg Z2VuZXJhdG9yLmVtaXRURFpDaGVja0lmTmVjZXNzYXJ5KHZhciwgZmluYWxEZXN0LCBudWxscHRy KTsKKyAgICBSZWZQdHI8UmVnaXN0ZXJJRD4gdW5jaGVja2VkUmVzdWx0ID0gZ2VuZXJhdG9yLm5l d1RlbXBvcmFyeSgpOworICAgIGdlbmVyYXRvci5lbWl0R2V0RnJvbVNjb3BlKHVuY2hlY2tlZFJl c3VsdC5nZXQoKSwgc2NvcGUuZ2V0KCksIHZhciwgVGhyb3dJZk5vdEZvdW5kKTsKKyAgICBnZW5l cmF0b3IuZW1pdFREWkNoZWNrSWZOZWNlc3NhcnkodmFyLCB1bmNoZWNrZWRSZXN1bHQuZ2V0KCks IG51bGxwdHIpOworICAgIGdlbmVyYXRvci5lbWl0TW92ZShmaW5hbERlc3QsIHVuY2hlY2tlZFJl c3VsdC5nZXQoKSk7CiAgICAgZ2VuZXJhdG9yLmVtaXRQcm9maWxlVHlwZShmaW5hbERlc3QsIHZh ciwgbV9wb3NpdGlvbiwgSlNUZXh0UG9zaXRpb24oLTEsIG1fcG9zaXRpb24ub2Zmc2V0ICsgbV9p ZGVudC5sZW5ndGgoKSwgLTEpKTsKLSAgICByZXR1cm4gcmVzdWx0OworICAgIHJldHVybiBmaW5h bERlc3Q7CiB9CiAKIC8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSBUZW1wbGF0ZVN0 cmluZ05vZGUgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K