18418 2008-04-10 17:08:12 -0700 REGRESSION (r31736?): DOM tree disappears when navigating to a new page with the Inspector open 2008-04-11 13:00:34 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Major --- 1 aroben timothy timothy oldest_to_newest 77212 0 aroben 2008-04-10 17:08:12 -0700 The Inspector's DOM tree disappears when you navigate to a new page with the Inspector open. 1. Go to http://webkit.org/ 2. Right-click and choose Inspect Element 3. Go to http://www.google.com/ 77291 1 20484 timothy 2008-04-11 12:10:13 -0700 Created attachment 20484 Patch 77292 2 20484 aroben 2008-04-11 12:13:24 -0700 Comment on attachment 20484 Patch @@ -141,8 +169,7 @@ WebInspector.ElementsPanel.prototype = { this.focusedDOMNode = canidateFocusNode; if (this.treeOutline.selectedTreeElement) this.treeOutline.selectedTreeElement.expand(); - } else - this.focusedDOMNode = null; + } }, What's this change for? You don't mention it in the ChangeLog. Maybe we should file a bug about the event listener being called with the inspected page's global object? r=me 77298 3 timothy 2008-04-11 13:00:23 -0700 I moved this.focusedDOMNode = null to the top of the reset function. 77299 4 timothy 2008-04-11 13:00:34 -0700 Landed in r31815. 20484 2008-04-11 12:10:13 -0700 2008-04-11 12:13:24 -0700 Patch 0001-Fixes-the-regression-where-the-DOM-tree-does-not-upd.patch text/plain 4603 timothy RnJvbSBiMmViMzkxOGEwMTUzYWNkYzljYmY2OWQ0MDhmMThmNGM4MjUzY2U0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBGcmksIDExIEFwciAyMDA4IDEyOjA4OjQ0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 ZXMgdGhlIHJlZ3Jlc3Npb24gd2hlcmUgdGhlIERPTSB0cmVlIGRvZXMgbm90IHVwZGF0ZSB3aGVu IG5hdmlnYXRpbmcKIHRvIGFub3RoZXIgcGFnZSB3aXRoIHRoZSBJbnNwZWN0b3Igb3Blbi4KCmh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQxOAoKUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgoqIHBhZ2UvaW5zcGVjdG9yL0VsZW1lbnRzUGFuZWwuanM6CihXZWJJ bnNwZWN0b3IuRWxlbWVudHNQYW5lbC5wcm90b3R5cGUucmVzZXQpOiBJZiB0aGUgaW5zcGVjdGVk IGRvY3VtZW50IGRvZXMgbm90IGhhdmUgYQpmaXJzdENoaWxkIHlldCwgYWRkIGFuIGV2ZW50IGxp c3RlbmVyIGZvciBET01Db250ZW50TG9hZGVkLiBUaGUgZXZlbnQgbGlzdGVuZXIganVzdCBzZXRz CmEgcHJvZXBydHkgdGhhdCBhIHBvbGxpbmcgZnVuY3Rpb25zIGxvb2tzIGZvciB0aGVuIHRyaWdn ZXJzIHRoZSByZXNldC4KKFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsLnByb3RvdHlwZS5fZm9j dXNlZE5vZGVDaGFuZ2VkKTogQWx3YXlzIGNhbGwgdXBkYXRlU3R5bGVzIHdpdGgKZm9yY2VVcGRh dGUgYXMgdHJ1ZS4gVGhpcyBtYWtlcyBzdXJlIHRoZSBTdHlsZXMgcGFuZSBjbGVhcnMgd2hlbiB0 aGVyZSBpc24ndCBhIGZvY3VzZWQgbm9kZS4KLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE2ICsrKysrKysrKysrKwogV2ViQ29yZS9wYWdlL2luc3BlY3Rv ci9FbGVtZW50c1BhbmVsLmpzIHwgICAzOSArKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0K IDIgZmlsZXMgY2hhbmdlZCwgNDkgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGY5ZDA3 OGQuLmY3YjViZTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDgtMDQtMTEgIFRpbW90aHkgSGF0Y2hlciAg PHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIEZpeGVzIHRoZSByZWdyZXNzaW9uIHdoZXJl IHRoZSBET00gdHJlZSBkb2VzIG5vdCB1cGRhdGUgd2hlbiBuYXZpZ2F0aW5nCisgICAgICAgIHRv IGFub3RoZXIgcGFnZSB3aXRoIHRoZSBJbnNwZWN0b3Igb3Blbi4KKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0MTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL0VsZW1lbnRz UGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNQYW5lbC5wcm90b3R5cGUu cmVzZXQpOiBJZiB0aGUgaW5zcGVjdGVkIGRvY3VtZW50IGRvZXMgbm90IGhhdmUgYQorICAgICAg ICBmaXJzdENoaWxkIHlldCwgYWRkIGFuIGV2ZW50IGxpc3RlbmVyIGZvciBET01Db250ZW50TG9h ZGVkLiBUaGUgZXZlbnQgbGlzdGVuZXIganVzdCBzZXRzCisgICAgICAgIGEgcHJvZXBydHkgdGhh dCBhIHBvbGxpbmcgZnVuY3Rpb25zIGxvb2tzIGZvciB0aGVuIHRyaWdnZXJzIHRoZSByZXNldC4K KyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsLnByb3RvdHlwZS5fZm9jdXNlZE5v ZGVDaGFuZ2VkKTogQWx3YXlzIGNhbGwgdXBkYXRlU3R5bGVzIHdpdGgKKyAgICAgICAgZm9yY2VV cGRhdGUgYXMgdHJ1ZS4gVGhpcyBtYWtlcyBzdXJlIHRoZSBTdHlsZXMgcGFuZSBjbGVhcnMgd2hl biB0aGVyZSBpc24ndCBhIGZvY3VzZWQgbm9kZS4KKwogMjAwOC0wNC0xMCAgVGltb3RoeSBIYXRj aGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4ZXMgZmxvYXRpbmcgcG9pbnQg cHJlY2lzaW9uIGluIHRoZSBSZXNvdXJjZXMgZ3JhcGggbGFiZWxzIGJ5IHVzaW5nIFN0cmluZy5z cHJpbnRmIHRvCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL0VsZW1lbnRzUGFu ZWwuanMgYi9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL0VsZW1lbnRzUGFuZWwuanMKaW5kZXggYWIy Y2Y3Ni4uOGI3M2NjYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9FbGVtZW50 c1BhbmVsLmpzCisrKyBiL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvRWxlbWVudHNQYW5lbC5qcwpA QCAtMTI2LDEwICsxMjYsMzggQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBl ID0gewogCiAgICAgcmVzZXQ6IGZ1bmN0aW9uKCkKICAgICB7CisgICAgICAgIHRoaXMucm9vdERP TU5vZGUgPSBudWxsOworICAgICAgICB0aGlzLmZvY3VzZWRET01Ob2RlID0gbnVsbDsKKwogICAg ICAgICB2YXIgaW5zcGVjdGVkV2luZG93ID0gSW5zcGVjdG9yQ29udHJvbGxlci5pbnNwZWN0ZWRX aW5kb3coKTsKLSAgICAgICAgaWYgKCFpbnNwZWN0ZWRXaW5kb3cpIHsKLSAgICAgICAgICAgIHRo aXMucm9vdERPTU5vZGUgPSBudWxsOwotICAgICAgICAgICAgdGhpcy5mb2N1c2VkRE9NTm9kZSA9 IG51bGw7CisgICAgICAgIGlmICghaW5zcGVjdGVkV2luZG93IHx8ICFpbnNwZWN0ZWRXaW5kb3cu ZG9jdW1lbnQpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgaWYgKCFpbnNwZWN0ZWRX aW5kb3cuZG9jdW1lbnQuZmlyc3RDaGlsZCkgeworICAgICAgICAgICAgLy8gRklYTUU6IFRoaXMg d2hvbGUgaWYgYmxvY2sgY2FuIGJlIHNpbXBsaWZpZWQgb25jZSB3ZSBjYW4gYWRkIGFuIGV2ZW50 IGxpc3RlbmVyIHRvCisgICAgICAgICAgICAvLyB0aGUgaW5zcGVjdGVkIHBhZ2UgYW5kIGhhdmUg aXQgZ2V0IGNhbGxlZCBpbiB0aGUgSW5zcGVjdG9yJ3MgY29udGV4dC4KKworICAgICAgICAgICAg dmFyIGVsZW1lbnRzUGFuZWwgPSB0aGlzOworICAgICAgICAgICAgZnVuY3Rpb24gY29udGVudExv YWRlZCgpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgLy8gVGhpcyBmdW5jdGlvbiB3 aWxsIGJlIGNhbGxlZCBpbiB0aGUgaW5zcGVjdGVkIHBhZ2UncyBjb250ZXh0LgorICAgICAgICAg ICAgICAgIGVsZW1lbnRzUGFuZWwuX2RvbUNvbnRlbnRMb2FkZWQgPSB0cnVlOworICAgICAgICAg ICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBjaGVja0NvbnRlbnRMb2FkZWQoKQorICAgICAg ICAgICAgeworICAgICAgICAgICAgICAgIGlmICghdGhpcy5fZG9tQ29udGVudExvYWRlZCkKKyAg ICAgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgICAgIHRoaXMucmVzZXQoKTsK KyAgICAgICAgICAgICAgICBpbnNwZWN0ZWRXaW5kb3cuZG9jdW1lbnQucmVtb3ZlRXZlbnRMaXN0 ZW5lcigiRE9NQ29udGVudExvYWRlZCIsIGNvbnRlbnRMb2FkZWQsIGZhbHNlKTsKKyAgICAgICAg ICAgICAgICBjbGVhckludGVydmFsKGNvbnRlbnRMb2FkZWRQb2xsaW5nSW50ZXJ2YWwpOworICAg ICAgICAgICAgICAgIGRlbGV0ZSB0aGlzLl9kb21Db250ZW50TG9hZGVkOworICAgICAgICAgICAg fQorCisgICAgICAgICAgICB0aGlzLl9kb21Db250ZW50TG9hZGVkID0gZmFsc2U7CisgICAgICAg ICAgICB2YXIgY29udGVudExvYWRlZFBvbGxpbmdJbnRlcnZhbCA9IHNldEludGVydmFsKGNoZWNr Q29udGVudExvYWRlZC5iaW5kKHRoaXMpLCAxMDApOworCisgICAgICAgICAgICBpbnNwZWN0ZWRX aW5kb3cuZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiRE9NQ29udGVudExvYWRlZCIsIGNvbnRl bnRMb2FkZWQsIGZhbHNlKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCkBAIC0x NDEsOCArMTY5LDcgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBlID0gewog ICAgICAgICAgICAgdGhpcy5mb2N1c2VkRE9NTm9kZSA9IGNhbmlkYXRlRm9jdXNOb2RlOwogICAg ICAgICAgICAgaWYgKHRoaXMudHJlZU91dGxpbmUuc2VsZWN0ZWRUcmVlRWxlbWVudCkKICAgICAg ICAgICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLnNlbGVjdGVkVHJlZUVsZW1lbnQuZXhwYW5kKCk7 Ci0gICAgICAgIH0gZWxzZQotICAgICAgICAgICAgdGhpcy5mb2N1c2VkRE9NTm9kZSA9IG51bGw7 CisgICAgICAgIH0KICAgICB9LAogCiAgICAgdXBkYXRlVHJlZVNlbGVjdGlvbjogZnVuY3Rpb24o KQpAQCAtMTk5LDcgKzIyNiw3IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsLnByb3RvdHlw ZSA9IHsKICAgICAgICAgZm9yICh2YXIgcGFuZSBpbiB0aGlzLnNpZGViYXJQYW5lcykKICAgICAg ICAgICAgIHRoaXMuc2lkZWJhclBhbmVzW3BhbmVdLm5lZWRzVXBkYXRlID0gdHJ1ZTsKIAotICAg ICAgICB0aGlzLnVwZGF0ZVN0eWxlcyhmb3JjZVVwZGF0ZSk7CisgICAgICAgIHRoaXMudXBkYXRl U3R5bGVzKHRydWUpOwogICAgICAgICB0aGlzLnVwZGF0ZU1ldHJpY3MoKTsKICAgICAgICAgdGhp cy51cGRhdGVQcm9wZXJ0aWVzKCk7CiAgICAgfSwKLS0gCjEuNS40LjQKCg==