184174 2018-03-29 22:23:22 -0700 IsoHeapImpl not IsoHeapImplBase should add itself to AllIsoHeaps 2018-04-05 18:30:26 -0700 1 1 1 Unclassified WebKit bmalloc Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue ews-watchlist fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1410547 0 saam 2018-03-29 22:23:22 -0700 Otherwise, another thread may see a partially formed IsoHeapImpl... 1411843 1 337209 saam 2018-04-04 12:42:50 -0700 Created attachment 337209 patch 1411845 2 337210 saam 2018-04-04 12:54:17 -0700 Created attachment 337210 patch for landing 1411846 3 ews-watchlist 2018-04-04 12:56:37 -0700 Attachment 337210 did not pass style-queue: ERROR: Source/bmalloc/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1412215 4 337313 saam 2018-04-05 17:00:03 -0700 Created attachment 337313 patch for landing 1412232 5 337313 commit-queue 2018-04-05 18:29:30 -0700 Comment on attachment 337313 patch for landing Clearing flags on attachment: 337313 Committed r230317: <https://trac.webkit.org/changeset/230317> 1412233 6 commit-queue 2018-04-05 18:29:32 -0700 All reviewed patches have been landed. Closing bug. 1412234 7 webkit-bug-importer 2018-04-05 18:30:26 -0700 <rdar://problem/39227401> 337209 2018-04-04 12:42:50 -0700 2018-04-04 12:54:17 -0700 patch b-backup.diff text/plain 1922 saam SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMDI2NikKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA0LTA0ICBTYWFtIEJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIElzb0hlYXBJbXBsIG5vdCBJc29I ZWFwSW1wbEJhc2Ugc2hvdWxkIGFkZCBpdHNlbGYgdG8gQWxsSXNvSGVhcHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDE3NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE90aGVyd2lzZSwgYW5vdGhlciB0 aHJlYWQgbWF5IHNlZSBhIG5vbi1mdWxseSBmb3JtZWQgSXNvSGVhcEltcGwuCisKKyAgICAgICAg KiBibWFsbG9jL0lzb0hlYXBJbXBsLmNwcDoKKyAgICAgICAgKGJtYWxsb2M6Oklzb0hlYXBJbXBs QmFzZTo6SXNvSGVhcEltcGxCYXNlKToKKyAgICAgICAgKiBibWFsbG9jL0lzb0hlYXBJbXBsSW5s aW5lcy5oOgorICAgICAgICAoYm1hbGxvYzo6SXNvSGVhcEltcGw8Q29uZmlnPjo6SXNvSGVhcElt cGwpOgorCiAyMDE4LTA0LTA0ICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5y dT4KIAogICAgICAgICBFbmFibGUgR2lnYWNhZ2UgdW5jb25kaXRpb25hbGx5IHdoZW4gYnVpbGRp bmcgSlNDT25seSBvbiBtYWNPUyAoYnVpbGQgZml4KQpJbmRleDogU291cmNlL2JtYWxsb2MvYm1h bGxvYy9Jc29IZWFwSW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvYm1hbGxv Yy9Jc29IZWFwSW1wbC5jcHAJKHJldmlzaW9uIDIzMDI2NikKKysrIFNvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvSXNvSGVhcEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNSw3ICsyNSw2IEBACiAK ICNpbmNsdWRlICJJc29IZWFwSW1wbC5oIgogCi0jaW5jbHVkZSAiQWxsSXNvSGVhcHMuaCIKICNp bmNsdWRlICJQZXJQcm9jZXNzLmgiCiAjaW5jbHVkZSA8Y2xpbWl0cz4KIApAQCAtMzMsNyArMzIs NiBAQCBuYW1lc3BhY2UgYm1hbGxvYyB7CiAKIElzb0hlYXBJbXBsQmFzZTo6SXNvSGVhcEltcGxC YXNlKCkKIHsKLSAgICBQZXJQcm9jZXNzPEFsbElzb0hlYXBzPjo6Z2V0KCktPmFkZCh0aGlzKTsK IH0KIAogSXNvSGVhcEltcGxCYXNlOjp+SXNvSGVhcEltcGxCYXNlKCkKSW5kZXg6IFNvdXJjZS9i bWFsbG9jL2JtYWxsb2MvSXNvSGVhcEltcGxJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L2JtYWxsb2MvYm1hbGxvYy9Jc29IZWFwSW1wbElubGluZXMuaAkocmV2aXNpb24gMjMwMjY2KQor KysgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Jc29IZWFwSW1wbElubGluZXMuaAkod29ya2luZyBj b3B5KQpAQCAtMjUsNiArMjUsNyBAQAogCiAjcHJhZ21hIG9uY2UKIAorI2luY2x1ZGUgIkFsbElz b0hlYXBzLmgiCiAjaW5jbHVkZSAiSXNvSGVhcEltcGwuaCIKICNpbmNsdWRlICJJc29UTFNEZWFs bG9jYXRvckVudHJ5LmgiCiAKQEAgLTM2LDYgKzM3LDcgQEAgSXNvSGVhcEltcGw8Q29uZmlnPjo6 SXNvSGVhcEltcGwoKQogICAgICwgbV9pbmxpbmVEaXJlY3RvcnkoKnRoaXMpCiAgICAgLCBtX2Fs bG9jYXRvcigqdGhpcykKIHsKKyAgICBQZXJQcm9jZXNzPEFsbElzb0hlYXBzPjo6Z2V0KCktPmFk ZCh0aGlzKTsKIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgQ29uZmlnPgo= 337210 2018-04-04 12:54:17 -0700 2018-04-05 17:00:03 -0700 patch for landing b-backup.diff text/plain 2303 saam SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMDI2OSkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA0LTA0ICBTYWFtIEJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIElzb0hlYXBJbXBsIG5vdCBJc29I ZWFwSW1wbEJhc2Ugc2hvdWxkIGFkZCBpdHNlbGYgdG8gQWxsSXNvSGVhcHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDE3NAorCisgICAgICAgIFJl dmlld2VkIGJ5IEZpbGlwIFBpemxvLgorCQorICAgICAgICBPdGhlcndpc2UsIGFub3RoZXIgdGhy ZWFkIG1heSBzZWUgYSBub24tZnVsbHkgZm9ybWVkIElzb0hlYXBJbXBsLgorCisgICAgICAgICog Ym1hbGxvYy9Jc29IZWFwSW1wbC5jcHA6CisgICAgICAgIChibWFsbG9jOjpJc29IZWFwSW1wbEJh c2U6Oklzb0hlYXBJbXBsQmFzZSk6CisgICAgICAgIChibWFsbG9jOjpJc29IZWFwSW1wbEJhc2U6 OmFkZFRvQWxsSXNvSGVhcHMpOgorICAgICAgICAqIGJtYWxsb2MvSXNvSGVhcEltcGwuaDoKKyAg ICAgICAgKiBibWFsbG9jL0lzb0hlYXBJbXBsSW5saW5lcy5oOgorICAgICAgICAoYm1hbGxvYzo6 SXNvSGVhcEltcGw8Q29uZmlnPjo6SXNvSGVhcEltcGwpOgorCiAyMDE4LTA0LTA0ICBLb25zdGFu dGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KIAogICAgICAgICBFbmFibGUgR2lnYWNh Z2UgdW5jb25kaXRpb25hbGx5IHdoZW4gYnVpbGRpbmcgSlNDT25seSBvbiBtYWNPUyAoYnVpbGQg Zml4KQpJbmRleDogU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Jc29IZWFwSW1wbC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Jc29IZWFwSW1wbC5jcHAJKHJldmlzaW9u IDIzMDI2NikKKysrIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvSXNvSGVhcEltcGwuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zMywxMyArMzMsMTcgQEAgbmFtZXNwYWNlIGJtYWxsb2MgewogCiBJc29I ZWFwSW1wbEJhc2U6Oklzb0hlYXBJbXBsQmFzZSgpCiB7Ci0gICAgUGVyUHJvY2VzczxBbGxJc29I ZWFwcz46OmdldCgpLT5hZGQodGhpcyk7CiB9CiAKIElzb0hlYXBJbXBsQmFzZTo6fklzb0hlYXBJ bXBsQmFzZSgpCiB7CiB9CiAKK3ZvaWQgSXNvSGVhcEltcGxCYXNlOjphZGRUb0FsbElzb0hlYXBz KCkKK3sKKyAgICBQZXJQcm9jZXNzPEFsbElzb0hlYXBzPjo6Z2V0KCktPmFkZCh0aGlzKTsKK30K Kwogdm9pZCBJc29IZWFwSW1wbEJhc2U6OnNjYXZlbmdlTm93KCkKIHsKICAgICBWZWN0b3I8RGVm ZXJyZWREZWNvbW1pdD4gZGVmZXJyZWREZWNvbW1pdHM7CkluZGV4OiBTb3VyY2UvYm1hbGxvYy9i bWFsbG9jL0lzb0hlYXBJbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvYm1hbGxv Yy9Jc29IZWFwSW1wbC5oCShyZXZpc2lvbiAyMzAyNjYpCisrKyBTb3VyY2UvYm1hbGxvYy9ibWFs bG9jL0lzb0hlYXBJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ4LDYgKzQ4LDcgQEAgcHVibGlj OgogICAgIAogcHJvdGVjdGVkOgogICAgIElzb0hlYXBJbXBsQmFzZSgpOworICAgIHZvaWQgYWRk VG9BbGxJc29IZWFwcygpOwogCiBwcml2YXRlOgogICAgIGZyaWVuZCBjbGFzcyBBbGxJc29IZWFw czsKSW5kZXg6IFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvSXNvSGVhcEltcGxJbmxpbmVzLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Jc29IZWFwSW1wbElubGluZXMuaAko cmV2aXNpb24gMjMwMjY2KQorKysgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Jc29IZWFwSW1wbElu bGluZXMuaAkod29ya2luZyBjb3B5KQpAQCAtMzYsNiArMzYsNyBAQCBJc29IZWFwSW1wbDxDb25m aWc+OjpJc29IZWFwSW1wbCgpCiAgICAgLCBtX2lubGluZURpcmVjdG9yeSgqdGhpcykKICAgICAs IG1fYWxsb2NhdG9yKCp0aGlzKQogeworICAgIGFkZFRvQWxsSXNvSGVhcHMoKTsKIH0KIAogdGVt cGxhdGU8dHlwZW5hbWUgQ29uZmlnPgo= 337313 2018-04-05 17:00:03 -0700 2018-04-05 18:29:30 -0700 patch for landing c-backup.diff text/plain 2280 saam SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMDMxNSkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA0LTA1ICBTYWFtIEJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIElzb0hlYXBJbXBsIG5vdCBJc29I ZWFwSW1wbEJhc2Ugc2hvdWxkIGFkZCBpdHNlbGYgdG8gQWxsSXNvSGVhcHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDE3NAorCisgICAgICAgIFJl dmlld2VkIGJ5IEZpbGlwIFBpemxvLgorCisgICAgICAgIE90aGVyd2lzZSwgYW5vdGhlciB0aHJl YWQgbWF5IHNlZSBhIG5vbi1mdWxseSBmb3JtZWQgSXNvSGVhcEltcGwuCisKKyAgICAgICAgKiBi bWFsbG9jL0lzb0hlYXBJbXBsLmNwcDoKKyAgICAgICAgKGJtYWxsb2M6Oklzb0hlYXBJbXBsQmFz ZTo6SXNvSGVhcEltcGxCYXNlKToKKyAgICAgICAgKGJtYWxsb2M6Oklzb0hlYXBJbXBsQmFzZTo6 YWRkVG9BbGxJc29IZWFwcyk6CisgICAgICAgICogYm1hbGxvYy9Jc29IZWFwSW1wbC5oOgorICAg ICAgICAqIGJtYWxsb2MvSXNvSGVhcEltcGxJbmxpbmVzLmg6CisgICAgICAgIChibWFsbG9jOjpJ c29IZWFwSW1wbDxDb25maWc+OjpJc29IZWFwSW1wbCk6CisKIDIwMTgtMDQtMDUgIFl1c3VrZSBT dXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgYm1hbGxvYyBTdGF0aWNN dXRleCdzIGNvbnN0cnVjdG9yIHNob3VsZCBiZSBjb25zdGV4cHIKSW5kZXg6IFNvdXJjZS9ibWFs bG9jL2JtYWxsb2MvSXNvSGVhcEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9j L2JtYWxsb2MvSXNvSGVhcEltcGwuY3BwCShyZXZpc2lvbiAyMzAzMTUpCisrKyBTb3VyY2UvYm1h bGxvYy9ibWFsbG9jL0lzb0hlYXBJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMsMTMgKzMz LDE3IEBAIG5hbWVzcGFjZSBibWFsbG9jIHsKIAogSXNvSGVhcEltcGxCYXNlOjpJc29IZWFwSW1w bEJhc2UoKQogewotICAgIFBlclByb2Nlc3M8QWxsSXNvSGVhcHM+OjpnZXQoKS0+YWRkKHRoaXMp OwogfQogCiBJc29IZWFwSW1wbEJhc2U6On5Jc29IZWFwSW1wbEJhc2UoKQogewogfQogCit2b2lk IElzb0hlYXBJbXBsQmFzZTo6YWRkVG9BbGxJc29IZWFwcygpCit7CisgICAgUGVyUHJvY2VzczxB bGxJc29IZWFwcz46OmdldCgpLT5hZGQodGhpcyk7Cit9CisKIHZvaWQgSXNvSGVhcEltcGxCYXNl OjpzY2F2ZW5nZU5vdygpCiB7CiAgICAgVmVjdG9yPERlZmVycmVkRGVjb21taXQ+IGRlZmVycmVk RGVjb21taXRzOwpJbmRleDogU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Jc29IZWFwSW1wbC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvSXNvSGVhcEltcGwuaAkocmV2aXNp b24gMjMwMzE1KQorKysgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Jc29IZWFwSW1wbC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC00OCw2ICs0OCw3IEBAIHB1YmxpYzoKICAgICAKIHByb3RlY3RlZDoKICAg ICBJc29IZWFwSW1wbEJhc2UoKTsKKyAgICB2b2lkIGFkZFRvQWxsSXNvSGVhcHMoKTsKIAogcHJp dmF0ZToKICAgICBmcmllbmQgY2xhc3MgQWxsSXNvSGVhcHM7CkluZGV4OiBTb3VyY2UvYm1hbGxv Yy9ibWFsbG9jL0lzb0hlYXBJbXBsSW5saW5lcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFs bG9jL2JtYWxsb2MvSXNvSGVhcEltcGxJbmxpbmVzLmgJKHJldmlzaW9uIDIzMDMxNSkKKysrIFNv dXJjZS9ibWFsbG9jL2JtYWxsb2MvSXNvSGVhcEltcGxJbmxpbmVzLmgJKHdvcmtpbmcgY29weSkK QEAgLTM2LDYgKzM2LDcgQEAgSXNvSGVhcEltcGw8Q29uZmlnPjo6SXNvSGVhcEltcGwoKQogICAg ICwgbV9pbmxpbmVEaXJlY3RvcnkoKnRoaXMpCiAgICAgLCBtX2FsbG9jYXRvcigqdGhpcykKIHsK KyAgICBhZGRUb0FsbElzb0hlYXBzKCk7CiB9CiAKIHRlbXBsYXRlPHR5cGVuYW1lIENvbmZpZz4K