184158 2018-03-29 14:31:24 -0700 Web Automation: clipToViewport is ignored for element screenshots 2018-03-29 17:07:46 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg cgarcia commit-queue joepeck thorton timothy webkit-bug-importer oldest_to_newest 1410402 0 bburg 2018-03-29 14:31:24 -0700 Current spec behavior is to clip elements to the viewport. We should respect that unless the spec changes. 1410403 1 webkit-bug-importer 2018-03-29 14:32:24 -0700 <rdar://problem/39014307> 1410418 2 336808 bburg 2018-03-29 15:20:16 -0700 Created attachment 336808 Patch 1410454 3 336808 commit-queue 2018-03-29 17:07:44 -0700 Comment on attachment 336808 Patch Clearing flags on attachment: 336808 Committed r230088: <https://trac.webkit.org/changeset/230088> 1410455 4 commit-queue 2018-03-29 17:07:46 -0700 All reviewed patches have been landed. Closing bug. 336808 2018-03-29 15:20:16 -0700 2018-03-29 17:07:44 -0700 Patch bug-184158-20180329152016.patch text/plain 3518 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcxODk3Y2I4MDE5ZjNmMjQw MTE4YjA5MTVkMDY1NzFkNmY2MjI4NWIuLjZhZjczYjJmYThkMDUxMThhZjI3OGQ4YTU0ZDQxNzBh Zjc5NDZjMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMDMtMjkgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEF1dG9tYXRpb246IGNsaXBUb1Zp ZXdwb3J0IGlzIGlnbm9yZWQgZm9yIGVsZW1lbnQgc2NyZWVuc2hvdHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDE1OAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMzkwMTQzMDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW4gwqcxOS4yIFRha2UgRWxlbWVudCBTY3JlZW5zaG90LCBzdGVwIDUuMiBz YXlzIHRoYXQgd2Ugc2hvdWxkIGNsaXAKKyAgICAgICAgdGhlIGVsZW1lbnQgc2NyZWVuc2hvdCBy ZWN0IHdpdGggdGhlIHZpc2libGUgdmlld3BvcnQgcmVjdC4gV2UgZG9uJ3QKKyAgICAgICAgZG8g dGhhdCByaWdodCBub3cgZXZlbiB0aG91Z2ggd2UgcGFzcyBvdmVyIGNsaXBUb1ZpZXdwb3J0Lgor CisgICAgICAgICogV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJv eHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpzbmFwc2hvdFJlY3RGb3JTY3JlZW5zaG90KToKKyAg ICAgICAgQ2xpcCB0aGUgcmVjdCB0byB2aWV3cG9ydCBpZiBuZWVkZWQuCisKKyAgICAgICAgKFdl YktpdDo6V2ViQXV0b21hdGlvblNlc3Npb25Qcm94eTo6dGFrZVNjcmVlbnNob3QpOgorICAgICAg ICBUaGlzIHNjcm9sbEludG9WaWV3IGlzIG1pc3BsYWNlZDsgYnkgdGhpcyBwb2ludCB3ZSBoYXZl IGFscmVhZHkgZG9uZQorICAgICAgICB0aGUgbWF0aCB0byBmaWd1cmUgb3V0IHRoZSBzY3JlZW5z aG90IHJlY3QuIE1vdmUgaXQgYmVmb3JlIGNvbXB1dGluZyB0aGUgcmVjdC4KKwogMjAxOC0wMy0y OSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgU3luY2hyb25p emUgU2VjdXJpdHlPcmlnaW4gcmVsYXRlZCBzY2hlbWUgcmVnaXN0cmllcyB3aXRoIE5ldHdvcmtQ cm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvQXV0b21hdGlvbi9X ZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9B dXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJveHkuY3BwCmluZGV4IDJlNmNiZWIyYWM5 YTJhODQxYWJiMjg1YWI0MjMwMjQ3Mjk4OTNlZTMuLmVhOGE0M2VlZDI5MjBhNGY2MWY5YmM5OTE1 MzUwMzhhYTA1MjAzY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRv bWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJveHkuY3BwCkBAIC02 NjMsMTIgKzY2MywyMCBAQCB2b2lkIFdlYkF1dG9tYXRpb25TZXNzaW9uUHJveHk6OnNlbGVjdE9w dGlvbkVsZW1lbnQodWludDY0X3QgcGFnZUlELCB1aW50NjRfdCBmcgogCiBzdGF0aWMgV2ViQ29y ZTo6SW50UmVjdCBzbmFwc2hvdFJlY3RGb3JTY3JlZW5zaG90KFdlYlBhZ2UmIHBhZ2UsIFdlYkNv cmU6OkVsZW1lbnQqIGVsZW1lbnQsIGJvb2wgY2xpcFRvVmlld3BvcnQpCiB7CisgICAgYXV0byog ZnJhbWVWaWV3ID0gcGFnZS5tYWluRnJhbWVWaWV3KCk7CisgICAgaWYgKCFmcmFtZVZpZXcpCisg ICAgICAgIHJldHVybiB7IH07CisKICAgICBpZiAoZWxlbWVudCkgewogICAgICAgICBpZiAoIWVs ZW1lbnQtPnJlbmRlcmVyKCkpCiAgICAgICAgICAgICByZXR1cm4geyB9OwogCiAgICAgICAgIFdl YkNvcmU6OkxheW91dFJlY3QgdG9wTGV2ZWxSZWN0OwotICAgICAgICByZXR1cm4gV2ViQ29yZTo6 c25hcHBlZEludFJlY3QoZWxlbWVudC0+cmVuZGVyZXIoKS0+cGFpbnRpbmdSb290UmVjdCh0b3BM ZXZlbFJlY3QpKTsKKyAgICAgICAgV2ViQ29yZTo6SW50UmVjdCBlbGVtZW50UmVjdCA9IFdlYkNv cmU6OnNuYXBwZWRJbnRSZWN0KGVsZW1lbnQtPnJlbmRlcmVyKCktPnBhaW50aW5nUm9vdFJlY3Qo dG9wTGV2ZWxSZWN0KSk7CisgICAgICAgIGlmIChjbGlwVG9WaWV3cG9ydCkKKyAgICAgICAgICAg IGVsZW1lbnRSZWN0LmludGVyc2VjdChmcmFtZVZpZXctPnZpc2libGVDb250ZW50UmVjdCgpKTsK KworICAgICAgICByZXR1cm4gZWxlbWVudFJlY3Q7CiAgICAgfQogCiAgICAgaWYgKGF1dG8qIGZy YW1lVmlldyA9IHBhZ2UubWFpbkZyYW1lVmlldygpKQpAQCAtNzA1LDYgKzcxMyw5IEBAIHZvaWQg V2ViQXV0b21hdGlvblNlc3Npb25Qcm94eTo6dGFrZVNjcmVlbnNob3QodWludDY0X3QgcGFnZUlE LCB1aW50NjRfdCBmcmFtZUlECiAgICAgICAgIH0KICAgICB9CiAKKyAgICBpZiAoY29yZUVsZW1l bnQgJiYgc2Nyb2xsSW50b1ZpZXdJZk5lZWRlZCkKKyAgICAgICAgY29yZUVsZW1lbnQtPnNjcm9s bEludG9WaWV3SWZOZWVkZWQoZmFsc2UpOworCiAgICAgU3RyaW5nIHNjcmVlbnNob3RFcnJvclR5 cGUgPSBJbnNwZWN0b3I6OlByb3RvY29sOjpBdXRvbWF0aW9uSGVscGVyczo6Z2V0RW51bUNvbnN0 YW50VmFsdWUoSW5zcGVjdG9yOjpQcm90b2NvbDo6QXV0b21hdGlvbjo6RXJyb3JNZXNzYWdlOjpT Y3JlZW5zaG90RXJyb3IpOwogICAgIFdlYkNvcmU6OkludFJlY3Qgc25hcHNob3RSZWN0ID0gc25h cHNob3RSZWN0Rm9yU2NyZWVuc2hvdCgqcGFnZSwgY29yZUVsZW1lbnQsIGNsaXBUb1ZpZXdwb3J0 KTsKICAgICBpZiAoc25hcHNob3RSZWN0LmlzRW1wdHkoKSkgewpAQCAtNzEyLDkgKzcyMyw2IEBA IHZvaWQgV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eTo6dGFrZVNjcmVlbnNob3QodWludDY0X3Qg cGFnZUlELCB1aW50NjRfdCBmcmFtZUlECiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBp ZiAoY29yZUVsZW1lbnQgJiYgc2Nyb2xsSW50b1ZpZXdJZk5lZWRlZCkKLSAgICAgICAgY29yZUVs ZW1lbnQtPnNjcm9sbEludG9WaWV3SWZOZWVkZWQoZmFsc2UpOwotCiAgICAgUmVmUHRyPFdlYklt YWdlPiBpbWFnZSA9IHBhZ2UtPnNjYWxlZFNuYXBzaG90V2l0aE9wdGlvbnMoc25hcHNob3RSZWN0 LCAxLCBTbmFwc2hvdE9wdGlvbnNTaGFyZWFibGUpOwogICAgIGlmICghaW1hZ2UpIHsKICAgICAg ICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkucGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2Vu ZChNZXNzYWdlczo6V2ViQXV0b21hdGlvblNlc3Npb246OkRpZFRha2VTY3JlZW5zaG90KGNhbGxi YWNrSUQsIGhhbmRsZSwgc2NyZWVuc2hvdEVycm9yVHlwZSksIDApOwo=