184150 2018-03-29 13:18:31 -0700 MIMETypeRegistry should return const HashSets 2018-03-29 14:50:23 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates pvollan webkit-bug-importer oldest_to_newest 1410364 0 dbates 2018-03-29 13:18:31 -0700 Mark more MIMETypeRegistry assessors const. 1410365 1 dbates 2018-03-29 13:20:00 -0700 (In reply to Daniel Bates from comment #0) > Mark more MIMETypeRegistry assessors const. err, I meant to write: MIMETypeRegistry should return const HashSets 1410367 2 336797 dbates 2018-03-29 13:22:45 -0700 Created attachment 336797 Patch 1410377 3 336797 pvollan 2018-03-29 13:27:46 -0700 Comment on attachment 336797 Patch R=me. 1410411 4 336797 dbates 2018-03-29 14:49:30 -0700 Comment on attachment 336797 Patch Clearing flags on attachment: 336797 Committed r230082: <https://trac.webkit.org/changeset/230082> 1410412 5 dbates 2018-03-29 14:49:32 -0700 All reviewed patches have been landed. Closing bug. 1410414 6 webkit-bug-importer 2018-03-29 14:50:23 -0700 <rdar://problem/39015369> 336797 2018-03-29 13:22:45 -0700 2018-03-29 14:49:30 -0700 Patch bug-184150-20180329132245.patch text/plain 5784 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTkyYTc4NTI3NGRmZmI3 MWVlMjRjOTgwOTFkMjk4NWYzN2JkMjM1NS4uYWNlOGZhNDA1N2RhZGNjOTVkNWUwYzk5NGM3NTMx YTI2NTkzMDQyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTAzLTI5ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBNSU1FVHlwZVJlZ2lzdHJ5 IHNob3VsZCByZXR1cm4gY29uc3QgSGFzaFNldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDE1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgZ2V0U3VwcG9ydGVkTm9uSW1hZ2VNSU1FVHlwZXMo KSBuZWVkcyB0byByZXR1cm4gYSBub24tY29uc3QgSGFzaFNldCBzbyB0aGF0CisgICAgICAgIExl Z2FjeVdlYktpdCBjYW4gbW9kaWZ5IHRoZSBzZXQgb2Ygbm9uLWltYWdlIE1JTUUgdHlwZXMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok1JTUVUeXBlUmVnaXN0cnk6OmdldFN1cHBvcnRlZEltYWdlTUlNRVR5cGVzKToKKyAgICAg ICAgKFdlYkNvcmU6Ok1JTUVUeXBlUmVnaXN0cnk6OmdldFN1cHBvcnRlZEltYWdlUmVzb3VyY2VN SU1FVHlwZXMpOgorICAgICAgICAoV2ViQ29yZTo6TUlNRVR5cGVSZWdpc3RyeTo6Z2V0U3VwcG9y dGVkSW1hZ2VNSU1FVHlwZXNGb3JFbmNvZGluZyk6CisgICAgICAgIChXZWJDb3JlOjpNSU1FVHlw ZVJlZ2lzdHJ5OjpnZXRTdXBwb3J0ZWRNZWRpYU1JTUVUeXBlcyk6CisgICAgICAgIChXZWJDb3Jl OjpNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRQREZNSU1FVHlwZXMpOgorICAgICAgICAoV2ViQ29yZTo6 TUlNRVR5cGVSZWdpc3RyeTo6Z2V0VW5zdXBwb3J0ZWRUZXh0TUlNRVR5cGVzKToKKyAgICAgICAg KiBwbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5Lmg6CisKIDIwMTgtMDMtMjkgIERhbmllbCBCYXRl cyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFN1YnN0aXR1dGUgQXJjaGl2ZUZhY3Rv cnk6OmlzQXJjaGl2ZU1JTUVUeXBlKCkgZm9yIEFyY2hpdmVGYWN0b3J5Ojppc0FyY2hpdmVNaW1l VHlwZSgpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdp c3RyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcApp bmRleCBjNjE3YjNhNzQyNGQ5NGYzMWMyMmRlYTBlMDY0ZmFiZDBjZDYxY2E0Li5mMDZjMDUxNTIy OTJiOWI0NWViZTU2ZjExMzMwZTcwZWYzZTgzNGIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcApAQCAtNjUxLDIxICs2NTEsMjEgQEAgYm9vbCBNSU1F VHlwZVJlZ2lzdHJ5OjpjYW5TaG93TUlNRVR5cGUoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKICAg ICByZXR1cm4gZmFsc2U7CiB9CiAKLUhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2 ZUhhc2g+JiBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRTdXBwb3J0ZWRJbWFnZU1JTUVUeXBlcygpCitj b25zdCBIYXNoU2V0PFN0cmluZywgQVNDSUlDYXNlSW5zZW5zaXRpdmVIYXNoPiYgTUlNRVR5cGVS ZWdpc3RyeTo6Z2V0U3VwcG9ydGVkSW1hZ2VNSU1FVHlwZXMoKQogewogICAgIGlmICghc3VwcG9y dGVkSW1hZ2VNSU1FVHlwZXMpCiAgICAgICAgIGluaXRpYWxpemVTdXBwb3J0ZWRJbWFnZU1JTUVU eXBlcygpOwogICAgIHJldHVybiAqc3VwcG9ydGVkSW1hZ2VNSU1FVHlwZXM7CiB9CiAKLUhhc2hT ZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+JiBNSU1FVHlwZVJlZ2lzdHJ5Ojpn ZXRTdXBwb3J0ZWRJbWFnZVJlc291cmNlTUlNRVR5cGVzKCkKK2NvbnN0IEhhc2hTZXQ8U3RyaW5n LCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+JiBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRTdXBwb3J0 ZWRJbWFnZVJlc291cmNlTUlNRVR5cGVzKCkKIHsKICAgICBpZiAoIXN1cHBvcnRlZEltYWdlUmVz b3VyY2VNSU1FVHlwZXMpCiAgICAgICAgIGluaXRpYWxpemVTdXBwb3J0ZWRJbWFnZU1JTUVUeXBl cygpOwogICAgIHJldHVybiAqc3VwcG9ydGVkSW1hZ2VSZXNvdXJjZU1JTUVUeXBlczsKIH0KIAot SGFzaFNldDxTdHJpbmcsIEFTQ0lJQ2FzZUluc2Vuc2l0aXZlSGFzaD4mIE1JTUVUeXBlUmVnaXN0 cnk6OmdldFN1cHBvcnRlZEltYWdlTUlNRVR5cGVzRm9yRW5jb2RpbmcoKQorY29uc3QgSGFzaFNl dDxTdHJpbmcsIEFTQ0lJQ2FzZUluc2Vuc2l0aXZlSGFzaD4mIE1JTUVUeXBlUmVnaXN0cnk6Omdl dFN1cHBvcnRlZEltYWdlTUlNRVR5cGVzRm9yRW5jb2RpbmcoKQogewogICAgIGlmICghc3VwcG9y dGVkSW1hZ2VNSU1FVHlwZXNGb3JFbmNvZGluZykKICAgICAgICAgaW5pdGlhbGl6ZVN1cHBvcnRl ZEltYWdlTUlNRVR5cGVzRm9yRW5jb2RpbmcoKTsKQEAgLTY3OSw3ICs2NzksNyBAQCBIYXNoU2V0 PFN0cmluZywgQVNDSUlDYXNlSW5zZW5zaXRpdmVIYXNoPiYgTUlNRVR5cGVSZWdpc3RyeTo6Z2V0 U3VwcG9ydGVkTm9uSW1hZwogICAgIHJldHVybiAqc3VwcG9ydGVkTm9uSW1hZ2VNSU1FVHlwZXM7 CiB9CiAKLUhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+JiBNSU1FVHlw ZVJlZ2lzdHJ5OjpnZXRTdXBwb3J0ZWRNZWRpYU1JTUVUeXBlcygpCitjb25zdCBIYXNoU2V0PFN0 cmluZywgQVNDSUlDYXNlSW5zZW5zaXRpdmVIYXNoPiYgTUlNRVR5cGVSZWdpc3RyeTo6Z2V0U3Vw cG9ydGVkTWVkaWFNSU1FVHlwZXMoKQogewogICAgIGlmICghc3VwcG9ydGVkTWVkaWFNSU1FVHlw ZXMpCiAgICAgICAgIGluaXRpYWxpemVTdXBwb3J0ZWRNZWRpYU1JTUVUeXBlcygpOwpAQCAtNjg3 LDE0ICs2ODcsMTQgQEAgSGFzaFNldDxTdHJpbmcsIEFTQ0lJQ2FzZUluc2Vuc2l0aXZlSGFzaD4m IE1JTUVUeXBlUmVnaXN0cnk6OmdldFN1cHBvcnRlZE1lZGlhTUkKIH0KIAogCi1IYXNoU2V0PFN0 cmluZywgQVNDSUlDYXNlSW5zZW5zaXRpdmVIYXNoPiYgTUlNRVR5cGVSZWdpc3RyeTo6Z2V0UERG TUlNRVR5cGVzKCkKK2NvbnN0IEhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhh c2g+JiBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRQREZNSU1FVHlwZXMoKQogewogICAgIGlmICghcGRm TUlNRVR5cGVzKQogICAgICAgICBpbml0aWFsaXplUERGTUlNRVR5cGVzKCk7CiAgICAgcmV0dXJu ICpwZGZNSU1FVHlwZXM7CiB9CiAKLUhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2 ZUhhc2g+JiBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRVbnN1cHBvcnRlZFRleHRNSU1FVHlwZXMoKQor Y29uc3QgSGFzaFNldDxTdHJpbmcsIEFTQ0lJQ2FzZUluc2Vuc2l0aXZlSGFzaD4mIE1JTUVUeXBl UmVnaXN0cnk6OmdldFVuc3VwcG9ydGVkVGV4dE1JTUVUeXBlcygpCiB7CiAgICAgaWYgKCF1bnN1 cHBvcnRlZFRleHRNSU1FVHlwZXMpCiAgICAgICAgIGluaXRpYWxpemVVbnN1cHBvcnRlZFRleHRN SU1FVHlwZXMoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBl UmVnaXN0cnkuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnkuaApp bmRleCAzYmZjNGU0NjI2OTg1MmFiNmQ0MmI0ZGFhMDViYmRhODgwNDI5MGRlLi5jNzA2ZWVhM2Uw MDEyYjA1YWIwMTg4YTYwMmIxNzViZDJhNWJmMGZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vTUlNRVR5cGVSZWdpc3RyeS5oCkBAIC0xMDYsMTMgKzEwNiwxNCBAQCBwdWJsaWM6CiAKICAg ICAvLyBGSVhNRTogV2ViS2l0IGNvZGluZyBzdHlsZSBzYXlzIHdlIHNob3VsZCBub3QgaGF2ZSB0 aGUgd29yZCAiZ2V0IiBpbiB0aGUgbmFtZXMgb2YgdGhlc2UgZnVuY3Rpb25zLgogICAgIC8vIEZJ WE1FOiBXb3VsZCBiZSBuaWNlIHRvIGZpbmQgYSB3YXkgdG8gYXZvaWQgZXhwb3NpbmcgdGhlc2Ug c2V0cywgZXZlbiB3b3JzZSBleHBvc2luZyBub24tY29uc3QgcmVmZXJlbmNlcy4KLSAgICBXRUJD T1JFX0VYUE9SVCBzdGF0aWMgSGFzaFNldDxTdHJpbmcsIEFTQ0lJQ2FzZUluc2Vuc2l0aXZlSGFz aD4mIGdldFN1cHBvcnRlZEltYWdlTUlNRVR5cGVzKCk7Ci0gICAgc3RhdGljIEhhc2hTZXQ8U3Ry aW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+JiBnZXRTdXBwb3J0ZWRJbWFnZVJlc291cmNl TUlNRVR5cGVzKCk7Ci0gICAgc3RhdGljIEhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNlbnNp dGl2ZUhhc2g+JiBnZXRTdXBwb3J0ZWRJbWFnZU1JTUVUeXBlc0ZvckVuY29kaW5nKCk7CiAgICAg V0VCQ09SRV9FWFBPUlQgc3RhdGljIEhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2 ZUhhc2g+JiBnZXRTdXBwb3J0ZWROb25JbWFnZU1JTUVUeXBlcygpOwotICAgIFdFQkNPUkVfRVhQ T1JUIHN0YXRpYyBIYXNoU2V0PFN0cmluZywgQVNDSUlDYXNlSW5zZW5zaXRpdmVIYXNoPiYgZ2V0 U3VwcG9ydGVkTWVkaWFNSU1FVHlwZXMoKTsKLSAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgSGFz aFNldDxTdHJpbmcsIEFTQ0lJQ2FzZUluc2Vuc2l0aXZlSGFzaD4mIGdldFBERk1JTUVUeXBlcygp OwotICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBIYXNoU2V0PFN0cmluZywgQVNDSUlDYXNlSW5z ZW5zaXRpdmVIYXNoPiYgZ2V0VW5zdXBwb3J0ZWRUZXh0TUlNRVR5cGVzKCk7CisKKyAgICBXRUJD T1JFX0VYUE9SVCBjb25zdCBzdGF0aWMgSGFzaFNldDxTdHJpbmcsIEFTQ0lJQ2FzZUluc2Vuc2l0 aXZlSGFzaD4mIGdldFN1cHBvcnRlZEltYWdlTUlNRVR5cGVzKCk7CisgICAgY29uc3Qgc3RhdGlj IEhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+JiBnZXRTdXBwb3J0ZWRJ bWFnZVJlc291cmNlTUlNRVR5cGVzKCk7CisgICAgY29uc3Qgc3RhdGljIEhhc2hTZXQ8U3RyaW5n LCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+JiBnZXRTdXBwb3J0ZWRJbWFnZU1JTUVUeXBlc0Zv ckVuY29kaW5nKCk7CisgICAgV0VCQ09SRV9FWFBPUlQgY29uc3Qgc3RhdGljIEhhc2hTZXQ8U3Ry aW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+JiBnZXRTdXBwb3J0ZWRNZWRpYU1JTUVUeXBl cygpOworICAgIFdFQkNPUkVfRVhQT1JUIGNvbnN0IHN0YXRpYyBIYXNoU2V0PFN0cmluZywgQVND SUlDYXNlSW5zZW5zaXRpdmVIYXNoPiYgZ2V0UERGTUlNRVR5cGVzKCk7CisgICAgV0VCQ09SRV9F WFBPUlQgY29uc3Qgc3RhdGljIEhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhh c2g+JiBnZXRVbnN1cHBvcnRlZFRleHRNSU1FVHlwZXMoKTsKIAogICAgIC8vIEZJWE1FOiBXZWJL aXQgY29kaW5nIHN0eWxlIHNheXMgd2Ugc2hvdWxkIG5vdCBoYXZlIHRoZSB3b3JkICJnZXQiIGlu IHRoZSBuYW1lIG9mIHRoaXMgZnVuY3Rpb24uCiAgICAgLy8gRklYTUU6IFVuY2xlYXIgd2hhdCB0 aGUgY29uY2VwdCBvZiBhIG5vcm1hbGl6ZWQgTUlNRSB0eXBlIGlzOyBjdXJyZW50bHkgaXQncyBh IHBsYXRmb3JtLXNwZWNpZmljIG5vdGlvbi4K