184137 2018-03-29 09:48:28 -0700 ArrayMode should not try to get the DFG to think it can convert TypedArrays 2018-03-29 12:10:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue ews-watchlist mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1410290 0 keith_miller 2018-03-29 09:48:28 -0700 ArrayMode should not try to get the DFG to think it can convert TypedArrays 1410291 1 336779 keith_miller 2018-03-29 09:52:33 -0700 Created attachment 336779 Patch 1410295 2 336779 saam 2018-03-29 09:54:45 -0700 Comment on attachment 336779 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336779&action=review maybe add a microbenchmark? > Source/JavaScriptCore/dfg/DFGArrayMode.cpp:121 > + // If we have seen multiple TypedArray types or a TypedArray and non-typed array it doesn't make sense to try to convert the array since we won't be able to when we have a typed array. "If we have seen multiple TypedArray types or a TypedArray and non-typed array it doesn't make sense to try to convert the array since we won't be able to when we have a typed array." => "If we have seen multiple TypedArray types, or a TypedArray and non-typed array, it doesn't make sense to try to convert the array since you can't convert typed arrays." 1410299 3 336782 keith_miller 2018-03-29 10:17:13 -0700 Created attachment 336782 Patch for landing 1410340 4 336782 commit-queue 2018-03-29 12:09:05 -0700 Comment on attachment 336782 Patch for landing Clearing flags on attachment: 336782 Committed r230078: <https://trac.webkit.org/changeset/230078> 1410341 5 commit-queue 2018-03-29 12:09:07 -0700 All reviewed patches have been landed. Closing bug. 1410342 6 webkit-bug-importer 2018-03-29 12:10:22 -0700 <rdar://problem/39008430> 336779 2018-03-29 09:52:33 -0700 2018-03-29 10:17:09 -0700 Patch bug-184137-20180329185232.patch text/plain 1846 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5ODEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx YTIzNmUzMDgwYWYxN2Q2NmY2NzIyMjhmNmVkMGYxNjQ4OTkyNmE2Li4wNGJjYmEzODcwNTBlNDlj MTk5MGFkMDZhMzZkZTc2ZDA2MzI0ZGY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0wMy0yOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBBcnJheU1vZGUgc2hvdWxkIG5vdCB0cnkgdG8gZ2V0IHRoZSBERkcg dG8gdGhpbmsgaXQgY2FuIGNvbnZlcnQgVHlwZWRBcnJheXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDEzNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0FycmF5TW9kZS5jcHA6CisgICAg ICAgIChKU0M6OkRGRzo6QXJyYXlNb2RlOjpmcm9tT2JzZXJ2ZWQpOgorCiAyMDE4LTAzLTIxICBL ZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIGJ0anMgc2hv dWxkIHByaW50IHRoZSBieXRlY29kZSBvZmZzZXQgaW4gdGhlIHN0YWNrIHRyYWNlIGZvciBKUyBm cmFtZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQXJyYXlNb2Rl LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQXJyYXlNb2RlLmNwcAppbmRleCAz MDc1YmRmNDVkODlhYTdhODgzZWQ2NTBhMjg0YjQxM2E0MzMyODljLi4yZjFhZmY1ODJkMDZiODBi YWEzMGM4Njk5YTZmYjJiZWQ1ZDhkNzAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0FycmF5TW9kZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdBcnJheU1vZGUuY3BwCkBAIC0xMTgsNiArMTE4LDEwIEBAIEFycmF5TW9kZSBBcnJheU1vZGU6 OmZyb21PYnNlcnZlZChjb25zdCBDb25jdXJyZW50SlNMb2NrZXImIGxvY2tlciwgQXJyYXlQcm9m aWxlCiAgICAgICAgIHJldHVybiBBcnJheU1vZGUoQXJyYXk6OkZsb2F0NjRBcnJheSwgbm9uQXJy YXksIEFycmF5OjpBc0lzKS53aXRoUHJvZmlsZShsb2NrZXIsIHByb2ZpbGUsIG1ha2VTYWZlKTsK IAogICAgIGRlZmF1bHQ6CisgICAgICAgIC8vIElmIHdlIGhhdmUgc2VlbiBtdWx0aXBsZSBUeXBl ZEFycmF5IHR5cGVzIG9yIGEgVHlwZWRBcnJheSBhbmQgbm9uLXR5cGVkIGFycmF5IGl0IGRvZXNu J3QgbWFrZSBzZW5zZSB0byB0cnkgdG8gY29udmVydCB0aGUgYXJyYXkgc2luY2Ugd2Ugd29uJ3Qg YmUgYWJsZSB0byB3aGVuIHdlIGhhdmUgYSB0eXBlZCBhcnJheS4KKyAgICAgICAgaWYgKG9ic2Vy dmVkICYgQUxMX1RZUEVEX0FSUkFZX01PREVTKQorICAgICAgICAgICAgcmV0dXJuIEFycmF5TW9k ZShBcnJheTo6R2VuZXJpYywgbm9uQXJyYXksIEFycmF5OjpBc0lzKS53aXRoUHJvZmlsZShsb2Nr ZXIsIHByb2ZpbGUsIG1ha2VTYWZlKTsKKwogICAgICAgICBpZiAoKG9ic2VydmVkICYgYXNBcnJh eU1vZGVzKE5vbkFycmF5KSkgJiYgcHJvZmlsZS0+bWF5SW50ZXJjZXB0SW5kZXhlZEFjY2Vzc2Vz KGxvY2tlcikpCiAgICAgICAgICAgICByZXR1cm4gQXJyYXlNb2RlKEFycmF5OjpTZWxlY3RVc2lu Z1ByZWRpY3Rpb25zKS53aXRoU3BlY3VsYXRpb25Gcm9tUHJvZmlsZShsb2NrZXIsIHByb2ZpbGUs IG1ha2VTYWZlKTsKICAgICAgICAgCg== 336782 2018-03-29 10:17:13 -0700 2018-03-29 12:09:05 -0700 Patch for landing bug-184137-20180329191712.patch text/plain 1830 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5ODEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx YTIzNmUzMDgwYWYxN2Q2NmY2NzIyMjhmNmVkMGYxNjQ4OTkyNmE2Li4yODNlZWM5YjBkMmM3ODE2 MmI5MDNmMDQ3Y2E1MmMxYzhhNjk1N2YwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0wMy0yOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBBcnJheU1vZGUgc2hvdWxkIG5vdCB0cnkgdG8gZ2V0IHRoZSBERkcg dG8gdGhpbmsgaXQgY2FuIGNvbnZlcnQgVHlwZWRBcnJheXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDEzNworCisgICAgICAgIFJldmlld2VkIGJ5 IFNhYW0gQmFyYXRpLgorCisgICAgICAgICogZGZnL0RGR0FycmF5TW9kZS5jcHA6CisgICAgICAg IChKU0M6OkRGRzo6QXJyYXlNb2RlOjpmcm9tT2JzZXJ2ZWQpOgorCiAyMDE4LTAzLTIxICBLZWl0 aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIGJ0anMgc2hvdWxk IHByaW50IHRoZSBieXRlY29kZSBvZmZzZXQgaW4gdGhlIHN0YWNrIHRyYWNlIGZvciBKUyBmcmFt ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQXJyYXlNb2RlLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQXJyYXlNb2RlLmNwcAppbmRleCAzMDc1 YmRmNDVkODlhYTdhODgzZWQ2NTBhMjg0YjQxM2E0MzMyODljLi41MjNhYjkxMTFjNjE1MzMyNjNi OGI1MGE5OGFjZWMyZDAxNmNiNmJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0FycmF5TW9kZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdB cnJheU1vZGUuY3BwCkBAIC0xMTgsNiArMTE4LDEwIEBAIEFycmF5TW9kZSBBcnJheU1vZGU6OmZy b21PYnNlcnZlZChjb25zdCBDb25jdXJyZW50SlNMb2NrZXImIGxvY2tlciwgQXJyYXlQcm9maWxl CiAgICAgICAgIHJldHVybiBBcnJheU1vZGUoQXJyYXk6OkZsb2F0NjRBcnJheSwgbm9uQXJyYXks IEFycmF5OjpBc0lzKS53aXRoUHJvZmlsZShsb2NrZXIsIHByb2ZpbGUsIG1ha2VTYWZlKTsKIAog ICAgIGRlZmF1bHQ6CisgICAgICAgIC8vIElmIHdlIGhhdmUgc2VlbiBtdWx0aXBsZSBUeXBlZEFy cmF5IHR5cGVzLCBvciBhIFR5cGVkQXJyYXkgYW5kIG5vbi10eXBlZCBhcnJheSwgaXQgZG9lc24n dCBtYWtlIHNlbnNlIHRvIHRyeSB0byBjb252ZXJ0IHRoZSBvYmplY3Qgc2luY2UgeW91IGNhbid0 IGNvbnZlcnQgdHlwZWQgYXJyYXlzLgorICAgICAgICBpZiAob2JzZXJ2ZWQgJiBBTExfVFlQRURf QVJSQVlfTU9ERVMpCisgICAgICAgICAgICByZXR1cm4gQXJyYXlNb2RlKEFycmF5OjpHZW5lcmlj LCBub25BcnJheSwgQXJyYXk6OkFzSXMpLndpdGhQcm9maWxlKGxvY2tlciwgcHJvZmlsZSwgbWFr ZVNhZmUpOworCiAgICAgICAgIGlmICgob2JzZXJ2ZWQgJiBhc0FycmF5TW9kZXMoTm9uQXJyYXkp KSAmJiBwcm9maWxlLT5tYXlJbnRlcmNlcHRJbmRleGVkQWNjZXNzZXMobG9ja2VyKSkKICAgICAg ICAgICAgIHJldHVybiBBcnJheU1vZGUoQXJyYXk6OlNlbGVjdFVzaW5nUHJlZGljdGlvbnMpLndp dGhTcGVjdWxhdGlvbkZyb21Qcm9maWxlKGxvY2tlciwgcHJvZmlsZSwgbWFrZVNhZmUpOwogICAg ICAgICAK