184124 2018-03-28 20:37:43 -0700 REGRESSION(r229480): ERROR: Unhandled web process message 'WebCookieManager:SetHTTPCookieAcceptPolicy' 2018-03-29 09:28:05 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 183519 1 cdumez bfulgham bfulgham ryanhaddad webkit-bug-importer oldest_to_newest 1410176 0 cdumez 2018-03-28 20:37:43 -0700 I frequently see this error on stderr when running the layout tests locally: ERROR: Unhandled web process message 'WebCookieManager:SetHTTPCookieAcceptPolicy' 1410263 1 webkit-bug-importer 2018-03-29 08:23:52 -0700 <rdar://problem/38998971> 1410265 2 bfulgham 2018-03-29 08:27:48 -0700 This started happening after Bug 183519, because that removed support in the WebContent process for receiving/handling this message. I should have removed the code in WebCookieManagerProxy::setHTTPCookieAcceptPolicy that spams the WebContent process with this changed state. The Network process (which is also messaged in that same place) is the only process that needs this information. 1410271 3 336773 bfulgham 2018-03-29 08:38:12 -0700 Created attachment 336773 Patch 1410285 4 bfulgham 2018-03-29 09:28:05 -0700 Committed r230076: <https://trac.webkit.org/changeset/230076> 336773 2018-03-29 08:38:12 -0700 2018-03-29 09:23:21 -0700 Patch bug-184124-20180329083812.patch text/plain 2270 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzAwNzMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE4LTAzLTI5ICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIyOTQ4MCk6 IEVSUk9SOiBVbmhhbmRsZWQgd2ViIHByb2Nlc3MgbWVzc2FnZSAnV2ViQ29va2llTWFuYWdlcjpT ZXRIVFRQQ29va2llQWNjZXB0UG9saWN5JworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg0MTI0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zODk5ODk3 MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb29r aWUgYWNjZXB0IHBvbGljeSBtZXNzYWdlcyB3ZXJlIHN0aWxsIGJlaW5nIHNlbnQgdG8gdGhlIFdl YkNvbnRlbnQgcHJvY2VzcyBhZnRlcgorICAgICAgICBJIHJlbW92ZWQgY29va2llIGFjY2VzcyBp biByMjI5NDgwLiBUaGUgV2ViQ29udGVudCBwcm9jZXNzIG5vIGxvbmdlciByZWNvZ25pemVzIHRo ZXNlCisgICAgICAgIG1lc3NhZ2VzLCBhbmQgZ2VuZXJhdGVzIGxvZ2dpbmcgdG8gdGhhdCBlZmZl Y3QuCisgICAgICAgIAorICAgICAgICBUaGlzIHBhdGNoIHN0b3BzIHNlbmRpbmcgdGhlc2UgdW5u ZWNlc3NhcnkgbWVzc2FnZXMgdG8gdGhlIFdlYkNvbnRlbnQgcHJvY2Vzcy4gT25seSB0aGUKKyAg ICAgICAgTmV0d29yayBwcm9jZXNzIG5lZWRzIHRvIHJlY2VpdmUgdGhpcyBpbmZvcm1hdGlvbi4K KworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb29raWVNYW5hZ2VyUHJveHkuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJDb29raWVNYW5hZ2VyUHJveHk6OnNldEhUVFBDb29raWVBY2NlcHRQb2xp Y3kpOgorCiAyMDE4LTAzLTI4ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgTWFrZSBpdCBwb3NzaWJsZSB0byBvdmVycmlkZSB0aGUgc2NyZWVuIHNpemUKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkNvb2tpZU1hbmFnZXJQcm94eS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQ29va2llTWFuYWdlclByb3h5LmNw cAkocmV2aXNpb24gMjMwMDczKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQ29va2ll TWFuYWdlclByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjUyLDExICsyNTIsNiBAQCB2b2lk IFdlYkNvb2tpZU1hbmFnZXJQcm94eTo6c2V0SFRUUENvb2tpCiAgICAgcHJvY2Vzc1Bvb2woKS0+ c2V0SW5pdGlhbEhUVFBDb29raWVBY2NlcHRQb2xpY3kocG9saWN5KTsKICNlbmRpZgogCi0gICAg Ly8gVGhlIHBvbGljeSBpcyBub3Qgc2VudCB0byBuZXdseSBjcmVhdGVkIHByb2Nlc3NlcyAob25s eSBTb3VwIGRvZXMgdGhhdCB2aWEgc2V0SW5pdGlhbEhUVFBDb29raWVBY2NlcHRQb2xpY3koKSku IFRoaXMgaXMgbm90IGEgc2VyaW91cyBwcm9ibGVtLCBiZWNhdXNlOgotICAgIC8vIC0gV2hlbiB0 ZXN0aW5nLCB3ZSBvbmx5IGhhdmUgb25lIFdlYlByb2Nlc3MgYW5kIG9uZSBOZXR3b3JrUHJvY2Vz cywgYW5kIFdlYktpdFRlc3RSdW5uZXIgbmV2ZXIgcmVzdGFydHMgdGhlbTsKLSAgICAvLyAtIFdo ZW4gbm90IHRlc3RpbmcsIENvY29hIGhhcyB0aGUgcG9saWN5IHBlcnNpc3RlZCwgYW5kIHRodXMg bmV3IHByb2Nlc3NlcyB1c2UgaXQgKGV2ZW4gZm9yIGVwaGVtZXJhbCBzZXNzaW9ucykuCi0gICAg cHJvY2Vzc1Bvb2woKS0+c2VuZFRvQWxsUHJvY2Vzc2VzKE1lc3NhZ2VzOjpXZWJDb29raWVNYW5h Z2VyOjpTZXRIVFRQQ29va2llQWNjZXB0UG9saWN5KHBvbGljeSwgT3B0aW9uYWxDYWxsYmFja0lE KCkpKTsKLQogICAgIGF1dG8gY2FsbGJhY2tJRCA9IG1fY2FsbGJhY2tzLnB1dChXVEZNb3ZlKGNh bGxiYWNrRnVuY3Rpb24pKTsKICAgICBwcm9jZXNzUG9vbCgpLT5zZW5kVG9OZXR3b3JraW5nUHJv Y2VzcyhNZXNzYWdlczo6V2ViQ29va2llTWFuYWdlcjo6U2V0SFRUUENvb2tpZUFjY2VwdFBvbGlj eShwb2xpY3ksIE9wdGlvbmFsQ2FsbGJhY2tJRChjYWxsYmFja0lEKSkpOwogfQo=