184120 2018-03-28 17:46:36 -0700 [Win] MSVC can't compile WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent 2018-04-02 10:45:44 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174003 1 fujii fujii achristensen beidson cdumez commit-queue webkit-bug-importer wilander oldest_to_newest 1410139 0 fujii 2018-03-28 17:46:36 -0700 [Win] MSVC can't compile WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent >WebResourceLoadStatisticsStore.cpp >c:\webkit\gb\webkitbuild\debug\derivedsources\forwardingheaders\wtf\ref.h(61): error C2039: 'deref': is not a member of 'WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e>' >c:\webkit\gb\source\webkit\uiprocess\webresourceloadstatisticsstore.cpp(830): note: see declaration of 'WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e>' >c:\webkit\gb\webkitbuild\debug\derivedsources\forwardingheaders\wtf\ref.h(55): note: while compiling class template member function 'WTF::Ref<WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e>,WTF::DumbPtrTraits<T>>::~Ref(void)' > with > [ > T=WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e> > ] >c:\webkit\gb\source\webkit\uiprocess\webresourceloadstatisticsstore.cpp(826): note: see reference to function template instantiation 'WTF::Ref<WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e>,WTF::DumbPtrTraits<T>>::~Ref(void)' being compiled > with > [ > T=WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e> > ] >c:\webkit\gb\source\webkit\uiprocess\webresourceloadstatisticsstore.cpp(824): note: see reference to class template instantiation 'WTF::Ref<WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e>,WTF::DumbPtrTraits<T>>' being compiled > with > [ > T=WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e> > ] 1410143 1 336740 fujii 2018-03-28 17:58:06 -0700 Created attachment 336740 WIP patch 1410148 2 fujii 2018-03-28 18:30:09 -0700 I created a reproducer and reported to MS. https://godbolt.org/g/kZq5Fn https://msdn.microsoft.com/library/mt748084.aspx 1410154 3 336745 fujii 2018-03-28 19:04:15 -0700 Created attachment 336745 Patch 1410304 4 336745 achristensen 2018-03-29 10:31:18 -0700 Comment on attachment 336745 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336745&action=review > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:824 > - grandfatherExistingWebsiteData([protectedThis = makeRef(*this), callback = WTFMove(callback)]() { > + grandfatherExistingWebsiteData([protectedThis = protectedThis.copyRef(), callback = WTFMove(callback)]() { protectedThis = WTFMove(protectedThis) There's no need to unnecessarily increment and decrement the ref count twice in this case. 1410475 5 336828 fujii 2018-03-29 18:32:33 -0700 Created attachment 336828 Patch 1410989 6 fujii 2018-04-01 18:57:14 -0700 Thank you for the review, Alex. I addressed the review feedback. Could you review again? 1411131 7 336828 commit-queue 2018-04-02 10:44:53 -0700 Comment on attachment 336828 Patch Clearing flags on attachment: 336828 Committed r230162: <https://trac.webkit.org/changeset/230162> 1411132 8 commit-queue 2018-04-02 10:44:54 -0700 All reviewed patches have been landed. Closing bug. 1411135 9 webkit-bug-importer 2018-04-02 10:45:44 -0700 <rdar://problem/39110400> 336740 2018-03-28 17:58:06 -0700 2018-03-28 19:04:11 -0700 WIP patch wip.patch text/plain 801 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRp c3RpY3NTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRT dGF0aXN0aWNzU3RvcmUuY3BwCmluZGV4IGY2YTA3ODkwMzIzLi5jODRiYTQyZDM2MSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0 b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0 aXN0aWNzU3RvcmUuY3BwCkBAIC04MjEsNyArODIxLDcgQEAgdm9pZCBXZWJSZXNvdXJjZUxvYWRT dGF0aXN0aWNzU3RvcmU6OnNjaGVkdWxlQ2xlYXJJbk1lbW9yeUFuZFBlcnNpc3RlbnQoU2hvdWxk R3IKICAgICAgICAgbV9wZXJzaXN0ZW50U3RvcmFnZS5jbGVhcigpOwogICAgICAgICAKICAgICAg ICAgaWYgKHNob3VsZEdyYW5kZmF0aGVyID09IFNob3VsZEdyYW5kZmF0aGVyOjpZZXMpCi0gICAg ICAgICAgICBncmFuZGZhdGhlckV4aXN0aW5nV2Vic2l0ZURhdGEoW3Byb3RlY3RlZFRoaXMgPSBt YWtlUmVmKCp0aGlzKSwgY2FsbGJhY2sgPSBXVEZNb3ZlKGNhbGxiYWNrKV0oKSB7CisgICAgICAg ICAgICBncmFuZGZhdGhlckV4aXN0aW5nV2Vic2l0ZURhdGEoW3Byb3RlY3RlZFRoaXMgPSBwcm90 ZWN0ZWRUaGlzLmNvcHlSZWYoKSwgY2FsbGJhY2sgPSBXVEZNb3ZlKGNhbGxiYWNrKV0oKSB7CiAg ICAgICAgICAgICAgICAgY2FsbGJhY2soKTsKICAgICAgICAgICAgIH0pOwogICAgICAgICBlbHNl IHsK 336745 2018-03-28 19:04:15 -0700 2018-03-29 18:32:30 -0700 Patch bug-184120-20180329110414.patch text/plain 1882 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRkODNkY2FmOTRjNzliYWRi N2Y1OWViZWVkOTNjODQxMWExZTkwYWQuLjY0MzNiODIzMDc3NmQ4OWQ2ZDI2MzZhOTY4OTE5NDIx MmU4ZDZkYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDMtMjggIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gTVNWQyBj YW4ndCBjb21waWxlIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6c2NoZWR1bGVDbGVh ckluTWVtb3J5QW5kUGVyc2lzdGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg0MTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSXQgc2VlbXMgdGhhdCBNU1ZDIGNhbid0IGNvbXBpbGUgdGhlIGNvZGUg dXNpbmcgYHRoaXNgIGluIGEKKyAgICAgICAgZ2VuZXJhbGl6ZWQgbGFtYmRhIGNhcHR1cmUgaW4g YW5vdGhlciBsYW1iZGEuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUmVzb3VyY2VMb2FkU3Rh dGlzdGljc1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUmVzb3VyY2VMb2FkU3RhdGlz dGljc1N0b3JlOjpzY2hlZHVsZUNsZWFySW5NZW1vcnlBbmRQZXJzaXN0ZW50KToKKyAgICAgICAg Q3JlYXRlZCB0aGUgaW5uZXIgcHJvdGVjdGVkVGhpcyBieSBwcm90ZWN0ZWRUaGlzLmNvcHlSZWYo KSBvZiB0aGUKKyAgICAgICAgb3V0ZXIgcHJvdGVjdGVkVGhpcyBpbnN0ZWFkIG9mIG1ha2VSZWYo KnRoaXMpLgorCiAyMDE4LTAzLTI4ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgTWFrZSBpdCBwb3NzaWJsZSB0byBvdmVycmlkZSB0aGUgc2NyZWVuIHNpemUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3Rp Y3NTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0 aXN0aWNzU3RvcmUuY3BwCmluZGV4IGY2YTA3ODkwMzIzOGE2ZDVmYjdmZDMzODhlMDhjZjhkZjU4 ZGFkOTUuLmM4NGJhNDJkMzYxOTM1MTI0YjQ1NDA4NTkzY2Y0YTI1YTkzODQyNmQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9y ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUmVzb3VyY2VMb2FkU3RhdGlz dGljc1N0b3JlLmNwcApAQCAtODIxLDcgKzgyMSw3IEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkU3Rh dGlzdGljc1N0b3JlOjpzY2hlZHVsZUNsZWFySW5NZW1vcnlBbmRQZXJzaXN0ZW50KFNob3VsZEdy CiAgICAgICAgIG1fcGVyc2lzdGVudFN0b3JhZ2UuY2xlYXIoKTsKICAgICAgICAgCiAgICAgICAg IGlmIChzaG91bGRHcmFuZGZhdGhlciA9PSBTaG91bGRHcmFuZGZhdGhlcjo6WWVzKQotICAgICAg ICAgICAgZ3JhbmRmYXRoZXJFeGlzdGluZ1dlYnNpdGVEYXRhKFtwcm90ZWN0ZWRUaGlzID0gbWFr ZVJlZigqdGhpcyksIGNhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldKCkgeworICAgICAgICAg ICAgZ3JhbmRmYXRoZXJFeGlzdGluZ1dlYnNpdGVEYXRhKFtwcm90ZWN0ZWRUaGlzID0gcHJvdGVj dGVkVGhpcy5jb3B5UmVmKCksIGNhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldKCkgewogICAg ICAgICAgICAgICAgIGNhbGxiYWNrKCk7CiAgICAgICAgICAgICB9KTsKICAgICAgICAgZWxzZSB7 Cg== 336828 2018-03-29 18:32:33 -0700 2018-04-02 10:44:53 -0700 Patch bug-184120-20180330103232.patch text/plain 2019 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZmMGVjMDI5MWJjODlmY2U4 NjI5OTk5YmM3ODM1ODBkMTBmYjU0ZWIuLmMxMDc2Njg2MTM3MTFiMmZiYmRiNzQwZjRmYTEyMWFl ZjdkZjVjNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDMtMjkgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gTVNWQyBj YW4ndCBjb21waWxlIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6c2NoZWR1bGVDbGVh ckluTWVtb3J5QW5kUGVyc2lzdGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg0MTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSXQgc2VlbXMgdGhhdCBNU1ZDIGNhbid0IGNvbXBpbGUgdGhlIGNvZGUg dXNpbmcgYHRoaXNgIGluIGEKKyAgICAgICAgZ2VuZXJhbGl6ZWQgbGFtYmRhIGNhcHR1cmUgaW4g YW5vdGhlciBsYW1iZGEuCisKKyAgICAgICAgSW4gdGhpcyBjYXNlLCB0aGVyZSBpcyBubyBuZWVk IHRvIGNvcHkgYHByb3RlY3RlZFRoaXNgIGZvciB0aGUKKyAgICAgICAgaW5uZXIgbGFtYmRhLiBN b3ZlIGBwcm90ZWN0ZWRUaGlzYCBvZiB0aGUgb3V0ZXIgbGFtYmRhIHRvIHRoZQorICAgICAgICBp bm5lciBhcyB3ZWxsIGFzIGBjYWxsYmFja2AuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUmVz b3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUmVzb3Vy Y2VMb2FkU3RhdGlzdGljc1N0b3JlOjpzY2hlZHVsZUNsZWFySW5NZW1vcnlBbmRQZXJzaXN0ZW50 KToKKyAgICAgICAgTW92ZWQgYHByb3RlY3RlZFRoaXNgIGZyb20gdGhlIG91dGVyIGxhbWJkYSB0 byB0aGUgaW5uZXIuCisKIDIwMTgtMDMtMjkgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEF1dG9tYXRpb246IGNsaXBUb1ZpZXdwb3J0IGlzIGlnbm9yZWQgZm9y IGVsZW1lbnQgc2NyZWVuc2hvdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuY3BwCmluZGV4IGY2YTA3ODkwMzIz OGE2ZDVmYjdmZDMzODhlMDhjZjhkZjU4ZGFkOTUuLjdmYTg5MTA3ZjliNzc4OTY0YzdlMjZiMWZl NzNlZjlhNDY5YmI1ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlJl c291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmNwcApAQCAtODIxLDcgKzgyMSw3IEBA IHZvaWQgV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpzY2hlZHVsZUNsZWFySW5NZW1v cnlBbmRQZXJzaXN0ZW50KFNob3VsZEdyCiAgICAgICAgIG1fcGVyc2lzdGVudFN0b3JhZ2UuY2xl YXIoKTsKICAgICAgICAgCiAgICAgICAgIGlmIChzaG91bGRHcmFuZGZhdGhlciA9PSBTaG91bGRH cmFuZGZhdGhlcjo6WWVzKQotICAgICAgICAgICAgZ3JhbmRmYXRoZXJFeGlzdGluZ1dlYnNpdGVE YXRhKFtwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGNhbGxiYWNrID0gV1RGTW92ZShj YWxsYmFjayldKCkgeworICAgICAgICAgICAgZ3JhbmRmYXRoZXJFeGlzdGluZ1dlYnNpdGVEYXRh KFtwcm90ZWN0ZWRUaGlzID0gV1RGTW92ZShwcm90ZWN0ZWRUaGlzKSwgY2FsbGJhY2sgPSBXVEZN b3ZlKGNhbGxiYWNrKV0oKSB7CiAgICAgICAgICAgICAgICAgY2FsbGJhY2soKTsKICAgICAgICAg ICAgIH0pOwogICAgICAgICBlbHNlIHsK