184119 2018-03-28 17:13:00 -0700 [GTK] DragAndDropHandler.cpp should include GUniquePtrGtk.h 2018-04-02 07:42:39 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia dbates mcatanzaro oldest_to_newest 1410131 0 mcatanzaro 2018-03-28 17:13:00 -0700 We've failed to figure out why, but in some build configurations, GUniquePtrGtk.h doesn't get pulled in and the unique_ptrs use the wrong deleter function. This file should include what it needs. 1410132 1 336736 mcatanzaro 2018-03-28 17:13:45 -0700 Created attachment 336736 Patch 1410195 2 336736 dbates 2018-03-28 23:35:44 -0700 Comment on attachment 336736 Patch OK 1411018 3 336736 cgarcia 2018-04-02 00:45:38 -0700 Comment on attachment 336736 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336736&action=review > Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp:31 > +#include "GUniquePtrGtk.h" This is a WebCoire header included in WebKLit layer, please use <WebCore/GUniquePtrGtk.h> instead. 1411069 4 mcatanzaro 2018-04-02 07:29:00 -0700 Whoops, must have gotten confused. And also forgot about this. 1411070 5 mcatanzaro 2018-04-02 07:29:52 -0700 Actually this tells me we have a bug with our include paths: that really should not have compiled at all. :/ 1411071 6 mcatanzaro 2018-04-02 07:30:19 -0700 (In reply to Michael Catanzaro from comment #5) > Actually this tells me we have a bug with our include paths: that really > should not have compiled at all. :/ I guess it's because we use PUBLIC include directories everywhere. CMake is wonderful that way.... 1411073 7 mcatanzaro 2018-04-02 07:42:39 -0700 Committed r230156: <https://trac.webkit.org/changeset/230156> 336736 2018-03-28 17:13:45 -0700 2018-04-02 00:45:38 -0700 Patch bug-184119-20180328191343.patch text/plain 1418 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBmMjBiZjI4ZmM4NmUwNDVm NmY0ZmIwMjI0N2FlYWExZmM5MWI3MTUuLjEyNDg1MzA5MGYwNjkwYmZhY2RiNDUwZmQxN2YzYzAy NGQyY2JmMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTgtMDMtMjggIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIERyYWdB bmREcm9wSGFuZGxlci5jcHAgc2hvdWxkIGluY2x1ZGUgR1VuaXF1ZVB0ckd0ay5oCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQxMTkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9ndGsv RHJhZ0FuZERyb3BIYW5kbGVyLmNwcDoKKwogMjAxOC0wMy0yOCAgTWljaGFlbCBDYXRhbnphcm8g IDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgRmFpbHMgdG8gYnVpbGQgd2Via2l0 Z3RrKyBhZnRlciBnaXQtc3ZuLWlkOiBodHRwOi8vc3ZuLndlYmtpdC5vcmcvcmVwb3NpdG9yeS93 ZWJraXQvdHJ1bmtAMjI5ODc3IDI2OGY0NWNjLWNkMDktMDQxMC1hYjNjLWQ1MjY5MWI0ZGJmYwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL0RyYWdBbmREcm9wSGFuZGxl ci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsvRHJhZ0FuZERyb3BIYW5kbGVyLmNw cAppbmRleCBjNjFlYTRkNGM5NTE3MjM4NmMwMTk5OTQ3MjcyZmJmMDE3NWUzOGRjLi5lMjMzMTkw MTU3NjYyNjY0OTk5ZTU3ZjExNDFlZmYzNDRjZDA1NmQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9ndGsvRHJhZ0FuZERyb3BIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9ndGsvRHJhZ0FuZERyb3BIYW5kbGVyLmNwcApAQCAtMjgsMTMgKzI4LDEz IEBACiAKICNpZiBFTkFCTEUoRFJBR19TVVBQT1JUKQogCisjaW5jbHVkZSAiR1VuaXF1ZVB0ckd0 ay5oIgogI2luY2x1ZGUgIldlYlBhZ2VQcm94eS5oIgogI2luY2x1ZGUgPFdlYkNvcmUvRHJhZ0Rh dGEuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0dSZWZQdHJHdGsuaD4KICNpbmNsdWRlIDxXZWJDb3Jl L0d0a1V0aWxpdGllcy5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUGFzdGVib2FyZEhlbHBlci5oPgog I2luY2x1ZGUgPHd0Zi9SdW5Mb29wLmg+Ci0jaW5jbHVkZSA8d3RmL2dsaWIvR1VuaXF1ZVB0ci5o PgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwo=