184117 2018-03-28 16:38:54 -0700 run-jsc-benchmarks should recognize Windows-style build directory structure. 2018-03-29 21:36:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling commit-queue fpizlo keith_miller lforschler mark.lam saam webkit-bug-importer ysuzuki oldest_to_newest 1410112 0 ross.kirsling 2018-03-28 16:38:54 -0700 run-jsc-benchmarks should recognize Windows-style build directory structure. 1410115 1 336733 ross.kirsling 2018-03-28 16:39:43 -0700 Created attachment 336733 Patch 1410488 2 336733 ysuzuki 2018-03-29 19:04:10 -0700 Comment on attachment 336733 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336733&action=review r=me with some nits > Tools/Scripts/run-jsc-benchmarks:1345 > + elsif @path =~ /\/Release\/bin(64|32|)\/([.a-zA-Z]+)$/ I think `[.a-zA-Z]` should be `[\.a-zA-Z]`. > Tools/Scripts/run-jsc-benchmarks:1347 > + elsif @path =~ /\/Debug\/bin(64|32|)\/([.a-zA-Z]+)$/ Ditto. 1410504 3 336835 ross.kirsling 2018-03-29 20:10:37 -0700 Created attachment 336835 Patch for landing 1410535 4 336835 commit-queue 2018-03-29 21:35:12 -0700 Comment on attachment 336835 Patch for landing Clearing flags on attachment: 336835 Committed r230093: <https://trac.webkit.org/changeset/230093> 1410536 5 commit-queue 2018-03-29 21:35:14 -0700 All reviewed patches have been landed. Closing bug. 1410538 6 webkit-bug-importer 2018-03-29 21:36:21 -0700 <rdar://problem/39026716> 336733 2018-03-28 16:39:43 -0700 2018-03-29 20:10:36 -0700 Patch bug-184117-20180328163954.patch text/plain 1948 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5OTg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWE3YTE2YzZiODFkOGRlNzNmNTJhMmMyNzliOWM2Yzdi ZWQ1MjBhNi4uNmIzNmM5NjM0NDc4YTcxMWRhMmQ0MTg5YzA5NDQ1NTgzYzQ3ZjhlNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTAzLTI4ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K KworICAgICAgICBydW4tanNjLWJlbmNobWFya3Mgc2hvdWxkIHJlY29nbml6ZSBXaW5kb3dzLXN0 eWxlIGJ1aWxkIGRpcmVjdG9yeSBzdHJ1Y3R1cmUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQxMTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWpzYy1iZW5jaG1hcmtzOgorICAg ICAgICBBbGxvdyBiaW42NC9iaW4zMiBpbiBhZGRpdGlvbiB0byBqdXN0ICJiaW4iLgorCiAyMDE4 LTAzLTI2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFdh cm4gYWdhaW5zdCBjb29raWUgYWNjZXNzIGluIHRoZSBXZWJDb250ZW50IHByb2Nlc3MgdXNpbmcg UHJvY2Vzc1ByaXZpbGVnZSBhc3NlcnRpb25zCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1 bi1qc2MtYmVuY2htYXJrcyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1iZW5jaG1hcmtzCmluZGV4 IDMxZjBlZDQ4ZmFkNTEwM2Q5MmEwOWY5Mjc2NGUwNDdkZDIxNTVjMGIuLjgzODY0OTkyYmYzYTAz ZGRmYmIxYTcxNzA1MTFkZGEyNWZkMzE2MGYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVu LWpzYy1iZW5jaG1hcmtzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1iZW5jaG1hcmtzCkBA IC0xMzQyLDEwICsxMzQyLDEwIEBAIGNsYXNzIFZNCiAgICAgICBAbGliUGF0aCwgQHJlbGF0aXZl QmluUGF0aCA9IFskfi5wcmVfbWF0Y2grIi9SZWxlYXNlIl0sICIuLyN7JDF9IgogICAgIGVsc2lm IEBwYXRoID1+IC9cL0RlYnVnXC8oW2EtekEtWl0rKSQvCiAgICAgICBAbGliUGF0aCwgQHJlbGF0 aXZlQmluUGF0aCA9IFskfi5wcmVfbWF0Y2grIi9EZWJ1ZyJdLCAiLi8jeyQxfSIKLSAgICBlbHNp ZiBAcGF0aCA9fiAvXC9SZWxlYXNlXC9iaW5cLyhbYS16QS1aXSspJC8KLSAgICAgIEBsaWJQYXRo LCBAcmVsYXRpdmVCaW5QYXRoID0gWyR+LnByZV9tYXRjaCsiL1JlbGVhc2UvbGliIl0sICIuLyN7 JDF9IgotICAgIGVsc2lmIEBwYXRoID1+IC9cL0RlYnVnXC9iaW5cLyhbYS16QS1aXSspJC8KLSAg ICAgIEBsaWJQYXRoLCBAcmVsYXRpdmVCaW5QYXRoID0gWyR+LnByZV9tYXRjaCsiL0RlYnVnL2xp YiJdLCAiLi8jeyQxfSIKKyAgICBlbHNpZiBAcGF0aCA9fiAvXC9SZWxlYXNlXC9iaW4oNjR8MzJ8 KVwvKFsuYS16QS1aXSspJC8KKyAgICAgIEBsaWJQYXRoLCBAcmVsYXRpdmVCaW5QYXRoID0gWyR+ LnByZV9tYXRjaCsiL1JlbGVhc2UvbGliI3skMX0iXSwgIi4vI3skMn0iCisgICAgZWxzaWYgQHBh dGggPX4gL1wvRGVidWdcL2Jpbig2NHwzMnwpXC8oWy5hLXpBLVpdKykkLworICAgICAgQGxpYlBh dGgsIEByZWxhdGl2ZUJpblBhdGggPSBbJH4ucHJlX21hdGNoKyIvRGVidWcvbGliI3skMX0iXSwg Ii4vI3skMn0iCiAgICAgZWxzaWYgQHBhdGggPX4gL1wvQ29udGVudHNcL1Jlc291cmNlc1wvKFth LXpBLVpdKykkLwogICAgICAgQGxpYlBhdGggPSBbJH4ucHJlX21hdGNoICsgIi9Db250ZW50cy9S ZXNvdXJjZXMiLCAkfi5wcmVfbWF0Y2ggKyAiL0NvbnRlbnRzL0ZyYW1ld29ya3MiXQogICAgIGVs c2lmIEBwYXRoID1+IC9cL0phdmFTY3JpcHRDb3JlLmZyYW1ld29ya1wvUmVzb3VyY2VzXC8oW2Et ekEtWl0rKSQvCg== 336835 2018-03-29 20:10:37 -0700 2018-03-29 21:35:12 -0700 Patch for landing bug-184117-20180329201048.patch text/plain 1925 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDkxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2M1NmMxMmZmNjAxMDYwOTMxMmVmMGYwMjAzOGJiNTNl ZjlmNDgwMy4uZmFmM2UzM2EwZGQwM2Q1YTExYWM0NTc4MDY2NzdlNjhkZjg4MjQyYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTAzLTI5ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K KworICAgICAgICBydW4tanNjLWJlbmNobWFya3Mgc2hvdWxkIHJlY29nbml6ZSBXaW5kb3dzLXN0 eWxlIGJ1aWxkIGRpcmVjdG9yeSBzdHJ1Y3R1cmUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQxMTcKKworICAgICAgICBSZXZpZXdlZCBieSBZdXN1 a2UgU3V6dWtpLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tanNjLWJlbmNobWFya3M6CisgICAg ICAgIEFsbG93IG5vdCBvbmx5IGJpbi9qc2MgYnV0IGFsc28gYmluNjQvanNjLmV4ZS4KKwogMjAx OC0wMy0yOSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMYXlv dXRSZWxvYWRlZF0gRGVjb3VwbGUgZm9ybWF0dGluZyBzdGF0ZSBhbmQgY29udGV4dCBsaWZldGlt ZS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1iZW5jaG1hcmtzIGIvVG9vbHMv U2NyaXB0cy9ydW4tanNjLWJlbmNobWFya3MKaW5kZXggMzFmMGVkNDhmYWQ1MTAzZDkyYTA5Zjky NzY0ZTA0N2RkMjE1NWMwYi4uNjU0Zjg0MDM4OTY3MjZiZTE2MTcwN2I2MTUwM2FkMTNhZWI0YWQ1 ZCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjLWJlbmNobWFya3MKKysrIGIvVG9v bHMvU2NyaXB0cy9ydW4tanNjLWJlbmNobWFya3MKQEAgLTEzNDIsMTAgKzEzNDIsMTAgQEAgY2xh c3MgVk0KICAgICAgIEBsaWJQYXRoLCBAcmVsYXRpdmVCaW5QYXRoID0gWyR+LnByZV9tYXRjaCsi L1JlbGVhc2UiXSwgIi4vI3skMX0iCiAgICAgZWxzaWYgQHBhdGggPX4gL1wvRGVidWdcLyhbYS16 QS1aXSspJC8KICAgICAgIEBsaWJQYXRoLCBAcmVsYXRpdmVCaW5QYXRoID0gWyR+LnByZV9tYXRj aCsiL0RlYnVnIl0sICIuLyN7JDF9IgotICAgIGVsc2lmIEBwYXRoID1+IC9cL1JlbGVhc2VcL2Jp blwvKFthLXpBLVpdKykkLwotICAgICAgQGxpYlBhdGgsIEByZWxhdGl2ZUJpblBhdGggPSBbJH4u cHJlX21hdGNoKyIvUmVsZWFzZS9saWIiXSwgIi4vI3skMX0iCi0gICAgZWxzaWYgQHBhdGggPX4g L1wvRGVidWdcL2JpblwvKFthLXpBLVpdKykkLwotICAgICAgQGxpYlBhdGgsIEByZWxhdGl2ZUJp blBhdGggPSBbJH4ucHJlX21hdGNoKyIvRGVidWcvbGliIl0sICIuLyN7JDF9IgorICAgIGVsc2lm IEBwYXRoID1+IC9cL1JlbGVhc2VcL2Jpbig2NHwzMnwpXC8oW1wuYS16QS1aXSspJC8KKyAgICAg IEBsaWJQYXRoLCBAcmVsYXRpdmVCaW5QYXRoID0gWyR+LnByZV9tYXRjaCsiL1JlbGVhc2UvbGli I3skMX0iXSwgIi4vI3skMn0iCisgICAgZWxzaWYgQHBhdGggPX4gL1wvRGVidWdcL2Jpbig2NHwz MnwpXC8oW1wuYS16QS1aXSspJC8KKyAgICAgIEBsaWJQYXRoLCBAcmVsYXRpdmVCaW5QYXRoID0g WyR+LnByZV9tYXRjaCsiL0RlYnVnL2xpYiN7JDF9Il0sICIuLyN7JDJ9IgogICAgIGVsc2lmIEBw YXRoID1+IC9cL0NvbnRlbnRzXC9SZXNvdXJjZXNcLyhbYS16QS1aXSspJC8KICAgICAgIEBsaWJQ YXRoID0gWyR+LnByZV9tYXRjaCArICIvQ29udGVudHMvUmVzb3VyY2VzIiwgJH4ucHJlX21hdGNo ICsgIi9Db250ZW50cy9GcmFtZXdvcmtzIl0KICAgICBlbHNpZiBAcGF0aCA9fiAvXC9KYXZhU2Ny aXB0Q29yZS5mcmFtZXdvcmtcL1Jlc291cmNlc1wvKFthLXpBLVpdKykkLwo=